From: "Pai G, Sunil" <sunil.pai.g@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>,
Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: Luca Boccassi <bluca@debian.org>,
"stable@dpdk.org" <stable@dpdk.org>, dev <dev@dpdk.org>,
"Stokes, Ian" <ian.stokes@intel.com>
Subject: Re: [dpdk-dev] 19.11.4 patches review and test
Date: Tue, 1 Sep 2020 13:22:20 +0000 [thread overview]
Message-ID: <MWHPR11MB1805C61D3CB8DACB76C2CA2ABD2E0@MWHPR11MB1805.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200901124747.GB1047@bricha3-MOBL.ger.corp.intel.com>
Hi,
Yes , OVS was using pkg-config even before these patches were rolled out.
But it always used to pick the DPDK shared libs by default for OVS even on using the -Bstatic/-Bshared flags.
These patches from Bruce simplify the process from DPDK side without having the user to specify them.
Moreover, with these patches , the problem of shared DPDK libs always being picked instead of static was not seen any more with a bit of changes from the OVS side as well.
http://patchwork.ozlabs.org/project/openvswitch/patch/20200707141126.71414-1-sunil.pai.g@intel.com/ .
The patches for ovs-master are ready as well and will them out soon.
Thanks and Regards,
Pai G, Sunil
Sunil
> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Tuesday, September 1, 2020 6:18 PM
> To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> Cc: Luca Boccassi <bluca@debian.org>; stable@dpdk.org; dev <dev@dpdk.org>;
> Pai G, Sunil <sunil.pai.g@intel.com>; Stokes, Ian <ian.stokes@intel.com>
> Subject: Re: [dpdk-dev] 19.11.4 patches review and test
>
> On Tue, Sep 01, 2020 at 02:32:26PM +0200, Christian Ehrhardt wrote:
> > On Tue, Sep 1, 2020 at 10:30 AM Luca Boccassi <bluca@debian.org> wrote:
> > >
> > > On Tue, 2020-08-18 at 19:12 +0100, Luca Boccassi wrote:
> > > > Hi all,
> > > >
> > > > Here is a list of patches targeted for stable release 19.11.4.
> > > >
> > > > The planned date for the final release is August 31st.
> > > >
> > > > Please help with testing and validation of your use cases and
> > > > report any issues/results with reply-all to this mail. For the
> > > > final release the fixes and reported validations will be added to the release
> notes.
> > > >
> > > > A release candidate tarball can be found at:
> > > >
> > > > https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.4-rc1
> > > >
> > > > These patches are located at branch 19.11 of dpdk-stable repo:
> > > > https://dpdk.org/browse/dpdk-stable/
> > > >
> > > > Thanks.
> > > >
> > > > Luca Boccassi
> > >
> > > Microsoft's regression tests are still running, delaying until
> > > Thursday the 3rd. Apologies for any inconvenience.
> >
> > Due to report on OVS failing to build I happened to find that 19.11.4
> > has massively changed linking.
> > => https://paste.ubuntu.com/p/znCRR4gpjP/
> >
> > This was meant to be helpful for sure and I assume is around:
> > 48f7fd27f6 build/pkg-config: prevent overlinking
> > 2d1535d592 build/pkg-config: improve static linking flags
> > 9fb13a12c1 build/pkg-config: output drivers first for static build
> > 59b108d824 build/pkg-config: move pkg-config file creation
> > aea915e944 devtools: test static linkage with pkg-config
> >
> > But overlinking has effectively become underlinking now
> > https://launchpadlibrarian.net/495845224/buildlog_ubuntu-groovy-amd64.
> > openvswitch_2.13.1-0ubuntu2~ppa1_BUILDING.txt.gz
> >
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `rte_eth_from_rings':
> > (.text+0x91c): undefined reference to `rte_vdev_init'
> > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/10/../../../x86_64-linux-
> gnu/librte_pmd_ring.a(net_ring_rte_eth_ring.c.o):
> > in function `vdrvinitfn_pmd_ring_drv':
> > (.text.startup+0x28): undefined reference to `rte_vdev_register'
> > collect2: error: ld returned 1 exit status
> >
> > Also as you can see in the pastebin above, CFlags and Libs massively
> > shrunk and likely too much so.
> >
> > Given that this should be a stable release I'd ask to back out those
> > changes so that a test build creates the same .pc file as before -
> > would that make sense?
> >
> >
> Adding some OVS folks on CC.
>
> The request for backporting these actually came from the OVS side, since they
> were deemed necessary to enable OVS to switch to use DPDK pkg-config rather
> than the older approach using a makefile-based build. However, it appears you
> guys were already building OVS using the pkg-config file, and since this causes
> issues where there were none, backing it out seems a prudent choice.
>
> Ian, Sunil, any comments here.
>
> Regards
> /Bruce
next prev parent reply other threads:[~2020-09-01 13:23 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 18:12 Luca Boccassi
2020-08-24 13:22 ` Christian Ehrhardt
2020-08-24 13:25 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2020-08-25 9:13 ` [dpdk-dev] " Pei Zhang
2020-08-25 10:08 ` Luca Boccassi
2020-08-26 2:30 ` Chen, BoX C
2020-08-26 9:50 ` Luca Boccassi
2020-08-27 9:47 ` Burakov, Anatoly
2020-08-27 10:37 ` Luca Boccassi
2020-08-27 10:57 ` Burakov, Anatoly
2020-08-27 13:23 ` Luca Boccassi
2020-08-28 4:03 ` Wang, ShougangX
2020-08-28 7:52 ` Luca Boccassi
2020-08-28 14:34 ` Govindharajan, Hariprasad
2020-08-28 15:23 ` Luca Boccassi
2020-08-30 14:36 ` Ali Alnubani
2020-08-31 9:13 ` Luca Boccassi
2020-09-01 8:30 ` Luca Boccassi
2020-09-01 12:32 ` Christian Ehrhardt
2020-09-01 12:47 ` Bruce Richardson
2020-09-01 13:22 ` Pai G, Sunil [this message]
2020-09-01 15:10 ` Stokes, Ian
2020-09-07 14:25 ` [dpdk-dev] [dpdk-stable] " Luca Boccassi
2021-03-18 11:54 ` [dpdk-dev] " Christian Ehrhardt
2021-03-18 13:36 ` Pai G, Sunil
2021-03-18 14:48 ` Ilya Maximets
2021-03-18 18:24 ` Pai G, Sunil
2021-03-22 9:49 ` Christian Ehrhardt
2021-03-22 11:41 ` Bruce Richardson
2021-03-22 11:59 ` Luca Boccassi
2021-03-22 12:25 ` Thomas Monjalon
2021-03-22 14:27 ` Christian Ehrhardt
2021-03-23 18:17 ` Thomas Monjalon
2021-03-23 18:51 ` Ilya Maximets
2021-03-24 7:44 ` Christian Ehrhardt
2021-03-24 10:28 ` Pai G, Sunil
2021-03-24 13:02 ` Christian Ehrhardt
2020-09-01 12:49 ` Luca Boccassi
2020-09-01 13:01 ` Bruce Richardson
2020-09-01 13:28 ` Bruce Richardson
2020-09-01 18:04 ` [dpdk-dev] [EXTERNAL] " Abhishek Marathe
2020-09-02 10:47 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR11MB1805C61D3CB8DACB76C2CA2ABD2E0@MWHPR11MB1805.namprd11.prod.outlook.com \
--to=sunil.pai.g@intel.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=christian.ehrhardt@canonical.com \
--cc=dev@dpdk.org \
--cc=ian.stokes@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).