From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F12ECA04BC; Thu, 8 Oct 2020 09:26:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 440911B81B; Thu, 8 Oct 2020 09:26:03 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3B2711B813 for ; Thu, 8 Oct 2020 09:26:00 +0200 (CEST) IronPort-SDR: IF3S5PldZ1EwnASqYsxMKEYR+DdMf1jtUvXMUcxOKu1prry6STVpoCNOfuXVlS8kqWB1X43Gyy pW9+D52Co+fA== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="161829688" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="161829688" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 00:25:58 -0700 IronPort-SDR: gfKm05x2WE3ffbCprOuY3MFr8uxQa7me688oTSGt7IhSy4Yq18q8XuJJKi+gMsfCRDngMNEdM0 3kXXBP3G4tvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="349397924" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga002.fm.intel.com with ESMTP; 08 Oct 2020 00:25:58 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 00:25:58 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 00:25:57 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 8 Oct 2020 00:25:57 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.50) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 8 Oct 2020 00:25:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wez1/jrKG1UqeBtsRwUMT8X/LN5oNzUqwwzFhlJ3Td17p+ZixAX2ZoMOta1BzJatnKRdxHUIBXIHwtjtiinMZiZjY3tgkB5z/bG18PLDHeMKtCaryT+0C/9GyEoPItEVeliogwEH8zUb+eYEWgUDgD3o4eQE9uLLmLDaRivH4Zmc00cPsTbv2YviS983N2aQH2yiWruaYVUNVy7ZkgxEsku09vOffNWM1FYeqA0H0r//GAX7Z0cMI5ffP1rLHUwG9c1xiFQZ2nZeWjggqgWa7rOvZWGEZOXHNEJylYCP6m5spwuvorr1Jx3Y2P23rM9FirEL5j9uV9507dkyWP5O6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GfIo6OyXpqJQx5yzDtOhe8vvkrdOn/m16ts4W3gyXhk=; b=KK+JMjrwT5gLCIit6yOpggdHpvWZJ7Vo5cahb6vG6sKMGtAVWs36H7Nu0OGtsPA6EhzmIuQoZQbRUW67iqV4a4fxhtgRkjf+qjHl+LLlrV9RWyu+IVDGsOZh1Kre5Zw8WEplQxx3rcyF3LEqWQHRt4GBJhMX0jOhvB+oRR0TcFUQYr7fKiI7CfYmppcHvR1Oh46stdSvBc5Wo5ws4r/kvgTOGWvMAea544ECWr+ao/9Ci+R8TL0m1Q+iP6AY5spjOoRsf2+SBRb76BWL91PYqNct7kdKWxzGpRwFyMxEeVKzUDAfNX/PKss3Q4BZ/Nz9gFkGIgYmTjDZoQ4jZYksmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GfIo6OyXpqJQx5yzDtOhe8vvkrdOn/m16ts4W3gyXhk=; b=DBCH4glpe3MVl2mNHcgIUQRhQ21o7XLsMFl/VL6XBmWk4GCjsCMRFWXXYffVEITTaN19pdJwFZFNsV/a9/qEA7wps2HiIBoYQFHlJUFP1Q+sKqxkSLb2Xdt7S6NUZAghJ8kNwJUwlGgE9L/v1bSqgKtKiSHG7bpbGokqlCa/I9o= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB1663.namprd11.prod.outlook.com (2603:10b6:301:d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 07:25:56 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3433.046; Thu, 8 Oct 2020 07:25:55 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" Thread-Topic: [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWnGqIJ5UVvNhBMU+D3KcfFTMg6amNT6Rg Date: Thu, 8 Oct 2020 07:25:55 +0000 Message-ID: References: <20200925072841.17578-1-adwivedi@marvell.com> <20201007052629.28566-1-adwivedi@marvell.com> <20201007052629.28566-2-adwivedi@marvell.com> In-Reply-To: <20201007052629.28566-2-adwivedi@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b0d1de0d-00a7-458e-6a56-08d86b5b6554 x-ms-traffictypediagnostic: MWHPR11MB1663: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AIv8mqbkcE5+Yz7NbKynFKB1gZ6Ys8B+gIuWWrfbzkEd96BuvL1HN5BKKw7+8bBz3Tuubd+xfi430PbyC9dUtxTYdcXxVe9cao0ZNJKFlp3LKHOmP7f+gTgVov8F3o4aIqSANntDh+vpNFetCpyhFS6h1kRdT14EtkIClv2xNF/+g2DX3voe8dO1Rf5RdsHbatfG1yxitfMJsmjglmNe0WFUwabTLVwQnHvN/iPnZLtVIi7ZgRVZlbO3PXVx5P25/LPRatw8Hvr/0MNUVXUI2hQ0y+4pm+aXdM2juUVgXy+pLFKoyO0bWMlSUpABPwaX5R+sNnJx6w3oUBUW0TQqRA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(7696005)(55016002)(86362001)(33656002)(8676002)(2906002)(52536014)(8936002)(186003)(9686003)(5660300002)(316002)(26005)(53546011)(55236004)(6506007)(478600001)(54906003)(110136005)(66476007)(66946007)(4326008)(64756008)(66446008)(66556008)(83380400001)(71200400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: yFvjb2QCLGfuDXjQ/oyZTwEhg8gZvs59OvbC80n1KvIWd3M22OiGBeBxUs3kWvvoDy3Rx4XoOjaxM90je6pb+4/IDGKTgJaF88kP0QWu1ID3Ep4O1VG8/977V13JQFtq6neBnyfIK6Lbrul4rLPNFVxrwFPWrpu7Ee4/HRUHb2uKLc/yvWvlI6RyH9ngXDZPrJ8TPRoE2zgX54ikmYSB7n+cfAS9HFWKFyIcuFN9mr5I5pwttbXimwuassa9WIVV8P5M8GY+8kECC0b7jm4wZ0MuvzwUp3XXdEaUaqq/4L5+H/gwYLpxs5Y28HrxZpE8dx0+GChUSbEdIOEDAnvjdGO/twSYCgl0iCNqoIONFaGhii1mBAf4yCz195ziZErRrfg9u+fIPUF8TQjj8qSZ3N/4IWXex36sKy9dulahZFEyXEvkv52CER/LqEzZ88qDWwSmbjLWWWgYv20+K197pcd/x8G8mpmbgqciIEnEqFfFh7zvCYJw/x05qMUWYjDdnhuPZ2gBxbiNzMlveJqXwImwxDS/D4d169SJHGJRvFHX6zKAvo/4d2EtIcaLyfgWXarOv+yqNTS3GP2WEvjG4/oVgVxX0MQ7SIG0DIZAwaS4Q95XnhtXsxRoEuTUuuLs9o7oH0Xfbq87v/Ad7PPI1g== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0d1de0d-00a7-458e-6a56-08d86b5b6554 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 07:25:55.7852 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CuUqVSddD8JuM3+X/YWlSas2yTzknHBMtif49LmTyWFwUN0p9WH0VI5SO1PGgh1fxcDQ0y9025zrodGhxc5a+BmtyJBpbwOTS/jSEec7+B0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1663 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" acked-by: abhinandan.gujjar@intel.com > -----Original Message----- > From: Ankur Dwivedi > Sent: Wednesday, October 7, 2020 10:56 AM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; jerinj@marvell.co= m; > anoobj@marvell.com; Ankur Dwivedi > Subject: [PATCH v3 1/3] test/event_crypto_adapter: return error with > unsupported mode >=20 > The capability of a hardware event device should be checked before creati= ng a > event crypto adapter in a particular mode. The test case returns error if= the > mode is not supported. >=20 > Signed-off-by: Ankur Dwivedi > --- > app/test/test_event_crypto_adapter.c | 33 +++++++++++++++++++--------- > 1 file changed, 23 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 8d42462d8..3c64742b3 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -750,15 +750,30 @@ configure_event_crypto_adapter(enum > rte_event_crypto_adapter_mode mode) > uint32_t cap; > int ret; >=20 > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > + > + /* Skip mode and capability mismatch check for SW eventdev */ > + if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND)) > + goto adapter_create; > + > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) > + return -ENOTSUP; > + > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) > + return -ENOTSUP; > + > +adapter_create: > /* Create adapter with default port creation callback */ > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > - TEST_CDEV_ID, > + evdev, > &conf, mode); > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n"); >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > - > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > ret =3D > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, > TEST_CDEV_ID, TEST_CDEV_QP_ID, > &response_info); @@ -813,6 +828,8 @@ test_crypto_adapter_conf(enum > rte_event_crypto_adapter_mode mode) > TEST_ASSERT(ret >=3D 0, "Failed to link queue %d " > "port=3D%u\n", qid, > params.crypto_event_port_id); > + } else { > + return ret; > } > crypto_adapter_setup_done =3D 1; > } > @@ -847,10 +864,8 @@ test_crypto_adapter_conf_op_forward_mode(void) > enum rte_event_crypto_adapter_mode mode; >=20 > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); >=20 > - return TEST_SUCCESS; > + return test_crypto_adapter_conf(mode); > } >=20 > static int > @@ -859,10 +874,8 @@ test_crypto_adapter_conf_op_new_mode(void) > enum rte_event_crypto_adapter_mode mode; >=20 > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); >=20 > - return TEST_SUCCESS; > + return test_crypto_adapter_conf(mode); > } >=20 >=20 > -- > 2.28.0