From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93EF8A04B5; Fri, 11 Sep 2020 09:37:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D9D71BF90; Fri, 11 Sep 2020 09:37:17 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 4E1381B75C for ; Fri, 11 Sep 2020 09:37:16 +0200 (CEST) IronPort-SDR: UZrZKm0OdEnxlMYUMhB+o11OlvyTj88x2BqIJVoOJ69U2oZtn++xTJSQqsdb+aprr2EtPmnZrk K6d8g3fA7HwQ== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="156110445" X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="156110445" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Sep 2020 00:37:15 -0700 IronPort-SDR: JvN8qLe9ji32r9NxiQd9KxlvQDlLrseRU349VIMJSDQ/f8NVOgix/X3j9pdbeJDpkrBkOmbLbL fT/9o+4JMKwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,414,1592895600"; d="scan'208";a="506122712" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 11 Sep 2020 00:37:15 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 11 Sep 2020 00:37:14 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 11 Sep 2020 00:37:14 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 11 Sep 2020 00:37:14 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 11 Sep 2020 00:37:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fnf/qgPygzaRex4z64VNLpGsZwkaSL4hzHMrLqOkIa3qLVeeT+cbmQ5zrGEzuk25W5gPJM/j/kBbzrUcKomNsdGn0za9bvLA3tpIGWnNkn5Dl077B65Kiynu7FUoNxCoW05nO9fCkjLVa0npf4gkdpNf/F8VmoF27V6eToyU62+CLVFie9jCiTTRiEepMbQgDSQEtwW+5muAp3YtS6CKDRTxR8N5C+benOeHwygIkfQgvW0OsWzWDSQgJ5s8RZVu15ZbiI2oqI847j71JzBrWfUEFd7fdXdwIO9jesvTPUHPSi3rhSJL7WBx+a4A/lV3rT2x68XgV5RMA0yMGy99lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1m70B6Ai64LcRwVOW3y+VHVIvWxKABv9BW14PrQCeU=; b=eMDu0lLn8Q94oUlPxV2rp98dXWoZl2v5Jsp11FsEzPHOG8yzO4/p9XQk7UuVvVrdhfryR/mP0WnMgZbiDg9HOhvOuBgebG+HHTzpQZwFDQwSVHIGpep3MsugFrsDqFEs8QZRxPxhbf8jJTqyFDelM9cFM35mw2++Ax8o+yWFo77AZEimpKDJmfMhd5oRLvvcZqqZ2CTHphWJN2wZZLQaMnkjmYar6DO5P1wG8yD7+kuvpCdea8guOWz9ZxnFX0rl/eBbT96ndijvNHyy9qnKr1me63q9wD/WITbV90q1NvvqXjAi6SSXVp/vWELhDXIGsXQNurz8L4Ah4X+jG1MCqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I1m70B6Ai64LcRwVOW3y+VHVIvWxKABv9BW14PrQCeU=; b=V+hTp0W4o85DQNxq11YoXAmRPDVHVe4T7BObjMuNtvDk4Zz+5jKM27+9hUphHyOvA7+LnnSfdhDhuEKgyP9jcHr4h1xzxV6hJAKXzr6qDf7s0JWW/R3cSKteFMMr4TGWRyPwSp4ncB3qW+tlcMXigy/reG7WF9UV4/M053JjfqQ= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Fri, 11 Sep 2020 07:37:13 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f%12]) with mapi id 15.20.3370.017; Fri, 11 Sep 2020 07:37:13 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcC1yYDJ1So6OUGIgVlNZgXtbKljELJw Date: Fri, 11 Sep 2020 07:37:13 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: <20200908091534.24305-2-adwivedi@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3c4158a-fa82-42d3-3899-08d856257fee x-ms-traffictypediagnostic: MW3PR11MB4747: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3968; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7SNlaSruitZbTQ1++bsaF07dIYSuyaY7i49uc0qrSFnow4fRHF3qEprm8QiJb8VOfzEuB2abCT8X+JHiTYwj92anICcDLDcU7Wqys5gSo5tw58sywp13DLF0GGBoRM0GQXztyAgG+ku8wn7Q+fiBmtb8H2Bc0VqmqMAgGZpPNrnAGJi2lnXMHdPlBA7EMJU2iLvU08KW+7jGQ0WrlwYmc8pnH6djK8hTrpR7cyoGP77zI4kzo1I3vss2PqVIB82p8VGVFQx44fb4ZIZ4NX/ogp3pAyfKrEUwGTT0I4EN6JLYSBhcB1poFIHYHbmQu1gL4XIwf32fZMrnINegGarduA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(366004)(136003)(478600001)(4326008)(66476007)(26005)(53546011)(33656002)(7696005)(76116006)(6506007)(316002)(64756008)(71200400001)(5660300002)(66946007)(186003)(66446008)(66556008)(55236004)(52536014)(54906003)(86362001)(110136005)(2906002)(8936002)(83380400001)(9686003)(55016002)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: /IZnZm0zbjKa7SOZkcrJnStAbaWXtGd9mPnctUJqFRQNDBOvtiBEdNiJg4UIYE+o+3apGR7RSMTiFXrrgdJoJWkgWo5B6grcrvMzSR+icMWLNdgp2Yga/fnAFG9likAgvkj8cPCarZN7FTXVDUmRv6ffnM0plY4iTJKmC09nKqt/MeL5wwUZf9nt3iJUU5zG/HttdgR2Meo+7BG5l1j1XC49QJlPi7igl+lm8xtcUDUFQsaHlUvoRPlZ+zjb1GTHGSW1ayMv5zOjOF2BrKmuGCYesmJsOYdJO4mUoZBQ4Dl/V0qn2tGNKX8mFZBBtMXi3sW0X1Rztuya99lTL4sqQ7IxyS4Cs/+Tugj4OckdNM0HrqXTDQI4fW4GbfvEOEKNUdx21c1bqU3pOn91EoqCOg6rcBdAJ4gpk4pLQdNpxC8H3fhioSE5yDjcqEJeY+nPs7QRmMRcoaosXH6PEm2abHjVcAFaNEZw130FOHI14J5e+vPy0FhhnlAVv6WDMmEaeyUXVfJvrPtSvO+y8AKsbd11/5aYErceFc++WtNsviLtB7fk/S3Ao/i8XRl9F+01bE52VrUNxEdqTXAU++MRchZYAQ93AmagBoSWjovEp3tWxGIKtUuXjmgf5Gp2eabNnDkXcQBRQSNktWt8Iy0DUQ== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3c4158a-fa82-42d3-3899-08d856257fee X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2020 07:37:13.0593 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9FFIhEZ0v83h/1h38WFHWgxcsyKUTgEBAXAmxFUWpxl1fddcr4akh1sDUvnMT5V947XB8l82+DuDFqpTygPeDjIJoXVosTJ9x98kySndWnU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4747 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Acked-by: abhinandan.gujjar@intel.com (For series) > -----Original Message----- > From: Ankur Dwivedi > Sent: Tuesday, September 8, 2020 2:46 PM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi > > Subject: [PATCH 1/3] test/event_crypto_adapter: return error with > unsupported mode >=20 > The capability of a event device should be checked before creating a even= t > crypto adapter in a particular mode. The test case returns error if the m= ode is > not supported. >=20 > Signed-off-by: Ankur Dwivedi > --- > app/test/test_event_crypto_adapter.c | 30 ++++++++++++++++++---------- > 1 file changed, 20 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 8d42462d8..930c2a9bc 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum > rte_event_crypto_adapter_mode mode) > uint32_t cap; > int ret; >=20 > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > + > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) > + return -ENOTSUP; > + > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > + !(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) > + return -ENOTSUP; > + > /* Create adapter with default port creation callback */ > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > - TEST_CDEV_ID, > + evdev, > &conf, mode); > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto > adapter\n"); >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > evdev, &cap); > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > - > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > ret =3D > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, > TEST_CDEV_ID, TEST_CDEV_QP_ID, > &response_info); @@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum > rte_event_crypto_adapter_mode mode) > TEST_ASSERT(ret >=3D 0, "Failed to link queue %d " > "port=3D%u\n", qid, > params.crypto_event_port_id); > + } else { > + return ret; > } > crypto_adapter_setup_done =3D 1; > } > @@ -845,24 +855,24 @@ static int > test_crypto_adapter_conf_op_forward_mode(void) > { > enum rte_event_crypto_adapter_mode mode; > + int ret; >=20 > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); > + ret =3D test_crypto_adapter_conf(mode); >=20 > - return TEST_SUCCESS; > + return ret; > } >=20 > static int > test_crypto_adapter_conf_op_new_mode(void) > { > enum rte_event_crypto_adapter_mode mode; > + int ret; >=20 > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > - "Failed to config crypto adapter"); > + ret =3D test_crypto_adapter_conf(mode); >=20 > - return TEST_SUCCESS; > + return ret; > } >=20 >=20 > -- > 2.28.0