From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 23516A0521;
Tue, 3 Nov 2020 08:45:28 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id EA770BE71;
Tue, 3 Nov 2020 08:45:26 +0100 (CET)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id 9F524BE6F
for <dev@dpdk.org>; Tue, 3 Nov 2020 08:45:24 +0100 (CET)
IronPort-SDR: JlhvpEYZu6tvH39eU0YZDM8AQoweKy+PhBVS9FwXuUGij3afQqxdAOyk4RD3yxEq0qV3s6CyuX
4Zmo1cNKgczA==
X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="230642192"
X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="230642192"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
02 Nov 2020 23:45:22 -0800
IronPort-SDR: WoCvtV/Q3i8t7JIjdp1AerTeSYRDlk0EsKkNqqbBXe5Tf9J98YYb2vYFbr9iMrUUZA/Raomz6j
370vkXGIjnAA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="527021398"
Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14])
by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2020 23:45:22 -0800
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Mon, 2 Nov 2020 23:45:21 -0800
Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Mon, 2 Nov 2020 23:45:21 -0800
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176)
by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Mon, 2 Nov 2020 23:45:21 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=jlST8ziqulYR3JJ6ahcttoQzmt+0M1DDkFfrkOM5S5DvUUHfs0cvoTAFpkZk9jL45eSW17Pz2fibrD1VU/+XlXgCwrkalmK60MKQ3YgeoE6KuE8NFaz1GYNF094uPn6PtcFJ002uSp+MSHGo7bBU9YJ/ScJhLoj5TKWnTWpHJr/AxTh6nLFuA2Bnf/VSRKIBbAWvw6VybznBmBIIZ4dWLkowOq+ThzoBJxsHn+HH9p/4oWWCGO7jg9aS40eNJ88zHlP5gGJG7hDKKURqzNJVQHIuJnnKE4yv5zP0DlHLjV3QDi+ylfs4Kf3chr5Qtvfkk7dfHoPfTL0PIaFwoMB7xQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=eo4/drjB+Lc0EVyA5e2/RCfIOrWjWFoDpJ0rs+ucPYg=;
b=PMPr1/6DXduu1aOOKhik/QM4mFGBdTWjhBHsOdIj/lTQPmK43WTx5Y25v5NT3veBAvpaUzcTQuOvKwshrjMBtWre2WjSZHf0xvKGRxwMzHEoFO67YQCbB2yid9PWqR8UK3HFwFpLH03gR06a2nUmaYWfn+uq21g/91BtYB1fF9jVN+nEMkAPhxMlWyWiEGEVkoC1HqfD7/o7x39Jg9VYT5wSW5ObKO/3nV6FCE7ABXnpLK2hRn/dax5/mMYP97P2I2+N8MzGTQelE0grZM9HUSfo3adOeks/R7eDv1NqBqupO5v6IBpM/SeFYJh5iQJ7U0gRcNTXpJbTttjtrUYQXA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=eo4/drjB+Lc0EVyA5e2/RCfIOrWjWFoDpJ0rs+ucPYg=;
b=pxcM04lES1b0wd1xwZH+q+ZfMm7f8/gJxGLqxLfJlJFeB1OYGF5F4hYq+1MPdgSaW0kuL0Dktc02hsKDpZAVf2PeLGgRLQU8zOIUorJuXrrZamRBYrsGFAytFb5z6m+PDFq2aorMK4rImlcZhGw79o1KLivojw1PNZsc3egcMOE=
Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11)
by MWHPR11MB2063.namprd11.prod.outlook.com (2603:10b6:300:29::12)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Tue, 3 Nov
2020 07:44:48 +0000
Received: from MWHPR11MB1838.namprd11.prod.outlook.com
([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com
([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.029; Tue, 3 Nov 2020
07:44:48 +0000
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>, "Honnappa.Nagarahalli@arm.com"
<Honnappa.Nagarahalli@arm.com>, "Ananyev, Konstantin"
<konstantin.ananyev@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>
CC: "Vangati, Narender" <narender.vangati@intel.com>, "jerinj@marvell.com"
<jerinj@marvell.com>
Thread-Topic: [v6 1/2] cryptodev: support enqueue & dequeue callback functions
Thread-Index: AQHWrpUcu4l0aZzUeUWHkBKE9uoPCKmwd9qAgAABNjCABCEKsIAAnOCAgAC0hfCAAAxYAIAAElNw
Date: Tue, 3 Nov 2020 07:44:48 +0000
Message-ID: <MWHPR11MB18384227BC119135C24F4D36E8110@MWHPR11MB1838.namprd11.prod.outlook.com>
References: <1603926611-19086-1-git-send-email-abhinandan.gujjar@intel.com>
<1603926611-19086-2-git-send-email-abhinandan.gujjar@intel.com>
<VI1PR04MB31683AD536BA31C84FEAF42FE6150@VI1PR04MB3168.eurprd04.prod.outlook.com>
<MWHPR11MB18386C90E0790BF149F55BE6E8150@MWHPR11MB1838.namprd11.prod.outlook.com>
<MWHPR11MB1838B898F503A13CEE68B00CE8100@MWHPR11MB1838.namprd11.prod.outlook.com>
<VI1PR04MB31680BD6B72042507911D349E6100@VI1PR04MB3168.eurprd04.prod.outlook.com>
<MWHPR11MB18387594E26D758947EA5536E8110@MWHPR11MB1838.namprd11.prod.outlook.com>
<VI1PR04MB316817DF799F9AD6A6971C08E6110@VI1PR04MB3168.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB316817DF799F9AD6A6971C08E6110@VI1PR04MB3168.eurprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: nxp.com; dkim=none (message not signed)
header.d=none;nxp.com; dmarc=none action=none header.from=intel.com;
x-originating-ip: [103.5.135.70]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 90063061-37b6-4798-804d-08d87fcc5752
x-ms-traffictypediagnostic: MWHPR11MB2063:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <MWHPR11MB2063C6DEB168BB32A9F659CCE8110@MWHPR11MB2063.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: Gw8TSSM/ybde9iG5scv1eTPrU5n8/ymcH8gvPyAqUeUYoSofxNrsyqxOpJ/TGyLq+B524krZsk3n0hqRDQJwYMPMudjI3Qis/vp8EUhEw86Ls8xTTJzV6zVo0c/6EHl/TcCwtbg+kEyfNZpxfM5acKh6zxb+IIzP5uxcDuuqE0SUjC8jDqSiVvSxSrW2IVy4yNS4/ItrhLZl1sSa+a67y8YFkxJU2ld7qcOOBabQ/7PfcIq5rQx3BRevHAUYtrtW+Xwb05uzqDeBIBDDEWLR8gyH8Zfitfk84oY16k6un47vzZMrzgRdGJ9ZjyEyc267PUtwpA7gzkavymglZoCAMQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(396003)(366004)(346002)(376002)(136003)(39860400002)(33656002)(86362001)(8676002)(2906002)(8936002)(76116006)(66446008)(66476007)(64756008)(66946007)(5660300002)(66556008)(52536014)(83380400001)(110136005)(55236004)(4326008)(53546011)(7696005)(54906003)(26005)(186003)(9686003)(55016002)(316002)(71200400001)(6506007)(478600001);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: mcLF+y4sjqDN5V4fUO6hOXtsp3TQEmGCBHmrV/MgqSe2XrgvRG4EEDjSmi5uv2A+piSPVIMA57OjjYQ/ln4s244jhpo/50byEvERsTwhLCoPkYHYjmH7RqFkkKNxT9WBmW5R4px1UwaMT0O67iRDIaysEhs4nCE5nMeDWtHWZ/6ms4+0lwQ6DAXsXZAn/3MM/EgUddlOKE4EmYmQjsv4mkSgsApgpTalosm1hki8VSrCBsMLu7JoO9nPzn1g7SN2A/ypXhNfKLUsNXE+OBiYIY/wNsUUWBUTZuK8rY66pO8eilLGIW9QkJKkS00UhowlIfi8Y4pkOOxgz1T6r/nQXHYSBHoPfSaGqsJ0NeSblaJeH8a6x8CBYaXRMN7EKIDIE2a0tUPoJfppPq0CyQ/20lONyuLHahBEGaFL+vo4R0YDati5i7iG5/tq0pgl1y7YQGcxp0Dfr2gySvD8EhE2vw/rhgj8JI1lQeECsdx6WciLQZK6b4LRKgFoXuDb5y+WqVrj0AApHFUFHGD/4Ng8jX9YkTJG17r4xOjMAiyED+9dVbG7By/AB9EoNtP80YsA1dKLCXvocobTmd+tXPtDjYPnbNywNgwsMwNRbhbuEsWlv5INjSIf1mHZYI5T99HQgBiWOg7ePm2f2O+YkIpwjA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90063061-37b6-4798-804d-08d87fcc5752
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 07:44:48.7296 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uCUv2relZP5MAlC50rxjJSJ78mHZIKWNUI1O9iZ1hxsUKse/cWB2hH3teMGZ1NKuilyngVdVAidq918Wao7aZLdc7jcNuIDNoZgSYJEA1Xw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2063
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue
callback functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Hi Akhil,
> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, November 3, 2020 11:58 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> Doherty, Declan <declan.doherty@intel.com>;
> Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Cc: Vangati, Narender <narender.vangati@intel.com>; jerinj@marvell.com
> Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback funct=
ions
>=20
> Hi Abhinandan,
> > Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback
> > functions
> >
> > Hi Akhil,
> >
> > Can you please go through the patch again and check if any more comment=
s?
>=20
> As I suggested 2 times that there are documentation issues. Haven't seen =
a
> version To fix that. Please check it at your end and try fixing the timin=
g of your
> system so that CI Can pick it for compilation.
As far as I remember, I have pulled in all the comments from you for the pr=
evious patch.
>=20
> > I understand that we work in same time zone, getting feedback from you
> > in the mid night will not help me/you to pull this patch in.
> > A quick response will enable me to prepare patch set quickly and send i=
t
> across.
>=20
> I am not dedicatedly working on your patchset. I will work as per my prio=
rities.
It is same for me. End of the day, we have mutually agreed to get this feat=
ure in.
> Had it been a CI pass for compilation for both documentation and code, it
> would have been applied last night. I could remove those extra spaces, bu=
t
> there are other issues also as the newly added APIs are not visible in ht=
ml files
> generated. Please ensure that there are no issues in doxygen build issues=
and
> should be able to see the newly added APIs in html guides.
This is the kind of information I was looking for, which was not available =
in your
previous patch. If this info had been available quickly, I would have prepa=
red next patchset.
Anyway, I will post the next patch set.
>=20
> And please note, do not top post your comments. It becomes difficult to r=
ead it
> in Archives.
Ok
>=20
> >
> > This time, I will prepare the patch along with dequeue test case.
> > Hope you understand the concern. Thanks..
> >
> > >
> > > Hi Abhinandan,
> > >
> > > > Hi Akhil,
> > > >
> > > > What is the status of this patch? Is it pulled into RC2?
> > > >
> > > >
> > > As I suggested below, please fix your date and let the CI pick your
> > > patches for build.
> > > In my local build for documentation, the newly added APIs are not
> > > added in the Documentation. Please fix doxygen issues as soon as poss=
ible.
> > > Did you try building documentation at your end?
> > >
> > > Regards,
> > > Akhil
> > >
> > > > >
> > > > > Regarding the date, I am not sure how it can be fixed now.
> > > > > May be the space is missed out as well. Could be please help?
> > > > >
> > > > > >
> > > > > > > +struct rte_cryptodev_cb {
> > > > > > > + struct rte_cryptodev_cb *next;
> > > > > > > + /** < Pointer to next callback */
> > > > > > > + rte_cryptodev_callback_fn fn;
> > > > > > > + /** < Pointer to callback function */
> > > > > > > + void *arg;
> > > > > > > + /** < Pointer to argument */ };
> > > > > > > +
> > > > > > > +/**
> > > > > > > + * @internal
> > > > > > > + * Structure used to hold information about the RCU for a qu=
eue
> pair.
> > > > > > > + */
> > > > > > > +struct rte_cryptodev_cb_rcu {
> > > > > > > + struct rte_cryptodev_cb *next;
> > > > > > > + /** < Pointer to next callback */
> > > > > > > + struct rte_rcu_qsbr *qsbr;
> > > > > > > + /** < RCU QSBR variable per queue pair */ }; #endif
> > > > > > There is an extra space in each of the comments above between *=
and
> <.
> > > > > > Check other doxygen errors if any.
> > > > > >
> > > > > > I believe the timestamp in your system is not correct, as the
> > > > > > patchwork show Date of 2 days back while the patches are sent t=
oday.
> > > > > > Could you please check? I believe CI server is not picking
> > > > > > your patches for auto build.
> > > > > > Please correct it so that auto build can happen. None of your
> > > > > > version was picked by CI.