From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 786C5A04E6; Fri, 30 Oct 2020 18:19:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A47D72E8F; Fri, 30 Oct 2020 18:19:09 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id AEE8C2E8D; Fri, 30 Oct 2020 18:19:06 +0100 (CET) IronPort-SDR: 6ayCLnhnrUVtE/3pMJCyu5s/atR+xtdbScIi+OJUwtmWkGJBkSoORp4v3FxZEEVBYFlIkLxkAc AuFzEQC1P6hw== X-IronPort-AV: E=McAfee;i="6000,8403,9790"; a="230275283" X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="230275283" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 10:19:03 -0700 IronPort-SDR: mMgtquKXDGbr+YBrN+pQ79gh7QRdZEO9kZVRgvuPn6pHuqPjS56nD1hDArvMeIk0Z5SSRcweU4 HeozgRXAKcvg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,434,1596524400"; d="scan'208";a="324146084" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 30 Oct 2020 10:19:03 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 30 Oct 2020 10:19:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 30 Oct 2020 10:19:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 30 Oct 2020 10:19:02 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AGYQdAPO4AyX54iTy8AXKA3Ad0k7Sl7VPLyVTsNKkUjPWEDwxjcJEKoin4O2/UxlYuktDyOc4jODQclUzTNS7+ChuP/cMkf/Cmk0Yhi6EzVoJapp2i6678clqq5kq36ZJWXLT2CmpRoXNJxbqjvCvbtxmEcdTzZSqDcDi0mzhvNEDsQiwI+7T1ubiC658d+dplEby1aiKQnb2OmJq0om2zf8m+635FZHoDABaW79SDx/Z5qV6+umZga5fSonfn6k/PhIKrsruckdQ2w370XBE02tHNCcWlyWrEXBDEoBkthUnT+6IA8srhi9tSGeexOGEB/NkGvA8z9gi8x9YJAGgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aW5J7fjNBbTdsxULis3IFnvOxVW0IN6gW07RQmxPla8=; b=Vdx++FKoSfykNZg57kC1/A3Ik3vPNPRMy1fLm8O7FX8Ad/AkEVxCwAb4B+H1eUEeSDd2/FCCnjDJ4zuN6m5D8m+53oLaDMVMRUadNyzxC/6aJJkhaNNPlmPvmGiaJfPGEMPgVOsSxPSFRL6Ow4WaUi4zOByJh3/b2vECDMbtfJxrqf2lCsVu+xw6qGF5YL4cEikS7ESXOh8HcEZPKfN4Dem9Gst65lYjPiJer9AKzaVoCN05JhdE59sVsj38bqGPxG5TpkrEIoKIHugTjhPYU1FGQhyWHsGG/YWg1XiUyCgleukzB1/+cUdHXJbKIvqaEGRcjVPJJqKIT1EIO5MFKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aW5J7fjNBbTdsxULis3IFnvOxVW0IN6gW07RQmxPla8=; b=IKDINXyGi6MT66X8eH+BCcfLH/wMoSZF4OJOaqCOCptvXXK9/FOXEhrYmz8xKQ6kieuMV2wc6fX7/IEDeZxttYRPMlxmazuj22Xw2QP6d2uolbeYuekBnY5mkAOz/5AKVtNr6z8oJrjv+w79mCou5hu9Vu38BOncdiwTsGm7Ua4= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB1552.namprd11.prod.outlook.com (2603:10b6:301:e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 30 Oct 2020 17:18:59 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.027; Fri, 30 Oct 2020 17:18:59 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , Honnappa Nagarahalli , "Richardson, Bruce" , Ray Kinsella , Thomas Monjalon CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd Thread-Topic: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khg/yqaE27MkanYRdfhPnwbqmrxnGAgADn6NCAAE1qgIAAGfCAgAAL9QCAAAL2AIABeSNwgAACeYCAAPClUIAA2JLg Date: Fri, 30 Oct 2020 17:18:59 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c9da6bd3-e3a0-42b8-3839-08d87cf7e407 x-ms-traffictypediagnostic: MWHPR11MB1552: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r0LYwMoOETE95KiAJxc7EjbOf5E9zIM5RGjN7Ri69280kik8SVLtEeNNgdzdFn/1+AuUd00AkJmkTb1qy815lOUVG5ij6oH2pqrSfWc5TMGA/gcIBWGihEACchODDNZTfbD3nHsXR3xNIJ54uPDGwBwgMpPi/+VOwcAZPz6+7HZsrZc2tKXxws1NH2L7Jzk0mtm3Kk+sgqJ9IvAsrSMWxmHF1zM7iSi75fjwruJI/qbFRucMHZfP+DKRMM8L24NVuHWXI2ao3elteDpWlMCnsDFb5UDHdFlu1tYI9D2k+YMDz+90MwOJ6RWGW32hVZBv9Z57oo7jnP1s3QqfoVJViQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(7696005)(33656002)(53546011)(54906003)(478600001)(9686003)(26005)(110136005)(66556008)(316002)(66446008)(64756008)(8936002)(83380400001)(66476007)(5660300002)(6506007)(52536014)(4326008)(2906002)(55236004)(2940100002)(55016002)(71200400001)(186003)(76116006)(66946007)(8676002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: fpPTVseeFq/QaBe66t5yewjJ2CEtvs2RiWReIiy/oNOd2Ey1Kb/+uNKEJFfLWnqu2/ZSUUm/ZVaHsryN6FBa24Q5SAWMnUV648/y5uyuB5lVYKs0z21v87ijInCbPEtYR5/WIWRpqFYD271QAN/+lq54snnymm+Gt3salFrWM7T0JP9BjOiAYnpxPwYQeGoFHzYsY8UEi76YT5vkySQRuQ7ZUGAHc3/Po5pQRRM64q0MmpPb1QuoQMfDAhLDbrhUSS0+XFhTf2PcnryP0TReLQve7sh31t65hSdTzcBpgGkyrHW/2uxQMS2/ZjcUarS3ZMgCjCBQSnr25HufRmvz/ewww884zYIqlZFUMobDEbE1C3wx8HzyCT0y9AI224kux5Yl/DXFcnIpshKYZSGxlH3D9bIiB5csGEoyQQ5p1pZE4wwCcUtTbTAJRy3QTkKDTWSdLgJHVvtfXvRgYarh47Ltu2HOCV2RX3Vo3WyanftJoYY7M+iwx5EJd8jGskITiheWc2SWAqBrQ75YTph1c/VqV9OUyH60/akZfL3cO9ZRKRRnpzYNmx9MpqHbay/oTCoDVUYM157YYUWrM+qMFL2GbwmY8R4wwRJQRAfR5t93yGBb3uyAwq1/MH7ikWKjC/uTvgI5MH7pe6fukjHi+A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9da6bd3-e3a0-42b8-3839-08d87cf7e407 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 17:18:59.5450 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QEdzWLlVaHTASPyXG97K+aPy7tpV2Ne/0+EaEhVbZqxeb4mfbeKalFW88UpDDhqOCRgjEuTS8w8jWCBjXARJXSbdv+rSNjzdeVeHNqJEqfE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1552 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, I have sent the v6 patch for RC2. As discussed, I will get the test app updated for dequeue callback for RC3. Thanks Abhinandan > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Friday, October 30, 2020 9:54 AM > To: Akhil Goyal ; Honnappa Nagarahalli > ; Richardson, Bruce > ; Ray Kinsella ; Thomas > Monjalon > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Doherty, Declan ; techboard@dpdk.org; Vangati, > Narender ; jerinj@marvell.com; nd > > Subject: RE: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callbac= k > functions >=20 >=20 > Thanks Tech board & Akhil for clarifying the concern. > Sure. I will send the new version of the patch. >=20 > Regards > Abhinandan >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Thursday, October 29, 2020 7:31 PM > > To: Gujjar, Abhinandan S ; Honnappa > > Nagarahalli ; Richardson, Bruce > > ; Ray Kinsella ; Thomas > > Monjalon > > Cc: Ananyev, Konstantin ; dev@dpdk.org; > > Doherty, Declan ; techboard@dpdk.org; > > Vangati, Narender ; jerinj@marvell.com; nd > > > > Subject: RE: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue > > callback functions > > > > > > > > Hi Akhil, > > > > > > Any updates on this? > > > > > There has been no objections for this patch from techboard. > > > > @Thomas Monjalon: could you please review the release notes. > > I believe there should be a bullet for API changes to add 2 new fields > > in rte_cryptodev. > > What do you suggest? > > > > @Gujjar, Abhinandan S > > Please send a new version for comments on errno. > > If possible add cases for deq_cbs as well. If not, send it by next week= . >=20 > > > > Regards, > > Akhil > > > > + Ray for ABI > > > > > > > > > > > > > > > > > > > > > > On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: > > > > > > > > > > > > Hi Konstantin, > > > > > > > > > > > > > > > Hi Tech board members, > > > > > > > > > > > > > > > > > > I have a doubt about the ABI breakage in below addition o= f field. > > > > > > > > > Could you please comment. > > > > > > > > > > > > > > > > > > > /** The data structure associated with each crypto dev= ice. > > > > > > > > > > */ struct rte_cryptodev { > > > > > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -867,6 > +922,10 > > > > > @@ > > > > > > > > > > struct rte_cryptodev { > > > > > > > > > > __extension__ > > > > > > > > > > uint8_t attached : 1; > > > > > > > > > > /**< Flag indicating the device is attached */ > > > > > > > > > > + > > > > > > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > > > > > > + /**< User application callback for pre enqueue > > > > > > > > > > +processing */ > > > > > > > > > > + > > > > > > > > > > } __rte_cache_aligned; > > > > > > > > > > > > > > > > > > Here rte_cryptodevs is defined in stable API list in map > > > > > > > > > file which is a pointer To all rte_cryptodev and the > > > > > > > > > above change is changing the size of the > > > > > > > structure. > > > > > > > > > > > > > > While this patch adds new fields into rte_cryptodev > > > > > > > structure, it doesn't change the size of it. > > > > > > > struct rte_cryptodev is cache line aligned, so it's current s= ize: > > > > > > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > > > > > > So for 64-bit we have 47B implicitly reserved, and for > > > > > > > 32-bit we have 19B reserved. > > > > > > > That's enough to add two pointers without changing size of th= is > struct. > > > > > > > > > > > > > > > > > > > The structure is cache aligned, and if the cache line size in > > > > > > 32Byte and the compilation is done on 64bit machine, then we > > > > > > will be left with 15Bytes which is not sufficient for 2 pointer= s. > > > > > > Do we have such systems? Am I missing something? > > > > > > > > > > > > > > > > I don't think we support any such systems, so unless someone can > > > > > point out a specific case where we need to support 32-byte CLs, > > > > > I'd tend towards ignoring this as a non-issue. > > > > Agree. I have not come across 32B cache line. > > > > > > > > > > > > > > > The reason I brought this into techboard is to have a > > > > > > consensus on such change As rte_cryptodev is a very popular and > stable structure. > > > > > > Any changes to it may Have impacts which one person cannot > > > > > > judge all use > > > > > cases. > > > > > > > > > > > > > > > > Haven't been tracking this discussion much, but from what I read > > > > > here, this doesn't look like an ABI break and should be ok. > > > > If we are filling the holes in the cache line with new fields, it > > > > should not be an ABI break. > > > > > > > > > > > > > > Regards, > > > > > /Bruce