From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5478A04DD; Wed, 28 Oct 2020 09:21:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63D39BE4F; Wed, 28 Oct 2020 09:21:14 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 04499BE3D; Wed, 28 Oct 2020 09:21:10 +0100 (CET) IronPort-SDR: /YEkJASOXHB6w8+1aLZzmHrmovpuuFU2VZ0U/n8P/RNOQ6FHnaI2AVt9WGGIOEMQKjKBbsgStX rI84i+6jTwOw== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="185978414" X-IronPort-AV: E=Sophos;i="5.77,425,1596524400"; d="scan'208";a="185978414" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 01:21:10 -0700 IronPort-SDR: P8zW/ptqQRydqUxhliRH5wIek1OTZa17AhflQNq3BhpfRoYawLeEhfwHbM1/U9qByiAOhXdTpf UNizyfUS8LbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,425,1596524400"; d="scan'208";a="526243671" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga005.fm.intel.com with ESMTP; 28 Oct 2020 01:21:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 01:21:09 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 01:21:09 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 01:21:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 01:21:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OFbB5Do2rEkNyLMMV1FSmkRKmmQdUpmCWp5EZ89K8a2FhWpUhQCPRvQ6DG+Sdhw3xoyIOHHYDYj7+wdmXbsWbWPjutyFrNB+WssCJNjoQ827ZXQfoUcXEXy8ONt87GCUr4oh5RHkhM04brEmQ2KkLy2N6mZsnAwhV6zr+O5d4a8hF9nmI2xu3R8IpaghSQ77H/rtYqyZGRGNKRUlh4OKmoHm+oNT1QXHAgOAXPSBbMyINzbQ6/YLF6ASOnmn8kRnBXTQjBCjlaB8AsHLRdNFeWf9ZlpSxDbpI95DsjYMO/cMwAARDuF3ns7Dd4cxyq6OP3JYkuEUd5Z1XC4gqnl3lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYxs6o3av0nuaz5onvSup1VcxTexlUwPDrvraHQWv8U=; b=BnZ4JRKyo9iauEKy8sf0lK6GN0JIG6DRtNy6CDDhoZNHgXB0AM7YHIFIyXXw3LKEqHsFz6VgLaWL/sdUJd1JgTa0JnDqe0w7LPMYxNs6LwyI5TPI+oVRfadVnKnZwSR0XSHtH4waKCtjWR0sg0D0R9T7uYgZ8K90ssNm0YH2TzXxHmTZ/ifgBIl/5F+9ZR7/ZrQ9h+Rz0ok1AuXA/nd8IfHdcCGTZrri76XaX5YeknLTjcqUWtuTDjajgQn2lhBHugcezre4xkZ249kGObReGZ575n6cS3SivIZW9EkgsC0soi/j6QtSyfoZodWeIilVZG+cU9ruoO/vmE35LNOr6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KYxs6o3av0nuaz5onvSup1VcxTexlUwPDrvraHQWv8U=; b=xmqjosfxC07vJF4vkKE/HS4/PL7+jT568p+aOs4rSwDy7RSy1yqyfFy9pihtiglgGgXUiauZD5FNsQazBiVN1kOgGPNgM3oQVMcZA0JsgjeE/6Ck1KjXsoyqSK9DqBwNprQTdR2D2W2v0ecMPzOzqpQOvx0rqC60gt2VYANul+4= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB2062.namprd11.prod.outlook.com (2603:10b6:300:2a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Wed, 28 Oct 2020 08:20:58 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.018; Wed, 28 Oct 2020 08:20:58 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "Ananyev, Konstantin" , "techboard@dpdk.org" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khg/yqaE27MkanYRdfhPnwbqmrxnGAgADn6NA= Date: Wed, 28 Oct 2020 08:20:58 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 918774bd-744d-4130-324d-08d87b1a664b x-ms-traffictypediagnostic: MWHPR11MB2062: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s7U7Q8p8K3Zhl8/LJlL1q2TAvFIB50YtTtsC17ZLfo3KSQ21MUvzfbOw5CTM68JjxLvAd2ToGwWZ2pRyr0Xtv5t9xsVF1TK/4reTf49iXpsuokO3BlbcxqHShhhTIdFC6hDgbXLF36L41yUSMW6jJAb9mmmH7+rPcXz3JV+FmC+5vuKMv+gcuNQPcksyCgNQcekc7Tim0BkHleguC6ygvy2GWoYSHZ/MKPFCkJcJLZFqlny+gN9xsi4iMtuCqObWQrrwaClZMJUUVDmL6yhBA3X259JabF5e8cEr9IhpZR6gmKwxu+PVds/27zx2S1dMH57dnB0sJ4u8qnYsK4r+6tyACEmOjLVf3fRjkpWgmcXm3kd5h7T3kWtFRI1XttyNM0qzMeZVsHWAuU4BBtKd2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(86362001)(110136005)(4326008)(186003)(9686003)(52536014)(33656002)(83380400001)(55016002)(478600001)(54906003)(316002)(2906002)(26005)(7696005)(66476007)(71200400001)(55236004)(53546011)(8936002)(66446008)(6506007)(66556008)(5660300002)(76116006)(8676002)(64756008)(66946007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: E2ycvIaxwUJa+WsR0JgMfjdnNiRK/+L74Bn50HOH2a6eCXXF1ju666hFGdy9ADRMDtYJBD9vcfaJeZnhTYysDrG0ZSP8lite+hnvs/etm3Laz++EJ2aRSa1bAK0aYbCgI9DYg9q2CpJ+tF6PpfpuqBYGEsDiOBRwjeyKiP+7m9q1j4X00t4UAbLC2Z7zbMWaYD4qAhfejrd7eBskxIG097+tnmYNAdxergHo0zGtkg92RZUIdVCu1pwIUmsUfjoXHcRIM5hNeViu3CzwYozZxRudtBHtJBW4aeD0b+r2kKv7L3F8v1uChH9rhWRSiIDbQIoTh2/CL5fQgZts5BujPyHL/9eb+KSL7/ZWzR+E2Vgnb6lst+7GzEQwoWth14Yu59+MbFJ+tPzMdXTjzXA+m5F6mZxLur2xZiTM2T4IeyRwzuSM6Gc0l4HnxPB3pMmi5YeejCWZOfrWYB3g3Vqik6mRe8EoauchwU5S0XDQO/0DBYYLTx1OHOeiCT4emBCXopx+AowQZiZqu0jpTziZUmLQ8xYajKbYqH5Xt2KvMnXnWd55qruyTyDfkeP39lv+ypUspVMJ+8/5oeK4MO/bAGDecUiMUpT76PlpMmifaFjSnza/MClU1FTrgfii/xFHmMGIDIai6jYyz1aOrEI0XA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 918774bd-744d-4130-324d-08d87b1a664b X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 08:20:58.7066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xUjrO09xwIKcyI9GMfB2NRv9W1nAXR/D0mjaiobszqnbYsDeE3ujH/G5rWiFtPL+NHOLkAPiOmPmFXhR4YrxjIUHYFObXK4F53CDWcBH4wI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB2062 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Tech board members, Could you please clarify the concern? The latest patch (https://patches.dpdk.org/patch/82536/) supports both enqu= eue and dequeue callback functionality. Thanks Abhinandan > -----Original Message----- > From: Akhil Goyal > Sent: Tuesday, October 27, 2020 11:59 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; > Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin > ; techboard@dpdk.org > Cc: Vangati, Narender ; jerinj@marvell.com > Subject: RE: [v4 1/3] cryptodev: support enqueue callback functions >=20 > Hi Tech board members, >=20 > I have a doubt about the ABI breakage in below addition of field. > Could you please comment. >=20 > > /** The data structure associated with each crypto device. */ struct > > rte_cryptodev { > > dequeue_pkt_burst_t dequeue_burst; > > @@ -867,6 +922,10 @@ struct rte_cryptodev { > > __extension__ > > uint8_t attached : 1; > > /**< Flag indicating the device is attached */ > > + > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > + /**< User application callback for pre enqueue processing */ > > + > > } __rte_cache_aligned; >=20 > Here rte_cryptodevs is defined in stable API list in map file which is a = pointer > To all rte_cryptodev and the above change is changing the size of the str= ucture. > IMO, it seems an ABI breakage, but not sure. So wanted to double check. > Now if it is an ABI breakage, then can we allow it? There was no deprecat= ion > notice Prior to this release. >=20 > Also I think if we are allowing the above change, then we should also add > another Field for deq_cbs also for post crypto processing in this patch o= nly. >=20 > Regards, > Akhil