DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Akhil Goyal <akhil.goyal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: "Vangati, Narender" <narender.vangati@intel.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>
Subject: Re: [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions
Date: Tue, 3 Nov 2020 05:50:49 +0000
Message-ID: <MWHPR11MB18387594E26D758947EA5536E8110@MWHPR11MB1838.namprd11.prod.outlook.com> (raw)
In-Reply-To: <VI1PR04MB31680BD6B72042507911D349E6100@VI1PR04MB3168.eurprd04.prod.outlook.com>

Hi Akhil,

Can you please go through the patch again and check if any more comments?
I understand that we work in same time zone, getting feedback from you in the mid night will not help me/you to pull this patch in.
A quick response will enable me to prepare patch set quickly and send it across.

This time, I will prepare the patch along with dequeue test case.
Hope you understand the concern. Thanks..

Regards
Abhinandan
   

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Tuesday, November 3, 2020 12:28 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> Doherty, Declan <declan.doherty@intel.com>;
> Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>
> Cc: Vangati, Narender <narender.vangati@intel.com>; jerinj@marvell.com
> Subject: RE: [v6 1/2] cryptodev: support enqueue & dequeue callback functions
> 
> Hi Abhinandan,
> 
> > Hi Akhil,
> >
> > What is the status of this patch? Is it pulled into RC2?
> >
> >
> As I suggested below, please fix your date and let the CI pick your patches for
> build.
> In my local build for documentation, the newly added APIs are not added in the
> Documentation. Please fix doxygen issues as soon as possible.
> Did you try building documentation at your end?
> 
> Regards,
> Akhil
> 
> > >
> > > Regarding the date, I am not sure how it can be fixed now.
> > > May be the space is missed out as well. Could be please help?
> > >
> > > >
> > > > > +struct rte_cryptodev_cb {
> > > > > +	struct rte_cryptodev_cb *next;
> > > > > +	/** < Pointer to next callback */
> > > > > +	rte_cryptodev_callback_fn fn;
> > > > > +	/** < Pointer to callback function */
> > > > > +	void *arg;
> > > > > +	/** < Pointer to argument */
> > > > > +};
> > > > > +
> > > > > +/**
> > > > > + * @internal
> > > > > + * Structure used to hold information about the RCU for a queue pair.
> > > > > + */
> > > > > +struct rte_cryptodev_cb_rcu {
> > > > > +	struct rte_cryptodev_cb *next;
> > > > > +	/** < Pointer to next callback */
> > > > > +	struct rte_rcu_qsbr *qsbr;
> > > > > +	/** < RCU QSBR variable per queue pair */ }; #endif
> > > > There is an extra space in each of the comments above between * and <.
> > > > Check other doxygen errors if any.
> > > >
> > > > I believe the timestamp in your system is not correct, as the
> > > > patchwork show Date of 2 days back while the patches are sent today.
> > > > Could you please check? I believe CI server is not picking your
> > > > patches for auto build.
> > > > Please correct it so that auto build can happen. None of your
> > > > version was picked by CI.

  reply	other threads:[~2020-11-03  5:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 23:10 [dpdk-dev] [v6 0/2] support enqueue & dequeue callbacks on cryptodev Abhinandan Gujjar
2020-10-28 23:10 ` [dpdk-dev] [v6 1/2] cryptodev: support enqueue & dequeue callback functions Abhinandan Gujjar
2020-10-30 18:28   ` Akhil Goyal
2020-10-30 18:36     ` Gujjar, Abhinandan S
2020-11-02  9:37       ` Gujjar, Abhinandan S
2020-11-02 18:57         ` Akhil Goyal
2020-11-03  5:50           ` Gujjar, Abhinandan S [this message]
2020-11-03  6:28             ` Akhil Goyal
2020-11-03  7:44               ` Gujjar, Abhinandan S
2020-11-03 16:04                 ` Thomas Monjalon
2020-11-03 16:37                   ` Gujjar, Abhinandan S
2020-11-03 16:53                     ` Akhil Goyal
2020-11-03 17:03                       ` Gujjar, Abhinandan S
2020-11-03 17:07                         ` Akhil Goyal
2020-10-28 23:10 ` [dpdk-dev] [v6 2/2] test: add testcase for crypto enqueue callback Abhinandan Gujjar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR11MB18387594E26D758947EA5536E8110@MWHPR11MB1838.namprd11.prod.outlook.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=akhil.goyal@nxp.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=narender.vangati@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git