From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A2C9A04B5; Tue, 27 Oct 2020 18:18:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 091A32BEA; Tue, 27 Oct 2020 18:18:01 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E151D2BE2 for ; Tue, 27 Oct 2020 18:17:57 +0100 (CET) IronPort-SDR: B4jgrwH6z7MJGpxxQSxo05QoPqE2B5LdoaamCKN9vPXQlMDaM8PQCBhZbFa+hJpt4axKcxotmB 6pmAB16Q+1aQ== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="147981164" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147981164" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 10:17:55 -0700 IronPort-SDR: NJicsRV82Owla/RS5KlbX1MnIl3dmG+QrTLbx/sESnrX0a+u6pMBEgnTuZP894a4ILydfPLj+B KAXsrXkSR4Eg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="323021471" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 27 Oct 2020 10:17:55 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 10:17:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 10:17:55 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 10:17:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BcxHbbhhDpIoEVonMUXw4BxsvJESIyGqJH6KNDWhWPlIby5nQpy3wy7/jMLPyA6QD3OhkNOkMgHylAaKkyro/mm6gjPF6LjU8GZ9QCPoC2Ubm/DBSuq5ZUp1KTaYAORrgs8svpHBzkGaLs5/2mten48KaWKLr4GnulpRccf/0XtULLS1O5/wXkpRl68iWZMr/dTHNmkTho7IJcmwifrsk1U8XXsR+7KE/RuMolYbL8KUSE+6AEQdUYQghfCA3RZ54ndOocxEQLjzbBUMY0rkjG4teGk5BF89Z26RkImJMC2oNyLGhDDcMDrd3QJh91P6yHTw+2C3dLG2Nod5PIy1rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hljWytoo4VsY7F3EJKWJeWIFe8/P9b80vCvboF75kIo=; b=YM8ck5OGQqAwXMIklxikHYrty/1axAyc0eThFFVX3RGZAW5NTWh1Uf3aJcGfxpRv1PwAk8OSJLPCr4Xf/PaGkE0yUuT1Y7MNNQE+hYSZzUjB0fO0d8Ua1sXOk055DnGhpOqQtQgS/tQ/vYuMFz04aQcqyWBcta79c4pYZOR0V7GNFjzHjCa3W9BqM+mR9ImXPlti53HtjDU38pIXNLmLQ6UgKMRF82nfkhLPxZXDyckUKqgg810nYx0bntQ/v8hVOlq34HK/VnMlGLWWbzenDisvdxjZ3bXW5VQtiARmChqGmbSIv3bDh3O9rNSLQA+HXL17HoBS1Yv9GG3h17FVxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hljWytoo4VsY7F3EJKWJeWIFe8/P9b80vCvboF75kIo=; b=loshkR+Z+QR9OSHbl8LFh8et/3jNe1zNl09QHXjMdM2rSmnK6sc0GnImbQ++8GPZgbVG79T9LZYXrf+SqAJl9FTNc53stNyWkq6y4il0Jk8IoF1/+r+Ux9ZDGvqBZ5yLyXx8cyr1SY9Yo7Hi3HxvljVyaUmpAZiOL3bleJNQrkE= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by CO1PR11MB5041.namprd11.prod.outlook.com (2603:10b6:303:90::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Tue, 27 Oct 2020 17:17:52 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 17:17:52 +0000 From: "Gujjar, Abhinandan S" To: "Ananyev, Konstantin" , "dev@dpdk.org" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "Honnappa.Nagarahalli@arm.com" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 3/3] doc: add enqueue callback APIs Thread-Index: AQHWq8kq6RL4BwL1xU+gtVhivPQLeKmraD2AgABKFCA= Date: Tue, 27 Oct 2020 17:17:52 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-4-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [157.49.168.0] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b25e541-9d8b-4f33-b14c-08d87a9c3c98 x-ms-traffictypediagnostic: CO1PR11MB5041: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yIxQI0SqIlyCSntfAPbbeYa+E0+/NC4RKA/bYFQfkwGOdZabobaFmkN5Tfvam8wge0uKOWMiLH0qmuTS0RUMoaQUPBJMmnB3IUftxWtYLY/Eo1a9Y6ROEsdBVJ1k4eyDKihjHLNWcRWx0tIdzinqVzZUf0LNunAkDiqqya0wWQE9UpEbyXogXEA/g8qq/hPR/KI99vhZw8N1KnVn25NKrGBoUWTDnTHh/BkGrqtXlNoFC3oZladNXZhfmTYwIDFh6txGpYfdlicqqVOifKRrY1HLXseMlCf5JuqCx9Acz6czL6L7t6ugrxyeA4vg6GSI5nc7o6OKrYYezyASButneA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(52536014)(26005)(2906002)(33656002)(7696005)(53546011)(71200400001)(478600001)(64756008)(66446008)(83380400001)(110136005)(8936002)(5660300002)(8676002)(86362001)(316002)(76116006)(6506007)(55016002)(66476007)(4326008)(54906003)(186003)(66946007)(9686003)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 4A/VoH/fc2zWGXRw7lP4HSS4qOvhHoWOzRjbpbCp/S9TpnpJkU1RV/3oZ5aibIGLpTUFa0oV3/sdX5M7D0USuqqlpS5XhQyDlZnAmgdLhf/0VDsFjwKYXcwvFUsVqNIcOxXqKHm9FHGOJxrjBoohcoOOJtACyNrF+qOFJFXd2baeTbTBFcvgJL0O1MijzkUom0l6UdFJ0qLIYJmUwTg7R+ti2TfY3pQE25XJmhJCJxVnOwCeaFFA9e/I603ro3tEoIikIAzUi8KW1c9kbPnJPiERgfp3zPEVx4Q3BLfB+vyTYkOnyNBqsXV1rcCvvMrg4UiVifnydTphMF53FbzF6sFl5D1LR7+cOf9pv9dJuqX9kC4l9iR2H93fqicGwjx8mvg0vBdnNRW2F/n0PJ1ECkQZHzCUAood3gwDpLLPXzALa9cVaTIdY0VHkGw2YUmXq736wA2u8iZ3KFOBCBjIpwPXmiHcu9pWUaNGmPuCEMDrUlsfMnIRJJwmMFLXMIvtUgCGWlLQ1l6xgkdMsi9GVslrFgXLSaatOzp8CNZVnsqZVDdbdu2ZWMVCb91cD5JoUGlQQKXNxbt6WAR0+AUp/ZND77L0Xvqd8LEaaqIgj/yVh2uMgiiksWApN54/KaoQAeuie9L2lqymAlBJD5W5Qw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b25e541-9d8b-4f33-b14c-08d87a9c3c98 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 17:17:52.2242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FxRizQswQALwBIJE3KKeP2ghDm6FDomslKDLPSdV+ozG+BJRvguq4TknLdMP5Jdael+aNp6lTDXSH4yPJljkYq0TKO9gIZ4i1khsqsDMq8U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5041 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 3/3] doc: add enqueue callback APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Tuesday, October 27, 2020 6:22 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Doherty, Declan ; akhil.goyal@nxp.com; > Honnappa.Nagarahalli@arm.com > Cc: Vangati, Narender ; jerinj@marvell.com > Subject: RE: [v4 3/3] doc: add enqueue callback APIs >=20 >=20 >=20 > > > > Add enqueue callback support for cryptodev library > > > > Signed-off-by: Abhinandan Gujjar > > --- > > doc/guides/prog_guide/cryptodev_lib.rst | 22 ++++++++++++++++++++++ > > doc/guides/rel_notes/release_20_11.rst | 5 +++++ > > 2 files changed, 27 insertions(+) > > > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > > b/doc/guides/prog_guide/cryptodev_lib.rst > > index 72129e4..bb3de61 100644 > > --- a/doc/guides/prog_guide/cryptodev_lib.rst > > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > > @@ -366,6 +366,28 @@ can never be larger than ``nb_ops``. > > uint16_t rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id= , > > struct rte_crypto_op **ops, > > uint16_t nb_ops) > > > > +User callback APIs > > +~~~~~~~~~~~~~~~~~~ > > +The add API configures a callback function to be called for each > > +burst of crypto ops received on a given crypto device queue pair. The > > +return value is a pointer that can be used later to remove the callbac= k using > rte_cryptodev_remove_enq_callback(). > > +Multiple callback functions can be added for a given queue pair. > > + > > +.. code-block:: c > > + > > + struct rte_cryptodev_cb * > > + rte_cryptodev_add_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + rte_cryptodev_callback_fn cb_fn, > > + void *cb_arg); > > + > > +The remove API removes a callback function added by > rte_cryptodev_add_enq_callback(). > > + > > +.. code-block:: c > > + > > + int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > + uint16_t qp_id, > > + struct rte_cryptodev_cb *cb); >=20 >=20 > Please add explicit statement that all installed callbacks wouldn't suruv= ive > dev_configure(). > So it is user responsibility to: remove them before dev_configure() and > (re)install after. > With that in place: > Acked-by: Konstantin Ananyev Ok. I will update the documentation and send a next version of patch. >=20 > > > > Operation Representation > > ~~~~~~~~~~~~~~~~~~~~~~~~ > > diff --git a/doc/guides/rel_notes/release_20_11.rst > > b/doc/guides/rel_notes/release_20_11.rst > > index 48717ee..7e2fd30 100644 > > --- a/doc/guides/rel_notes/release_20_11.rst > > +++ b/doc/guides/rel_notes/release_20_11.rst > > @@ -285,6 +285,11 @@ New Features > > * Added scatter gather support. > > * Added NIST GCMVS complaint GMAC test method support. > > > > +* **Added enqueue callback APIs for cryptodev library.** > > + > > + Cryptodev is added with enqueue callback APIs to enable > > + applications to add/remove user callbacks which gets called for > > + every enqueue operations. > > > > Removed Items > > ------------- > > -- > > 1.9.1