From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDBF1A04C7; Fri, 18 Sep 2020 09:10:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 524AB1D8EA; Fri, 18 Sep 2020 09:10:43 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id EDBD51D65C for ; Fri, 18 Sep 2020 09:10:40 +0200 (CEST) IronPort-SDR: tpe4HExAGSIaQHS7rd3BkaWw9GcIXOCxNjERrkoO6wz8B66rpuyqxlGPihq42VWbxEPUXG71On lLEkAwcs/Esg== X-IronPort-AV: E=McAfee;i="6000,8403,9747"; a="159182492" X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="159182492" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Sep 2020 00:10:39 -0700 IronPort-SDR: rZ8MLcIHbuNIutJ6sqY5wvu4iRiL3qjU7vnBd2uF3D5va7SIBnM3XGNhZe5CVN0m+e+Tfnvmzs yGORgKyrZ3/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,274,1596524400"; d="scan'208";a="332486114" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 18 Sep 2020 00:10:39 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Sep 2020 00:10:39 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 18 Sep 2020 00:10:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 18 Sep 2020 00:10:38 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 18 Sep 2020 00:10:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g9SeJzuPPHU5hcRx8kyRKqglsb//XWkmoT64BxvGQiU954EAztapTZu3A2epr7Lq1HBMY8wMZnX9ja+K7ZO/AFMol6AMjDbmawlzIorX9bMnoIWHbaGHps6cOXTl57ow2GVJY6J2oeFmAG2RWJ9ZjxP8M8kfVxd12N68NbjMyjGiRSnRg1w2nvVPN2H+4r9LHUtBbbDQlMACHBjuQAoaJL7yu0t1ReEillbJGYWVoIRVGZLA/67ErsS6MkowiR5kGXVXdsaJd9/8/p9P8jdtEDMLIRJtYAjhL3XS03gxSH7xdvPksEYXE5RaN19EJaZgGmQYrQQTZyzkMaCoP6rc6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n74nJtNxoEurlF/j1wy0RTye5ArS2T67JHtPV/Z2vnM=; b=QBlOBiKH0jbIJNrCA2xnvx5fTvxBufef88FsYOLU40l6+6dpEDiyJUerJuySfYGnXSx7MgXivhmekZwYdeu/S2VnrOsfR6zFpF2R/KotiEZnsEEYYg3YKE0xZ9uPLCBmGK3UKuXpFj6gX2eZHqcnmVyIYhpy4DEcE1ctB4rnXalJkWdwhM8LcAQ8DOdSibmGPf0ovtPXicMVu4dGXJNW8vnd9LbC+IB9sUyoWg+Raf0kSb1cgg1bKv3yf6y3C4vP7Q0Go18OHfC1MP0tyJT5Qs4kGmDKEftx277HcPWyqfBhfkMqxVj80oDGfzXBsvK38wWWrwkoum+6qy7/eqNjCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n74nJtNxoEurlF/j1wy0RTye5ArS2T67JHtPV/Z2vnM=; b=qTFIKeIcsuL6DF8Ao2RH4xs/Ae3HJ4Map+ZoQeQA3YIVjfWB/ju3kezJtg7nivredrs3NuW72mw8Wqylq725hdKIm6jktmvq1PqdG+r9F1STrajkIzoy6WJkv8z6/X7k+KtcpUFqivwQXf5d31NbVjTWIlzaOTOnmi+gIKHFnhU= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB1888.namprd11.prod.outlook.com (2603:10b6:300:10e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Fri, 18 Sep 2020 07:10:36 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::34c5:6550:a098:209f%12]) with mapi id 15.20.3391.011; Fri, 18 Sep 2020 07:10:36 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcC1yYDJ1So6OUGIgVlNZgXtbKljELJwgAr4YMA= Date: Fri, 18 Sep 2020 07:10:35 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: efdb93f5-f021-4d9a-0856-08d85ba1f103 x-ms-traffictypediagnostic: MWHPR11MB1888: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: egLplCVbm18HkSjzm724enMBs32waYt1/+HC1xPxunflt7EWUtA/mWE9AYe6OpFQ+Bqc8q0KoEL0pvz2pCocOBr6Mds5+kswg+8Il0YTPymtiVhPFwzIh/GeNooZ4K7n0CriL0pOL2RSiNDVKNeUcrS9d4XO8ahQvAdnj+jZeliBBlwrYEsB+7MIuD52w1byYzkXiUTLgTnmClbXuu1EpaV29I1zdaGjsBnyq8g/Kacri/vZGGKA15XHh3oRx/jQGwS+Mdbtx8yPiRTbbjLUqdibJvr8M4gje+5erBMS9eTRRMLvBknT8Moa6lO6+va9Rv5Q+1VHrs4+FIQnRFwp3w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(346002)(396003)(366004)(8676002)(2906002)(186003)(83380400001)(7696005)(52536014)(110136005)(33656002)(54906003)(86362001)(478600001)(64756008)(71200400001)(76116006)(66946007)(55016002)(66556008)(316002)(66476007)(9686003)(66446008)(5660300002)(8936002)(53546011)(55236004)(4326008)(6506007)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: nymVPheGBoYgttC9nahG3KvXOYvZ59/MDFkR2BkxfPlxR/K0/2b/h5c1YO9LNBUZYQg96oFY6ZzIcNas3XTjDCXDbdS/Eg9+ac6Ii9ed4OxLImvnEWs11eewCFyFgVze3mDl/zLbD9obXirUBCeyS7lAuNnqr+DbN+XCNfU8U0sRWkqBej4RTCtlxS7o6LU8yMrIf6hui5Z81FSkCx5gvZJIaBCIOf8kWBkBnERWSZHLMh8Fdy9ivnd8YcxhHfYLQIQoR9rZspDF7nonALeoH8GPInWMX1v0N8BBbbhJm2N9gQ1fBL8VQ81lQw4Gnbn+LrSrsbL28OKYQvwDGpM3PvqqFEq7kWQvp/dZ060bjROs4xDzjcLZ0/Jk6PdUsWA6orrlN8fITvpk+ldS58a4vODYOcQ7UzDTy27S8qQV9EqjfBzhjaEclciwuay2ZW+1JNTiPemBK/0UiaqW8UpaX3OqMXikUS4C8ZqPO63z4SdrdQu//qHbzaG5Qsv89/jh8cPDHxXNGAEb7CxlPduH/Jy3M8F2TCdwjt1h80e2w9u4HpX3fzvaFUOsXO/gActBHT68IN3rK2DdflkBURg3l+fe19lKmFkYoH3wjt+BjED/RUgEeiGJFK/bof0hjEPD1AiPvTZeD9Fgo0svQfzT/Q== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: efdb93f5-f021-4d9a-0856-08d85ba1f103 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 07:10:36.0556 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qCLrJ8HUaiRWZCGDg3yeSShzGhXMNfpCxRWQqlomJS68sOq3HwomvAg5bN8ekPagSfe6CTYbUXXeZynO47vhFYRZWQNk4+cbg9yx4iArcY4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1888 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ankur, This patch requires minor change. Please find the comment inline. > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Friday, September 11, 2020 1:07 PM > To: Ankur Dwivedi ; dev@dpdk.org > Cc: jerinj@marvell.com; anoobj@marvell.com > Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with > unsupported mode >=20 > Acked-by: abhinandan.gujjar@intel.com (For series) >=20 > > -----Original Message----- > > From: Ankur Dwivedi > > Sent: Tuesday, September 8, 2020 2:46 PM > > To: dev@dpdk.org > > Cc: Gujjar, Abhinandan S ; > > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi > > > > Subject: [PATCH 1/3] test/event_crypto_adapter: return error with > > unsupported mode > > > > The capability of a event device should be checked before creating a > > event crypto adapter in a particular mode. The test case returns error > > if the mode is not supported. > > > > Signed-off-by: Ankur Dwivedi > > --- > > app/test/test_event_crypto_adapter.c | 30 > > ++++++++++++++++++---------- > > 1 file changed, 20 insertions(+), 10 deletions(-) > > > > diff --git a/app/test/test_event_crypto_adapter.c > > b/app/test/test_event_crypto_adapter.c > > index 8d42462d8..930c2a9bc 100644 > > --- a/app/test/test_event_crypto_adapter.c > > +++ b/app/test/test_event_crypto_adapter.c > > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum > > rte_event_crypto_adapter_mode mode) > > uint32_t cap; > > int ret; > > > > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > > &cap); > > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > > + > > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && > > + !(cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) > > + return -ENOTSUP; > > + > > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && > > + !(cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) > > + return -ENOTSUP; > > + SW adapter does not have *_INTERNAL_PORT_* caps. Just noticed test was fail= ing here. Could you please bypass this check for "event_sw" and repost the patch? > > /* Create adapter with default port creation callback */ > > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > > - TEST_CDEV_ID, > > + evdev, > > &conf, mode); > > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto > adapter\n"); > > > > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > > evdev, &cap); > > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); > > - > > if (cap & > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > > ret =3D > > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, > > TEST_CDEV_ID, TEST_CDEV_QP_ID, > > &response_info); @@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum > > rte_event_crypto_adapter_mode mode) > > TEST_ASSERT(ret >=3D 0, "Failed to link queue %d " > > "port=3D%u\n", qid, > > params.crypto_event_port_id); > > + } else { > > + return ret; > > } > > crypto_adapter_setup_done =3D 1; > > } > > @@ -845,24 +855,24 @@ static int > > test_crypto_adapter_conf_op_forward_mode(void) > > { > > enum rte_event_crypto_adapter_mode mode; > > + int ret; > > > > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; > > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > > - "Failed to config crypto adapter"); > > + ret =3D test_crypto_adapter_conf(mode); > > > > - return TEST_SUCCESS; > > + return ret; > > } > > > > static int > > test_crypto_adapter_conf_op_new_mode(void) > > { > > enum rte_event_crypto_adapter_mode mode; > > + int ret; > > > > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; > > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), > > - "Failed to config crypto adapter"); > > + ret =3D test_crypto_adapter_conf(mode); > > > > - return TEST_SUCCESS; > > + return ret; > > } > > > > > > -- > > 2.28.0