From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53207A04BC; Thu, 8 Oct 2020 09:26:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA62F1B9E6; Thu, 8 Oct 2020 09:26:17 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 954401B952 for ; Thu, 8 Oct 2020 09:26:16 +0200 (CEST) IronPort-SDR: 3YWVPRymrABh8XnCsLrSv8BxsA8Gi7nJpNm+NVquD/1qhKn+FI3Ti6SVfdI27CVk/WVAeOpWCy rEg5RVI8vTxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9767"; a="165399965" X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="165399965" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Oct 2020 00:26:14 -0700 IronPort-SDR: YjgbYmYs51aiWTYaYoXCcGryazbL0g5NLLUfpDxH3kOL5vMCnaHt6qXXfwl/qKcvh4gfdchbQf yXLtO6/2VS9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,350,1596524400"; d="scan'208";a="316594137" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 08 Oct 2020 00:26:14 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 8 Oct 2020 00:26:13 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 8 Oct 2020 00:26:13 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 8 Oct 2020 00:26:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j1HJy/fo9ewnIMWZlcrySSypMOnOoVqXEYx9fdYaGKnOIpwfY7A/RML5aRavRZ9rD3JrSXwlQ81o90t6sTDMjpAAGvb4Vfkgm5OQPtEa3CWSoHi/u1lIO0oi1jrqsjQQuz5gJ1K4hIcFi1QkZiwmR/FZ/DtAX2LRnjq+mCx2PDqnTsV9DjCeGYSXkp5ULWOccdk4Og7i+fmfLKHvJ0zONzmWNbIzNjevO1nMF/wvCSiPUk6tIXX/30wBMTPTw3yRoyNMO1tgjjAd2eCLbbzbyw4YiGioV3yOQSUTGB51eJRquaC81QLacbOUUlnGS53bK2Qv1E/hckZjR9MOynYeDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHoRCORW+g4ObIz9frV3oZ/cVBuRzN0wju8A4vWu938=; b=Fo35yqcPvK+L9v2FhVfwHV0hoN3xHk1R0valoepk/ViY/jzD65ozFfbxjdDOkFEFuApos3I8MhzQu/z5mOQD6IlOxPFP+2KXfjxn9Vfzv2P+CopZynJ/9gCwIB510UXNc0zcA/fE6POIVTCTBnd8XlzYhd3HnAAr14z2F8s6QtGT6BqeeTdvrftSG0XrnYLOzjLf6GtgeDpLQRouPkyWsAKhPS3pfivkcGS+3yuUC/x5uToV2UN+CyPoA6gYduPmmAIrFLBCVhbejN1p2pQwc5a6qPK478RVS0NFqKRKnA9oiljmyP4Vbj7U49gp9uT2+S4QT/L++uCZKD1HXlneOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eHoRCORW+g4ObIz9frV3oZ/cVBuRzN0wju8A4vWu938=; b=gMgV2Z8i0myEqPR/EPbwC6kpJi7yCgtOv8zhqmVjwPHSrj+lui3WbtzCfrDxv92J8No2E9LkODUvtIqco4FeyS5/dfpKAHdrRLP8QvFZYpvgK8DbcCoTdGpxym4uDFGir3P8OgwPoRS79mD+lwC0/GxSymsPj7UHwEbtYbTlq0o= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR11MB1663.namprd11.prod.outlook.com (2603:10b6:301:d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Thu, 8 Oct 2020 07:26:12 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3433.046; Thu, 8 Oct 2020 07:26:12 +0000 From: "Gujjar, Abhinandan S" To: Ankur Dwivedi , "dev@dpdk.org" CC: "jerinj@marvell.com" , "anoobj@marvell.com" , "Vangati, Narender" Thread-Topic: [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments Thread-Index: AQHWnGqDwo0o06Jc/kukZH/fMEmlq6mNT7eQ Date: Thu, 8 Oct 2020 07:26:12 +0000 Message-ID: References: <20200925072841.17578-1-adwivedi@marvell.com> <20201007052629.28566-1-adwivedi@marvell.com> <20201007052629.28566-3-adwivedi@marvell.com> In-Reply-To: <20201007052629.28566-3-adwivedi@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6795f7c8-c847-4651-6f79-08d86b5b6f5a x-ms-traffictypediagnostic: MWHPR11MB1663: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:901; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iMkFEqnnL5aWsb1jM1dUdzG/5KhrrXeui4nUbxFKxGpCt8ZNpxSk1Fo0thR0XUbycHalBqpIr9eQ4clle1WlfI/SaeqInfcUJh6Rf1ihsuHL4JMbftJDD8JoZUdavQyLzu+R50hAaZU7h7SSwpU3OqP8Xg2m0tDTy109DEY63wHY7r095+lPeGYkt7J+LKve2dUoN8x6wM+dh0BNkX6MUClW4oVVGUtLLGBmK+h+zvi9+ZeVR+Dz8jXM3QDmOswbGF5dchgBbJc8/hg6m8O8SUiTC4EeCgUO80on8tpOYA2Q6N1hVUJdfmAJV8lyq3VIDYYiP27eHY40kuw+U8yapw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(7696005)(55016002)(86362001)(33656002)(8676002)(2906002)(52536014)(8936002)(186003)(9686003)(5660300002)(316002)(26005)(53546011)(55236004)(6506007)(478600001)(54906003)(110136005)(66476007)(66946007)(4326008)(107886003)(64756008)(66446008)(66556008)(83380400001)(71200400001)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: DuX1ag6p8aYrrQc17E59qXeVHRn0Mnq088pJ06ABMuFbP/IM/lWrki6u85XqgwlIaRVLaOaBE8Z0IbZ5MIWDs8xs/j5euGIv3SxogyeW2JzLDrCg43xjqFvUr9ZxTSf/dHp4GQdbVDBv97UFltUK2bwjfx9NO44/2xqRmvEJAiBE6w5cMNCSDd4Gh91jaWM2XcMR7zcuOskqFXS7lp8JI52EzokHQi0HmLZ4n3DNUz2JnW0tub6dwCG8D6FBKTQLUYER4wauVpmQd26ywRb8QIALIFfZ20LPiRJkD/NpjV5RkMlJXOzWSunjGuszVzpDKyI4bGhc6o3Z+T+WeI2A0FCPt+/GPvMSQLEXPaI56DHlynXWfpmqGmUpAoopJsMYX+GBGAFPvx2aE8xG5fSx7JB/zCr7YcAW5BD2lPDmoXUWNUjj6hwTiRHDfR+mKiuiMM/eocZgYMy6WtbS+21jbRrWShVqm0coxSYH4Q5JXAjR/7g/mr7NVYsPS5Ien0AbPmvqZysyjOD2aiUwvuUgbKd866tv3sMG0hoKkCQYGc3h5k70cKvgHgL+0y93tPXFNeSzHamRCBaTfGQops1dgeVhHbpPDIL/9pFE/qU1qxNvGhA6UiCJ/JdpMS2D6zEgJEBRlAT0YJlH5UAWC3K0Cg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6795f7c8-c847-4651-6f79-08d86b5b6f5a X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Oct 2020 07:26:12.6209 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pvADYhhYD/XnyMN0gAOtRjt0UR48Qoes1rSQDE64vZmOrcDZPT1tVmO/J1hXTIXgHS0Z9/SstQHj45yx5aWN94+em5OwwvySubmdiismTug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1663 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" acked-by: abhinandan.gujjar@intel.com > -----Original Message----- > From: Ankur Dwivedi > Sent: Wednesday, October 7, 2020 10:56 AM > To: dev@dpdk.org > Cc: Gujjar, Abhinandan S ; jerinj@marvell.co= m; > anoobj@marvell.com; Ankur Dwivedi > Subject: [PATCH v3 2/3] test/event_crypto_adapter: fix function arguments >=20 > The arguments passed to rte_event_crypto_adapter_caps_get() and > rte_event_crypto_adapter_create() are incorrect. >=20 > In the rte_event_crypto_adapter_caps_get(), event device id should be the= first > argument and cryptodev id should be the second argument. > In the rte_event_crypto_adapter_create(), the event device id should be t= he > second argument. >=20 > Signed-off-by: Ankur Dwivedi > --- > app/test/test_event_crypto_adapter.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/app/test/test_event_crypto_adapter.c > b/app/test/test_event_crypto_adapter.c > index 3c64742b3..87a67139d 100644 > --- a/app/test/test_event_crypto_adapter.c > +++ b/app/test/test_event_crypto_adapter.c > @@ -209,8 +209,8 @@ test_op_forward_mode(uint8_t session_less) > &cipher_xform, params.session_priv_mpool); > TEST_ASSERT_SUCCESS(ret, "Failed to init session\n"); >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > - evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, > TEST_CDEV_ID, > + &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -296,7 > +296,7 @@ test_sessionless_with_op_forward_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 321,7 +321,7 @@ test_session_with_op_forward_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 410,8 +410,8 @@ test_op_new_mode(uint8_t session_less) > params.session_mpool); > TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n"); >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, > - evdev, &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, > TEST_CDEV_ID, > + &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter > capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -460,7 > +460,7 @@ test_sessionless_with_op_new_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 486,7 +486,7 @@ test_session_with_op_new_mode(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (!(cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - > 706,7 +706,7 @@ test_crypto_adapter_create(void) >=20 > /* Create adapter with default port creation callback */ > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, > - TEST_CDEV_ID, > + evdev, > &conf, 0); > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n"); >=20 > @@ -719,7 +719,7 @@ test_crypto_adapter_qp_add_del(void) > uint32_t cap; > int ret; >=20 > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, evdev, > &cap); > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, > &cap); > TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >=20 > if (cap & > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { > -- > 2.28.0