From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8382AA04DD; Fri, 30 Oct 2020 05:24:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 86219CCD9; Fri, 30 Oct 2020 05:24:25 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 9B9C9CCB3; Fri, 30 Oct 2020 05:24:21 +0100 (CET) IronPort-SDR: 73A088XPGZMuRMT9Ly6Rl9cQx3KhWRhevOdPgXW7qVeFbZ1li5KItnhpZ9mZCbCw99ia1AcsAj vQHACvzPexYA== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="147842177" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="147842177" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 21:24:20 -0700 IronPort-SDR: KAJ7INh33GgX+ewHF5iSDjuDax4NjwSq/P8rMnPJ5r6o3iXYhIbTNICpEd3Lh4lAlQsV+NGaLo mFphUFfKeHKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="323952676" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 29 Oct 2020 21:24:20 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 29 Oct 2020 21:24:19 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 29 Oct 2020 21:24:19 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.54) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 29 Oct 2020 21:24:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q0+ZYTOOuCs3SzWZfR220MaIMmUfOilLuYztvJ7Qjtd0J4MA9FM7273kxeqQhXDHovnYw4xgfmYOs+twUKHDAUg0zjznq+SDF2CkwSLfUt4RcW0xzeftdrl1vPxdvYphKJBYh3T80KkL9SkZBlNrfEuJo49cIF0yMDO7cOlFtdVSkzss1GcwLc9LrT7UURkWtmte7kl4lNoakDrgNdKg3e6pgQsY/KWxqsND3oJmKv/7c/ijsjm4rTP4LFmbEMLgBZtd3hbliw8p9yCNchKyLheJFeuTBvr69yD4yw0NQs/jBpipYfFBETheoMEQRHD7optXkT/YQ9X9qNcgW3H89Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAa9zvoTgwk8CNP/6twS0xVbXgaXUwpcGK9UdlSObyU=; b=VqOKgM8Oc7vWHTL2RfGnEir/6QTVhbRo6k6YN4r1HlqfUBWqr58h8Yru4oKhfsW9dBCXf7+W6EDzoE8++asMIV7CiQlNSckUURlTnSiI53EvUQZUiHmVasRGJHVrMjJaQ0CzyQzUUTD2ZrB4iLL3/+dc+yAUjUVy8ehin0GICQNx/xIiZUFust7I+RR6WBNUO2e24D67tI5uqIJvTWK8E/b1AFv+i+wWR1g1p814/XT9x9bVAqS/1qy1HkvKubSiVNN5g16t2LgrlSJIV+gT8IodkKhf9cxJR/tJgdr3t8ZTA79RjmOQpQahAEDJT+WfsGF90N9U3xg0ijocJ1QR6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SAa9zvoTgwk8CNP/6twS0xVbXgaXUwpcGK9UdlSObyU=; b=KlG4VNFmzGFd9KVYGQ8gifWNtAFGax+h8ounlb6ZvhQZHxSdSlkjMz+5+syQxJcy1N+6ulDQLblGM2RKt/OXTLCfZb0QR65zsSAa1FNKLxeXs0G6RuboPL5UUJYycCYYdUeRdX9fk6yUm4VARixfz9fE9DLaJawyeSPFTjRl8gs= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by MWHPR1101MB2078.namprd11.prod.outlook.com (2603:10b6:301:4e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Fri, 30 Oct 2020 04:24:17 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.027; Fri, 30 Oct 2020 04:24:17 +0000 From: "Gujjar, Abhinandan S" To: Akhil Goyal , Honnappa Nagarahalli , "Richardson, Bruce" , Ray Kinsella , Thomas Monjalon CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd Thread-Topic: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khg/yqaE27MkanYRdfhPnwbqmrxnGAgADn6NCAAE1qgIAAGfCAgAAL9QCAAAL2AIABeSNwgAACeYCAAPClUA== Date: Fri, 30 Oct 2020 04:24:17 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3ac162a6-c481-4285-56bd-08d87c8baa5d x-ms-traffictypediagnostic: MWHPR1101MB2078: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: n1Bf7nzLMvq3zjANOZoUo6yyt7yuHaOpuRINbdv/9jeeJC9Y0V/PC1hfLFRn+KM6y555/tXUZR8rPZSjdYOEsxkSpg23GUJw5AwI04GFMk9MdCjUnaCLokc2/7UXFZm61fMkLvwHFXXMoZQCCtvMf0YZWRJHbDGpQmAu2ofPFfdusUnSeZ32Kc5oyf35555x2ygcYAPSAFtMASsOYU90Ml/7DMxt/ZKhAs7Ay5/RjDHRUnRwML8sM+18IYfKHoSLvNsvu8ISnZxX4oDpj9ZNNvuml/5d8Hm/jI35LBs9uF9QoVDKytuw3mLSTDv7Mg2QLkGxVSpQsQZTNLjF8220Iw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(346002)(376002)(136003)(396003)(71200400001)(8936002)(2906002)(5660300002)(7696005)(53546011)(6506007)(66556008)(4326008)(478600001)(66446008)(54906003)(26005)(76116006)(66946007)(64756008)(66476007)(316002)(8676002)(110136005)(186003)(52536014)(9686003)(86362001)(55016002)(55236004)(83380400001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: gREFWD2x8SSeYDq7a6jGDa3L1mpkGLKT7AcwWjVeLpIAxoFKhXj4+v0+DBvRYYzTMgyebmLCgqWeR3v04crholI3gmeDhSJWowHZxk4JY2BSRgWfuItC9pydFrGJ8f7Eecu07ISJPj3MIXYw8RT2szL16aY6Q5MF4mGJrE3cM6EUBkpzrNzzWrViUnh7i18H4vnAB+ggtlU2PNPUa+V4S/O+t1uTxHGfmyrU2uPUhLCbT+RHgtXfcv6LAcpobU6nfn1NLWFOSLwq02avCIWEYESsOnhGHNbmydc9230s84UGpAjn1VCx77fAApWB8Twr5l2xDoUVKTeXt0h129F88/UWXbB5uAYv2tUbX8DGi8J/wY2u1qTSGAW7fafAYhbjlUaMCczyStSowKn3U0khgqVsLuKN3NXIXKvyvRSj7ebLYpM92EYo5R3bC6Z42xsFE68sbh6UwrcKFRXHhMccUBVZVzorOyj6q7UKeAU8CEApWKRzWKNSTZ+z+DJw0YjRm0ymNQ4jZTH6PxmmZRHk7WQ7/SOvQ8EZRB8RQ44QMTsOzJuPqV4pw4/lV0Kosyap4jenYWGFh2CCRN/W7xxbHu3wuqfevyO9osYsM2mMxJNSjkjzZnJhfBr+kePNjNSyhdlb4bZahuU7VdDu5uzqrw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ac162a6-c481-4285-56bd-08d87c8baa5d X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 04:24:17.1977 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tmDsGG3IqTAjtrkCPwVR6xA1BgsiqmIXRagSeqDyPTZLM0djfAvcsJKZ/C9ItBZDPW79YaS00eiJx+9cRzZCpZ+iltSqMebe2UHHCscQP+k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2078 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Thanks Tech board & Akhil for clarifying the concern. Sure. I will send the new version of the patch. Regards Abhinandan > -----Original Message----- > From: Akhil Goyal > Sent: Thursday, October 29, 2020 7:31 PM > To: Gujjar, Abhinandan S ; Honnappa > Nagarahalli ; Richardson, Bruce > ; Ray Kinsella ; Thomas > Monjalon > Cc: Ananyev, Konstantin ; dev@dpdk.org; > Doherty, Declan ; techboard@dpdk.org; Vangati, > Narender ; jerinj@marvell.com; nd > > Subject: RE: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callbac= k > functions >=20 > > > > Hi Akhil, > > > > Any updates on this? > > > There has been no objections for this patch from techboard. >=20 > @Thomas Monjalon: could you please review the release notes. > I believe there should be a bullet for API changes to add 2 new fields in > rte_cryptodev. > What do you suggest? >=20 > @Gujjar, Abhinandan S > Please send a new version for comments on errno. > If possible add cases for deq_cbs as well. If not, send it by next week. >=20 > Regards, > Akhil > > > + Ray for ABI > > > > > > > > > > > > > > > > > On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: > > > > > > > > > > Hi Konstantin, > > > > > > > > > > > > > Hi Tech board members, > > > > > > > > > > > > > > > > I have a doubt about the ABI breakage in below addition of = field. > > > > > > > > Could you please comment. > > > > > > > > > > > > > > > > > /** The data structure associated with each crypto devic= e. > > > > > > > > > */ struct rte_cryptodev { > > > > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -867,6 +922,10 > > > > @@ > > > > > > > > > struct rte_cryptodev { > > > > > > > > > __extension__ > > > > > > > > > uint8_t attached : 1; > > > > > > > > > /**< Flag indicating the device is attached */ > > > > > > > > > + > > > > > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > > > > > + /**< User application callback for pre enqueue > > > > > > > > > +processing */ > > > > > > > > > + > > > > > > > > > } __rte_cache_aligned; > > > > > > > > > > > > > > > > Here rte_cryptodevs is defined in stable API list in map > > > > > > > > file which is a pointer To all rte_cryptodev and the above > > > > > > > > change is changing the size of the > > > > > > structure. > > > > > > > > > > > > While this patch adds new fields into rte_cryptodev structure, > > > > > > it doesn't change the size of it. > > > > > > struct rte_cryptodev is cache line aligned, so it's current siz= e: > > > > > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > > > > > So for 64-bit we have 47B implicitly reserved, and for 32-bit > > > > > > we have 19B reserved. > > > > > > That's enough to add two pointers without changing size of this= struct. > > > > > > > > > > > > > > > > The structure is cache aligned, and if the cache line size in > > > > > 32Byte and the compilation is done on 64bit machine, then we > > > > > will be left with 15Bytes which is not sufficient for 2 pointers. > > > > > Do we have such systems? Am I missing something? > > > > > > > > > > > > > I don't think we support any such systems, so unless someone can > > > > point out a specific case where we need to support 32-byte CLs, > > > > I'd tend towards ignoring this as a non-issue. > > > Agree. I have not come across 32B cache line. > > > > > > > > > > > > The reason I brought this into techboard is to have a consensus > > > > > on such change As rte_cryptodev is a very popular and stable stru= cture. > > > > > Any changes to it may Have impacts which one person cannot judge > > > > > all use > > > > cases. > > > > > > > > > > > > > Haven't been tracking this discussion much, but from what I read > > > > here, this doesn't look like an ABI break and should be ok. > > > If we are filling the holes in the cache line with new fields, it > > > should not be an ABI break. > > > > > > > > > > > Regards, > > > > /Bruce