DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] net/iavf: increase the reset complete wait count
@ 2022-05-27  2:13 Qiming Yang
  2022-05-27  4:27 ` Zhang, Qi Z
  2022-05-30  5:34 ` [PATCH v2] " Qiming Yang
  0 siblings, 2 replies; 5+ messages in thread
From: Qiming Yang @ 2022-05-27  2:13 UTC (permalink / raw)
  To: dev; +Cc: beilei.xing, Qiming Yang, stable

Kernel iavf driver has sent patch to increase the completion
wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Cc: stable@dpdk.org

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
 drivers/net/iavf/iavf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index f1c2daa06e..025ab3ff60 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -18,7 +18,7 @@
 
 #define IAVF_AQ_LEN               32
 #define IAVF_AQ_BUF_SZ            4096
-#define IAVF_RESET_WAIT_CNT       50
+#define IAVF_RESET_WAIT_CNT       500
 #define IAVF_BUF_SIZE_MIN         1024
 #define IAVF_FRAME_SIZE_MAX       9728
 #define IAVF_QUEUE_BASE_ADDR_UNIT 128
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] net/iavf: increase the reset complete wait count
  2022-05-27  2:13 [PATCH] net/iavf: increase the reset complete wait count Qiming Yang
@ 2022-05-27  4:27 ` Zhang, Qi Z
  2022-05-27  4:49   ` Yang, Qiming
  2022-05-30  5:34 ` [PATCH v2] " Qiming Yang
  1 sibling, 1 reply; 5+ messages in thread
From: Zhang, Qi Z @ 2022-05-27  4:27 UTC (permalink / raw)
  To: Yang, Qiming, dev; +Cc: Xing, Beilei, Yang, Qiming, stable



> -----Original Message-----
> From: Qiming Yang <qiming.yang@intel.com>
> Sent: Friday, May 27, 2022 10:13 AM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: increase the reset complete wait count
> 
> Kernel iavf driver has sent patch to increase the completion wait time to
> reduce the "Reset never finished" case.
> Follow this action in DPDK iavf driver.

Could you add a link to the corresponding kernel patch, so people can know why we need this change

^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] net/iavf: increase the reset complete wait count
  2022-05-27  4:27 ` Zhang, Qi Z
@ 2022-05-27  4:49   ` Yang, Qiming
  0 siblings, 0 replies; 5+ messages in thread
From: Yang, Qiming @ 2022-05-27  4:49 UTC (permalink / raw)
  To: Zhang, Qi Z, dev; +Cc: Xing, Beilei, stable

sure

> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: 2022年5月27日 12:28
> To: Yang, Qiming <qiming.yang@intel.com>; dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: increase the reset complete wait count
> 
> 
> 
> > -----Original Message-----
> > From: Qiming Yang <qiming.yang@intel.com>
> > Sent: Friday, May 27, 2022 10:13 AM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, Qiming
> > <qiming.yang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: increase the reset complete wait count
> >
> > Kernel iavf driver has sent patch to increase the completion wait time
> > to reduce the "Reset never finished" case.
> > Follow this action in DPDK iavf driver.
> 
> Could you add a link to the corresponding kernel patch, so people can
> know why we need this change

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v2] net/iavf: increase the reset complete wait count
  2022-05-27  2:13 [PATCH] net/iavf: increase the reset complete wait count Qiming Yang
  2022-05-27  4:27 ` Zhang, Qi Z
@ 2022-05-30  5:34 ` Qiming Yang
  2022-05-30 11:41   ` Zhang, Qi Z
  1 sibling, 1 reply; 5+ messages in thread
From: Qiming Yang @ 2022-05-30  5:34 UTC (permalink / raw)
  To: dev; +Cc: qi.z.zhang, Qiming Yang, stable

Kernel iavf driver has sent patch to increase the completion
wait time to reduce the "Reset never finished" case.
Follow this action in DPDK iavf driver.
Kernel reference commit:
8e3e4b9da7e6 ("iavf: increase reset complete wait time")

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Cc: stable@dpdk.org

Signed-off-by: Qiming Yang <qiming.yang@intel.com>
---
* v2: add kernel patch reference in commit log
---
 drivers/net/iavf/iavf.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h
index f1c2daa06e..025ab3ff60 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -18,7 +18,7 @@
 
 #define IAVF_AQ_LEN               32
 #define IAVF_AQ_BUF_SZ            4096
-#define IAVF_RESET_WAIT_CNT       50
+#define IAVF_RESET_WAIT_CNT       500
 #define IAVF_BUF_SIZE_MIN         1024
 #define IAVF_FRAME_SIZE_MAX       9728
 #define IAVF_QUEUE_BASE_ADDR_UNIT 128
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH v2] net/iavf: increase the reset complete wait count
  2022-05-30  5:34 ` [PATCH v2] " Qiming Yang
@ 2022-05-30 11:41   ` Zhang, Qi Z
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2022-05-30 11:41 UTC (permalink / raw)
  To: Yang, Qiming, dev; +Cc: stable



> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Monday, May 30, 2022 1:35 PM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; stable@dpdk.org
> Subject: [PATCH v2] net/iavf: increase the reset complete wait count
> 
> Kernel iavf driver has sent patch to increase the completion wait time to
> reduce the "Reset never finished" case.
> Follow this action in DPDK iavf driver.
> Kernel reference commit:
> 8e3e4b9da7e6 ("iavf: increase reset complete wait time")
> 
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-30 11:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-27  2:13 [PATCH] net/iavf: increase the reset complete wait count Qiming Yang
2022-05-27  4:27 ` Zhang, Qi Z
2022-05-27  4:49   ` Yang, Qiming
2022-05-30  5:34 ` [PATCH v2] " Qiming Yang
2022-05-30 11:41   ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).