From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5449B41BA8; Thu, 2 Feb 2023 06:55:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FF0C42D0E; Thu, 2 Feb 2023 06:55:07 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6E7034067B; Thu, 2 Feb 2023 06:55:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675317305; x=1706853305; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/r9lFR0uyP1SPt8swaFK4WPlMQyc7SVSZgUF8JpSCh4=; b=OxiJOizF2++OMW20swHTOTipc4i5MfN61Yhyzo8Q3DtWymxaQf5w8/KX +2vccPC1mjNyAtWuACjgCt4t2BEPrBDHqpv5w9rTTrsRP/xPeDvAXWSgj Xv4eV0rs9YG1B+dqW6c0hGYNsflidRU2v27vk01V5WMA1HZazIvEIKVPC NyEHdU96J18NRfHyR+Ky4EK0z9illoIrmxpMAdwG52DvMjTcseHfcRq+a hhuQvilk242+1g8WUqocQ3Xw81brdcBZvIkyuDjNX5YSm9pEm70b23CQQ XcSMMFh1Q0oDp9DmjPo7yAVnckNvq7y2IJlReTatvCad+QIuu4HAITaEn g==; X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="328374758" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="328374758" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2023 21:54:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10608"; a="667180581" X-IronPort-AV: E=Sophos;i="5.97,266,1669104000"; d="scan'208";a="667180581" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 01 Feb 2023 21:54:58 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 1 Feb 2023 21:54:57 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 1 Feb 2023 21:54:57 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 1 Feb 2023 21:54:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PHziKUCqEAnmUxgPZw7pX1L0Vzc9zHcUNPCuXUWd8VONMxGnEsy9zobFnwHcb8UhNo6qI+lnFslBQqiwvpYQG9ZTDX/JdfLhNbWnJ2eMa3KGTsmK8ytwKG/Dd0J7BtsJ70Q4+Yi/TtDhWByxkQh5QIbDaDpTjfDa3L9IocLloTvlttaj5pG5EUFAWDoMw8k9cQQN7TH95F7+8eQbCiATks1e84FMhQzclMhmjUW/twxUn7YSN+gIXoyqy/yxBGCs0FiRj0G/E2vq0mYDUJGp1iv8jXupGga0hL838zpwZy+ZZg1EGZ5eELgXHA6ckPH1nC37l3W+pynfexXdgJ3wTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1eZcxuOO6drAyU3Kx0UGpn7mcw1ZCLxNgknz4yONHeE=; b=KTdVEaRlqyT4jLszl5J5jBudWkRgPCvr1RRwgIXoAi6c91o0lsUGdBwHeE/Pe8sEL+w3c5qpKg5AZCkrRLAdnZNIBsx06A3GT4tunGeSF5LCtLGu4uw479aE5eMmAShszHzSHpUufr8GtgQarsQCY0Lx6X7CZhzP2xPtDTeEN0qr4yeFWQZl5Ok32cY823ptCLVAam6undUpZpGSpDx5mgSPXreTqq9+HnfGdf3eXVqkV+ehNZ1fKLS36SN+Fnqb3i+8WgoAx2Zd/FupCabuClz4jgxAz/2rzpJO4XTXvoBgmHPxQIKBPceLFTl6LrMhxwQMMojbVXJIhTEywoZBLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9) by MW4PR11MB5934.namprd11.prod.outlook.com (2603:10b6:303:189::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6064.25; Thu, 2 Feb 2023 05:54:56 +0000 Received: from MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad]) by MWHPR11MB1886.namprd11.prod.outlook.com ([fe80::6c25:9f9b:b5ec:24ad%7]) with mapi id 15.20.6064.027; Thu, 2 Feb 2023 05:54:55 +0000 From: "Yang, Qiming" To: "Su, Simei" , "Xing, Beilei" , "Zhang, Yuying" , "david.marchand@redhat.com" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "stable@dpdk.org" Subject: RE: [PATCH v3] net/i40e: rework maximum frame size configuration Thread-Topic: [PATCH v3] net/i40e: rework maximum frame size configuration Thread-Index: AQHZNV9RzvaR2XDyaU24S0KTxW4QVK67JEog Date: Thu, 2 Feb 2023 05:54:55 +0000 Message-ID: References: <20230131065229.290041-1-simei.su@intel.com> <20230131103138.302942-1-simei.su@intel.com> In-Reply-To: <20230131103138.302942-1-simei.su@intel.com> Accept-Language: en-US, zh-CN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MWHPR11MB1886:EE_|MW4PR11MB5934:EE_ x-ms-office365-filtering-correlation-id: fe13a6a3-ba08-41c7-d3dd-08db04e2027e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PofeMhBx9pzjDekkiz9ItKXlMivsVMrrRLfYoocosLW1h+L55h7Kd4FYuYjaB7KuV6WO1OYOVxjVpiS/zq8D4USmZwZ72FCHi05jIiN+e00d1HXn0b/0z3lG8d5cWB9A439167KbA7NOnKx/duzi+D5pSxow4KX4wVQD40OC/nvzxEJ9QMMwlBJQER2MJ2okIEBKAfsrMhfRBCJbdVrIGCZtpL0Ksqz+NmwyKap0AJ2Qglql4TE4JAwBT5fopTJVyrXmA9jtGuQqQpFr2Ey4Gpa9jDbYpzJ5F7XeqL76Rt2VLg6asyZRlBrKMO6MxTu2G+idNkReUJ4Gd3jIRcZc7J3bGuPcqKKAM2O5lxNRudtt0mhY8Gf4prlyD808K7lc8JOg51qd7WbkBSMNDJgfpw7dypAAyN5719fMM9B57bOQkhs3c7zAkNdIxavs9SN44UwsPw0ytAL7rQ4o6oxyMKyviglpifutyvbVaVEFYK1qtFDDGZ8uUItMd5JPy4dZy0EHcs214Lfz2IIkhbKj3uXn8ivBnK5owHoPRAte7bdYL/qVBjAuFDXy5w+GvnDSY+L03MZ7pXO/hcEmM0NnJD5EdFaCUaHzYTX8E4GuX55QQVuA7Ke5xQE4YmUuY3nk4vUxAiKZDZFPQOiLHB4EWdW7qxc/miE6P/augzYXnao9dNIGuWKqmX2QcUiX175UYNgyDJm3J8xLFwQw4myVEMRVWEuevmyAIIs1R9f0u1U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1886.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(366004)(136003)(346002)(376002)(396003)(451199018)(83380400001)(71200400001)(316002)(54906003)(110136005)(33656002)(2906002)(38100700002)(7696005)(82960400001)(122000001)(53546011)(76116006)(6506007)(66946007)(66556008)(66476007)(8676002)(26005)(186003)(9686003)(478600001)(64756008)(52536014)(41300700001)(86362001)(55016003)(38070700005)(66446008)(4326008)(5660300002)(8936002)(309714004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fyBhKSUmQCdzTFnVlsoryZu16qr4gVcxdfLcWTlulqNbUvGhXd3XFyaUl8+l?= =?us-ascii?Q?qjhwGXyNBYYgRqRZOlv5z4jrCVUs1DOgEGCZijhu5D3X1fXo/dL/2j68BoIx?= =?us-ascii?Q?6hUMzaArx/2OX+TWO7GYmsB4v/C2oFlZI6QX7JlgbAhR85z0mwt96m5A6UlV?= =?us-ascii?Q?Y2i+ZUqfnpKQWYdIa1TOEMKCEd5D1TgjCMD3n2ly3zUxkus3tprAUjVVIPxu?= =?us-ascii?Q?vupm/knVwWE6dkiIxxuynApjGKBpsera5Ht6hFUGsj3YrttmklGkWCbJc1mB?= =?us-ascii?Q?YblWHHBSbdFC4a2G+Fnvn4XroyRzDyIZlHw8HYk5lgTFxCO5AD9AGAnGYwfY?= =?us-ascii?Q?HmDCMPuS7mywK0B9L/q5RE1LjjHeXmDoaqAhrF59q8tZ1xMklyrUWc68sz3d?= =?us-ascii?Q?Xyt0TFJN65NUsNeFWL7rAm8sJhEvwkRn8Xc3auOWSfPAUoPNgAp3FE07NUMR?= =?us-ascii?Q?B9y4NFFMbk/cMJTN/TRzoqMl1ghRVaSx5a10dGguECu9pRxTej/ks7qFNMdE?= =?us-ascii?Q?GbajSgtPu81RCQ48taVVjmeb0FOnYon+Dt6NEFm4zMX/khzeQHsZKbnFL965?= =?us-ascii?Q?D3RZf4rKYZHEcitQFWKyN5kHr82jW39jRN94Lhee/xKMFunPlq984S1WpGlN?= =?us-ascii?Q?LXWCdXiM5kvDoqfOWrvsN+0uGeKoaUboZOT+rVhN/rogeIZr9QAsS1Tard13?= =?us-ascii?Q?USEHsmBuwXsBMbqOYG6hcCGbtqQPbKoEWwzzZp4aJ9NAI3kjB/4xMOxWNF2b?= =?us-ascii?Q?rflEz+KscZPrq6yiH7UBHhx16ISXPWEI6aZcHUGqngucvVVd9Vqa/hIA3zTH?= =?us-ascii?Q?AI95OvG3+Xy4GbsxDx8XiK1IrJj9k3urn7z9NXGR0jtn+clF4pDRTM900bN4?= =?us-ascii?Q?8LOI8sgPXt0nXsa6MlxmYDt9Yd8SFjrYUJEvuR/MNMzBNoUE2PDaZxcZYX3q?= =?us-ascii?Q?5m+Sf9Mu/JvKv/QZFkpoautycMTI51S84vgx08TH3JNJ0XZFOZ4lifR3d3Yc?= =?us-ascii?Q?DyoKIIkaz3hNw8GPwJ8q+Qk0ZoT02DRavvG3wzFjNtJQXellQyGAks66baLy?= =?us-ascii?Q?ei0rCSrVu+s7X3VYbhM5K2Q/eZbKfLp8Y/MFja7zE0cOrN5T5Qglt3Zg0Hts?= =?us-ascii?Q?k8o4sY7ek+BLE0V1McArmeczwBNRvVK85mAlObvr4P5dxvR5uYTyd5FQo4km?= =?us-ascii?Q?L6XAuZH911+KSKShgO/9YtqQKj4ygM4bWzG4kYSzv0ismg9lBWc9Ziw/hZyn?= =?us-ascii?Q?MW789K5RmAtnnRtbnp5JAV7ntvCovOsgDynwFidhNHl+1mo5k7QjLHXm7qUu?= =?us-ascii?Q?dmbtZ9Mh4Ie4rnptZGOpVjcVWvxcqXGDrPwQsCwd06qfuUB5DfHG+ndkJUwM?= =?us-ascii?Q?PLE4bAXdYtu/5T/3XyLXlfZ1FbUP+SbtlzdP8wyUvc0JdJPz6LNUaacUsWgW?= =?us-ascii?Q?krGgBFSbX1qGAoQ1QW2wxz+Ly5BYpSScLAqWLEcPhMc3sGM3Al4CNrJvGUun?= =?us-ascii?Q?LJSuLlZg0/GKKeO29KDtrWvxSdjrOBdZjKdOlHgj6c8KaRu/fxyGXg8KkV0q?= =?us-ascii?Q?2p6GikEc1BEFKdgKl8/RzGsrhSQcsiL3s/pNHQAS?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe13a6a3-ba08-41c7-d3dd-08db04e2027e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2023 05:54:55.3623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uDhKLY5BVEThLK8qoeXDZBOue5BgwUWwZ0GQeDxU9aSeHzwApEQaRpCA1NhJremQfJFfQYOAMEaNHbSTSTotqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5934 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Su, Simei > Sent: Tuesday, January 31, 2023 6:32 PM > To: Xing, Beilei ; Zhang, Yuying > ; david.marchand@redhat.com > Cc: dev@dpdk.org; Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; > stable@dpdk.org > Subject: [PATCH v3] net/i40e: rework maximum frame size configuration >=20 > This patch removes unnecessary link status check and adds link update. I think this patch is not adding link update, just delete interrupt mode ch= eck before link update. And why you change the wait to complete from 0 to 1? >=20 > Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level") > Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level") > Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722") > Cc: stable@dpdk.org >=20 > Signed-off-by: Simei Su > --- > v3: > * Put link update before interrupt enable. >=20 > v2: > * Refine commit log. > * Add link update. >=20 > drivers/net/i40e/i40e_ethdev.c | 58 +++++++++++-------------------------= ------ > 1 file changed, 15 insertions(+), 43 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 7726a89d..f5a6cec 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -387,7 +387,6 @@ static int i40e_set_default_mac_addr(struct > rte_eth_dev *dev, > struct rte_ether_addr *mac_addr); >=20 > static int i40e_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu); -sta= tic > void i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size); >=20 > static int i40e_ethertype_filter_convert( > const struct rte_eth_ethertype_filter *input, @@ -2447,11 +2446,11 > @@ i40e_dev_start(struct rte_eth_dev *dev) > I40E_AQ_EVENT_MEDIA_NA), > NULL); > if (ret !=3D I40E_SUCCESS) > PMD_DRV_LOG(WARNING, "Fail to set phy mask"); > - > - /* Call get_link_info aq command to enable/disable LSE */ > - i40e_dev_link_update(dev, 0); > } >=20 > + /* Call get_link_info aq command to enable/disable LSE */ > + i40e_dev_link_update(dev, 1); > + > if (dev->data->dev_conf.intr_conf.rxq =3D=3D 0) { > rte_eal_alarm_set(I40E_ALARM_INTERVAL, > i40e_dev_alarm_handler, dev); > @@ -2467,8 +2466,16 @@ i40e_dev_start(struct rte_eth_dev *dev) > "please call hierarchy_commit() " > "before starting the port"); >=20 > - max_frame_size =3D dev->data->mtu + I40E_ETH_OVERHEAD; > - i40e_set_mac_max_frame(dev, max_frame_size); > + max_frame_size =3D dev->data->mtu ? > + dev->data->mtu + I40E_ETH_OVERHEAD : > + I40E_FRAME_SIZE_MAX; > + > + /* Set the max frame size to HW*/ > + ret =3D i40e_aq_set_mac_config(hw, max_frame_size, TRUE, false, 0, > NULL); > + if (ret) { > + PMD_DRV_LOG(ERR, "Fail to set mac config"); > + return ret; > + } >=20 > return I40E_SUCCESS; >=20 > @@ -2809,9 +2816,6 @@ i40e_dev_set_link_down(struct rte_eth_dev *dev) > return i40e_phy_conf_link(hw, abilities, speed, false); } >=20 > -#define CHECK_INTERVAL 100 /* 100ms */ > -#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ > - > static __rte_always_inline void > update_link_reg(struct i40e_hw *hw, struct rte_eth_link *link) { @@ - > 2878,6 +2882,8 @@ static __rte_always_inline void update_link_aq(struct > i40e_hw *hw, struct rte_eth_link *link, > bool enable_lse, int wait_to_complete) { > +#define CHECK_INTERVAL 100 /* 100ms */ > +#define MAX_REPEAT_TIME 10 /* 1s (10 * 100ms) in total */ > uint32_t rep_cnt =3D MAX_REPEAT_TIME; > struct i40e_link_status link_status; > int status; > @@ -12123,40 +12129,6 @@ i40e_cloud_filter_qinq_create(struct i40e_pf > *pf) > return ret; > } >=20 > -static void > -i40e_set_mac_max_frame(struct rte_eth_dev *dev, uint16_t size) -{ > - struct i40e_hw *hw =3D I40E_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > - uint32_t rep_cnt =3D MAX_REPEAT_TIME; > - struct rte_eth_link link; > - enum i40e_status_code status; > - bool can_be_set =3D true; > - > - /* > - * I40E_MEDIA_TYPE_BASET link up can be ignored > - * I40E_MEDIA_TYPE_BASET link down that hw->phy.media_type > - * is I40E_MEDIA_TYPE_UNKNOWN > - */ > - if (hw->phy.media_type !=3D I40E_MEDIA_TYPE_BASET && > - hw->phy.media_type !=3D I40E_MEDIA_TYPE_UNKNOWN) { > - do { > - update_link_reg(hw, &link); > - if (link.link_status) > - break; > - rte_delay_ms(CHECK_INTERVAL); > - } while (--rep_cnt); > - can_be_set =3D !!link.link_status; > - } > - > - if (can_be_set) { > - status =3D i40e_aq_set_mac_config(hw, size, TRUE, 0, false, > NULL); > - if (status !=3D I40E_SUCCESS) > - PMD_DRV_LOG(ERR, "Failed to set max frame size at > port level"); > - } else { > - PMD_DRV_LOG(ERR, "Set max frame size at port level not > applicable on link down"); > - } > -} > - > RTE_LOG_REGISTER_SUFFIX(i40e_logtype_init, init, NOTICE); > RTE_LOG_REGISTER_SUFFIX(i40e_logtype_driver, driver, NOTICE); #ifdef > RTE_ETHDEV_DEBUG_RX > -- > 2.9.5