From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 59D02A0540;
Thu, 7 Jul 2022 08:58:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id DF36842836;
Thu, 7 Jul 2022 08:57:59 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id C5F93406B4
for <dev@dpdk.org>; Thu, 7 Jul 2022 08:57:58 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1657177079; x=1688713079;
h=from:to:cc:subject:date:message-id:references:
in-reply-to:content-transfer-encoding:mime-version;
bh=N17+FUyddA99/mloDjdue+7MrqjlLhEoA5N/FHrNq4I=;
b=K1DFudKjQUB8OCR3rNz1NpC2SS2oI0nxJAMVr57/RYdwjf/Kx3JYG/4v
yYKox4xDhIwsguZzgIuLqdMJ5VV8xvLpvRadijUBe5tivLZLnZzzzPVAy
yVe+ZVg8QQ+fh59db0DGzzDVSj6ytoI6Tk7UUKlUL61xO1hbBIIufhnzt
JPtYEmdtcWmJCc9IRhVNRzyVNuKUR0LYwxMYeZ0yXoznyQlOGKXVkgvzr
GelOomYUoaKjDdHP0e2JObvFRBrpSlgX5UXCvD3GlkvLY5R3FWix8xN+V
u7r1vi6LGxaQgxJrWTyRLtfmzaNf0/j/UnMLLCKlK6s8XJTD5AZYmVl3/ A==;
X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="263733468"
X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="263733468"
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
06 Jul 2022 23:57:57 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="920479116"
Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19])
by fmsmga005.fm.intel.com with ESMTP; 06 Jul 2022 23:57:57 -0700
Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by
ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.27; Wed, 6 Jul 2022 23:57:56 -0700
Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by
ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.27; Wed, 6 Jul 2022 23:57:56 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 23:57:56 -0700
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171)
by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2308.27; Wed, 6 Jul 2022 23:57:55 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=JH/oaJ0TMMuFHUvAZbCtO/P39C3WFnk127i36sg57LPudo/54eIx+YeU4kUo3IRs1EysSmUAscm6E91bpMEeucjKrMRCXACacO+TYVan7fQUYEME7VJb7atTkOjQrUHLnsUpsHjTFosnweng0Fe95nCiziUChMEiPW8hbVj+HYPReTtJyhM6s1C1nt2/8SP3z/KUSIjGVTbtyP2CWIZ+7kW2WQBOjGP+dAZ9KILd5x8JvE+FVVrsfxYkFkx7CIe0gyoo1lvvaaXgd9ne6vUA+8bFjuodfeQmwRWnRZSx4y382Gx2aPo+nzTklZmPVlVjiZuuWM4CGJX+3K9XMhIQmA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=E3kn9MUJy7iLbT0NsdhGbBb9VohCw9DeAMYN9OIi1KQ=;
b=Ma6sVcwfw3k+P2PDvRk2fJzTCqOirZdO8saxM7BzVgW7dHTJJYL6jKFcZ+7QMxdTcGuM4NL6LYTtCeu3xN7u0g/6w5x6xTuMa/nSlqdayOL4qp0mcen2IY75zuCh9CVEvpQY9mtBDcfl3wlTnpQtYQQiCV9Yu0bBCBXbgiqmX4+X72iCCkwCkkVvRFbDuudC4x2d27FoaHMD9BNujBq12TfHYunPegAd37ThjP/grlDTpXzgwAWeVxzPd7PAFkyCOYrh7czb8TsSwPEYUc5umQkr0HAwuVusrc9+8mS5n14y2LRUA9fnT1x/j/5/qh1utdY0tbYxFz/uuAK7nOc7ew==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
Received: from MWHPR11MB1886.namprd11.prod.outlook.com (2603:10b6:300:110::9)
by CY4PR11MB1640.namprd11.prod.outlook.com (2603:10b6:910:8::10) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul
2022 06:57:52 +0000
Received: from MWHPR11MB1886.namprd11.prod.outlook.com
([fe80::14e0:4dae:c8f5:3146]) by MWHPR11MB1886.namprd11.prod.outlook.com
([fe80::14e0:4dae:c8f5:3146%9]) with mapi id 15.20.5395.022; Thu, 7 Jul 2022
06:57:52 +0000
From: "Yang, Qiming" <qiming.yang@intel.com>
To: "Wu, WenxuanX" <wenxuanx.wu@intel.com>, "qiz.zhang@intel.com"
<qiz.zhang@intel.com>, "Xing, Beilei" <beilei.xing@intel.com>, "dev@dpdk.org"
<dev@dpdk.org>
CC: "Zhou, YidingX" <yidingx.zhou@intel.com>, "Su, Simei"
<simei.su@intel.com>, "stable@dpdk.com" <stable@dpdk.com>
Subject: RE: [PATCH v2] net/iavf: fix gtpu extension flow error
Thread-Topic: [PATCH v2] net/iavf: fix gtpu extension flow error
Thread-Index: AQHYkOR6cM8RzgA5ME+slKsZP2wJyq1ye44g
Date: Thu, 7 Jul 2022 06:57:52 +0000
Message-ID: <MWHPR11MB18865890DDC08A5396319B9AE5839@MWHPR11MB1886.namprd11.prod.outlook.com>
References: <20220705100949.1060962-1-wenxuanx.wu@intel.com>
<20220706025626.1070737-1-wenxuanx.wu@intel.com>
In-Reply-To: <20220706025626.1070737-1-wenxuanx.wu@intel.com>
Accept-Language: en-US, zh-CN
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: dkim=none (message not signed)
header.d=none;dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 26e5a390-421c-4e10-6cb7-08da5fe6031f
x-ms-traffictypediagnostic: CY4PR11MB1640:EE_
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: zXY9iGUMnqA10lwXEYhEjameAZlpZh6r2UOnmCBO+V+ENELL4CGcWZqmFIkMl/B+6ihiYoB0sORR+aDYtZ8NwejJq5oBS6dxC+80BridiLrt0CwzFhwa7VDjz/ei+x48OJuNrfp6VtIo1zNrYACAl98gXwjMSjnygAL2I1Vmn0zYhU2mcqABEyR7hd/sL9N9vdMjC7DJLV6it4URZBwyM34j8ncDir2IRnHjkwOGm6vRuE8ypPD78I2Eue1yl9e0Y27Qb9IVO72a+uatwIum2tw9ybwTcJlVqjOWHfcODd/hsnZb+6EmoFuKg3EEOc6gYq+cUvukqlvV/OKF6cYPdtJxKw0LAU7hXespvcEi8wvHXgTzP5QvmwWm5km0rf/WNge7iRYpzlrDfKpcI8zHFApzZGKBD2sbzwg+b8GoM/VFZAH7D1ivCvSE00L6gDByxRB44oh3+axu8exMJaVlNGRMLSuGrcZcVTcPRSXUJnXIao8XJnAfCMENA5ArCV9yJ/AD4zmianGJyJy9VMJt+u0OAGmcmKuPgTbXHy9epvoMI8hdVdweynfsF4XPQmt15WCK0HLnnxObHzQkVKEw6111NAdvgzdxV0oLX5dAU9/+ACUyV5FWh2FGNvUgZSsmDBPMyjnAsXeu5LTOhw5BeebdmjqctM6yvpyrpZt6PkcNoSojkJn0XvRWybx4gUXv5AA6xiPuRZNRinu20VVdxlN5kMA7oHnFv4mf9TJIkKu/IZqTttkM3ciQkLdv0SUSEbExPWR7SdiOgN9HC6iwsLObVeUMVOKJnc6gBuTLMh9KZ8KRk4sC0OSbmqek9aVY
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:MWHPR11MB1886.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(13230016)(396003)(366004)(376002)(136003)(39860400002)(346002)(186003)(7696005)(55016003)(110136005)(54906003)(66446008)(66946007)(76116006)(64756008)(66556008)(66476007)(4326008)(8676002)(9686003)(26005)(71200400001)(83380400001)(53546011)(6506007)(33656002)(86362001)(38070700005)(38100700002)(122000001)(41300700001)(2906002)(316002)(478600001)(82960400001)(52536014)(8936002)(5660300002);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QJPFeQq8KmxWEj24cSXKUJH3AR+nI9IDQjoxHEoVfUB08TQh9W7n9uDTkgUM?=
=?us-ascii?Q?a43lGwJUoPD1Sq77iS3BGulWCRFrFyubIfRAYCI573SCxzb7DSuWRYNioxc9?=
=?us-ascii?Q?XJUYbUXrd4hC3yluvM4H7mWaN/rPPg+a1comjLzqaF9/lsJGMt76GsiY3ZWe?=
=?us-ascii?Q?2kyTzkxeWQA+/UiDSfwDzc794WJ5f7Nrokxwe8ytAPIVaL5XKZu3yaL/85v0?=
=?us-ascii?Q?iO0Cu7XnYl/FwB25x9LmdrTBLgp4K++MBt6+l7N40KNRy4Fx83n3nl67u+PS?=
=?us-ascii?Q?tG40E+N0M4Nmeb5B+phamkmLotrvAnEF5NsyPEj2GnrBBRerasE0WnOJJzfT?=
=?us-ascii?Q?eOBI0Zma24XyRGaIu9FLfqDzosInrXCU7TuKDTma53z+3U19EDB0Gz83sC3L?=
=?us-ascii?Q?tN0QclV5SXdOi3Hmng3EJ6afK0Msg5ORwGYC76rC0CqzLUhMCg7RsbL56C0s?=
=?us-ascii?Q?/s4ug7Dto/fzYpoNr7pNVh86LaC9YpMXu+vFewsGQIVpZ/Dm5k90Q/ofkG6D?=
=?us-ascii?Q?WajkMwAvE9GQpxQIBb4cM+jN6tgIbH7Vf4dyoLJ36fwaDUkEetIG3ThiFKjZ?=
=?us-ascii?Q?acrhIDKpPkJ9Sy77Gwzu1C6S4z3dpKs/XjixKlXl9lFNCzVBVqDOb56iXy60?=
=?us-ascii?Q?+wq/xNiRFiy+aiH1XhqZtTocoucSekXbPLP8RGNaDaxLLCr4/2eZ7LZkN84w?=
=?us-ascii?Q?A+eLQEtGJ4V7zTtMLHIkCOWrD4L5BeOXfT5Ypemp51YMxQWZpB1oHu4bBNzv?=
=?us-ascii?Q?VsSJi2zRwDvnkEUUPUqyH9XhcKSFUPKzEMcSKTMZDtJ1NsaA4kfcqY6IfZrN?=
=?us-ascii?Q?4aKhVa3qtljeFP9k1ldfAM+9IShgGrzsJXf5gLhmv2ewVAw757cbIKZqj8BH?=
=?us-ascii?Q?DKIm5+CkBvfQlFT3JFFX0+syoHK56FRqXD3UJE+SfZbLq1Wjxtvdf4ujK37A?=
=?us-ascii?Q?6ck2KXFtkB6lfoJxpgwwvhlJhO3QzQPgaQ8smd1lNhE3bhbT5BF60bcRJIAK?=
=?us-ascii?Q?5PWBedIZ0BSynsKaW3GtLWwX9GP9eJFLqsj9H81Xm18XkqTfQ54VScFyVqyu?=
=?us-ascii?Q?BH6fckopRoGMner/oyF4yW7vBvK1zU2AIDq6L12BIGVIMI1q1E8TU+917A+d?=
=?us-ascii?Q?I8rQOI8P03aE74xQkfzKvHCGYG+AwSgrJZqZetPXTzBLHQK32MD+yQU2rIBg?=
=?us-ascii?Q?71DrpcqdzGB4hxanG5omUM8AzemxjAKKZT4Kw0DhJcGVcrNmi50ahnfS3GwS?=
=?us-ascii?Q?Q6K0grGtMwqrxK8ngZCXY4ezXC/OuAtjwyhlj1Bunyi4kea9VotuCEt9huwJ?=
=?us-ascii?Q?Yx+MyABEhCC2j4MBKNvJdsPb4+WW2nX5QFh2oIPi7HnErDCJoJPtRzlHtM5h?=
=?us-ascii?Q?ZviB4YIZbkJaZLe/GtCnlFT8/JGkgdeFDLNdHLaW6rDHTVi40EIxVBi+jgYT?=
=?us-ascii?Q?JJeEhEHrW5fFfzHVjd0+Lo/S4+FXIMlhR81XGaDH1/H11esaIuNYLWg8Eg40?=
=?us-ascii?Q?XkskBP3DVOQ8r1ZSd8/s4e49rIKxfWH1NrtFJWHRLKQPlQdvuy6mYY/YBLxg?=
=?us-ascii?Q?DsmWq40TYH/Y6W2ABtGBIBAHUhMqgHw49AanfmC4?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1886.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26e5a390-421c-4e10-6cb7-08da5fe6031f
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 06:57:52.5698 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oREQQiA4ByQKDG012aXrfsCOXapbuk0p+JPctoSPWxYg6KvrGLXcWgsev8BeR8mICf5G21nG76WjX6eLAM821A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1640
X-OriginatorOrg: intel.com
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Hi,
> -----Original Message-----
> From: Wu, WenxuanX <wenxuanx.wu@intel.com>
> Sent: Wednesday, July 6, 2022 10:56
> To: qiz.zhang@intel.com; Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.o=
rg
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Wu, WenxuanX <wenxuanx.wu@intel.com>; Su,
> Simei <simei.su@intel.com>; stable@dpdk.com
> Subject: [PATCH v2] net/iavf: fix gtpu extension flow error
>=20
> From: Wenxuan Wu <wenxuanx.wu@intel.com>
>=20
> Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can no=
t
> handle gtp_psc properly, we introduce a new structure to fix this gap bet=
ween
> kernel driver and struct rte_gtp_psc_generic_hdr.
>=20
> Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
> Cc: simei.su@intel.com
This line should be delete before patch sent.
> Cc: stable@dpdk.com
>=20
> Signed-off-by: Wenxuan Wu <wenxuanx.wu@intel.com>
>=20
> ---
> v2: refine commit log and doc.
> ---
> drivers/net/iavf/iavf_fdir.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c =
index
> f236260502..4789d46ab2 100644
> --- a/drivers/net/iavf/iavf_fdir.c
> +++ b/drivers/net/iavf/iavf_fdir.c
> @@ -1300,8 +1300,22 @@ iavf_fdir_parse_pattern(__rte_unused struct
> iavf_adapter *ad,
>=20
> GTPU_DWN, QFI);
> }
>=20
> - rte_memcpy(hdr->buffer, gtp_psc_spec,
> - sizeof(*gtp_psc_spec));
> + /*
> + * New structure to fix gap between kernel
> driver and
> + * rte_gtp_psc_generic_hdr.
> + */
> + struct iavf_gtp_psc_spec_hdr {
> + uint8_t len;
> + uint8_t qfi:6;
> + uint8_t type:4;
> + uint8_t next;
> + } psc;
> + psc.len =3D gtp_psc_spec->hdr.ext_hdr_len;
> + psc.qfi =3D gtp_psc_spec->hdr.qfi;
> + psc.type =3D gtp_psc_spec->hdr.type;
> + psc.next =3D 0;
> + rte_memcpy(hdr->buffer, &psc,
> + sizeof(struct iavf_gtp_psc_spec_hdr));
> }
>=20
> hdrs->count =3D ++layer;
> --
> 2.25.1
Acked-by: Qiming Yang <Qiming.yang@intel.com>