* [PATCH] net/ice: fix Tx checksum offload capability
@ 2021-11-24 1:09 Qi Zhang
2021-12-07 3:17 ` Yang, Qiming
0 siblings, 1 reply; 3+ messages in thread
From: Qi Zhang @ 2021-11-24 1:09 UTC (permalink / raw)
To: qiming.yang; +Cc: dev, wei1.xu, Qi Zhang, stable
Add missing capability for outer UDP Tx checksum.
Also fixed the feature list in ice_dcf.ini
Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
Cc: stable@dpdk.org
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
doc/guides/nics/features/ice_dcf.ini | 5 +++++
drivers/net/ice/ice_dcf_ethdev.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/doc/guides/nics/features/ice_dcf.ini b/doc/guides/nics/features/ice_dcf.ini
index 4d6fb6d849..54073f0b88 100644
--- a/doc/guides/nics/features/ice_dcf.ini
+++ b/doc/guides/nics/features/ice_dcf.ini
@@ -3,6 +3,9 @@
;
; Refer to default.ini for the full list of available PMD features.
;
+; A feature with "P" indicates only be supported when non-vector path
+; is selected.
+;
[Features]
Queue start/stop = Y
Scattered Rx = Y
@@ -10,6 +13,8 @@ RSS hash = P
CRC offload = Y
L3 checksum offload = P
L4 checksum offload = P
+Inner L3 checksum = P
+Inner L4 checksum = P
Basic stats = Y
Linux = Y
x86-32 = Y
diff --git a/drivers/net/ice/ice_dcf_ethdev.c b/drivers/net/ice/ice_dcf_ethdev.c
index 28f7f7fb72..fb0d13e5ec 100644
--- a/drivers/net/ice/ice_dcf_ethdev.c
+++ b/drivers/net/ice/ice_dcf_ethdev.c
@@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
RTE_ETH_TX_OFFLOAD_TCP_TSO |
RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/ice: fix Tx checksum offload capability
2021-11-24 1:09 [PATCH] net/ice: fix Tx checksum offload capability Qi Zhang
@ 2021-12-07 3:17 ` Yang, Qiming
2022-01-02 8:23 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Yang, Qiming @ 2021-12-07 3:17 UTC (permalink / raw)
To: Zhang, Qi Z; +Cc: dev, Xu, Wei1, stable
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Wednesday, November 24, 2021 09:09
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix Tx checksum offload capability
>
> Add missing capability for outer UDP Tx checksum.
> Also fixed the feature list in ice_dcf.ini
>
> Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> doc/guides/nics/features/ice_dcf.ini | 5 +++++
> drivers/net/ice/ice_dcf_ethdev.c | 1 +
> 2 files changed, 6 insertions(+)
>
> diff --git a/doc/guides/nics/features/ice_dcf.ini
> b/doc/guides/nics/features/ice_dcf.ini
> index 4d6fb6d849..54073f0b88 100644
> --- a/doc/guides/nics/features/ice_dcf.ini
> +++ b/doc/guides/nics/features/ice_dcf.ini
> @@ -3,6 +3,9 @@
> ;
> ; Refer to default.ini for the full list of available PMD features.
> ;
> +; A feature with "P" indicates only be supported when non-vector path ;
> +is selected.
> +;
> [Features]
> Queue start/stop = Y
> Scattered Rx = Y
> @@ -10,6 +13,8 @@ RSS hash = P
> CRC offload = Y
> L3 checksum offload = P
> L4 checksum offload = P
> +Inner L3 checksum = P
> +Inner L4 checksum = P
> Basic stats = Y
> Linux = Y
> x86-32 = Y
> diff --git a/drivers/net/ice/ice_dcf_ethdev.c
> b/drivers/net/ice/ice_dcf_ethdev.c
> index 28f7f7fb72..fb0d13e5ec 100644
> --- a/drivers/net/ice/ice_dcf_ethdev.c
> +++ b/drivers/net/ice/ice_dcf_ethdev.c
> @@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
> RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> RTE_ETH_TX_OFFLOAD_TCP_TSO |
> RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> --
> 2.26.2
Acked-by: Qiming Yang <qiming.yang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] net/ice: fix Tx checksum offload capability
2021-12-07 3:17 ` Yang, Qiming
@ 2022-01-02 8:23 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2022-01-02 8:23 UTC (permalink / raw)
To: Yang, Qiming; +Cc: dev, Xu, Wei1, stable
> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Tuesday, December 7, 2021 11:17 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix Tx checksum offload capability
>
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Wednesday, November 24, 2021 09:09
> > To: Yang, Qiming <qiming.yang@intel.com>
> > Cc: dev@dpdk.org; Xu, Wei1 <wei1.xu@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ice: fix Tx checksum offload capability
> >
> > Add missing capability for outer UDP Tx checksum.
> > Also fixed the feature list in ice_dcf.ini
> >
> > Fixes: bf89db4409bb ("net/ice: complete device info get in DCF")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> > doc/guides/nics/features/ice_dcf.ini | 5 +++++
> > drivers/net/ice/ice_dcf_ethdev.c | 1 +
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/ice_dcf.ini
> > b/doc/guides/nics/features/ice_dcf.ini
> > index 4d6fb6d849..54073f0b88 100644
> > --- a/doc/guides/nics/features/ice_dcf.ini
> > +++ b/doc/guides/nics/features/ice_dcf.ini
> > @@ -3,6 +3,9 @@
> > ;
> > ; Refer to default.ini for the full list of available PMD features.
> > ;
> > +; A feature with "P" indicates only be supported when non-vector path
> > +; is selected.
> > +;
> > [Features]
> > Queue start/stop = Y
> > Scattered Rx = Y
> > @@ -10,6 +13,8 @@ RSS hash = P
> > CRC offload = Y
> > L3 checksum offload = P
> > L4 checksum offload = P
> > +Inner L3 checksum = P
> > +Inner L4 checksum = P
> > Basic stats = Y
> > Linux = Y
> > x86-32 = Y
> > diff --git a/drivers/net/ice/ice_dcf_ethdev.c
> > b/drivers/net/ice/ice_dcf_ethdev.c
> > index 28f7f7fb72..fb0d13e5ec 100644
> > --- a/drivers/net/ice/ice_dcf_ethdev.c
> > +++ b/drivers/net/ice/ice_dcf_ethdev.c
> > @@ -681,6 +681,7 @@ ice_dcf_dev_info_get(struct rte_eth_dev *dev,
> > RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
> > RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
> > RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
> > + RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
> > RTE_ETH_TX_OFFLOAD_TCP_TSO |
> > RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
> > RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
> > --
> > 2.26.2
>
> Acked-by: Qiming Yang <qiming.yang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-02 8:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-24 1:09 [PATCH] net/ice: fix Tx checksum offload capability Qi Zhang
2021-12-07 3:17 ` Yang, Qiming
2022-01-02 8:23 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).