From: Andrey Vesnovaty <andreyv@nvidia.com> To: Ori Kam <orika@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: "jer@marvell.com" <jer@marvell.com>, "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Slava Ovsiienko <viacheslavo@nvidia.com>, "andrey.vesnovaty@gmail.com" <andrey.vesnovaty@gmail.com>, "mdr@ashroe.eu" <mdr@ashroe.eu>, "nhorman@tuxdriver.com" <nhorman@tuxdriver.com>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, "samik.gupta@broadcom.com" <samik.gupta@broadcom.com>, Ori Kam <orika@mellanox.com>, Andrew Rybchenko <arybchenko@solarflare.com> Subject: Re: [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Date: Tue, 6 Oct 2020 10:28:03 +0000 Message-ID: <MWHPR1201MB25254378AB55FA712344C4E5DB0D0@MWHPR1201MB2525.namprd12.prod.outlook.com> (raw) In-Reply-To: <MN2PR12MB42861AE74E25A596704FB581D60F0@MN2PR12MB4286.namprd12.prod.outlook.com> PSB > -----Original Message----- > From: Ori Kam <orika@nvidia.com> > Sent: Sunday, October 4, 2020 2:11 PM > To: Andrey Vesnovaty <andreyv@nvidia.com>; dev@dpdk.org > Cc: jer@marvell.com; jerinjacobk@gmail.com; NBU-Contact-Thomas Monjalon > <thomas@monjalon.net>; ferruh.yigit@intel.com; > stephen@networkplumber.org; bruce.richardson@intel.com; Slava Ovsiienko > <viacheslavo@nvidia.com>; andrey.vesnovaty@gmail.com; mdr@ashroe.eu; > nhorman@tuxdriver.com; ajit.khaparde@broadcom.com; > samik.gupta@broadcom.com; Ori Kam <orika@mellanox.com>; Andrew > Rybchenko <arybchenko@solarflare.com> > Subject: RE: [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API > > Hi Andrey > > Why is this patch not part of the previous one? Got it. Will be squashed. > > Best, > Ori > > -----Original Message----- > > From: Andrey Vesnovaty <andreyv@nvidia.com> > > Sent: Sunday, October 4, 2020 1:06 AM > > To: dev@dpdk.org > > Cc: jer@marvell.com; jerinjacobk@gmail.com; NBU-Contact-Thomas > Monjalon > > <thomas@monjalon.net>; ferruh.yigit@intel.com; > > stephen@networkplumber.org; bruce.richardson@intel.com; Ori Kam > > <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; > > andrey.vesnovaty@gmail.com; mdr@ashroe.eu; nhorman@tuxdriver.com; > > ajit.khaparde@broadcom.com; samik.gupta@broadcom.com; Ori Kam > > <orika@mellanox.com>; Andrew Rybchenko <arybchenko@solarflare.com> > > Subject: [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API > > > > Add configuration argument to shared action create interface. > > Currently there is only ingress & egress fields but more fields can be > > added later. Shared action configuration & implementation are PMD > > specific. > > > > Signed-off-by: Andrey Vesnovaty <andreyv@nvidia.com> > > --- > > lib/librte_ethdev/rte_flow.c | 4 +++- > > lib/librte_ethdev/rte_flow.h | 17 +++++++++++++++-- > > lib/librte_ethdev/rte_flow_driver.h | 5 +++-- > > 3 files changed, 21 insertions(+), 5 deletions(-) > > > > diff --git a/lib/librte_ethdev/rte_flow.c b/lib/librte_ethdev/rte_flow.c > > index ba3f01f7c7..9afa8905df 100644 > > --- a/lib/librte_ethdev/rte_flow.c > > +++ b/lib/librte_ethdev/rte_flow.c > > @@ -1255,6 +1255,7 @@ rte_flow_get_aged_flows(uint16_t port_id, void > > **contexts, > > > > struct rte_flow_shared_action * > > rte_flow_shared_action_create(uint16_t port_id, > > + const struct rte_flow_shared_action_conf *conf, > > const struct rte_flow_action *action, > > struct rte_flow_error *error) > > { > > @@ -1265,7 +1266,8 @@ rte_flow_shared_action_create(uint16_t port_id, > > if (unlikely(!ops)) > > return NULL; > > if (likely(!!ops->shared_action_create)) { > > - shared_action = ops->shared_action_create(dev, action, error); > > + shared_action = ops->shared_action_create(dev, conf, action, > > + error); > > if (shared_action == NULL) > > flow_err(port_id, -rte_errno, error); > > return shared_action; > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > index 02391316cb..8a2db4f6da 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -3380,6 +3380,16 @@ int > > rte_flow_get_aged_flows(uint16_t port_id, void **contexts, > > uint32_t nb_contexts, struct rte_flow_error *error); > > > > +/** > > + * Specify shared action configuration > > + */ > > +struct rte_flow_shared_action_conf { > > + uint32_t ingress:1; > > + /**< Action valid for rules applied to ingress traffic. */ > > + uint32_t egress:1; > > + /**< Action valid for rules applied to egress traffic. */ > > +}; > > + > > /** > > * @warning > > * @b EXPERIMENTAL: this API may change without prior notice. > > @@ -3388,6 +3398,8 @@ rte_flow_get_aged_flows(uint16_t port_id, void > > **contexts, > > * > > * @param[in] port_id > > * The port identifier of the Ethernet device. > > + * @param[in] conf > > + * Shared action configuration. > > * @param[in] action > > * Action configuration for shared action creation. > > * @param[out] error > > @@ -3404,6 +3416,7 @@ rte_flow_get_aged_flows(uint16_t port_id, void > > **contexts, > > __rte_experimental > > struct rte_flow_shared_action * > > rte_flow_shared_action_create(uint16_t port_id, > > + const struct rte_flow_shared_action_conf *conf, > > const struct rte_flow_action *action, > > struct rte_flow_error *error); > > > > @@ -3432,8 +3445,8 @@ rte_flow_shared_action_create(uint16_t port_id, > > __rte_experimental > > int > > rte_flow_shared_action_destroy(uint16_t port_id, > > - struct rte_flow_shared_action *action, > > - struct rte_flow_error *error); > > + struct rte_flow_shared_action *action, > > + struct rte_flow_error *error); > > > > /** > > * @warning > > diff --git a/lib/librte_ethdev/rte_flow_driver.h > > b/lib/librte_ethdev/rte_flow_driver.h > > index 72bfc3b7a7..adaace47ea 100644 > > --- a/lib/librte_ethdev/rte_flow_driver.h > > +++ b/lib/librte_ethdev/rte_flow_driver.h > > @@ -111,8 +111,9 @@ struct rte_flow_ops { > > /** See rte_flow_shared_action_create() */ > > struct rte_flow_shared_action *(*shared_action_create) > > (struct rte_eth_dev *dev, > > - const struct rte_flow_action *action, > > - struct rte_flow_error *error); > > + const struct rte_flow_shared_action_conf *conf, > > + const struct rte_flow_action *action, > > + struct rte_flow_error *error); > > /** See rte_flow_shared_action_destroy() */ > > int (*shared_action_destroy) > > (struct rte_eth_dev *dev, > > -- > > 2.26.2
next prev parent reply other threads:[~2020-10-06 10:28 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 12:05 [dpdk-dev] [PATCH] add flow shared action API Andrey Vesnovaty 2020-07-03 15:02 ` Jerin Jacob 2020-07-03 15:21 ` Thomas Monjalon 2020-07-04 9:54 ` Andrey Vesnovaty 2020-07-04 10:10 ` Andrey Vesnovaty 2020-07-04 12:33 ` Jerin Jacob 2020-07-05 10:26 ` Ori Kam 2020-07-06 9:00 ` Jerin Jacob 2020-07-06 12:28 ` Ori Kam 2020-07-06 13:32 ` Andrey Vesnovaty 2020-07-07 2:30 ` Jerin Jacob 2020-07-07 6:21 ` Ori Kam 2020-07-07 15:21 ` Ferruh Yigit 2020-07-07 17:24 ` Ori Kam 2020-07-07 17:52 ` Ferruh Yigit 2020-07-07 19:38 ` Jerin Jacob 2020-07-07 21:03 ` Ori Kam 2020-07-08 9:25 ` Jerin Jacob 2020-07-08 9:47 ` Ori Kam 2020-07-08 11:00 ` Jerin Jacob 2020-07-08 11:50 ` Thomas Monjalon 2020-07-08 12:18 ` Ori Kam [not found] ` <20200708204015.24429-2-andreyv@mellanox.com> 2020-07-13 8:04 ` [dpdk-dev] [PATCH v2 1/6] ethdev: " Kinsella, Ray 2020-07-13 10:16 ` Andrew Rybchenko 2020-07-15 8:54 ` Andrew Rybchenko 2020-07-15 9:00 ` Andrew Rybchenko 2020-09-15 11:30 ` Andrey Vesnovaty [not found] ` <20200708204015.24429-3-andreyv@mellanox.com> 2020-07-13 8:06 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Kinsella, Ray 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API Andrey Vesnovaty 2020-09-12 2:18 ` Ajit Khaparde 2020-09-15 11:50 ` Andrey Vesnovaty 2020-09-15 15:49 ` Ajit Khaparde 2020-09-16 15:52 ` Andrey Vesnovaty 2020-09-16 19:20 ` Ajit Khaparde 2020-09-17 15:33 ` Andrew Rybchenko 2020-09-17 16:02 ` Ori Kam 2020-09-24 19:25 ` Ajit Khaparde 2020-09-26 11:09 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 00/10] RTE flow shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-04 11:10 ` Ori Kam 2020-10-06 10:22 ` Andrey Vesnovaty 2020-10-04 17:00 ` Stephen Hemminger 2020-10-04 17:01 ` Stephen Hemminger 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Andrey Vesnovaty 2020-10-04 11:11 ` Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty [this message] 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-10-04 11:21 ` Ori Kam 2020-10-06 10:34 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action Andrey Vesnovaty 2020-10-04 11:28 ` Ori Kam 2020-10-04 12:04 ` Ori Kam 2020-10-06 10:36 ` Andrey Vesnovaty 2020-10-04 11:14 ` [dpdk-dev] [PATCH v3 00/10] RTE flow " Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-07-09 4:44 ` Jerin Jacob 2020-07-09 6:08 ` Ori Kam 2020-07-09 12:25 ` Andrey Vesnovaty 2020-07-09 12:39 ` Thomas Monjalon 2020-07-09 4:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Jerin Jacob 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 0/2] RTE flow shared action Andrey Vesnovaty 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 6:27 ` Ori Kam 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 6:30 ` Ori Kam 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 13:01 ` Ori Kam 2020-10-07 21:23 ` Ajit Khaparde 2020-10-08 7:28 ` Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 20:01 ` Ajit Khaparde 2020-10-08 10:58 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 0/2] RTE flow " Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-08 22:30 ` Ajit Khaparde 2020-10-14 11:47 ` Andrey Vesnovaty 2020-10-12 14:19 ` Andrew Rybchenko 2020-10-13 20:06 ` Andrey Vesnovaty 2020-10-14 6:49 ` Andrew Rybchenko 2020-10-14 7:22 ` Thomas Monjalon 2020-10-14 11:43 ` Andrey Vesnovaty 2020-10-14 11:42 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-08 23:54 ` Ajit Khaparde 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 0/2] RTE flow " Andrey Vesnovaty 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API Andrey Vesnovaty 2020-10-14 11:44 ` Andrew Rybchenko 2020-10-14 16:17 ` Ferruh Yigit 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action Andrey Vesnovaty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MWHPR1201MB25254378AB55FA712344C4E5DB0D0@MWHPR1201MB2525.namprd12.prod.outlook.com \ --to=andreyv@nvidia.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrey.vesnovaty@gmail.com \ --cc=arybchenko@solarflare.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jer@marvell.com \ --cc=jerinjacobk@gmail.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=orika@mellanox.com \ --cc=orika@nvidia.com \ --cc=samik.gupta@broadcom.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git