From: Andrey Vesnovaty <andreyv@nvidia.com> To: Ajit Khaparde <ajit.khaparde@broadcom.com> Cc: dpdk-dev <dev@dpdk.org>, "jer@marvell.com" <jer@marvell.com>, Jerin Jacob <jerinjacobk@gmail.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Stephen Hemminger <stephen@networkplumber.org>, Bruce Richardson <bruce.richardson@intel.com>, Ori Kam <orika@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>, "andrey.vesnovaty@gmail.com" <andrey.vesnovaty@gmail.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Samik Gupta <samik.gupta@broadcom.com>, Andrew Rybchenko <arybchenko@solarflare.com> Subject: Re: [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Date: Thu, 8 Oct 2020 07:28:46 +0000 Message-ID: <MWHPR1201MB2525818A9D3BEDDD0AAEB7BDDB0B0@MWHPR1201MB2525.namprd12.prod.outlook.com> (raw) In-Reply-To: <CACZ4nhvJvc3bwV8i23yKpueg7LNtvUq5kbm0-xTMEeoOn=P_HQ@mail.gmail.com> Hi, Ajit. All spelling & rephrases will be fixed in next couple of hours & v7 will be sent. PSB response on shared action configuration documentation. Please respond ASAP since RC1 window about to close very soon. Thanks, Andrey > -----Original Message----- > From: Ajit Khaparde <ajit.khaparde@broadcom.com> > Sent: Thursday, October 8, 2020 12:23 AM > To: Andrey Vesnovaty <andreyv@nvidia.com> > Cc: dpdk-dev <dev@dpdk.org>; jer@marvell.com; Jerin Jacob > <jerinjacobk@gmail.com>; NBU-Contact-Thomas Monjalon > <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; Stephen > Hemminger <stephen@networkplumber.org>; Bruce Richardson > <bruce.richardson@intel.com>; Ori Kam <orika@nvidia.com>; Slava Ovsiienko > <viacheslavo@nvidia.com>; andrey.vesnovaty@gmail.com; Ray Kinsella > <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>; Samik Gupta > <samik.gupta@broadcom.com>; Andrew Rybchenko > <arybchenko@solarflare.com> > Subject: Re: [PATCH v5 1/2] ethdev: add flow shared action API > > Please see inline.. > > On Wed, Oct 7, 2020 at 5:56 AM Andrey Vesnovaty <andreyv@nvidia.com> > wrote: > > > > This commit introduces extension of DPDK flow action API enabling > > sharing of single rte_flow_action in multiple flows. The API intended for > > PMDs, where multiple HW offloaded flows can reuse the same HW > > essence/object representing flow action and modification of such an > > essence/object affects all the rules using it. > > > > Motivation and example > > === > > Adding or removing one or more queues to RSS used by multiple flow rules > > imposes per rule toll for current DPDK flow API; the scenario requires > > for each flow sharing cloned RSS action: > > - call `rte_flow_destroy()` > > - call `rte_flow_create()` with modified RSS action > > > > [snip] > > Shared action create/use/destroy > > === > > Shared action may be reused by some or none flow rules at any given > > moment, i.e. shared action reside outside of the context of any flow. > s/reside/resides > > [snip] > > testpmd > > === > > In order to utilize introduced API testpmd cli may implement following > > extension > > create/update/destroy/query shared action accordingly > > > > flow shared_action (port) create {action_id (id)} (action) / end > Same comment as in testpmd patch. Please add the ability to specify > and parse direction. > > > flow shared_action (port) update (id) (action) / end > > flow shared_action (port) destroy action_id (id) {action_id (id) [...]} > > flow shared_action (port) query (id) > > > > testpmd example > > === > > > > configure rss to queues 1 & 2 > > > > > flow shared_action 0 create action_id 100 rss queues 1 2 end / end > > > > create flow rule utilizing shared action > > > > > flow create 0 ingress \ > > pattern eth dst is 0c:42:a1:15:fd:ac / ipv6 / tcp / end \ > > actions shared 100 / end > > > > add 2 more queues > > > > > flow shared_action 0 modify 100 rss queues 1 2 3 4 end / end > > > > example > > === > > > > struct rte_flow_action actions[2]; > > struct rte_flow_action action; > > /* skipped: initialize action */ > > struct rte_flow_shared_action *handle = rte_flow_shared_action_create( > > port_id, &action, &error); > > actions[0].type = RTE_FLOW_ACTION_TYPE_SHARED; > > actions[0].conf = handle; > direction? > > > actions[1].type = RTE_FLOW_ACTION_TYPE_END; > > /* skipped: init attr0 & pattern0 args */ > [snip] > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h > > index da8bfa5489..383d516fbd 100644 > > --- a/lib/librte_ethdev/rte_flow.h > > +++ b/lib/librte_ethdev/rte_flow.h > > @@ -1714,7 +1714,8 @@ enum rte_flow_action_type { > > /** > > * Enables counters for this flow rule. > > * > > - * These counters can be retrieved and reset through rte_flow_query(), > > + * These counters can be retrieved and reset through rte_flow_query() or > > + * rte_flow_shared_action_query() if the action provided via handle, > > * see struct rte_flow_query_count. > > * > > * See struct rte_flow_action_count. > > @@ -2132,6 +2133,14 @@ enum rte_flow_action_type { > > * see enum RTE_ETH_EVENT_FLOW_AGED > > */ > > RTE_FLOW_ACTION_TYPE_AGE, > > + > > + /** > > + * Describe action shared a cross multiple flow rules. > s/a cross/across > > > + * > > + * Allow multiple rules reference the same action by handle (see > > + * struct rte_flow_shared_action). > > + */ > > + RTE_FLOW_ACTION_TYPE_SHARED, > > }; > > > > /** > > @@ -2693,6 +2702,20 @@ struct rte_flow_action_set_dscp { > > uint8_t dscp; > > }; > > > > + > > +/** > > + * RTE_FLOW_ACTION_TYPE_SHARED > > + * > > + * Opaque type returned after successfully creating a shared action. > > + * > > + * This handle can be used to manage and query the related action: > > + * - share it a cross multiple flow rules > s/a cross/across > > > + * - update action configuration > > + * - query action data > > + * - destroy action > > + */ > > +struct rte_flow_shared_action; > > + > > /* Mbuf dynamic field offset for metadata. */ > > extern int32_t rte_flow_dynf_metadata_offs; > > > > @@ -3357,6 +3380,144 @@ int > > rte_flow_get_aged_flows(uint16_t port_id, void **contexts, > > uint32_t nb_contexts, struct rte_flow_error *error); > > > > +/** > > + * Specify shared action configuration > > + */ > > +struct rte_flow_shared_action_conf { > > + uint32_t ingress:1; > > + /**< Action valid for rules applied to ingress traffic. */ > > + uint32_t egress:1; > > + /**< Action valid for rules applied to egress traffic. */ > Add a note to indicate only one of these shall be set. > "only" -> "at least" Action should be valid for at least one direction but some actions valid for both ingress & egress. For example, shared counter can be incremented on both incoming & outgoing packets. > > +}; > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice. > > + * > [snip]
next prev parent reply other threads:[~2020-10-08 7:29 UTC|newest] Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-02 12:05 [dpdk-dev] [PATCH] " Andrey Vesnovaty 2020-07-03 15:02 ` Jerin Jacob 2020-07-03 15:21 ` Thomas Monjalon 2020-07-04 9:54 ` Andrey Vesnovaty 2020-07-04 10:10 ` Andrey Vesnovaty 2020-07-04 12:33 ` Jerin Jacob 2020-07-05 10:26 ` Ori Kam 2020-07-06 9:00 ` Jerin Jacob 2020-07-06 12:28 ` Ori Kam 2020-07-06 13:32 ` Andrey Vesnovaty 2020-07-07 2:30 ` Jerin Jacob 2020-07-07 6:21 ` Ori Kam 2020-07-07 15:21 ` Ferruh Yigit 2020-07-07 17:24 ` Ori Kam 2020-07-07 17:52 ` Ferruh Yigit 2020-07-07 19:38 ` Jerin Jacob 2020-07-07 21:03 ` Ori Kam 2020-07-08 9:25 ` Jerin Jacob 2020-07-08 9:47 ` Ori Kam 2020-07-08 11:00 ` Jerin Jacob 2020-07-08 11:50 ` Thomas Monjalon 2020-07-08 12:18 ` Ori Kam [not found] ` <20200708204015.24429-2-andreyv@mellanox.com> 2020-07-13 8:04 ` [dpdk-dev] [PATCH v2 1/6] ethdev: " Kinsella, Ray 2020-07-13 10:16 ` Andrew Rybchenko 2020-07-15 8:54 ` Andrew Rybchenko 2020-07-15 9:00 ` Andrew Rybchenko 2020-09-15 11:30 ` Andrey Vesnovaty [not found] ` <20200708204015.24429-3-andreyv@mellanox.com> 2020-07-13 8:06 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Kinsella, Ray 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API Andrey Vesnovaty 2020-09-12 2:18 ` Ajit Khaparde 2020-09-15 11:50 ` Andrey Vesnovaty 2020-09-15 15:49 ` Ajit Khaparde 2020-09-16 15:52 ` Andrey Vesnovaty 2020-09-16 19:20 ` Ajit Khaparde 2020-09-17 15:33 ` Andrew Rybchenko 2020-09-17 16:02 ` Ori Kam 2020-09-24 19:25 ` Ajit Khaparde 2020-09-26 11:09 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 00/10] RTE flow shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-04 11:10 ` Ori Kam 2020-10-06 10:22 ` Andrey Vesnovaty 2020-10-04 17:00 ` Stephen Hemminger 2020-10-04 17:01 ` Stephen Hemminger 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Andrey Vesnovaty 2020-10-04 11:11 ` Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-10-04 11:21 ` Ori Kam 2020-10-06 10:34 ` Andrey Vesnovaty 2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action Andrey Vesnovaty 2020-10-04 11:28 ` Ori Kam 2020-10-04 12:04 ` Ori Kam 2020-10-06 10:36 ` Andrey Vesnovaty 2020-10-04 11:14 ` [dpdk-dev] [PATCH v3 00/10] RTE flow " Ori Kam 2020-10-06 10:28 ` Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action Andrey Vesnovaty 2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty 2020-07-09 4:44 ` Jerin Jacob 2020-07-09 6:08 ` Ori Kam 2020-07-09 12:25 ` Andrey Vesnovaty 2020-07-09 12:39 ` Thomas Monjalon 2020-07-09 4:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Jerin Jacob 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 0/2] RTE flow shared action Andrey Vesnovaty 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 6:27 ` Ori Kam 2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 6:30 ` Ori Kam 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 13:01 ` Ori Kam 2020-10-07 21:23 ` Ajit Khaparde 2020-10-08 7:28 ` Andrey Vesnovaty [this message] 2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 0/2] RTE flow " Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-07 20:01 ` Ajit Khaparde 2020-10-08 10:58 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 0/2] RTE flow " Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Andrey Vesnovaty 2020-10-08 22:30 ` Ajit Khaparde 2020-10-14 11:47 ` Andrey Vesnovaty 2020-10-12 14:19 ` Andrew Rybchenko 2020-10-13 20:06 ` Andrey Vesnovaty 2020-10-14 6:49 ` Andrew Rybchenko 2020-10-14 7:22 ` Thomas Monjalon 2020-10-14 11:43 ` Andrey Vesnovaty 2020-10-14 11:42 ` Andrey Vesnovaty 2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action Andrey Vesnovaty 2020-10-08 23:54 ` Ajit Khaparde 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 0/2] RTE flow " Andrey Vesnovaty 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API Andrey Vesnovaty 2020-10-14 11:44 ` Andrew Rybchenko 2020-10-14 16:17 ` Ferruh Yigit 2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action Andrey Vesnovaty
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MWHPR1201MB2525818A9D3BEDDD0AAEB7BDDB0B0@MWHPR1201MB2525.namprd12.prod.outlook.com \ --to=andreyv@nvidia.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrey.vesnovaty@gmail.com \ --cc=arybchenko@solarflare.com \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jer@marvell.com \ --cc=jerinjacobk@gmail.com \ --cc=mdr@ashroe.eu \ --cc=nhorman@tuxdriver.com \ --cc=orika@nvidia.com \ --cc=samik.gupta@broadcom.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git