From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45ED7A09E0; Fri, 13 Nov 2020 15:57:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 28423C87A; Fri, 13 Nov 2020 15:57:27 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id F2B9B1E2B; Fri, 13 Nov 2020 15:57:23 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 13 Nov 2020 22:57:21 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Nov 2020 14:57:21 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 13 Nov 2020 14:57:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CeFw9QvxJ3lLPmfhRFtSm/ElxaqKmMlekyuKYIAqizn3zzj0VJCPgdViKxy38kh1q0o5Y526gn2wOlLcUKKp0v7RBWDTJ5NWnjFnHFAtI7IONv/VdSVmC6DI12mS2BxiTNhPG8qtJb7BvUeerU7LPuA+DIflCV269gwnx6YXglV1rQvWSTpqiM2Xaq0697o4FxUSHek4JGPpr5CpGAVHS0eATou8oUMwkX7pWhQYlUP19k++uz9shtgwMuUIfgmNwmJH9l+Rm4CEoXOwi4W4C68PSWIVrXy7t4JDduNxiPXkw7Bo+NX7zY4GIiEkXhPDDr2+/zvZg5fvoCZq4BsHsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h/PSBNIa8Q4m/TTsMmh9FKVMW5YbOKSGdCyMI6PGbGk=; b=MbQTf612etNWnsQA22JKIIrZ9KwnmXZ3tNSXvXBmhv3Xwfboi52kjqrBjjgTZ8ipGai9lsCvkcF332yLoHaM+PlxTBLvJWw9C17oCEVK3KWc3FKLTAj/D98w51XkwVJvYeV3ulw6277AyJUVruR8pVvP73vlMYmi8lOBkSMf/+1R2ZNe3N9hBBSdEvGU7UsQf7Mah2FAgzb5nv6B49KEMrs+bAVnLY10nXukILW0BCY7NphCuTlDZOMB1RX95LQCyrTPP65W6G+ami+zCYXOgoq3EK0B5i9sopbuiabguoehMy77TTh5aE/PvQ++piTehCyG11tkTOhbBJv/sq1U9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1757.namprd12.prod.outlook.com (2603:10b6:300:111::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.23; Fri, 13 Nov 2020 14:57:19 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 14:57:19 +0000 From: Slava Ovsiienko To: "Xueming(Steven) Li" , Matan Azrad CC: "dev@dpdk.org" , "Xueming(Steven) Li" , Asaf Penso , Bing Zhao , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix unix socket server file name Thread-Index: AQHWsbtdV+rH2r5R1k6C4tNJwiXLw6nGNtsw Date: Fri, 13 Nov 2020 14:57:18 +0000 Message-ID: References: <1604392123-8397-1-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1604392123-8397-1-git-send-email-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9d06cb1-7728-4160-0fe7-08d887e46b0e x-ms-traffictypediagnostic: MWHPR12MB1757: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:353; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xDtk+Y5ngaxXoGDDLlq4+DF+CpOZynXaBji0hqpQeFg1j2sT23TwGSO0+Snr1+WaW8ZA4uADH0nYyyHHksRMGF2R649qkqDMI34WWJO42G5+DbNhpWyIDCmUUSZo/R1Lqashrg+5ePV4eVboe2OGTXGtdlTrzfCcmZ4uP6QLPsUXkliDubmZKcORu/uvwJZiLZWFmLeVTaQoLSwkxXcCrFwXEQstLQQogIY6ZKfZdv9ni3DuLeZhydG/thnC+uQjOh7/nwKtra26H6mzi1u4+oHf8MoqYTVo5DcI22cZ/+Vhn0uvE6R8GN+Im2ZK+rTgRHdanrN62Q/sUKwMeXG7wg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(366004)(346002)(396003)(8936002)(5660300002)(26005)(2906002)(7696005)(9686003)(86362001)(33656002)(55016002)(478600001)(53546011)(64756008)(186003)(66476007)(71200400001)(6636002)(110136005)(52536014)(450100002)(54906003)(76116006)(8676002)(66446008)(83380400001)(66946007)(66556008)(316002)(4326008)(6506007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: EQmI62zwBtyKF9xmKZSGfB77xg7x/Gd7/fOW/Tt1ArCuJ98tYrdLvFvLO+tzeg6hEAwxuANa1cZ4KdzJaz0o4tosyABGntOQwB0qg1Y12C1p5NOAFyvOeN3zqeMkyjp3iLbZweITBgtSBgKz6L/DH6EXUOqxrX8tHMKislXYR5fUZFVpOYLauJRJd1qaNNzQWPElR5Jmpz4LQPMUP5PIWfVf4VlvTd1GZ6TieDc2JEq5bW4rDRWy7P6sDrwefd1QXnKGFuAlVXnBO8E+cSIqaiLsTO3yx1WvpZTPdhedk4SCONlj0OkxZUtKf5Olg0CeIwnIa0hh2r5vkqYInuuLM+X9tRt6HSWHfFH9GR+wziCoLMeSzrQ3NbLQjVg+1ytNzOHM4Z8m7nO3leqGOBUG/ivVc1HSHBdQbqklNi8yJGTXu4zS63ClCAU2Fv5IRDU4dkNKJ4W9+zCyk0LTnTqOaeSr4K0EeD1NI/jWEl1C7eQGD8pylglTJ11droSydcmkWNRWuy+L8teCbRFC4dZb9DQncxVbBM9tkq8UaI4mrFL30zlfcpoKRNRjJLRkVHK700R7mlkxmu+yKSLdozK7p0rBQ/UVfbFioEUc6Ari93g+Ys207AXRVnfpUqa9n/WIHhTOLAiM1QoDAMhWHvS/dw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9d06cb1-7728-4160-0fe7-08d887e46b0e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 14:57:18.9352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gkEbuk5+6WMHuTs7uXr/Awv9wCjmbVWleg4LJPjnNpMZfFUWl2TP41Sh8IcEzEcXQlBR4IAEjWGaGJPrbtdXnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1757 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605279441; bh=h/PSBNIa8Q4m/TTsMmh9FKVMW5YbOKSGdCyMI6PGbGk=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=N2Pqh6BeGE344VCISsuW5BOXEYu44VFe6Ir4yYwUcmJPw39y/eG2eN28cxQVwLLoZ GA6Bgnd9iKURHzKI6UK97Pu9l6DuBI/fkShROrBrIqD2zst5xsiI1XUdQGyLN1bO0L mmdBvrg+P6IcDrTUVwCPQSBkmjoonoYkWUAZy4U4uKMOR3zL1THANLGngh/3TFQEQ6 ZJ7QO64DXdIhtnaTFzbfcfeR4uusyWWPkULj09owyJNJ5VXcRTEVzhc+wiT1dKGwJJ /ifnX4a/iezdxHrrrb0Ig/9cyoZBkLgbkLvv4TXTd3cXEevoWY4LmGzvwOFEkvGTZ3 6skPwZT4WM78Q== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix unix socket server file name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xueming Li > Sent: Tuesday, November 3, 2020 10:29 > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Bing Zhao ; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix unix socket server file name >=20 > mlx_steering_dump_parser.py tool failed to dump flow due to socket file n= ame > changed. >=20 > Change socket file name back to make it consistent. >=20 > Fixes: b1e15224849b ("common/mlx5: fix PCI driver name") > Cc: bingz@nvidia.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/linux/mlx5_socket.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-) >=20 > diff --git a/drivers/net/mlx5/linux/mlx5_socket.c > b/drivers/net/mlx5/linux/mlx5_socket.c > index 08af905126..1938453980 100644 > --- a/drivers/net/mlx5/linux/mlx5_socket.c > +++ b/drivers/net/mlx5/linux/mlx5_socket.c > @@ -20,16 +20,11 @@ >=20 > /* PMD socket service for tools. */ >=20 > +#define MLX5_SOCKET_PATH "/var/tmp/dpdk_net_mlx5_%d" > + > int server_socket; /* Unix socket for primary process. */ struct > rte_intr_handle server_intr_handle; /* Interrupt handler. */ >=20 > -static void > -mlx5_pmd_make_path(struct sockaddr_un *addr, int pid) -{ > - snprintf(addr->sun_path, sizeof(addr->sun_path), > "/var/tmp/dpdk_%s_%d", > - MLX5_DRIVER_NAME, pid); > -} > - > /** > * Handle server pmd socket interrupts. > */ > @@ -186,7 +181,8 @@ mlx5_pmd_socket_init(void) > ret =3D fcntl(server_socket, F_SETFL, flags | O_NONBLOCK); > if (ret < 0) > goto error; > - mlx5_pmd_make_path(&sun, getpid()); > + snprintf(sun.sun_path, sizeof(sun.sun_path), MLX5_SOCKET_PATH, > + getpid()); > remove(sun.sun_path); > ret =3D bind(server_socket, (const struct sockaddr *)&sun, sizeof(sun))= ; > if (ret < 0) { > @@ -225,6 +221,6 @@ RTE_FINI(mlx5_pmd_socket_uninit) > mlx5_pmd_interrupt_handler_uninstall(); > claim_zero(close(server_socket)); > server_socket =3D 0; > - MKSTR(path, "/var/tmp/dpdk_%s_%d", MLX5_DRIVER_NAME, > getpid()); > + MKSTR(path, MLX5_SOCKET_PATH, getpid()); > claim_zero(remove(path)); > } > -- > 2.25.1