From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B9B4A04DD; Mon, 16 Nov 2020 21:03:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6724C2C16; Mon, 16 Nov 2020 21:03:17 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by dpdk.org (Postfix) with ESMTP id 7096E2BAB for ; Mon, 16 Nov 2020 21:03:15 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 16 Nov 2020 12:03:23 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 16 Nov 2020 20:03:13 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 16 Nov 2020 20:03:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHWw+7tQJQ/xuS5blchI8uiHWv3wYsay1prTkVnGSUKG5SdEyJLEaCKk/T5W3MBZ+2KQ3YIFKZpdJXwWELa/n8ElDbkDlPMhhpU8G43kdWMMKDvJBsYkzroygvSyBcZhaksS5J/3oZgpa7XetXnb+xlTVsh1UKhYmefjKoAJ26Sk6WmXANT42t0YK86ZgiGvtPPjeCsFI7aWJcG75jgroLmd2127wxOzrVY4L0euA4JdWMTS/euv/8wSUfGwhDGuKTObcGgVbO2Kq98cb660wuOiUgLPAjGRCrAiq+/xhFHWvyiGQtSUBCOeakf2cJkZUQq3tB9cPGlHA4Xr8sgdKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gVuQE+KdQk4fwG7QyAiQl+sgRoGgZL2UgmogHwqLDTk=; b=SEfgbobl1pyOALmJUVgiCccjHZBpaqm/VFGnKyh3f2vPdJXfwaEma4pmwStdtfrGan38x5YIsMeUJrlq9+KHEWsLijz0ttWsEMCy42D9fFh8i8i7gvQsqy063kq2EevbGHSK+m3BQJSWyQT3NP220pwC04bHbV+l9kaOYcfVTr1VQS5HxZAdhqBzsWljnoBYFOIe3VDe7VnLgFBgqfiWczZOTKus3gvQgHPhqydeFqT7vxJaZ509grEes2QPr+wLE7tlri2xBC9V8IqWLf2iQ16fvixUiTi03/XUQUy02z/YcmcLyd1QIQdAgb8htK+SaqMYDLHQW7ytslP4zDiSLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MW3PR12MB4553.namprd12.prod.outlook.com (2603:10b6:303:2c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.28; Mon, 16 Nov 2020 20:03:12 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3564.028; Mon, 16 Nov 2020 20:03:12 +0000 From: Slava Ovsiienko To: Maxime Leroy , Matan Azrad , Shahaf Shuler , Olivier Matz CC: "dev@dpdk.org" , Didier Pallard Thread-Topic: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value Thread-Index: AQHWvDqEW7SIqvigmEOSwBt1XIPV/KnLLPRg Date: Mon, 16 Nov 2020 20:03:12 +0000 Message-ID: References: <20201116170258.18583-1-maxime.leroy@6wind.com> <20201116170258.18583-3-maxime.leroy@6wind.com> In-Reply-To: <20201116170258.18583-3-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 61192971-91ed-4e6e-26f3-08d88a6aa5bf x-ms-traffictypediagnostic: MW3PR12MB4553: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Iqudd9zQqPdQ9Gn0p0nmkQOK5EQkWbuJe+B9pi7U8S6jrBFPkkzwt1IQ9ryUb4ImZAI3i5JnBIe15q1Zg1WX7Qhl1RGmV716C8J45qJyfqmgvSzWel34yoXHiDnFQ54t4egnAdYD9R/lkX518O9LSeUxXK3PV8bhmfjgUoykAZqWuaqe0ln0IFjle0KPaPei6bUXtjjAbAbIPvo+vQYXjO/BKkXXz7/ilQia1Qe7vWR8uycySOTg4DTm/fMcqkl3ayAiuz3zyjMi+f4txJpgwrTbYOMz7alt2IybZJmngnWr0PmOAsGVJcNhaxPKNBYX8z9YVrp2ZO7di6amXjPGTg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(346002)(366004)(376002)(396003)(52536014)(83380400001)(86362001)(55016002)(8676002)(7696005)(9686003)(5660300002)(6506007)(53546011)(316002)(54906003)(110136005)(186003)(26005)(64756008)(66476007)(66556008)(71200400001)(66946007)(76116006)(2906002)(66446008)(478600001)(4326008)(33656002)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MNFehvqeuzAFinrSKa928LaLjcEgdCZbcAqljz4qSYq3R7cj/BsIr5YNpUTEUf9iBYws5s1uK1hFEarGEKjOVH2lXB7UHle9NjhA79JZtc/KfI4VoFoOOe3me2lfxjz6Ocgw61UcWZEObcY+L4tm+woPsWZS+CIznr7Z9W2wFRkENo/B0+M9UHu6VVHZhNgbivjJayzzKH168dq/SyCwvFfGGk7UILrPybvWBHX+QjpYRcpJqzMlwSj8JHoFcLvuwggE+h8Mq3oYv1VQijHBFZYPQbCZOFPMJkFLvFp3B/zgzcci4HKv0YpRqDP5v/huDMYvGxKpzTCgEJamdSQQuvJbbJ2be/FDzkc5CAPruxqq3MVHwRVJhyuPQQFovFxpG5/vvBMxWXE6WL1YwAiW9SWlG55i3UDdSwNHbEAd0IK6kpbRVcfSd2gWYkZ8UvwxNlJ1ToPrt/B04EpbRinU/eLTmtD2+LbMRJ4kMdRAp5p7PfV8ludHIiDfhHIhhUdrUUnaQOpzEtCj52Xh7GtWhLdBRQWOWLgI0LMn5iNym1Ms/IMzPayumHBZB84LXEODvMyvli37O6IdLJ0xjx99UQQPf2qF602d9G+lo4e00+U1AdK/AM08qmdq1HMAqkA1gaeaSuVCKH9PGTrqgJEc1g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 61192971-91ed-4e6e-26f3-08d88a6aa5bf X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2020 20:03:12.3010 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4xtPspykWiPAIkkpSCkHbxGqX6fX/bV+OsU1zvwQ3XEpPx+9B84vhMsBnV+DO6/BAAi/wjvQykFtVjDoyvl0lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4553 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605557003; bh=gVuQE+KdQk4fwG7QyAiQl+sgRoGgZL2UgmogHwqLDTk=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=kwLE3szaPaK+5Dt1/rSl3HWWZwTThHQUOVceZDxTbbrQsW2L6IRyFq4zNcp1X2o74 qggzxKIqCK5u8YA05e67fPtJOm4SGLOSF0MlB8Q2Tx3PU56KC6kWhrFDsn7211wy90 vVVCxmqeNa0sd4KfP9BKySCeAca/8yDn/7SqZkKEo4DIA6HDJwgNTt/+Zzj3gNoVyA 8C4ewYR4Q6zzTRplTnAD1pp0mzIs2WIrQQmj4Z4V0J1yzc+zT3m/WtMrbpUwdeHl3D RPdJTVJnemLUVfcqa5RK38k3/bJ/Wp9O6/gbr38rAYOiiyxvnEBvK6vtPElbV9GzF9 R5yr48D4SVTQg== Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Maxime It seems there are some typos (see below). Beside these ones - ACKed. > -----Original Message----- > From: Maxime Leroy > Sent: Monday, November 16, 2020 19:03 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Olivier Matz > > Cc: dev@dpdk.org; Didier Pallard > Subject: [PATCH v3 2/2] net/mlx5: fix Rx descriptor status returned value >=20 > From: Didier Pallard >=20 > Three bugs in rx_queue_count function: > - One entry may contain several segments, so 'used' must be multiplied > by number of segments per entry to properly reflect the queue usage. > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in non mqrt > mode. The range returned by rx_queue_count should be the number of Should it be "bullet number 3" ? > entries used in queue, so it ranges from 0 to max number of entries > in queue, not this number minus one. WARNING:TYPO_SPELLING: 'acount' may be misspelled - perhaps 'account'? Should it be - "to take into account?" Should it be "MPRQ" ? > - For MQRT mode, we need to take acount of the number of strd. >=20 > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > Signed-off-by: Didier Pallard > Signed-off-by: Maxime Leroy Acked-by: Viacheslav Ovsiienko