From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA8BBA09D9; Wed, 11 Nov 2020 20:51:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60A3E4C90; Wed, 11 Nov 2020 20:51:56 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 4A450493D for ; Wed, 11 Nov 2020 20:51:55 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.9]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 12 Nov 2020 03:51:52 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 11 Nov 2020 19:51:52 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 11 Nov 2020 19:51:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nj/9fjp1hmIvLgUwT0K5qF7sviK3wrsgefVUuj1coSsBC4/eL1HOUI5oSkHLVjb725SB/rc7NexklfngPlCntjh4YuutTkaYA+pWf4TbLXKukxe0iOwvtDbp73YzgOaIIIqgX0ttvNyV94s3uhlr54+ZeJghe0HGqXEldrO6t1sfdX+D3M9M5K49RUbOTj0zGEUIuQlvmsn1VqCEZtclWjmcnWjrWF5Oqkisur6JjwY7oLBhgQICtgZnbmql0DqlzVCPDFDaYP3i28pNYj0qYAL5XYgvA570r/GSQl45PCT3PINUveueO8PnvaThKTZnI5SmyNpVPZw+viiVuAufSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=88b6r8+WjuL68EKXTPb4fOb2baM4opWs3yK4b3GuT2o=; b=VSBtm8LM1r3Bm/EfRGvq6CuqIt0Muxi9sJrUjvJ34ZlQmvCzaDL3gcpEXJOvqC4KhXTVALwYcJAs7KkTX4POUA3ZBRwHXzRMkyePm1qYVYoQ4DMQLi7ncSV4XcEYEDI+ETxzJf+0kODuCp34r6TnUBbkv3YCRLez0xwITI7NyS6cVE8/sFsbgb9FfsNh6jfs9GTDOhQRmEn+lwUW1CsVLRAkpupEEWtUfOAsBqWQZ7bn8e6Eltm/REAfRFKFnLfUCGDiuzixxfPZ2pNeA90tx6BhdFbWEgBaOZQ/1e64ykiUa3rYCsBCi87hLT9iRUGBOpUjGfRPgqAQTYN6aitT3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MW3PR12MB4379.namprd12.prod.outlook.com (2603:10b6:303:5e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 19:51:49 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3541.025; Wed, 11 Nov 2020 19:51:49 +0000 From: Slava Ovsiienko To: Maxime Leroy , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , NBU-Contact-N?lio Laranjeiro Thread-Topic: [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation" Thread-Index: AQHWt2s1sT0yNjD/ZUudgUGw7QuhOqnDVIWg Date: Wed, 11 Nov 2020 19:51:49 +0000 Message-ID: References: <20201110140938.15046-1-maxime.leroy@6wind.com> <20201110140938.15046-2-maxime.leroy@6wind.com> In-Reply-To: <20201110140938.15046-2-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bcba1d83-0409-473c-4d0a-08d8867b3a97 x-ms-traffictypediagnostic: MW3PR12MB4379: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tqrp/r9csHwpeQArx+HIoc1lkFBXJPM1dooo2q3i85C1cjXmqekmWZkYoVMXs3Zltw6b43Ey3J52/G/o92f3gG2E6Eiwkq7dHEJ4FJOB7iXqN8n1BcZxnFxmE0KJraxm48k76wLtzX1cAMTUCeBg1LcLnvfta9DfpZLywrCvftHcNUcGdPKUJhNB7fxOexMQipQBR2xtTWdK33kw+chhPXAyypvfP0M4ostBkLlqOstMoqNRq4w2sP54YqV75mTtQtgwRq4gpRjImPL4giLll0M71Yx3wmUA9hP4JMKipER4fmIfSrCyhjM3v39SuYUQ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(83380400001)(2906002)(478600001)(316002)(9686003)(26005)(186003)(4326008)(55016002)(6506007)(8676002)(7696005)(66446008)(64756008)(66946007)(66476007)(8936002)(76116006)(33656002)(66556008)(6636002)(71200400001)(5660300002)(110136005)(52536014)(86362001)(54906003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: rm/qgk/pgE/oVWUeGpFncBsPVfRE1TT7bwCIc5S97I7N7o3gszsVyxHJNsboRq6Lov2C+P6eRmOHR7AiMAZFGa9sADQ60XTVWoVlEjCyVUnWHd4pLrI3SsRvQsSOZkyy8BKZPn9Epehv33dMVVhmAgispOvFbsMrBPHCVxyevJjnXxN3alswnFICCMoqR57JMvGyu0dCf+tNSchu++jD8Eok5gs8PXRVdsApicmFksQD+Ela654MB4sw6ynB/g2U5g7N0YHgp13ZqvUbtePCORchFq9PDrlq1vpfNNjzBClExWuCdh36j1Vh+57f+QSGOAYjDMAbPNI+5ihzQ1WUv/OcSnM1dJTMLmF1Sl8w6IhiSFGOt7rrsqUkSGsFtjW6rHCG3nMSgy7laKlYsYUMTNtmW5gGXk8m457ERdFcxtvoRmM3/55s0MoXhP1VMqsYDvlYu2qztwrjpjypbJl7ZYcNpHzGgL19NMvhFGJUu079qptLv/efKFAAQw2+z3tt26JtvpMJMlUbMsDAUhvEJuSYrlJkOcWVW3x9Huf6gm0LSsdEN/l+lkLMsa1Q9UKITKaVM2LMPiQ2w3x7qT/PUoQsMrtQmkPI/fQjVQK7PMmpXo5eqEhpKqI1ujBJaiV82XNi+nOnwKMOmzrL5jO0oQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcba1d83-0409-473c-4d0a-08d8867b3a97 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 19:51:49.4079 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EZIS+doq5uxReTincfx+cCNSqn1si6hFQj4gluBfWd+JtkeqVR0J7cFgHJ0xijZTJXXurPu+MDu/jmq3bcp25g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR12MB4379 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605124312; bh=88b6r8+WjuL68EKXTPb4fOb2baM4opWs3yK4b3GuT2o=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=L04xLrylmRbj/9cQgnpc/rbGTR0Ptw80t00ZeX3sVF4fva5ri2tw1meLE0Ko1bOSF wVFH4T2lI2FXzLDJkzR/nsZBT/do7e/ERDxJ8aNKDvuA9AUEeEzud4dyPFYhpJpCyl WpyzaTIZFg+tzA8mrg+VREOSZ7a0tjOxgh4cNa7tATxTkPzCFBR5OmuViUM/2lJVWo wXjz8Z2oH4ahy/ku6G+441/gxr4Qp65PKxhSDIHYDmzT9SxKl5hqZkK0FMCfQQnG2R oeSr93EaR36RX+BWYKKh4r3/2FzxP2ej9wyWiLIxKL5/BttTuP0poL+y79n1PEG1HM Rph0Fuc0UZTaA== Subject: Re: [dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Maxime Thanks a lot for the patch. There is the comment for the entire series. [1]_____ >=20 > First issue, when there are more than 8 CQEs to uncompress, the computati= on > done in this commit cannot work. Because the zip-ai variable describes th= e > current index inside the CQE8 array and thus is limited from 0 to 7 inclu= ded. So > if we are decompressed the 9 packets, ai is 0. So in this case, n is equa= ls to > cqe_cnt - 0. >=20 > Example with 11 packets we will have: > C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0 >=20 1. ai is not index in the array (just tree lsbs of ai). It is an index of t= he miniCQE being processed in the compressed session and is in the range [0 . .zip.cqe_cnt-1]. In your= example there will be two compressed sessions. The bug was we corrected each compressed session f= or the ai of the first one (in processing that we were). [2]_____ > /* if we are processing a compressed cqe */ > if (zip->ai) { >- used =3D zip->cqe_cnt - zip->ca; > cq_ci =3D zip->cq_ci; >+ cq_end =3D cq_ci + zip->cqe_cnt; >+ cq_cur =3D zip->ca + zip->ai; >+ used =3D cq_end - cq_cur; > } else { > used =3D 0; > cq_ci =3D rxq->cq_ci; Sorry, it seems to be incorrect. zip->cq_ci is the index of the NEXT CQE, following the compressed session b= eing processed. zip->ai is index of miniCQE being processed. "used" should be calculated mu= ch simple: used =3D zip->cqe_cnt - zip->ai [3]_____ - if (dev->rx_pkt_burst =3D=3D NULL || - dev->rx_pkt_burst =3D=3D removed_rx_burst) { + if (dev->rx_pkt_burst !=3D mlx5_rx_burst) { In this way, we cut the support for other rx_burst routines, we should rest= ore. [4]______ I'am OK with Didier patch "net/mlx5: fix Rx descriptor status returned valu= e" I see you wrote the luxury commit messages, and I'm crying with bloody tear= s about what I'm going to ask you for - could we squash the series in to single commit? Or at least two - Didier an= d yours?=20 With best regards, Slava =20