From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD39DA0521; Tue, 3 Nov 2020 07:56:14 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5527FC30D; Tue, 3 Nov 2020 07:56:10 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id B3432BE9F; Tue, 3 Nov 2020 07:56:06 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 03 Nov 2020 14:56:05 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 3 Nov 2020 06:56:05 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 3 Nov 2020 06:56:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K4faqxJt6kKCFuCUSn7hlNe0JW5GoeeM6OtutL18d/y6X8+r6EDu+n4U8dLx0rT+OiSvntMBSxnIVmgfZjJkeqLCB7RlpdktjRwBOtbJ2BlnC5hw/yFp23942XbKxD+B42bZ7MrON5JPI2eYfpq8vdRwlyZcuqPMUCJLVoJu6GJ1rvO407g2CJLxwANrzbe3c2xi4ZEfyVfmej2flC1LcgiAOF3baccrXaa7RhtSQ1cBBtfivETlnV4L3UKB5BWZgh3nLfuWJeGLFTOx4RCL76NbD3HaD1nMU/Go4c7LNXoF8JebD72tQbxxkNHp2ie2UkxOjdq7v7UAGcFWRTzKeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dELKWt+BSusxQzbpAEd31nRk44Bkx6HZVQSj389y+jU=; b=lvCHMmIovRJz/7+zqVxgkK0+Hq6V0hnMjsGdBNelaZJnE9Y1mTBFPEnfMaL5D7gMwvfS01HdUVyQM+ZTlzLaQcFLKww+HTsfGjWCX9OI9Sq6sOQQj6F9s1tZGr28QF0HVvJk3uhYwXV+XZMl0tPVoWUgEy3kw5y6YXQGpjiN3Sjo0Is5AMen2UHdZhr5XAj0iVgTZIZ1cXqEyWhm3Um9uU9C+a3kHTuThEUuoNq0W48NevPODKCvV7MMUVw6csDrXQCMVmC4xCDmLJQaL4kNAnpupGwMCc1SMhum/psBi067iS5oyYhFfv+frN6tBwEthkqkvYjR+1ftnjVdB/HIGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1630.namprd12.prod.outlook.com (2603:10b6:301:c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 06:56:02 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 06:56:02 +0000 From: Slava Ovsiienko To: Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix Tx queue stop state Thread-Index: AQHWsa10LBPaqD4NNkC/OgbEourqKKm1+WGw Date: Tue, 3 Nov 2020 06:56:02 +0000 Message-ID: References: <1604386112-342335-1-git-send-email-matan@nvidia.com> In-Reply-To: <1604386112-342335-1-git-send-email-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1ceeab61-0dbc-4f42-924c-08d87fc58724 x-ms-traffictypediagnostic: MWHPR12MB1630: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: luSPeBCbzaC20BKGkeePVmGXU5P4MSGvTqZ/44Z7M6TbyhfzVZNfPUh1f7PZNTnV1/H2iGufchciFzDj73sIO4ey3Givp9YR/nUar76VzVGkh2RPcABiMONEIo9pB/91/OzbpLDtx5Xz3B0p/NC0Un5fVF1IUeKhamydqQ191YSXI86iv47RI8S3sG32n+gjO4cjXnSb+ibpx6uBGYgPB3n4ffJtl1Roux4luD5oxbizLpZC45H8qoi9d25iUhKDvrkovLxJXjRsliATvgz/uXigG+iUBJF79eA/ze/jQzsdEvr9kbsj/1TiBcIQG3Ammv85yYAIWKVBDWqzJbyNxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(478600001)(66446008)(186003)(7696005)(26005)(8676002)(86362001)(66556008)(9686003)(64756008)(33656002)(4326008)(2906002)(8936002)(450100002)(6636002)(55016002)(52536014)(53546011)(66476007)(6506007)(76116006)(71200400001)(54906003)(6862004)(83380400001)(5660300002)(66946007)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 7L4KeWXfjv1KyeYNGpMeA786EceF6YVQLwDZ/HWkKfzyxw5+RW84HsXUHfbWMhuA2UchDVZPIpkosCi1AxmayFakZWUW7hIQmg7cbcEIePShRK7kNeK7tXUK3viHUF6H9Ob/doUqWiaan4X6JJBXnkm5HyIVTFB0Thjqda8q9VRtn57dgsuKnFexs+1Ap4eq2gJ6AFXBSfGAA+vJl7gxvflXbsk8Qg0K+zKw/5AQCLFYr1D+gxueraI7CcxQNhK4lBTbq80WLirzTycBUvK/M2zys2MVqxECXk0tY4HCe6NkHsI4qFUydJLKcowfcUcx27yzBHVyjglAPJU3iBeUwCpZNsIE5a8bHj+tX6oJxcONnL7RJ6asjdEKHDR2T6L++6DXregQxGS+y84FwNVq90Z7FnutuZOw7ShWBUxDsODnAEfyUUfK2szMzthf4V2BeZm7WRZSCJGm+iIvz5k8Buujo5lbaHKF5ytjuuPVEMuf7Pmy6xiWZD4bkiybbvtDIuR9eRzLGYO/rEWo7jMr8Bfger3FtniFBr1UWqNFHd+LigOGkDNeRXkkrpyeJgI9xymrQ3SOdxkMHv8LzTtx+3zH7ks0kvZPWYOKkIaF77ZMDUXaS2CwaX6X5B72Gnkzy7TmpdeIqYqK8b29NHtHUA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ceeab61-0dbc-4f42-924c-08d87fc58724 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 06:56:02.3481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XXWV8ocCV0NPuw5w/ZQ2fRXjem5ZNB+mRL/Vz6mKjGbACMy+brISuL5jAFRQ88YMP7JFaYiOg9ll8E4S/dHlDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1630 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604386565; bh=dELKWt+BSusxQzbpAEd31nRk44Bkx6HZVQSj389y+jU=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=cQNuqn2GTNIH32Mt2fH4yib7CUb5ROw/QPhDwpr75nSAcnsg+/VghfpDYhk2DTwUp fCZuubUdrnqjVkr6QjCM2DstT2tGbXbBRlZ1Gj56s0nKMTH5S8ygzrVTnAGGwkzb8w 91xsZIcDNig2N0vtFQ6t+SxcL1I9TWJ4OpExEE8GJlVd6NmMsU5SCIyEP6nOH3D5q4 iZW78hRrmN7Oz0AWOTD8BU3z+76AKSlol7FGplGPS2SwovrbhbCt5s8i5c30V4tBOT B2XLbRtpZiplgbUP5CqyCs1qKAv3sb+YhgiBTI3+V8MWejU3hHIjVe8I8WoGhC8kLq FN/QmNsMXT2kg== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Matan Azrad > Sent: Tuesday, November 3, 2020 8:49 > To: Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [PATCH] net/mlx5: fix Tx queue stop state >=20 > The Tx queue stop API doesn't call the PMD callback when the state of the > queue is stopped. > The drivers should update the state to be stopped when the queue stop > callback is done successfully or when the port is stopped. > The drivers should update the state to be started when the queue start > callback is done successfully or when the port is started. >=20 > The driver wrongly didn't update the state to be started when the port st= art > callback was done what remained the state as stopped. > Following call to a queue stop API was not completed by ethdev layer beca= use > the state is already stopped. >=20 > Move the state update from the Tx queue setup to the port start callback. >=20 > Fixes: 161d103b231c ("net/mlx5: add queue start and stop") > Cc: stable@dpdk.org >=20 > Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko