From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F2DEA0521; Tue, 3 Nov 2020 07:55:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D8628BE6F; Tue, 3 Nov 2020 07:55:56 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 0420BBE5D for ; Tue, 3 Nov 2020 07:55:53 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 02 Nov 2020 22:55:55 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 3 Nov 2020 06:55:52 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.50) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 3 Nov 2020 06:55:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ig6hg7kFLsEELvqytVMGDpf3I+dGPI+ZkBK6Z4aptYZBZFYVtBirxpi5lv8qxCHHd1fuuzi0iYExnlbp+Cf9+y7Dids5KpFwXJ/3rJB72wZ63daOJjvfIZubct9biL2im4Og3L1I4FjU8tHRVj1wyGVtfRqFkyGYIjGS7SNTSMxmVSM0TXqSu2OtqS+iX8cjnjFH/W5K8tmylxbPskPxpCEt9LHwxBUAeq3frxQAYCGRMwRYgY0R3I0L5efUsu3VJ9wIOQtAm0adfTzrUSkjcdEaqUFknVTiSasqsvCCFh9Xd5fZtvc9k19AF+gXqdg8MJmjXu+PxfO+PM74tbcIXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=//9Tizg7ngYpYK3dfnQkJO5s+zUoXLsbrAUZcnp12XM=; b=j9cw0TLATOUqPWJpX+Zx0XJ6GMeNyf6d9aY1sbZHpRdP2FMREmQ9p0X+FRVnD8Y2B+75vNMT/jBFFEKm5Qe6+kA/aE5vc8CoHnOrrVIp8znYNT4nlAWfceQapXsMv+QcxD+8w+aZxDYS3CZhkHGV1VzSmlBuyb05iaXpDDpHn4lxOSXnzfY91BVitb1St0RKeNIFdk9by8dXSzC92PN+hKyaF03LD11ilMCJ8ShKSw+Oyye6rk1mryyWOWAYYCdYZbRvhMpy3WCLAkjoemfPC98hrR+9Gx/daOwPghyKzX2P7xDD1FiZjytzcKvUdNWIf2t7jJ/tNrCARLSsdWHSiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1630.namprd12.prod.outlook.com (2603:10b6:301:c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 3 Nov 2020 06:55:48 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3499.030; Tue, 3 Nov 2020 06:55:47 +0000 From: Slava Ovsiienko To: Matan Azrad CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix atomic API update Thread-Index: AQHWsa1aVaeD56Qw8kuPJIANgan8KKm1+TgA Date: Tue, 3 Nov 2020 06:55:47 +0000 Message-ID: References: <1604386064-342267-1-git-send-email-matan@nvidia.com> In-Reply-To: <1604386064-342267-1-git-send-email-matan@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3b2e5eb-e1de-4b0a-aae2-08d87fc57e70 x-ms-traffictypediagnostic: MWHPR12MB1630: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +KgAqG8svwK0c9p6MkTjdYkywAJM2/ibDzqcslGg9dGo02vOqgfKfh4P9GK6T/ZDzsilgh9BzqO6JokVhTSx/bZTP7FnqFqkU8zcLlXZUW+Z0H5rzagG6JnVt9PzwBHVrS5eGkh4BXhtYT5z1zUglsv0kTEiLWxOW5Pj4EHO9X7LUw3ZJrCVgCa7LgA1DaZUVS/ALIcNd7U1qGFpqrKJlbOEeA8l2/dHjd2Ckmg4jpCrCxrGmjpwrQr+Q0pYN03oom8MCqENFSdDBSL7aOKv7SWB+Tq/NUcNB01avP5DOyX1BVCZAbLI5uYqHECReQh2 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(366004)(136003)(346002)(396003)(478600001)(66446008)(186003)(7696005)(26005)(8676002)(4744005)(86362001)(66556008)(9686003)(64756008)(33656002)(4326008)(2906002)(8936002)(6636002)(55016002)(15650500001)(52536014)(53546011)(66476007)(6506007)(76116006)(71200400001)(6862004)(83380400001)(5660300002)(66946007)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DcWTD2TQTP/GTgP9qs5xzRtF8fI6e4RgFEqE/+LbGG5ZElSGVRogAmvfeDos2tfoQxvvyNQUf0VXspbsL1SPrfqI8j9gu2VlupqQLnS9By1l6afwqsCd00xteihrl6flIqRA3FShouxFkOFKsxOIkFoPaCrtMAOmpYGkQCpgMS/tGmNarsABN+NvI5Td7UXTN3AWyzX6/5Hjy63zsYUrgs+eywoYAmMQHl5ra55OSywqmYKvgU6YMb3U4dWjDMLAEsFMf+qZTP2BBFvv3Zuh8hafSR3281ETM8+A43ByGw8MeiUpXFxK2OfRkyOUQpdeSO5ptwwbVr2vgxyvQqDzlj/bqe/Ve8oZoMUXlsKSkWDel73BoSozjJ/ENL+hupN91s3itgmhClso/IL1UYMHr3iDTh08P2pjzQ+gKGgpHTwjQo1B/gTwYhJOwun7Qx3XhkzuaiJP8wxIvx8unH6sbWcOv2bN97nR2gON1yWE/wlkLUF+X/oPPm53ISS4fJTxOTumslLXXZEI0ZmZtiHHXxduDRpi9RX3B//9vX2PFu+Ea+OTr8hW5dIRYaQIwMZ1GkL9bmglc591zrmBZnzhbVaqeJ/XCdM0Z+wo6JeO1qjE0+rUKQvlRLyEFWYHI8g0WcGuEIqJUNFigYSk/d86Cw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3b2e5eb-e1de-4b0a-aae2-08d87fc57e70 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 06:55:47.7673 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DcV4VEHSMosM4J91egnOiCYVG2mMSnpksVjQ7u5i2+I6LJGJbpD12kaIBIMVJDQHuD1uGRsud5XCy6xzmdOqeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1630 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604386555; bh=//9Tizg7ngYpYK3dfnQkJO5s+zUoXLsbrAUZcnp12XM=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=ZnZ6xBjAy+VcJV6ON/WIH4CAZt+C8gLI0wV7Shq98UE5V5Cv0t1FArlpFkEf38Sbe AQ6j2PsA0MSpJqljzHjb/F4H00xW7S7Xp0AowUY3KErCKnkI54d5mPOvHaVCz9ZN+O wiJvYQP6Kx9nPP6fWbqxMuZ8f00gzX48mJem3XD7oimHrfSDaol9FYp2k6fITJssO+ FZJW0HwjbB6a72dsFxq1r6rA9XA3anoE7Xeyf0hMcmD2BxClwyHkb7/mcfBelYTP5B 2RAY0kbm+SJ1o2+gLVsOk/Rq8zAOIPhQaRb2zdFAVtTO0YFFzWlvwOF5m7wIvjTakS sCki5wK5dCn6A== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Matan Azrad > Sent: Tuesday, November 3, 2020 8:48 > To: Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: fix atomic API update >=20 > The Txq refcnt 1 value means that there is not real reference to the queu= e and > only the control configuration are saved in the struct. >=20 > The patch below wrongly didn't consider it and caused a leak in the Txq o= bject > resource. >=20 > Revert the specific update in the refcnt. >=20 > Fixes: a02d6dd9e61f ("net/mlx5: use C11 atomics for RxQ/TxQ refcounts") >=20 > Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko