* [dpdk-dev] [PATCH] net/mlx5: fix atomic API update
@ 2020-11-03 6:47 Matan Azrad
2020-11-03 6:55 ` Slava Ovsiienko
2020-11-05 17:37 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Matan Azrad @ 2020-11-03 6:47 UTC (permalink / raw)
To: Viacheslav Ovsiienko; +Cc: dev
The Txq refcnt 1 value means that there is not real reference to the
queue and only the control configuration are saved in the struct.
The patch below wrongly didn't consider it and caused a leak in the Txq
object resource.
Revert the specific update in the refcnt.
Fixes: a02d6dd9e61f ("net/mlx5: use C11 atomics for RxQ/TxQ refcounts")
Signed-off-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/mlx5_txq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index 6390cd0..cdd1022 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -1234,7 +1234,7 @@ struct mlx5_txq_ctrl *
if (!(*priv->txqs)[idx])
return 0;
txq_ctrl = container_of((*priv->txqs)[idx], struct mlx5_txq_ctrl, txq);
- if (__atomic_sub_fetch(&txq_ctrl->refcnt, 1, __ATOMIC_RELAXED) != 0)
+ if (__atomic_sub_fetch(&txq_ctrl->refcnt, 1, __ATOMIC_RELAXED) > 1)
return 1;
if (txq_ctrl->obj) {
priv->obj_ops.txq_obj_release(txq_ctrl->obj);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update
2020-11-03 6:47 [dpdk-dev] [PATCH] net/mlx5: fix atomic API update Matan Azrad
@ 2020-11-03 6:55 ` Slava Ovsiienko
2020-11-05 17:37 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2020-11-03 6:55 UTC (permalink / raw)
To: Matan Azrad; +Cc: dev
> -----Original Message-----
> From: Matan Azrad <matan@nvidia.com>
> Sent: Tuesday, November 3, 2020 8:48
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix atomic API update
>
> The Txq refcnt 1 value means that there is not real reference to the queue and
> only the control configuration are saved in the struct.
>
> The patch below wrongly didn't consider it and caused a leak in the Txq object
> resource.
>
> Revert the specific update in the refcnt.
>
> Fixes: a02d6dd9e61f ("net/mlx5: use C11 atomics for RxQ/TxQ refcounts")
>
> Signed-off-by: Matan Azrad <matan@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update
2020-11-03 6:47 [dpdk-dev] [PATCH] net/mlx5: fix atomic API update Matan Azrad
2020-11-03 6:55 ` Slava Ovsiienko
@ 2020-11-05 17:37 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-11-05 17:37 UTC (permalink / raw)
To: Matan Azrad, Slava Ovsiienko; +Cc: dev
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Tuesday, November 3, 2020 8:48 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix atomic API update
>
> The Txq refcnt 1 value means that there is not real reference to the
> queue and only the control configuration are saved in the struct.
>
> The patch below wrongly didn't consider it and caused a leak in the Txq
> object resource.
>
> Revert the specific update in the refcnt.
>
> Fixes: a02d6dd9e61f ("net/mlx5: use C11 atomics for RxQ/TxQ refcounts")
>
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_txq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-05 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03 6:47 [dpdk-dev] [PATCH] net/mlx5: fix atomic API update Matan Azrad
2020-11-03 6:55 ` Slava Ovsiienko
2020-11-05 17:37 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).