From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60002A09E0; Fri, 13 Nov 2020 15:04:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D6A8C8C6; Fri, 13 Nov 2020 15:03:59 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 5FEFE4CA6 for ; Fri, 13 Nov 2020 15:03:57 +0100 (CET) Received: from HKMAIL102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 13 Nov 2020 22:03:55 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 13 Nov 2020 14:03:54 +0000 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.55) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 13 Nov 2020 14:03:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ChGyLMn8YHk3Jr/GEFIsKE8cWnjX/ANtpXcvsAg46RRMvZvW1TnPMNtsogZoFxRUto94kDnUY+ediiIG4dkDfvHYdJ5FrXAw2bl74ssnJ4wDjBudBBtuMl1CNMoQi+GsQmTvfNxBE3faE+52I4AncMm4Dgu3Sp0RCosgVvCrxEYnPWVR4kfC+kAfMmgu5oZWmhkQOCqQqSemA8OdvtclzLD7zCgY4n4NOyc/IevCUCQQJBbEmcNdg7xWm0+YSWZi+zLPfh62IBX8BJXnVIG9EunQRTWzd9lsLWUmq/LsWT0DrpniOtrkth8Zy1n1T9293YQs0O25tfGAad52nNLX5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pn88UF+gMbisNh4o2/Hj2JYiuTWPRw6nG+bhPugISRI=; b=d4Iao/MVgtdJknq+C7c9V5dEQTFgvnNXJ7qHk8PXYJ7986IKGRIbkeHQjjGn94WLV84smQEhafAD74ZdKfR4YiX7sdEt0OPnEcP6ZnPNOzADHZ8pVordCpA6+cdLvWdjBIRJBwYldw9qiYuLDAC8wCDZ3W2125q3YWNoWXNQEOb/Ab2f+uYumP5WT/Bd1zRaUvjT10dCKsyyMNMjB22bRLxCfA9nc3MNX3L7FbJvbmcwNBgOaZBRTdSO1saHNBrWzcISu28eWj47dR5veOnqZTqc+dsXFEnxtRztxhurC7ImHbFP04r5Eu42BkbxA3YOeOqaFciHbTrmWq3iM4WsoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR1201MB0143.namprd12.prod.outlook.com (2603:10b6:301:54::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.23; Fri, 13 Nov 2020 14:03:51 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3541.025; Fri, 13 Nov 2020 14:03:51 +0000 From: Slava Ovsiienko To: Maxime Leroy , Matan Azrad , Shahaf Shuler , Olivier Matz CC: "dev@dpdk.org" , Didier Pallard Thread-Topic: [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value Thread-Index: AQHWuQoBxUBuoeEfRkexm6OZaNERganGF7HA Date: Fri, 13 Nov 2020 14:03:50 +0000 Message-ID: References: <20201112153911.15044-1-maxime.leroy@6wind.com> <20201112153911.15044-3-maxime.leroy@6wind.com> In-Reply-To: <20201112153911.15044-3-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 128cddde-6895-4fc3-39ce-08d887dcf2e4 x-ms-traffictypediagnostic: MWHPR1201MB0143: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AYRfpT88rI/pCDgEcGd44VrZE+wtRM3FOKzoDz/JjcYiJUW81nQILrBmfmUq+1ozQ3I58zpTAx1e48hM2umN17lXh1HPps6cu46Xm+45TjU98xCEFDBIlS6WCXqDVnlurIZab7S2CHGpGazvYqWSmFPZTyI46SLc5tdbiqlG/Blm+hf0OyHV2I0rYNoDEh63RJ4qffreYsTCZlnmbX3+f1CgnsZU+bjpqcdVMRv8BzYb8MqdjXkh3qlPFALAXt32KNnf20P/9Ikv/tqvVG5lEuQOnRD/7Tt2gUacooD/30USfJILYLrLRwng8+HvJ+Ci x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(6506007)(64756008)(54906003)(66476007)(316002)(7696005)(110136005)(76116006)(8936002)(52536014)(4326008)(66556008)(186003)(53546011)(26005)(66446008)(8676002)(478600001)(66946007)(9686003)(33656002)(86362001)(83380400001)(55016002)(2906002)(71200400001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 6wXlbkwlYuQl+TL8yKaFZs0gzGauhznxg84Z3B9MXVgKBq4TbEu2tAqJbT76om0OUlKby/a3/MB6tfBidOZ+NRpqzbvhQGYqdOzoyE9K6Mq9Ig/UDh/O76V5T5hlzuyvkoy9q7zZYiNl+UpFgLUdbWLQXv7IAF3bSeiaFwbb41k1xHk/JzBMQlnoM/gYD7sxVHqZ84cOnYFqhanYJCup76ohqh4AhBIVO61OxNuOocpLJNtrP/OCsIJuNulTSbzCsutREsUmXvzNYaxV1syUp06ood8KtWhEU23B23lhpKslGfqpS+WxT8xM9sUZ97sSZNUnoAaXQRPFqVIxDxH/98//zlAwVZFqeWKHyLbB8JB7ThZd6t7ErxF9+nR/Euca8ObVVmlQ/mWBVHalTHp30dcGMuHuDBf7+3hrReU1VQ748q7dfCp8i1u34xrQxbscKFDQjNOmlevCEVRUeyisyuweLd0VB535PbTm/U6A8T6xGfHvQ7lGJYlEtqJ5EL3hdiqJbHmWNfmnN/kayLjMLBcVBNRB/ENEJqvMCNbAzDbjg/UPK5En2sUKGAT1Be+hMsYoT0UhIBHJC5kROADRe9n7ZfuXJ1iHPt57abkCcS0v+MKedE+tI/8vSVGaBGi3ez0iUfVrBNeuZGT4O0EDlA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 128cddde-6895-4fc3-39ce-08d887dcf2e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 14:03:50.9293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FOh6KKzM7ylX0Ujo3Tb77ud7GxS8Erzsc5yK/pJcVKFlnaXBOudy4N4YolNVciRUW9sGUqQQaSPSaFcYkCyzcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0143 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605276235; bh=Pn88UF+gMbisNh4o2/Hj2JYiuTWPRw6nG+bhPugISRI=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=DBMt3HVZLlvRq8SeWyic5gKorprDOjhXa0ZKtDnTzx1xbXFB9cnQfq0Ay0nLddwMy 8d2dMnc23gFh/UgcQCtCEpuUC1blqnVtxzpj91JkDYYD3KM5gzMGXmdX7Y9blAzphY hrrlbUHskNBsAG0TQEV23yiLMDJnjFLCYN+uriHZNH6ft7stWKomj/ycDHvtM2FnGt ViiDhpF5omrxnJrGZKExEy8AJ9O4P7tOMADsrwlhs3XRLF/sHeVDpjzyazSJtcXNx9 V5ZxvHXwxBKXWKNoDffn8+YL+ckd0eudyarapCwHq7m62lWwJaUnbTnkludTZidnln Y/p/Ou6fpvimQ== Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Maxime > -----Original Message----- > From: Maxime Leroy > Sent: Thursday, November 12, 2020 17:39 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Olivier Matz > > Cc: dev@dpdk.org; Didier Pallard > Subject: [PATCH v2 2/2] net/mlx5: fix Rx descriptor status returned value >=20 > From: Didier Pallard >=20 > One entry may contain several segments, so 'used' must be multiplied by > number of segments per entry to properly reflect the queue usage. >=20 > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > Signed-off-by: Didier Pallard > Signed-off-by: Maxime Leroy > --- > drivers/net/mlx5/mlx5_rxtx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c = index > 2733dcd3..f390dd66 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -463,6 +463,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq) > struct rxq_zip *zip =3D &rxq->zip; > volatile struct mlx5_cqe *cqe; > const unsigned int cqe_n =3D (1 << rxq->cqe_n); > + const unsigned int sges_n =3D (1 << rxq->sges_n); > const unsigned int cqe_cnt =3D cqe_n - 1; > unsigned int cq_ci, used; >=20 > @@ -488,7 +489,7 @@ rx_queue_count(struct mlx5_rxq_data *rxq) > used +=3D n; > cqe =3D &(*rxq->cqes)[cq_ci & cqe_cnt]; > } > - used =3D RTE_MIN(used, cqe_n); > + used =3D RTE_MIN(used * sges_n, cqe_n); cqe_n reflects the number of the data descriptors in the RxQ, there might b= e convergency. I suppose the clamping should be: - for non-MPRQ rx_burst (regular and vectorized) - (1 <elts_n) - for MPRQ (1 <elts_n) * (1 << rxq->strd_n) For non-MPRQ the rxq->strd_n is zero, hence, it could look like: used =3D RTE_MIN(used * sges_n, (1 <elts_n) * (1 << rxq->strd_n)); With best regards, Slava