From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57A29A09D2; Wed, 11 Nov 2020 09:52:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6CBED4C90; Wed, 11 Nov 2020 09:51:41 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id AFD822AB for ; Wed, 11 Nov 2020 09:51:37 +0100 (CET) Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 11 Nov 2020 16:51:36 +0800 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 11 Nov 2020 08:51:36 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 11 Nov 2020 08:51:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iq91wymak2hk8MhuHNED92PIxOvAbGHtr0JKs4yvCN0Skp1k0ZCxmJ2eY8TSgtf3NfJ8NY4fu0ws7WTqnCUa3hCf36C7V7OWu7lD53wb5622hea/i068yLdKddK9ywQsZYr4ULaNQ4NMHOe6bjIsjiDt4D2mxUmhE7NmQdC4rUqeqeh2IGV8WsTEoUwFAfp1xVqWl5TZ6ZkAJoNDdkjpBqqoUcDy/D0subrExdm6nAURsl/aA1nGqnxMhtQ2xJH4aN1wphQ5HsjdFPw2OTYV7GNBg0C3t6r94B4rSj3J3de7OkGEihphdARH5R/GsUt+NfUsIIx1UwVIvY8fq+kIYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5h24d6gv5LNz9r3xmdS8vOnJqvf07AAP0lnaXm+Qiw=; b=hD9oAAr8zVOjWlh2RLQz5jZCGrx6oVPaqget2RU3dY1RCRu+JlwNQjjqrZCxw35OQ/3+Yn7AIU+CM5zMYTGLzRQ/iNRD4bEVyTPfkZwLOlHug/79MA5WMSrnA3TIIDSacjJ0QQb+61jCstAS4JJo6qm8t+HHZc8Sc51+xfQ6RoYU0RG+NidCVksCDjl1Qif0Suct0qp8Uu0B70maqwMI/YypdjLm8UYxuIC+wgMtvnEYlwE08K8VSJHw+tTdfHWNwIFmeZPEKvHOQcWbVqtPfTycmEYcrL9CpFUdEe9xRnoAewEpGWrdTkafpeWZ1DzlDWbpj/aH8gcxZbCjIknmUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1758.namprd12.prod.outlook.com (2603:10b6:300:10f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Wed, 11 Nov 2020 08:51:33 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3541.025; Wed, 11 Nov 2020 08:51:33 +0000 From: Slava Ovsiienko To: Gregory Etelson , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh , Shahaf Shuler , "Xueming(Steven) Li" Thread-Topic: [PATCH 3/4] net/mlx5: fix PMD crash after tunnel offload match rule destruction Thread-Index: AQHWt/pa7+z01rwRGEeMPzMH3z0OGqnCn7aQ Date: Wed, 11 Nov 2020 08:51:33 +0000 Message-ID: References: <20201111071417.21177-1-getelson@nvidia.com> <20201111071417.21177-4-getelson@nvidia.com> In-Reply-To: <20201111071417.21177-4-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 685b3343-11bc-4daa-d56a-08d8861efdc5 x-ms-traffictypediagnostic: MWHPR12MB1758: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xP9iYzx0fDNw6aEFkRf40rjxH/M7EfbLWnJsX5e5dUCg4gaSTFP8G4F6dIc7+RyecyNG0fyzs/R+YJF4lJvwMiXH0Ca34oY9MDqxRebiPLYcJfLoZnxlK9v2GTNXttvlrQdeJghpkHlFToOx2O5vTYIsCgHBtiU3cwt/fQ/BT5tZIij6CfJUeIVMZXh64ETC0o2jDz0EM0crw9p6XWEvj93/KbAEw7WTrQWstkFrc9iOJg+Ehs1U8dSnN/v90hz5jALNf3AzDm9XX06wVXDlW4dKIzIYDwGfT+7qZa4eNp05w+onVtDGnlhIsBHZ0NCq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(39860400002)(366004)(396003)(136003)(83380400001)(8936002)(86362001)(110136005)(2906002)(107886003)(55016002)(8676002)(26005)(316002)(76116006)(7696005)(4326008)(52536014)(186003)(478600001)(66476007)(66556008)(66946007)(54906003)(33656002)(53546011)(5660300002)(6506007)(9686003)(66446008)(71200400001)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: W60j9/TIMziC7/5T4d0FXA53xrD4nwB4HA+7yhW41aFeIHaxjGUH+1VheLufTz5995wgmxFu5wfkRXW6kl540TpGqiPJ05gawbUl5JoT0srks8k7xCVL6rVYgyLljhSiwstoAipLMrH9/Iszn+1rQ7cLCfuGQxJGtcyaWp8km3R4+Ym5YAXlo/lZxMy+5NBOY39KlpmKBJkQMr7AYW2KgOeSeAIEHc+JXP+ujm7OAjhK9IA4L1JQGgC1eYc3Pb9zsgf+QTwd6vMKlLk/Dahv+dWbMLHsIJBd7TIQ9FovC1Tl/ggh2evEW1tHOos/vpCjdXYi7ZgIRR6Bwm2MnEzY0WWIrUbFjMTe2gJkuhP6EadxAyfZuMM5nFFzZKnqKn6F3RpVVbqud6B4lYXUvteKl26kH6E/MixhUIOL9z/3BCcdqkpoEWW29qIEqVZWhff1nIdi4IHHZj4vSY0n6XEX+X3/U6W4352TM/Em/IwlpnJt5+Gmb7Z8y0dU7yqakn4n2AE11jclGYeqiTtQcaJMiGr81Ub5ZUZiiVf4gPfM7XI0KkLdaltHwbq2kv38GUccrAXtd1dqlKdaNbWJUxumdA73vei1775UhNXWly4ChEAvvMe5xJMm3k4uOx8dH/wzlbO3Ko2tj6LwsJ7Ys5l6wg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 685b3343-11bc-4daa-d56a-08d8861efdc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2020 08:51:33.6077 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SqDGSViKgWFontL2fKO8TL+uOVDSlbtEhp4MaqCGtQqg9C7VvmOUsL3bZM5ir39f0Rc6h3yWD3TWrUz+IEHPUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1758 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605084696; bh=y5h24d6gv5LNz9r3xmdS8vOnJqvf07AAP0lnaXm+Qiw=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=p1oc56Hta550sGbLgcDM+SMIoRWWONGiFCPNjG0buXTf3uEdOWdt71Ej1uezFBCLK JmkMRyNojpgb7CUVHIXUriTEX8qr7WXj0oiKdkTXGzHDFg37ykVTRLsa0toHPhMJfP 5LFoTpJMuGfjTdeIuRkjljPcQpuoN5KdSPnThDqkpZBGWhdhDwm2BaWqL8XURY1N6j bvQkgz9n4eR6flte/buLWSMRXp1V6veKniEOk3rIf8YdQQZE+6BRoLmJdbsLQEIcIB aJ13zG2IV7XZEXNHlUxldg3ZTHdBSpzK6cBTqQ3BZoGbwsSEIi15x+7B6rXRZWYGpf maOoq8Yef5syQ== Subject: Re: [dpdk-dev] [PATCH 3/4] net/mlx5: fix PMD crash after tunnel offload match rule destruction X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: > -----Original Message----- > From: Gregory Etelson > Sent: Wednesday, November 11, 2020 9:14 > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Shahaf > Shuler ; Slava Ovsiienko ; > Xueming(Steven) Li > Subject: [PATCH 3/4] net/mlx5: fix PMD crash after tunnel offload match r= ule > destruction >=20 > The new flow table resource management API triggered a PMD crash in tunne= l > offload mode, when tunnel match flow rule was inserted before tunnel set > rule. >=20 > Reason for the crash was double flow table registration. The table was > registered by the tunnel offload code for the first time and once more by= PMD > code, as part of general table processing. The table counter was decremen= ted > only once during the rule destruction and caused a resource leak that tri= ggered > the crash. >=20 > The patch updates PMD registration with tunnel offload parameters and > removes table registration in tunnel related code. >=20 > Fixes: 663ad57dabb2 ("net/mlx5: make flow table cache thread safe") >=20 > Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko