From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: "Jiawei(Jonny) Wang" <jiaweiw@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix incorrect group value of sample suffix flow
Date: Sun, 1 Nov 2020 16:41:14 +0000 [thread overview]
Message-ID: <MWHPR12MB150188763961822C3E6F08A2DF130@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1604213400-287636-1-git-send-email-jiaweiw@nvidia.com>
> -----Original Message-----
> From: Jiawei Wang <jiaweiw@nvidia.com>
> Sent: Sunday, November 1, 2020 8:50
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v3] net/mlx5: fix incorrect group value of sample suffix flow
>
> mlx5 PMD splited the sampling flow into prefix flow and suffix flow. On the
> sample action translation function, the scaled group value of suffix flow be
> attached into sample object and saved into sample resource.
>
> mlx5 PMD fetched the group value from the sample resource to create the
> suffix flow. On the mlx5_flow_group_to_table function the group value of
> suffix flow was scaled with table factor again and translated into HW table.
> That caused the incorrect group value of sample suffix flow.
>
> The fix introduces a 'skip_scale' flag and sets it to 1 for the sample suffix flow
> creation. On the mlx5_flow_group_to_table function skips the scale with table
> factor to use the correct group value.
>
> Fixes: dc67aa6 ("net/mlx5: implement tunnel offload API")
>
> Signed-off-by: Jiawei Wang <jiaweiw@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2020-11-01 16:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 7:41 [dpdk-dev] [PATCH] " Jiawei Wang
2020-10-30 7:26 ` [dpdk-dev] [PATCH v2] " Jiawei Wang
2020-10-30 7:26 ` [dpdk-dev] [PATCH v2] net/mlx5: " Jiawei Wang
2020-11-01 6:50 ` [dpdk-dev] [PATCH v3] " Jiawei Wang
2020-11-01 16:41 ` Slava Ovsiienko [this message]
2020-11-04 13:29 ` [dpdk-dev] [PATCH v4] " Jiawei Wang
2020-11-08 11:13 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR12MB150188763961822C3E6F08A2DF130@MWHPR12MB1501.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=jiaweiw@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).