From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C370A04E7; Sun, 1 Nov 2020 17:41:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 940E82C15; Sun, 1 Nov 2020 17:41:23 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id C78DF2BF9 for ; Sun, 1 Nov 2020 17:41:20 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 02 Nov 2020 00:41:18 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 1 Nov 2020 16:41:18 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 1 Nov 2020 16:41:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=chny4axXxGU3jGt6ESZrZLRk/fBx1DM+/Gqh5xbZJyHDHJ8lFvzmxQVHP4FVDGQtwMRlYnXRdBe2lnEFfdP8VrQz3A4OwDh8hGH6tsCScOuHPxf8dlXDMMuk3qi5mwKr8f2nqFjCj4+ib8Bk0bqkcGWR26LnFEJSlti2Cdcj1tYurcm4Xv4GOYOCq6k0RtGaUROJL73E4sRyEKQgS8n0IXcMQq/I3eUEm055bexJlCUTZOtlXPN27NICFEfBuuHb6SZL2pXKtOKpDmVjHUQFR//ELydl7jFVtNuQ+f7z2IW8osMaMznvAfngbo5brY26Q5VMINwNzIyJMRko4Ho6jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oXyrDe6SfInhZuAq/vXR+eE3J9Lp3v1XOPZBODMYnRo=; b=ESl+ojHZkbHsD8b4bUiWpSvATiYXPCIB7nI/F0c+JakkRefDPdFaL9a9BJYZPCUdV3qBlnl3b4WMc+ImupWLDfMtIgvg0XuDWomyp9OpWfiPALOOja4kI+5TXMezgvEdsak28hXdM89oqenG/nLRuRaUeqZzOcFcY/D6MoG5HUkD0v+MkEnD+4fWlLqts3jzYSmxZjLnE2yrsiY8hD9LPl1k4QTJ1Z8d2rF1TSn7awsXUJKnpleRpxaTisjLWQKwUbHpHt3lfP9Xja5W49dTJf4FNV4RNzgTihDECC2cC2WfuN3THTqhVaNls4pzgxgXhCMt3Imc/j4lRZpfVPGM/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1694.namprd12.prod.outlook.com (2603:10b6:301:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Sun, 1 Nov 2020 16:41:14 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3499.029; Sun, 1 Nov 2020 16:41:14 +0000 From: Slava Ovsiienko To: "Jiawei(Jonny) Wang" , Matan Azrad , Ori Kam CC: "dev@dpdk.org" , Raslan Darawsheh Thread-Topic: [PATCH v3] net/mlx5: fix incorrect group value of sample suffix flow Thread-Index: AQHWsBtPwbM+QFOxcUqspsiH1arWsamze0yQ Date: Sun, 1 Nov 2020 16:41:14 +0000 Message-ID: References: <1604042819-405419-2-git-send-email-jiaweiw@nvidia.com> <1604213400-287636-1-git-send-email-jiaweiw@nvidia.com> In-Reply-To: <1604213400-287636-1-git-send-email-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 674f148c-0aa6-4236-147f-08d87e84f295 x-ms-traffictypediagnostic: MWHPR12MB1694: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WWZscGZIR6AUtgDHx2Ucjh7Ty3qbZ6FOPcoirWWAtX+6gYpu/PkTpARZKcA71ucLDIE15h4hRTkKvqUfgSdZgvWp+UfejSAyjALtsokTvNUgHMtuX2OWs9tJBV3wikDB27ztETancLCZfm6zcBQEwovON25tb36uoWinCvYQcpbU7YAa2LwtGIz9jugg7Sb8T8rT06KTI1D6r+Twirpl2qO5DN+b5rbcmYUqh6HekKDYiGkb5CqjjZHdv4t9tvt73s1Jlz6wDR1Pp//Rj/IvzS1qb5CSMtt0MwfPYoQIKjkHWajp3PJ9T74xI7QV01jU3jim5BgR144zcUScpAPAmA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(52536014)(8936002)(26005)(186003)(8676002)(478600001)(5660300002)(6636002)(6506007)(55016002)(53546011)(33656002)(83380400001)(107886003)(76116006)(66446008)(64756008)(110136005)(7696005)(66556008)(54906003)(66476007)(4326008)(66946007)(2906002)(316002)(86362001)(9686003)(71200400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: XxeCCdOA1sQv0an8him3qPu0M0mxiavXFCIIeSsn9hGMb7njbz5spSCReWMxXjHzLFXpuJCw0e4GpcuWS00g5qx/UHg4oEY8SnZ3N80uRrozDhDOowIcHV8LMyXoyhZ0qRDrx9BmsfCFAPAplGKFZxhg9+AeDm7Gm9O1aVWtZvuvceovC86rgy6uiCCSfphf1TxLKvwaW5XqQYIJOeRfVbfNqXYBxshRTTsdLf9zZmsOml50gqPYlr3umfnIMKVjtwLo7VU4pRRz6VM1VckDXc9cy7qUpLRN5QsaX6xk8Fb/VYIaGIjrxGOLGJiCrJe90q654FA3X/r4d8DiO9Hyl8suMIq0Fd/0NVGS3XgznbEAwwVwLrz4EhEuf83y8BZkqm6O54ONEbsDkNdWrUsHZq3u1ydXLY9j9tUkX1BnPC/IwfRjlPFGp3g0T8h5McIfF62k3MCWdNBc8vPxtu/lxaiPjW0UGayyUEMOv/wE6NuS2Nzxyg5RAO8EJFagldqAWI3XLF3NOpC77DSuaoAMWeBZDMROwqOxfNVT7yLQKp02NDb/IiEH351aCJLuuUxo2YsDdCRHV9Rtwpdif7tSbo7S14/z8W4bNGomnFd8dO5wzreDdozLuSP07DVgIrhM5iWCBtZE/S2ZGQIKN/NTCA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 674f148c-0aa6-4236-147f-08d87e84f295 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2020 16:41:14.2294 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nBewSKxNMlB3THkvbkJJPyFEdBQAsG9huh+y1swW7FZVhRu/j4xnW+NCJLJitmIB6+5TeCLLVo8Pj3tbdTlEMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1694 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604248878; bh=oXyrDe6SfInhZuAq/vXR+eE3J9Lp3v1XOPZBODMYnRo=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=MeiTmwoEoJWkhWWCs1X4p7vJ0JW2CV4Bi5FepEqieVbxIleeT3DXoaCa/jo42x/oG cGRYVXcEkh+kmMW/NAapS630ofdkuX27Lf3k2MeOYwrKdBCR/zPeo9pPLrLCCwu05B 8zeCX4kd9krC780LRd7Zm8FQEWiMnj2H0axJ+AEnaUZlILJoMXoZ7Jj3SHOoaW0chy K8EFjC9a5TQLE3bPDJ3t9ignPBju+402bi4gRgWuqp5ebweO17dIDRB6wvSO41XaqB fnRAp3dsBuBuZXcHkzhxCuZjSI64Yz38QfEKSejOmzramXbcEi8QkvTgoX++GCNCUc 0xvoE6637XbFg== Subject: Re: [dpdk-dev] [PATCH v3] net/mlx5: fix incorrect group value of sample suffix flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jiawei Wang > Sent: Sunday, November 1, 2020 8:50 > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v3] net/mlx5: fix incorrect group value of sample suffix = flow >=20 > mlx5 PMD splited the sampling flow into prefix flow and suffix flow. On t= he > sample action translation function, the scaled group value of suffix flow= be > attached into sample object and saved into sample resource. >=20 > mlx5 PMD fetched the group value from the sample resource to create the > suffix flow. On the mlx5_flow_group_to_table function the group value of > suffix flow was scaled with table factor again and translated into HW tab= le. > That caused the incorrect group value of sample suffix flow. >=20 > The fix introduces a 'skip_scale' flag and sets it to 1 for the sample su= ffix flow > creation. On the mlx5_flow_group_to_table function skips the scale with t= able > factor to use the correct group value. >=20 > Fixes: dc67aa6 ("net/mlx5: implement tunnel offload API") >=20 > Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko