From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D0744A04B5; Fri, 6 Nov 2020 18:41:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8EA06100C; Fri, 6 Nov 2020 18:41:35 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id AA2D923D for ; Fri, 6 Nov 2020 18:41:32 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sat, 07 Nov 2020 01:41:30 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 6 Nov 2020 17:41:30 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 6 Nov 2020 17:41:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TQ81ZhhmRU2COSc43Ib9B/Q39ccFd0inJdvZ/yfiTRvl14Z0UYdOmCkqHwVmcLsLxTxINBrizn3KraV5+87MGOxaOJRuyACYRKIs5JV33g1BEevWJcX9W2Vh2po+uqszKtZros28lTjFJp9XXv2fvRwAoxi7lg7DenyX5a/CCBb3j5kZ+pfSnwI/zqIpsIpN3V/pfgL38IUQXdFKRvt+5B5w6aqe8QDdN58b8FcysOQlgurXrpWidt7nM2M4erNCzAl2Oh6MXuh6y4T1BRP3ViYMpgMRPGfAaz2x7Udk3Y8tA/dooDTlhzzVSm05r77rcvNuG6yqnj+8EAIL690waw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KuGTxBsmCPprtV3hMzm6SAO/tHMUTPEOgq5lH4iTkmA=; b=RS4cSr/Dk4vsROsTJFl9VALJ29zCfX/G1Pj19UbjldT5hjO2GVYeKdcxdzfVb/yhm5hOqTK1nsTB5gFn0xytEwIvXWk7pN2IiUu0SdMi/eQyUGun/kaadmjaLoHEYfkzjVq4Lwvp4dSmlUu9SfSzSte/VFBny7dkYEeM7NzGyG+WIglKkrkpBFTSscV6ClklEuQwfqPh7BJAGu3k0TBvGK2pCi+3Uc+9F/3yz3n4WUtmtFCU3FyuxpCs8JusB072cSstg2CvX2fpqNjVK+CBBMHgtM7MS0rbYQDZ7FW6Yu8iZzbW0no/N6gzoznbL5aapXHgEP4ySvqKlVhd7iY7Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR1201MB0208.namprd12.prod.outlook.com (2603:10b6:301:56::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.27; Fri, 6 Nov 2020 17:41:28 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3499.032; Fri, 6 Nov 2020 17:41:28 +0000 From: Slava Ovsiienko To: Suanming Mou , Matan Azrad CC: Raslan Darawsheh , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix invalid entry assert Thread-Index: AQHWs+lIBl5ByivXZUmNLxevH9wP2am7YCyw Date: Fri, 6 Nov 2020 17:41:27 +0000 Message-ID: References: <1604631741-128270-1-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1604631741-128270-1-git-send-email-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 46d67864-5b16-48cd-c2a9-08d8827b3099 x-ms-traffictypediagnostic: MWHPR1201MB0208: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vIxEdw5wqfq46vZMf6AhM4EQx5hnNTYltwTYobZWTz+awZHOW1J5DGR2PsJfqhryw8dQW/u85KYw1C4UWJU2+6KVavOrHvGbhIjuXbX1BedRgYYsgpbm6Z8IHNX4FGrTCLPUOhYdZHcGs4rG9gN+3sWMbGWLgj5Nj+ak4X1ouHu77/yCdaoHx89d5TMka04C7f1PCjnD3CAR6c8Hpvn0e2GK/8aL/l/1ZyoQxW7ymjyGhl378PuNsCHSGlaqF0MZ38YemWaoAYQB7VeO57y7UqtfGV2DUFo1oZTIcPU4E97Sh+gDZJ/NEdfrDjyuCJMMb4lUQ0rwu1nn/zeJhWpB/A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(136003)(366004)(39860400002)(346002)(2906002)(71200400001)(8676002)(6636002)(66446008)(86362001)(33656002)(64756008)(76116006)(8936002)(66476007)(5660300002)(66556008)(52536014)(53546011)(4326008)(7696005)(55016002)(9686003)(6506007)(186003)(26005)(83380400001)(478600001)(54906003)(110136005)(316002)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Pmizew8Ev1hevyB5R/CGuakn+sleOQHWredWu/SP1WdwPsKjNt4JjYacq176gYMJSJQZLZ1RRFlh8/Mzr4w8YrdNT5+ygCENrQNloo+IaH+UwjSEjnJ3MRqlOfAuB1dw5fPFu5aw+VVX1SdB0GEWUHdpx4Qdi4FwbyOvNx3HKb+ltvsHJyJYrhDaXcMow5zPWn3zbEdRv9knR9JG8/LaylHuzpLQCZWBLNz4972ktMDWwdQXINkiHValQfGZQjqOmN9mfQXthwEwrjDTT6qpSLwUdeb+iF3b3YePmi4w/jaXYlnr0sY7JuGEhAAuysf9aRB8CV6fNODJDJh9EAIsdNs4bGnRdCwXy/vKTeVjVQOgjM8flqbv3bC+iSjbMrFlEA7YgdzGRuSe1qa86xrMa7FjFa8c8G5P77QqRRl1LW/VnAa3P3FXr+DAhFVkg8edFYexckJWa7uAFgwzK3bCv8erYaG1Vr1HdU1ff7l1GC9CEVaN9LARLFk433xF1rrtyITogfZA6JusKnRx14jmcr/OZJMLX+UiEAM5bcQEKj3Hp97iTZeeNWcK4wH9QTm8GGyK6G/VOvIytgMgZxkbn7vu3DdZeVtYYqwJKM1MlI4rsFsFufmg+9akYGscFTBxVFy1YTzm1DRkKMGBiEuOOQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46d67864-5b16-48cd-c2a9-08d8827b3099 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Nov 2020 17:41:27.9847 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: taGMMimNPpvTGhy+Wd1vRORt4uZoP/nRhvCU48wzonyy+lbwHd2ospY1i0ZZTcy42ZyKsFQ4mE6p+McJe2HNXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0208 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604684490; bh=KuGTxBsmCPprtV3hMzm6SAO/tHMUTPEOgq5lH4iTkmA=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=al5Ejwef58eW0/6xwk6JfD2OggmAnM/YixPs7bm1t4NWNUsqPh+rtnfc6D+UJ8Ize vV/zQufRjD6oyFqaYJGIqGzz/mgjv1hPeES0OnG7INyy3uHI8nWphvcpY0lusgXOuf lecut2i8L01EnKJawTnQzr6sW3Epp8uDiYDic+mSkyxRpYMiGkSr9vZakBv6cQV1ko VrXLRKjsU+KSUy0Clm1sx4QM16OIGGMdrWSdnTGc2YNJerl+aytkwF9UOOkWJ7gShk NWYPR19uTml7+wMX0NJ1eWKWiqNqNYRvqQg8Rc766f2hYQleUW3uqQc7waoC3IJfLx qBziaInZPjPJQ== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Suanming Mou > Sent: Friday, November 6, 2020 5:02 > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org > Subject: [PATCH] net/mlx5: fix invalid entry assert >=20 > The entry variable assert in the mlx5_hlist_register() function is not co= rrect. > Remove the invalid entry variable. >=20 > Fixes: e69a59227db0 ("net/mlx5: support concurrent access for hash list") >=20 > Signed-off-by: Suanming Mou Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.= c index > 13590dd..9889437 100644 > --- a/drivers/net/mlx5/mlx5_utils.c > +++ b/drivers/net/mlx5/mlx5_utils.c > @@ -132,7 +132,7 @@ struct mlx5_hlist_entry* > struct mlx5_hlist_entry *entry; > uint32_t prev_gen_cnt =3D 0; >=20 > - MLX5_ASSERT(h && entry); > + MLX5_ASSERT(h); > /* Use write lock directly for write-most list. */ > if (!h->write_most) { > prev_gen_cnt =3D __atomic_load_n(&h->gen_cnt, > __ATOMIC_ACQUIRE); > -- > 1.8.3.1