* [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert
@ 2020-11-06 3:02 Suanming Mou
2020-11-06 17:41 ` Slava Ovsiienko
2020-11-09 8:21 ` Raslan Darawsheh
0 siblings, 2 replies; 3+ messages in thread
From: Suanming Mou @ 2020-11-06 3:02 UTC (permalink / raw)
To: viacheslavo, matan; +Cc: rasland, dev
The entry variable assert in the mlx5_hlist_register() function is not
correct. Remove the invalid entry variable.
Fixes: e69a59227db0 ("net/mlx5: support concurrent access for hash list")
Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
---
drivers/net/mlx5/mlx5_utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c
index 13590dd..9889437 100644
--- a/drivers/net/mlx5/mlx5_utils.c
+++ b/drivers/net/mlx5/mlx5_utils.c
@@ -132,7 +132,7 @@ struct mlx5_hlist_entry*
struct mlx5_hlist_entry *entry;
uint32_t prev_gen_cnt = 0;
- MLX5_ASSERT(h && entry);
+ MLX5_ASSERT(h);
/* Use write lock directly for write-most list. */
if (!h->write_most) {
prev_gen_cnt = __atomic_load_n(&h->gen_cnt, __ATOMIC_ACQUIRE);
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert
2020-11-06 3:02 [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert Suanming Mou
@ 2020-11-06 17:41 ` Slava Ovsiienko
2020-11-09 8:21 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2020-11-06 17:41 UTC (permalink / raw)
To: Suanming Mou, Matan Azrad; +Cc: Raslan Darawsheh, dev
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Friday, November 6, 2020 5:02
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix invalid entry assert
>
> The entry variable assert in the mlx5_hlist_register() function is not correct.
> Remove the invalid entry variable.
>
> Fixes: e69a59227db0 ("net/mlx5: support concurrent access for hash list")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_utils.c b/drivers/net/mlx5/mlx5_utils.c index
> 13590dd..9889437 100644
> --- a/drivers/net/mlx5/mlx5_utils.c
> +++ b/drivers/net/mlx5/mlx5_utils.c
> @@ -132,7 +132,7 @@ struct mlx5_hlist_entry*
> struct mlx5_hlist_entry *entry;
> uint32_t prev_gen_cnt = 0;
>
> - MLX5_ASSERT(h && entry);
> + MLX5_ASSERT(h);
> /* Use write lock directly for write-most list. */
> if (!h->write_most) {
> prev_gen_cnt = __atomic_load_n(&h->gen_cnt,
> __ATOMIC_ACQUIRE);
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert
2020-11-06 3:02 [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert Suanming Mou
2020-11-06 17:41 ` Slava Ovsiienko
@ 2020-11-09 8:21 ` Raslan Darawsheh
1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2020-11-09 8:21 UTC (permalink / raw)
To: Suanming Mou, Slava Ovsiienko, Matan Azrad; +Cc: dev
Hi,
> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Friday, November 6, 2020 5:02 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: Raslan Darawsheh <rasland@nvidia.com>; dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix invalid entry assert
>
> The entry variable assert in the mlx5_hlist_register() function is not
> correct. Remove the invalid entry variable.
>
> Fixes: e69a59227db0 ("net/mlx5: support concurrent access for hash list")
>
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-09 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-06 3:02 [dpdk-dev] [PATCH] net/mlx5: fix invalid entry assert Suanming Mou
2020-11-06 17:41 ` Slava Ovsiienko
2020-11-09 8:21 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).