DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Maxime Leroy <maxime.leroy@6wind.com>,
	Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	Olivier Matz <olivier.matz@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Didier Pallard <didier.pallard@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value
Date: Tue, 17 Nov 2020 12:05:49 +0000
Message-ID: <MWHPR12MB1501BDE999EEA82941AF78BFDFE20@MWHPR12MB1501.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201117112648.29725-3-maxime.leroy@6wind.com>

> -----Original Message-----
> From: Maxime Leroy <maxime.leroy@6wind.com>
> Sent: Tuesday, November 17, 2020 13:27
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
> Slava Ovsiienko <viacheslavo@nvidia.com>; Olivier Matz
> <olivier.matz@6wind.com>
> Cc: dev@dpdk.org; Didier Pallard <didier.pallard@6wind.com>
> Subject: [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value
> From: Didier Pallard <didier.pallard@6wind.com>
> Three bugs in rx_queue_count function:
> - One entry may contain several segments, so 'used' must be multiplied
>   by number of segments per entry to properly reflect the queue usage.
> - The number of cqes is equals to (1U << rxq->elts_n) - 1 in SPRQ mode.
>   The range returned by rx_queue_count should be the number of entries
>   used in queue, so it ranges from 0 to max number of entries
>   in queue, not this number minus one.
> - For MPRQ mode, we need to take into account of the number of strd.
> Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
> Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

  reply	other threads:[~2020-11-17 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 11:26 [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx queue count calculation Maxime Leroy
2020-11-17 11:26 ` [dpdk-dev] [PATCH v4 1/2] net/mlx5: fix Rx " Maxime Leroy
2020-11-17 12:06   ` Slava Ovsiienko
2020-11-17 11:26 ` [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value Maxime Leroy
2020-11-17 12:05   ` Slava Ovsiienko [this message]
2020-11-17 13:48 ` [dpdk-dev] [PATCH v4 0/2] net/mlx5: fixes for rx queue count calculation Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR12MB1501BDE999EEA82941AF78BFDFE20@MWHPR12MB1501.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=didier.pallard@6wind.com \
    --cc=matan@nvidia.com \
    --cc=maxime.leroy@6wind.com \
    --cc=olivier.matz@6wind.com \
    --cc=shahafs@nvidia.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git