From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A960A04DB; Tue, 17 Nov 2020 13:05:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CD9CC37B1; Tue, 17 Nov 2020 13:05:57 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id DF27AF90 for ; Tue, 17 Nov 2020 13:05:54 +0100 (CET) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 17 Nov 2020 20:05:53 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 17 Nov 2020 12:05:53 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 17 Nov 2020 12:05:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dhwd6npOkIXzRQXjqh1k86QZXpH59m4LqDruy9t0gPq6kY01POXqRzmxIUX8DBwoplNAHPky/XQiLflLF3aByvMtfC7hS8JqGb0eLpCUBsAspoQXTp0MWC731qDTsmIGEE/Ic+CkhM9ybWrYc0SgnajNQ2y7v3MhX2N5QF2AeSiAehJ1rHr9b6hHegYAHs3P/6PdvtxkLRI/bcVDYBjYhvQZXmPuvNFE90NG8C87EAwgLvg9Gau5EcLRz60VHxhj543o4HBMrlsZfEVFUtT9BZCW0F1oS5vfJ4KEp0m2+RQj1TsrFMqWMcj7+iF97IcWjBgGTWk9FKywk99VAgMU3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqhe29ntwe9Q0qN/30X7L/YfYj4rmN+pq/FwSG59c80=; b=lIPyFoWyjR4Db5cDxLJ/gBzC6NfDhbLxnWznUtcpxwUim/DCU6TWYpnXPvP/Zv5KvM01CA6D30KWjh4hJK0kbpdOBUaXhRjQ5timUuA5AippsJxtl5X5IuAvgSUtaYffNR7zzs+KWTs1Xqf+dgGCSyPTnMokUj0f56opYVh6kZZ8k5wtnkyZL3OAw8Tsi7OkoerKrxVx36qV2UQqArjT/JBKux9QJ6Gy21cdDX3HpEY/p3QHDVZ+fixKqllO7SoG9L/2JEb4UqGgFPNPFM7K64qRZvolnvHlK0PXkYUd6lpJ2EZCOYsgaHWwh05t+GbtGYC52ZsxuTcvlVhaoCD1ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR1201MB0061.namprd12.prod.outlook.com (2603:10b6:301:52::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Tue, 17 Nov 2020 12:05:50 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3564.028; Tue, 17 Nov 2020 12:05:50 +0000 From: Slava Ovsiienko To: Maxime Leroy , Matan Azrad , Shahaf Shuler , Olivier Matz CC: "dev@dpdk.org" , Didier Pallard Thread-Topic: [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value Thread-Index: AQHWvNSo/V34OGY6UEOuPzkhnZBr2KnMOjKA Date: Tue, 17 Nov 2020 12:05:49 +0000 Message-ID: References: <20201117112648.29725-1-maxime.leroy@6wind.com> <20201117112648.29725-3-maxime.leroy@6wind.com> In-Reply-To: <20201117112648.29725-3-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 35fdd572-1255-4388-b185-08d88af11ff6 x-ms-traffictypediagnostic: MWHPR1201MB0061: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Y8Of8GDu/BbV7OOo4rasme0uNzJAbSD5gZ3osaG5WAkvWwXFVPEgnsmzPzdYitXQcsYVnZIH43cFbEaLgy9dfsNev7OAsp+qgw8egNq2Zx1auAdiAwesP0nuS/FOW+9NRwnowt133nGHeAhMTCeXmqBgsG0kPRpRm0B0jFq1LGdrZJjEBSlcyM5jLEUdm2LElP0Qva+lJzJvvISAB1+V6I4iFH7eEmCuHFzsN+BpSeywxAu2OHL6ay9yOgUIpsRCvPvcRTB8JUFZE2DkXbmEfdPWuo9xCP89m94mghMQD6DKNoPis1K6O6io+AccRw0+2xYWm6cMOqPa5lb7eYK1Hg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(7696005)(76116006)(66946007)(8676002)(33656002)(4326008)(4744005)(83380400001)(52536014)(2906002)(66476007)(316002)(8936002)(66556008)(110136005)(478600001)(54906003)(64756008)(5660300002)(86362001)(9686003)(71200400001)(26005)(55016002)(186003)(6506007)(53546011)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: m6LJudKApzxPcsCbvP6x0a5L+881DWNTjHErCpwEuN3vIkVJqB4oFQRM/n5GDdpTaNu1oDcKJaGUJJEFTGATBvUTWs6WyiVuhK3hD7h37Be9XWlwqHEvEXsGFoFZnRAfXs4YawnqX7/9S5evj7UdCCQ6NYfsqaPjSlHcDAzg3y8nYnbns/cYae78GruEcaTXP5861ZBFJbe2i7qIrpLA6fWQbH7ZybCwdxzopDJYZnFPEOoZdZnjeae+8c+nU16AZdZ/U37Axnp1bSvMlQwtR41eCSww8yBPgAge8AkGhcv74R2rNPMQ2b6v7M2MMPaUA6LQLVqMg28orzrzE4+hNT9n986TFXAtfBWK2OOQqvZ5slJhTbnSlchfa+HTXOzA+YvSm4y3M4Jen2vjQBOSUBtp8RR2KMAfguu0ciJ7c8fDFGGooMc61fBBMRKUNKWNNXd3VfHN9GofP8xny/XRJhcmnTwzfppTgmvE6P/LgQOnBpjXgDPvbnIdyG8duEYclPGIJoEuFpA2lTM61HIGe78n4hDfgzQDcMuNfHDVko+xsDGW8fgngA5BQP7jA3fk3uksU2KTfHodXIChRlqyUzUOVDC5NsRQcTYJbjuYvU5vFzJXxZvnXIR6yLnSX5YS3w9bnfS7ELHJCucMLqpUuQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35fdd572-1255-4388-b185-08d88af11ff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2020 12:05:49.9108 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xVWc2vua5RKmKnJWwDrZKmeXSsNLR3l6hLJ8ELwgzzaX+jO0LAxp3OFlq/lv2PHmj9SLrZudltIb2B2Sl5l99Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1201MB0061 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605614753; bh=kqhe29ntwe9Q0qN/30X7L/YfYj4rmN+pq/FwSG59c80=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=M2WBwyPqnoS41fZx647a4mWwWchywaumTX1KyYRibt2b3g2okHQ+KYtyR+NPdUwEI q5AklHwfaE3ENNx2fwZURPdNECIQLgjj4abTJsz+xiKN52g12IZ6tPXdxNwlLj+6dA JwwCTPs2r63hXrMkdIDS4TdDsja8zbG6ZEqQJOgcvu8+FkVgDNY7x0VWqdGJYNk5xk J982FEV0u8LZmRfwSqRJ3uiBQf5gtmckfOiJocpKiGEoTLqbDmRTnDRsbodDZUEVgq G72Gdg/Bq54eTAL9apWz6Xp8NmUI/gRUDCMWVCKsw5QKkC2i4nT6tTRgIUay5QH23N 4HZsSoZu7YAUw== Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Maxime Leroy > Sent: Tuesday, November 17, 2020 13:27 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Olivier Matz > > Cc: dev@dpdk.org; Didier Pallard > Subject: [PATCH v4 2/2] net/mlx5: fix Rx descriptor status returned value >=20 > From: Didier Pallard >=20 > Three bugs in rx_queue_count function: > - One entry may contain several segments, so 'used' must be multiplied > by number of segments per entry to properly reflect the queue usage. > - The number of cqes is equals to (1U << rxq->elts_n) - 1 in SPRQ mode. > The range returned by rx_queue_count should be the number of entries > used in queue, so it ranges from 0 to max number of entries > in queue, not this number minus one. > - For MPRQ mode, we need to take into account of the number of strd. >=20 > Fixes: 8788fec1f269 ("net/mlx5: implement descriptor status API") > Signed-off-by: Didier Pallard > Signed-off-by: Maxime Leroy Acked-by: Viacheslav Ovsiienko