From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91F28A09D3; Thu, 12 Nov 2020 18:04:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38915592C; Thu, 12 Nov 2020 18:04:21 +0100 (CET) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id E1B5F4CA6 for ; Thu, 12 Nov 2020 18:04:18 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 12 Nov 2020 09:04:21 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 12 Nov 2020 17:04:17 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 12 Nov 2020 17:04:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZruMqiE+4GMe8WcAafxTEthI8yxYsPTsRZGg+fAxFgHlXy7Ru770wg8cglDbjQ5v/Uji9u+1vvoBcmLKmpMtwxBb1I7wQZpJTHD/za1t52LGjB4yB8hAwPxzHzwarh9d0aee4gf5xYfRzR5ShbKE1eiAoHMU0AQaq9TDxhIPK3uPR/dUarEG131AJAJZz4e+Wrp8jQsPhY5md9Fp8VQi7v9yB2+cqOSnKkRt1tzvVNfXdMIDLSthDqkCpebpVRFMuUxE+FY94auW9p7jShRfw/mlB6d5Jf0dxAn7zhMGE8wicV9SjYhpmCwLGmhM7SPctilKN0V129MfGlP/DTAew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0OvKlNKrva1b45d/eT5sVICQNU0XlfcfRa9BuPp3QkA=; b=lF8Jf2/iA21QTDEvnEZkOlUmGa47aTcMd0A/ua7PXnN32d5GqQ6J+n1KP1v2iYWChyxMhKiOe9ZBWExqAqIajNkRHTL4/PBR672fSC7zgBqkJnWpZ53AHxWrQ1SSbdDkp0fWP3lRJ0Bd7Cr6WAAXhcLPG/5b2j1UMOjmo53Dr3zzB8oBTKvqH2uDD8Clqoqee+XX6uupRWdJ9qJubIBBCbgVDJSbTSBMUakxZOG726JwTvyjTA4txUn3yiGJY+xKkJ4WNzC7s2XoDSDj+ucDf784JmUHz1NnvJCDn6Ey8yq0riiLuayjXnqtJM1/Up05LKEEIG1H+gtXRkPO9vV8pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1501.namprd12.prod.outlook.com (2603:10b6:301:f::18) by MWHPR12MB1166.namprd12.prod.outlook.com (2603:10b6:300:7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.25; Thu, 12 Nov 2020 17:04:15 +0000 Received: from MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4]) by MWHPR12MB1501.namprd12.prod.outlook.com ([fe80::ec4d:f17d:402c:78b4%6]) with mapi id 15.20.3541.025; Thu, 12 Nov 2020 17:04:15 +0000 From: Slava Ovsiienko To: Maxime Leroy , Matan Azrad , Shahaf Shuler , Alexander Kozyrev CC: "dev@dpdk.org" , NBU-Contact-N?lio Laranjeiro Thread-Topic: [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation Thread-Index: AQHWuQoBBK6HHXLOikSGfQAmU4j7CKnEsW7A Date: Thu, 12 Nov 2020 17:04:15 +0000 Message-ID: References: <20201112153911.15044-1-maxime.leroy@6wind.com> <20201112153911.15044-2-maxime.leroy@6wind.com> In-Reply-To: <20201112153911.15044-2-maxime.leroy@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8073b50-345b-4c75-13b4-08d8872cfc61 x-ms-traffictypediagnostic: MWHPR12MB1166: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1360; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X8aGVl/bd2uau1Ir0ukaB4+CxlK/Vm56eAx84a84CrblpPBEZhQSNL91NxfcW9Ix1m3XiCVmp1g2+/GtdEZ0msWbbIHyhlTs6nFs481Eq7DSOPLVTeckU3fPRRB/SJ6peS1Czm5UC8XTO1JAwA0SuiiZdbN8jECBpWpufJAxrjbcpI2c53FYL1VldogJA6N3LG9TL8pue/IedKSD/Oi9xJQle0oewEnTcMk2KM1bgwTxBMsxEO529yRpuMZbUdc10wkueBbmEPtIneLX5qwP/tN4V6L8w9XYxzkhgT5MEfAuDwDF6IQ0m9D1X5VlFTXm x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1501.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(55016002)(9686003)(54906003)(316002)(5660300002)(6506007)(53546011)(110136005)(7696005)(2906002)(66556008)(64756008)(478600001)(6636002)(86362001)(83380400001)(66476007)(66446008)(76116006)(66946007)(71200400001)(8676002)(8936002)(52536014)(186003)(33656002)(4326008)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: MZMSyULd2X8euejKm6MVhRhd4Dj0jKouAW5/3WH3OXNn8OCNY2rH6D5uAp9vasCsLYcQhWy6+cFJbtDkpjC76AheXDzoqa/oxYN4rKs7TPWhhcD+TZyf+zoB27ihwYCnjeN5G6EH1Xf40k6YEChdeBgq9QAGszb+DThk/OxglJPG2Tu4oruD3nqDe+y9Hdzn50FgCYnwqG3XT9X2H4UgbnlI/0weRGoGWqMVCK/kFjdJFkFHLks/e4l76ILsJ+x+tJCIihLzbGh5NTBx7omTE6ZF0dc8hFWEvWrjtaTbTClHGrEtAcVY9uv4vygLYNGBHr8bsBcvdzE+H6aMJ9dsA85wpnb6hONkV/l1o1CrNUZTEhAcrQcRB+5NW3mx9YSX9sZQD3m2ujfVqC3xkU0OmUAEeGxHXADNRS0p0MLTVO+6QT5/FugKp+4GkAxjV8pZbqj7g6r/bNFisEgOi3t6BKiDNUZRu3OvVntMAlSosrwlUMatFtUhm1ORjp5/VNQ68tJfLcfLu3BQhFh77lFLP4iz4S4fCNtMmo449XGkFOHltTIhadAulrO/Z07M2TXMUcwTwl12Koo4t+/VEGci9ZwrPmAtlZn1vxSqJKAQfSSXsnmJTNzEjEwjvHaqGqAHbNrMiAmWJ5EvBj+XHioQ7Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1501.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8073b50-345b-4c75-13b4-08d8872cfc61 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2020 17:04:15.2967 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4CeNpkGUwiS09Nu2kxoKkklLYaY2lM7Gopoo/RtJIlF9ThuJ43UEZOB5m8tvkFHdzbLWgViJvPCXHcOsf4R6/g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1166 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605200661; bh=0OvKlNKrva1b45d/eT5sVICQNU0XlfcfRa9BuPp3QkA=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-ms-exchange-transport-forked:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=UrTVviokGXI9opgu3VJw5BSA0r6ZJO0enEdvfCFTqHq4UzMYqpDi00zcQcBbGG3zA dyXAirjUYdQn9ZN7rXg2XUd+T+BFObq6zCOr1O5LOAhEAVyURyJCEkIgL1M+14S0V6 tRA+gCepb2S724gThhDhrGiVtSGRx3G77Q9JRVK3KRAdA9Conewcjj0xtdAzuNIGDa n8kOPw8mKXGKmvjtX7rbz0TZDMvjbqAujevJ8o1sVuwjPfB9E2UYWjltrGvwEIhDbt fcQS1GHUR1MBpxRYaW25gYUz2zamzuzTxdsL29yzp4T3Lf8TW5E1Ei6ywAYK4ZhkSA rsyHVwu/YBo5Q== Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Maxime Leroy > Sent: Thursday, November 12, 2020 17:39 > To: Matan Azrad ; Shahaf Shuler ; > Slava Ovsiienko ; Alexander Kozyrev > > Cc: dev@dpdk.org; NBU-Contact-N?lio Laranjeiro > > Subject: [PATCH v2 1/2] net/mlx5: fix Rx queue count calculation >=20 > The commit d2d57605522d ("net/mlx5: fix Rx queue count calculation") is > uncorrect because the count calculation is wrong for the next cqe: >=20 > Example: >=20 > Compressed Set of packets 1 | Compressed Set of packets 2 > C | a | e0 | e1 | e2 | e3 | e4 | e5 | C | a | e0 >=20 > There are 2 compressed set of packets in the first queue. For the first s= et, n is > computed correctly. >=20 > But for the second, n is not computed properly. Because the zip context i= s for > the first set. The second set is not yet decompressed, so there are no c= ontext. >=20 > To fix the issue, we should only use the zip context for the first CQEs s= erie. >=20 > Fixes: d2d57605522d ("net/mlx5: fix Rx queue count calculation") > Signed-off-by: Maxime Leroy > Signed-off-by: Nelio Laranjeiro Thank you for the fix. The second patch is still on review - I have some do= ubts about final RTE_MIN(), checking. Acked-by: Viacheslav Ovsiienko