From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87841A09E4; Thu, 28 Jan 2021 10:18:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 161844067A; Thu, 28 Jan 2021 10:18:48 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id 6923C40395; Thu, 28 Jan 2021 10:18:46 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 28 Jan 2021 01:18:45 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 28 Jan 2021 01:18:45 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 28 Jan 2021 01:18:45 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Jan 2021 09:18:45 +0000 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 28 Jan 2021 09:18:30 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 28 Jan 2021 09:18:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZnRlG3BVH/EdUQDvvNq2bXVNMSnqB1TH/ZgNy1BA5+8xjYke7k1QX6KSIuBY6MJFIF+9tH4lL4lvYuhUBZpz07AeXb6B55bkZg6nLF6MhawgrH7G114kb5GRH5brIVP5EqwBj+JaQ/aIwMBNzT8YAgGGQtHPBGdpoJG6X2oD4fhykt6SKmr+leOSB14rn6qpAkktCy0wUIEiRfqu5+pBcY0stH5sZjRWdWn8Z3CbM7ZbzKXqlxRBZpgv7tEjGIJY46rjn8qGTLnQwp5rxV0DqfTi3J+RIUVufK3ffoop1s0UX4+sD5WMdsGqYmdIORy5xraujjjXMpHNs62SsYS3ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQEORcd2ZO9jYOtVISsquOtVUGt8TlzDdiCxBi+tsvc=; b=GHBfG37j1NVdZVVcMmd5sZvAZin1UTjVDYBqpI14GwEkEJZSrK+7FiV3H5Of29d5cNa9mKD3csY2GKl+zpfsAy8kv7XoC6KFASy/XN0CD9UkK7/xGxwMWh6GlEnSnMiMx2sU8NdrGFO4+nPZIe1qb6N82XLfOUT+Sr7Ua2JK4P8f99MNSVSCrijl9qOamXwxKk3uJutEaVUQoRmxZAEuStqpANVbIgvZrw42ylUUMfPN1HcnX7O+PS9M4VUG/58Tqycz1NqpmiKgY3zA2gSVXi1oNHVR2o9gCtjZb6Fejhwd1qdrHHgpMNj/lcTg9fzGfhy/8jlMAYzk+YlR+ndvIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from MWHPR12MB1677.namprd12.prod.outlook.com (2603:10b6:301:11::13) by MWHPR12MB1278.namprd12.prod.outlook.com (2603:10b6:300:10::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Thu, 28 Jan 2021 09:18:29 +0000 Received: from MWHPR12MB1677.namprd12.prod.outlook.com ([fe80::75d6:cd9:3d37:3797]) by MWHPR12MB1677.namprd12.prod.outlook.com ([fe80::75d6:cd9:3d37:3797%11]) with mapi id 15.20.3784.017; Thu, 28 Jan 2021 09:18:29 +0000 From: Wisam Monther To: Ferruh Yigit , Wenzhuo Lu , Xiaoyun Li , Bernard Iremonger , Steve Yang CC: "dev@dpdk.org" , "stable@dpdk.org" , "lance.richardson@broadcom.com" , "oulijun@huawei.com" , "lihuisong@huawei.com" Thread-Topic: [PATCH v5] app/testpmd: fix setting maximum packet length Thread-Index: AQHW80YnJYaCqwZtREKK2sZYKpt/jao8xh4g Date: Thu, 28 Jan 2021 09:18:29 +0000 Message-ID: References: <20210125083202.38267-1-stevex.yang@intel.com> <20210125181548.2713326-1-ferruh.yigit@intel.com> In-Reply-To: <20210125181548.2713326-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [45.147.66.134] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 272d6afd-14c0-4197-d5ea-08d8c36dad0a x-ms-traffictypediagnostic: MWHPR12MB1278: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:52; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wGFCyjmlkpKuGcRLeQ5Ezj5fFNMd9cewtF24KsrsAgaVvpws9BrNbXLYMmiVvs/IF703CaPOidV8gHvjD/RneDjKn3qljmmzOq7bATkMrUMk4tQpJgApWP8AUabFRuD3c1aI5CreniHXvNRD1oen+5Orz0WFbdrggniAIMJMbLb4Ii3Hq0/9R33HNpPEeVa+tdndjqZAF7BWzwioWcjVFCnKuUy6eJzfVtTnwQTl/BGOQ9eHix/2iQJBeEsu5TFgBRTWuLsYS5+GlPlu2Knq4sp3QcJ7Ja+CrzHQmkTxWXgB3pz60bX5a7PftWeMxJL4fo/YnONgZWU9vnbQSccnQGzotaNbvyzddt17C+LI4yrV18xdlwZqolAE51EzHKzsaP6QkEVfvqxWtHXtebVJKp9vFInckoWcySbgNKDoIddbLODLi9FFkrZhf8l4bR+TOpRkfXXD1XndBUC3Q0fYHwf9LZhi0ZIDoNzeNUqlfzNBcavy8UbC99w2c+2zFd4gbdRmCHpquu5Qr4CzHlbv0YUChhJr06cCgv0D6+meSYe1swojyGbPUxN1VFBL99oO9Ih45lVEHytUCiasZygPdWzdKiWes7MNuNK788wwukE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR12MB1677.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(33656002)(5660300002)(86362001)(26005)(76116006)(54906003)(110136005)(66946007)(66476007)(64756008)(71200400001)(66446008)(186003)(316002)(7416002)(8676002)(52536014)(53546011)(2906002)(966005)(6506007)(55016002)(83380400001)(478600001)(4326008)(7696005)(66556008)(9686003)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Ub7b6LJEV/lZFiBFLU8fzcgWor4tAMw7gelcAQyo00dLu6mOckFdDEFZQuBn?= =?us-ascii?Q?Wc5k+TbkCWECxXJo1PhidcDBj+RzBPu0rPR2UY5v8hBBkOJNLMT/IMFMvWIJ?= =?us-ascii?Q?FpnySK8SUEkE0sWoDjYLvIXKwAyuZkWQmVj5A+c70Ul5biZnY6b9M7TXU+xX?= =?us-ascii?Q?eo85TSrtODxjbnYpWeScvcvNRonDlhNKrEaElnEyFi3ft/0vZhEQhfTYlK1Y?= =?us-ascii?Q?w5bCv2UoqLiPAeUaIxclVEpFNSs2moHMPS7bP6SktSRrG7uB0amXR90D/Yu3?= =?us-ascii?Q?Wn3P561PXD4Q+JFq7Tq0mIxjj8C9qHrHvmFdp0vcEuRK+/7F/zl3laqa9OhN?= =?us-ascii?Q?lDU2knzvoWYAhxtb53RFMsh7jrz9VwZMQR5TXdiSwgZwAf/vVx+BJ1JRUV+u?= =?us-ascii?Q?3bxLopBDy3j8n9wjfPsle3fK57V80kqnH+jWjdgyJWnoOMwXSN5Myfk1LfWB?= =?us-ascii?Q?rxo09i051szcm3D0xsdoffLkHCgZ3K3c8clA5q5srklqPT3tY3bNRslbHzCv?= =?us-ascii?Q?Tdl1qKORR1iCROeDczpo9K4wk6K+FNTJn0ZZ1QqHZmA7qnWb+evGT2vQ651Z?= =?us-ascii?Q?q5fqkSgWsO46uTp7FycTU56M1y/o/Gv0J1qJYKOuoGnKzcakiDWDe9tejKzm?= =?us-ascii?Q?wqlpi2nsHt9eCwveJN3TK5uYgYYwYTP7gpOWbk8OLgRbGFndOIbxNw8MaHZd?= =?us-ascii?Q?aH2qFtTUV2OrEL2fvEPOdKGwz4t0qBfcq0zDtgdJ35eNjirZc9RrcptC8D84?= =?us-ascii?Q?hHBfLcoIM4EiUAje+D9vsF+BncfKI24yLYS1iNG/g7CbxpuhTxDyyQ9xa5aF?= =?us-ascii?Q?UMKv03VWiKMIw8sLrW34fGmYPkGgs6/2gBUyWbV0VvAZUbdMhO9yOZS3hm8h?= =?us-ascii?Q?03VvgMsk11G0kASRcFkzAS5KPt0xKTjKWXEIg7zXus4AGSPJMqUnjdojOoJQ?= =?us-ascii?Q?ceJqJUXdmY2ZXL5eR5crMD+kz2beBobB7Hw/JrFdnObJbzQQfPOKcFaB0TcK?= =?us-ascii?Q?v633dgpB/kDriPNQkDXlaw7/rMsAXPA17LoidPufS1NwjmfYyHxhIQwiZatP?= =?us-ascii?Q?PLU96NS1?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR12MB1677.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 272d6afd-14c0-4197-d5ea-08d8c36dad0a X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2021 09:18:29.3755 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 27PL6FlSg5RuDIO9XeVFfG27hm7u3jSkBi5IoegovwnU4KzociPXtEMoVS6FD4LIjpt3ZFgswPUTQfCR3hdiwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1278 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611825525; bh=RQEORcd2ZO9jYOtVISsquOtVUGt8TlzDdiCxBi+tsvc=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: x-ms-exchange-transport-forked:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=qkyIH1ooc+epPzCvgCrrNOepRvpIay9VryAJEy1OEo4hDrEIWc8XsmCO50m8z0HKo LPi7sYCzJmXNv4DClT9vymfrfj8FO4SQ9uFFOGiiDKf2OKvG/hlpVIzuyLZs6IteyM kVE4tm8UfFAFtyvl19eZyALWuMejFzza8WLO4hr+Hybl6kmjoHwk7LztBg1wwoKrYO 4i6AbtzAzcJH6JXOLwcx5SUVlDvVJbT4hluYcR7P+Z4Fm5TVi2qRKvFJi2v3YB0ex8 nGftsdfxsJChC5Nt8EBsUjxeUnT0+BPnJqdNVrKq+pEGBLSetw1Juuj7Rk1vcm/f0t cPHGhrhT8Tm/g== Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: fix setting maximum packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ferruh, > -----Original Message----- > From: Ferruh Yigit > Sent: Monday, January 25, 2021 8:16 PM > To: Wenzhuo Lu ; Xiaoyun Li > ; Bernard Iremonger > ; Steve Yang > Cc: Ferruh Yigit ; dev@dpdk.org; stable@dpdk.org; > lance.richardson@broadcom.com; oulijun@huawei.com; Wisam Monther > ; lihuisong@huawei.com > Subject: [PATCH v5] app/testpmd: fix setting maximum packet length >=20 > From: Steve Yang >=20 > "port config all max-pkt-len" command fails because it doesn't set the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag properly. >=20 > Commit in the fixes line moved the 'DEV_RX_OFFLOAD_JUMBO_FRAME' > offload flag update from 'cmd_config_max_pkt_len_parsed()' to > 'init_config()'. > 'init_config()' function is only called during testpmd startup, but the f= lag > status needs to be calculated whenever 'max_rx_pkt_len' changes. >=20 > The issue can be reproduce as [1], where the 'max-pkt-len' reduced and > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag should be cleared but it > didn't. >=20 > Adding the 'update_jumbo_frame_offload()' helper function to update > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag and 'max_rx_pkt_len'. This > function is called both by 'init_config()' and > 'cmd_config_max_pkt_len_parsed()'. >=20 > Default 'max-pkt-len' value set to zero, 'update_jumbo_frame_offload()' > updates it to "RTE_ETHER_MTU + PMD specific Ethernet overhead" when it is > zero. > If '--max-pkt-len=3DN' argument provided, it will be used instead. > And with each "port config all max-pkt-len" command, the > 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag, 'max-pkt-len' and MTU is > updated. >=20 > [1] > -------------------------------------------------------------------------= - > dpdk-testpmd -c 0xf -n 4 -- -i --max-pkt-len=3D9000 --tx-offloads=3D0x800= 0 > --rxq=3D4 --txq=3D4 --disable-rss > testpmd> set verbose 3 > testpmd> port stop all > testpmd> port config all max-pkt-len 1518 port start all >=20 > // Got fail error info without this patch Configuring Port 0 (socket 1) E= thdev > port_id=3D0 rx_queue_id=3D0, new added offloads 0x800 must be within per- > queue offload capabilities 0x0 in rte_eth_rx_queue_setup() Fail to config= ure > port 0 rx queues //<-- Fail error info; > -------------------------------------------------------------------------= - >=20 > Fixes: 761c4d66900f ("app/testpmd: fix max Rx packet length for VLAN > packets") > Cc: stable@dpdk.org >=20 > Signed-off-by: Steve Yang > Signed-off-by: Ferruh Yigit > --- >=20 > v5: > * 'update_jumbo_frame_offload()' helper updated > * check zero 'max-pkt-len' value > * Update how queue offload flags updated > * Update MTU if JUMBO_FRAME flag is not set > * Default testpmd 'max-pkt-len' value set to zero >=20 > Cc: lance.richardson@broadcom.com > Cc: oulijun@huawei.com > Cc: wisamm@mellanox.com > Cc: lihuisong@huawei.com > --- I think we need to have https://bugs.dpdk.org/show_bug.cgi?id=3D625 ID in t= he commit log as fix, In order to allow the scripts to close related bugs directly from Bugzilla. BRs, Wisam Jaddo