DPDK patches and discussions
 help / color / mirror / Atom feed
From: Wisam Monther <wisamm@nvidia.com>
To: Georgios Katsikas <katsikas.gp@gmail.com>
Cc: "wisamm@mellanox.com" <wisamm@mellanox.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches
Date: Wed, 4 Nov 2020 11:25:38 +0000
Message-ID: <MWHPR12MB1677FB607A697E19BCF723BBA4EF0@MWHPR12MB1677.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAN9HtFC474OEj3C=nZ-YT_fOnm4+cY9KXaFiFisGqfktiHRTPQ@mail.gmail.com>

I think Thomas can add it if he want to merge it in this version.

Moreover I think you need to keep the ack between versions and the person who acked before should comment if newer version not ok with him, otherwise he is ok with it. “Using git commit —amend”.

Thomas, correct me if I’m wrong, At least this how I understood the procedure here.

Moreover I noticed that you sending the versions as new patch all the time, but for history and comments tracking you should send with versions. V2-v3 ...etc with reply to older version of the patch.

Wisam Jaddo

Get Outlook for iOS<https://aka.ms/o0ukef>
From: Georgios Katsikas <katsikas.gp@gmail.com>
Sent: Wednesday, November 4, 2020 1:11:09 PM
To: Wisam Monther <wisamm@nvidia.com>
Cc: wisamm@mellanox.com <wisamm@mellanox.com>; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; dev@dpdk.org <dev@dpdk.org>
Subject: Re: [PATCH] app/flow-perf: configurable rule batches


Is what you are asking possible with a simple git commit --amend?


On Wed, Nov 4, 2020 at 10:04 AM Wisam Monther <wisamm@nvidia.com<mailto:wisamm@nvidia.com>> wrote:


You can add my ack:

Acked-by: Wisam Jaddo <wisamm@nvidia.com<mailto:wisamm@nvidia.com>>


Do you have comments left here?


Wisam Jaddo

From: Georgios Katsikas <katsikas.gp@gmail.com<mailto:katsikas.gp@gmail.com>>
Sent: Tuesday, November 3, 2020 1:26 PM
To: wisamm@mellanox.com<mailto:wisamm@mellanox.com>
Cc: dev@dpdk.org<mailto:dev@dpdk.org>
Subject: Re: [PATCH] app/flow-perf: configurable rule batches


Any news on this patch?

Is there anything else I could do?



  reply	other threads:[~2020-11-04 11:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-11 10:03 Georgios Katsikas
2020-11-03 11:26 ` Georgios Katsikas
2020-11-04  8:04   ` Wisam Monther
2020-11-04 11:11     ` Georgios Katsikas
2020-11-04 11:25       ` Wisam Monther [this message]
2020-11-04 20:46     ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2020-09-24  9:10 Georgios Katsikas
2020-09-24 12:01 ` Wisam Monther
2020-10-05 17:16   ` Georgios Katsikas
2020-10-05 22:25     ` Thomas Monjalon
2020-10-11 10:33       ` Georgios Katsikas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR12MB1677FB607A697E19BCF723BBA4EF0@MWHPR12MB1677.namprd12.prod.outlook.com \
    --to=wisamm@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=katsikas.gp@gmail.com \
    --cc=thomas@monjalon.net \
    --cc=wisamm@mellanox.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git