From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BFECA056B; Wed, 4 Mar 2020 06:47:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14CA01BFAE; Wed, 4 Mar 2020 06:47:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6FD162C02; Wed, 4 Mar 2020 06:47:51 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0245eI8x003590; Tue, 3 Mar 2020 21:47:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=XJgBpVmbMjKraFYCsG3nN0vAusESOa7B91kos9S4V1Y=; b=F1NQTvwWlLY7srOOSKVDduUd6gjXzdPvSq/ftsosS1CmXLybI+Ovj1HVS0z21k4wgdL1 gMEIGU5VCHDGfr5xAGY6GD+ArpNN/hlvHCgdMz0ghJKscvJSA6Md3w3GTxglIQMsbWqF l6H+teHVEhqBJeQc9ByR6IF0EHCU5qZU02CouSz72EQMmipzaNl23md5oGDRdfuZDb7Z J6cxfjGWBfsoKVBRKHWKa0ueoF6EwX/FX5eAjoKlYOPomiCUIWmqUJJtzVj9CBaD1xm6 86vP97zrsNDq9At6r6lwfIyKgmr3yiaMR1l1U9iJ4zgfsdITnSDplAouToVlD4pWeNpS Gw== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 2yhxw4acgd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 03 Mar 2020 21:47:50 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Mar 2020 21:47:48 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 3 Mar 2020 21:47:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YRmqdYLnoCyaWOs51xLfQxUdLZyYSAjTipo7a0w1mbffNN6dgMfFjYvTxbGbQzg+qM5smX4PlIjfgIwjwjbQ4I3w5DqlZibJvTzNY0EhFU6IjlUwSkrnCQcOT3zRzcvDijzJelZfbVLA4kWeY0AcgW4GdjZLLxkFDwHEN2nzrrithkGpT5dw2DDxLGWTE9GyVZvyUMWlIDTMyQLempPgXRSPYtno62eFDzk4CH2tCADDZ4z3souOtyhcq7Em62zzuLelHPGOpAHOrgSq+539MNti94T2nocuoWm8/AR/CcYrHlhwaKU4h6KYD4N18zi91DdqZxGeT4jcO0zOzx3Tnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XJgBpVmbMjKraFYCsG3nN0vAusESOa7B91kos9S4V1Y=; b=kVF8IBt6jcffjSXOiH0kPqu8LnC25mhz2ERXD1v5KminU5lqewheclMVwqe6YkO77j1SLXuk5RgmWSUcMwY3YWnFaVJ0p53S/rEfnWNmw86ZCDl4qPtnDfwJI5zQQuhGBFCPkCJuwTBJwoh+d+OLaf5by3VwAKFzGL4mQaQ2JLWnl6ReYzkFQAhsgaQm+RHb5IO2aTI08FltFrKad1UCVlxgyW/YCIxFrlF28Wuf8e6HbBwARFPHySSfeyahSEmCdeDCMu2okbOIYYcODW8daMKRe2zOvTbn6IDZMV6+cGFDdIAVqEC3cEHyUB+OBpQen8L4DkOBz9/goQadgOAbig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XJgBpVmbMjKraFYCsG3nN0vAusESOa7B91kos9S4V1Y=; b=Vdatr1bOoaaYJ2xQqggFEZiVSjMdfDHeSLZlwEvJe5PXScqSsSy7MfE4xFB0XAlE+JylhPramPJNGNgiaiOqTaDUz2rkBH4JaHaFntwI2x1bMcIwgPytnFU1/E1HctWuI2C3UgAt/AJOgL+9Ike4PWMYi8pTwSoAVVraccD8Fdk= Received: from MWHPR1801MB1934.namprd18.prod.outlook.com (2603:10b6:301:64::34) by MWHPR1801MB1935.namprd18.prod.outlook.com (2603:10b6:301:63::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.19; Wed, 4 Mar 2020 05:47:47 +0000 Received: from MWHPR1801MB1934.namprd18.prod.outlook.com ([fe80::55a:3c86:4065:da79]) by MWHPR1801MB1934.namprd18.prod.outlook.com ([fe80::55a:3c86:4065:da79%3]) with mapi id 15.20.2772.019; Wed, 4 Mar 2020 05:47:47 +0000 From: Amit Gupta To: Bruce Richardson CC: Harman Kalra , "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers Thread-Index: AQHV8FxVG/y/qXHeZkSxvje0XidVBqg1INGAgAEQmECAAIhogIABNkKw Date: Wed, 4 Mar 2020 05:47:47 +0000 Message-ID: References: <1581925669-15294-1-git-send-email-agupta3@marvell.com> <1583130716-28360-1-git-send-email-agupta3@marvell.com> <20200302105313.GA1603@bricha3-MOBL.ger.corp.intel.com> <20200303111705.GA1557@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200303111705.GA1557@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 49ae114e-cdbc-4929-55e6-08d7bfff9160 x-ms-traffictypediagnostic: MWHPR1801MB1935: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3513; x-forefront-prvs: 0332AACBC3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(136003)(396003)(366004)(376002)(189003)(199004)(71200400001)(33656002)(55016002)(76116006)(55236004)(6916009)(2906002)(86362001)(81166006)(64756008)(5660300002)(7696005)(66556008)(6506007)(53546011)(54906003)(66446008)(8936002)(66946007)(186003)(4326008)(316002)(52536014)(478600001)(9686003)(26005)(81156014)(66476007)(8676002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR1801MB1935; H:MWHPR1801MB1934.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a1s+ejB41XAV2Fhtnu5IxxkHxFwyaRZHqu5njYS+OLnFHWCoRmqTkvJ/e6jZLWNoeMoGQyO07JnQ7XhTNof9GrRM9Plzu2HVDziZUN/dzGtjBY2Mg+Cwxe+TdTTK1RTMirbzWYuhKSWx9UxOTGpITBK9B0aIILHGVBQA5kcbkWNhkP4JhY5ERMrlzV8sar3eQyvhcLKYDQKlZOfAm9mnMjxLgjlDfbkJ70XShyaKrXLC6TOvJ/236kK8OjZx1LFeWbTyFnS+uaFDyA0ebF4Rsi85FIw52bkhO0ZRod+klI7leKieWs8S03SBzFF2CAV7DvS7EdrKR4ENYwR+UaftpaOQ2DZcZSarQzk63zbc4Or4nLPndNevsEDR9w2mHJCYtFCpnmkMbzwo99Tl5QQsyNEqlzZatVeGFPTBl0nQeOKL8af6uks0+7cP2fH2ScTQ x-ms-exchange-antispam-messagedata: K6H+JKSxoT4YNAV3GJ67gavyZrwA04Yy2cyfmy3dqeJqduiRDqX01oNWUnaGDpd4pVAv0oUXpKXS4hr1tIIMGpTTbj/NHgoz01RS/pbphn7gXvusCKxCzNoyYKqSXi4ER1eYsPLptHjbxEkJ0IKYQg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 49ae114e-cdbc-4929-55e6-08d7bfff9160 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2020 05:47:47.0501 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: borNTs+GZAasgbK/A94kX8tqUq/J+/8JzGcEj9X0VGusjOqgg38FXEjBKqi2L+FlN8yqMbQtJUCc3SS4+rF5gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1801MB1935 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.572 definitions=2020-03-03_08:2020-03-03, 2020-03-03 signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/1] net/octeontx: fix meson build for disabled octeontx drivers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ACK > -----Original Message----- > From: Bruce Richardson > Sent: Tuesday, March 3, 2020 4:47 PM > To: Amit Gupta > Cc: Harman Kalra ; dev@dpdk.org; stable@dpdk.org > Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson > build for disabled octeontx drivers >=20 > On Tue, Mar 03, 2020 at 03:10:56AM +0000, Amit Gupta wrote: > > > > > -----Original Message----- > > > From: Bruce Richardson > > > Sent: Monday, March 2, 2020 4:23 PM > > > To: Amit Gupta > > > Cc: Harman Kalra ; dev@dpdk.org; > stable@dpdk.org > > > Subject: [EXT] Re: [dpdk-dev] [PATCH v2 1/1] net/octeontx: fix meson > > > build for disabled octeontx drivers > > > > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- On Mon, Mar 02, 2020 at 12:01:55PM +0530, agupta3@marvell.com > > > wrote: > > > > From: Amit Gupta > > > > > > > > Add a additional condition to check if all required internal > > > > dependencies are met before building octeontx drivers using meson. > > > > > > > > Bugzilla ID: 387 > > > > > > > > Fixes: 7f615033d64f ("drivers/net: build Cavium NIC PMDs with > > > > meson") > > > > > > > > Signed-off-by: Amit Gupta > > > > --- > > > > v2: > > > > - rebased to v20.02 > > > > - upstream comments incorporated. > > > > > > > > drivers/net/octeontx/base/meson.build | 6 +++++- > > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/octeontx/base/meson.build > > > > b/drivers/net/octeontx/base/meson.build > > > > index a06a2c8..035aeda 100644 > > > > --- a/drivers/net/octeontx/base/meson.build > > > > +++ b/drivers/net/octeontx/base/meson.build > > > > @@ -10,7 +10,11 @@ sources =3D [ > > > > depends =3D ['ethdev', 'mempool_octeontx'] static_objs =3D [] > > > > foreach > > > > d: depends > > > > - static_objs +=3D [get_variable('static_rte_' + d)] > > > > + test_dep_obj =3D '@0@'.format(get_variable('static_rte_' + d, '')= ) > > > > + if test_dep_obj =3D=3D '' > > > > + subdir_done() > > > > + endif > > > > + static_objs +=3D get_variable('static_rte_' + d) > > > > endforeach > > > > > > very minor nit - you can use "test_dep_obj" here rather than calling > > > get_variable twice. > > > > > test_dep_obj is being formatted as string object, so can't be used as s= tatic > obj.. >=20 > Apologies, you are quite right, I missed that. >=20 > One final suggestion - the "is_variable" function is probably want you wa= nt > rather than using get_variable with a fallback. It should save the use of= a > temporary variable completely. >=20 > /Bruce