From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8D8DA04CC; Mon, 21 Sep 2020 14:03:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EE741D921; Mon, 21 Sep 2020 14:03:11 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 9B24F1C1A2 for ; Mon, 21 Sep 2020 14:03:09 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08LC1VAp017639; Mon, 21 Sep 2020 05:03:08 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=wq3LLXgDbt0b1JZRaZHFPVLy+zp6XxHvyNf+CVLftdc=; b=EDwaU2C/B0s/PXGtx/Tbiz8UeqqbnQtuZTw0BSmEE3t0SItV/SEIMcdMQoPmhM/tuu1t WmENpZZcfaLZOAVeUPufurDPlZ1TaJWk33hdYrk0P780Iu9AgwizZCpS/zxbHBlxoqcN CmhnwcR+ZlUEu1ifs0/5IDpboXVvrPmGLc9DYXS4KhmB5JsuzQ+QeQ7A29b2uhlRolrY LQirAhZjPn2WlqnLIxx5MfDX+LwZRRrX124G8keETNeyahc1+RbLHlyjlQ5qCw/YdGkF iWDgcdceQrFJ51OjoAqeD3m4ly7wwNeQU5brEiUBFwyI3CKXV9QBo0W1ADFiZ/VOOh4W 9w== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 33nfbpntkh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 21 Sep 2020 05:03:08 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 21 Sep 2020 05:03:07 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 21 Sep 2020 05:03:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqgeIvxN7TkiJkv6UOtU5RvhpE4gNb3nWtZbq5A/w8jDbBDSpjfrLXhy2uLmrNVloWEjNiyFE58ZnxU9GwBoxGGmIMeiQCMldRBA7ScAiClTUf+m5Ltr80HthjRsKVmeyJwTWD5IyNnixy5uv1BEa+ufaSBNNLbRuhSnOVpQDHmCzuHC+WXSVpnle56bU6VjL2v95taJEeZulzddobKDqGTGK+h2y0LI0ID+KDhsr01G9HPkBvVRlbAXL7cQuPcCIzXeaLYBGpSXFv+tHkKr8qpEPgA7XsDrsgElJ/Aa957DiEbbWBWYv4Sd2h8MBm2v1lBBprHmc1o+htRFis2Zkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wq3LLXgDbt0b1JZRaZHFPVLy+zp6XxHvyNf+CVLftdc=; b=EGV0ihZn6qUxZb8crFVd0j2eFF4b9Y5CVMQnv2tOIrG3Yan9PrrqNg66oS1fTSjMZGKLB6vdnWCd5Ixi5RSfhgP5Y5QaIWw0wr7Z21QlUrIIriVjaHV3fVZuQ9jYbhD9Y06aPUADJYW/idgDLepX4PIoMRv6NK7sT03oCOyL4+p49Qmbpqnq1AUFaNCeF9C/ZisDFmLG0b4wBNHcyyfRyPTxN6sKn8fUqJF9ZLYRRB2SHuxq3MLEg/GoyM0r5DldufpSS3/bavIKSBcKnYOY2+ZdLWZUBbyZLaNSABlyUR3TFwd0cn7Ek+zzNnUf7a+H43nI7hKGym9fFk9gecOYKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wq3LLXgDbt0b1JZRaZHFPVLy+zp6XxHvyNf+CVLftdc=; b=GIj/VZplf3P6l8D4Wxn7ZhHb4r7K4Dnc/1uCWsjblv4KW01jgUgtoXXD2ykR+91dZhiMBDmPDgqgsRAPwyU2Mq6XCBwBrZYCimdJ/d0tAjbJF91+JKpV+F68MaxnxxPrpjrvRZq0gRtla0Qet6Yv/mg2M2w+e35JgzoS0su/jpY= Received: from MWHPR18MB1104.namprd18.prod.outlook.com (2603:10b6:300:a5::19) by MWHPR18MB1247.namprd18.prod.outlook.com (2603:10b6:320:2a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 12:03:06 +0000 Received: from MWHPR18MB1104.namprd18.prod.outlook.com ([fe80::2920:4b19:fd68:c93b]) by MWHPR18MB1104.namprd18.prod.outlook.com ([fe80::2920:4b19:fd68:c93b%7]) with mapi id 15.20.3391.011; Mon, 21 Sep 2020 12:03:06 +0000 From: Tejasree Kondoj To: Akhil Goyal , Radu Nicolau CC: Narayana Prasad Raju Athreya , Anoob Joseph , "dev@dpdk.org" Thread-Topic: [PATCH] security: allow application to specify UDP ports to PMD Thread-Index: AQHWgbXgQ5g3P7PGB0OK7dquBqyZHKliSGEAgBCUNGCAABO0gIAABN9A Date: Mon, 21 Sep 2020 12:03:06 +0000 Message-ID: References: <20200903064206.16208-1-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [49.206.51.234] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2bde403c-8af8-4e90-8bf1-08d85e264d04 x-ms-traffictypediagnostic: MWHPR18MB1247: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZptIK1zJAr9uKmt781zCKPaySpjw+hp2hwcCRX/ubBhhANwyVAdEw0FVqEZTcQPd4fxZeIVjp3us0Eu4hTvcue8jOupQFg/K5V8jdjYekfsS+pPmusqrPQTXIQLhOXn4hoAEZl4uzd3KXRgOYaZy0wxAU77H+2KPWZwNDe55bZpJ1PRiL3Q7VfF1yFYqYUlXLkxzwom8Ds7uk016i9jFv9JIEfeB770kBMsOBHQb/wqpYZh2vi4HuNdbCE0XJFaZNZEPyY2ZpuBSWSJQzZ67kOEUTzsbxVE2m53XL5X5vHT7iSlvmfX8Io/JExCeG3qcJFZchrxuIeauRM0u+4Ti4Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR18MB1104.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(136003)(39850400004)(366004)(376002)(9686003)(55016002)(2906002)(6506007)(86362001)(7696005)(66946007)(76116006)(53546011)(55236004)(71200400001)(66476007)(66556008)(54906003)(66446008)(64756008)(52536014)(5660300002)(4326008)(15650500001)(33656002)(316002)(8936002)(110136005)(83380400001)(8676002)(478600001)(186003)(26005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: RUMdI68rgYFNqHLvZ8vrbk0yuX2hWXgYsIsuZEoyUS0YvEhl/Xq6UogeH7Nk4KPzmXiDWbeyh2qBI7OJqZnUSVQCd3KS800l1IR0/TCD4nEc+2sVQo8+Bte0v2CVzfIN9di1mcqafr1x4cPxdR577XWL2Q4WoQCQYFYA7groDC/N4okT7W4CQNSag1oVV2LuYR9Cf8rIVqwf22NBG4IcMj0hMM7IoxP56YCrjLxGj3L9ZfRhj4QvFy42YBZ9/H4hHSAEGbGbxeobrWQBvUKv31oBl/be54Cx+hnS0uTnLamb8cK+RCzVbaKcccr/7xlQS7+bbNUY99r3vx6BnoFhbPIvKpjgHDOtP0UPtzvUroTOoI7oxlOZJYA8s1BZgtd6LUkTMs3twOOGQrqulFqyq38d1pQ5/nBCQMLDKVQtZsNt6HlURUjgItdaZug6IFd2TTGBMezGJ+98oR8o6n5KpYuXs5WTBZPGwukQ8h3W+4BYbXnnCry/pdJS/7HkigaxzjXlhfnOWvmEbgFrHLr3JO7VI2LySNA2JGtd0Ltv46gwg8VydCZXMrZ8RgxBplvQGw7zIuoDErN2IS3wo0KrXwabDGjnRyFJAtMGVb9FkzPrFWn9wwjlNgvSs/MJToqLWa2XGH/KtMCM4HKZL5MuLQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR18MB1104.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bde403c-8af8-4e90-8bf1-08d85e264d04 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 12:03:06.5077 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m/BorCeIU7kLsoapdlxoG/vkQmXLz1sHTK2+5lpR/Ng5wHZKr52TYaokc9Q+KZWNu9MlmWY3zk/u0l5/fL/05A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1247 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-21_03:2020-09-21, 2020-09-21 signatures=0 Subject: Re: [dpdk-dev] [PATCH] security: allow application to specify UDP ports to PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Please see inline. Thanks Tejasree > -----Original Message----- > From: Akhil Goyal > Sent: Monday, September 21, 2020 3:01 PM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH] security: allow application to specify UDP por= ts to > PMD >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Tejasree, >=20 > > > > Add UDP source and destination ports in ipsec_xform to allow > > > > application to specify ports to be used for IPsec UDP > > > > encapsulation as they are dynamically changed by NAT in between. > > > > Also adding an extra flag to indicate whether PMD needs to perform > > > > encapsulation header verification in case of inbound. In case of > > > > inline IPsec implementation, verification of outer IP headers and > > > > UDP encapsulation headers need to be handled in the PMD. For > > > > lookaside IPsec, application can optionally offload this to the PMD= . > > > > > > > > Signed-off-by: Tejasree Kondoj > > > > --- > > > > > > I think we should add some usage of these newly added params > > > - either in app/test or in examples/ipsec-secgw > > > > [Tejasree] You mean adding test case in either of the above apps or > > addition of PMD implementation also? Also is the proposal sounds fine? > > > I would say both, so that the newly added parameters are tested. > I am ok with the proposal with a minor comment, >=20 > We can have udp_src_port and udp_dst_port directly into > rte_security_ipsec_xform Instead of adding a new struct > rte_security_ipsec_udp_encapsulation. =20 [Tejasree] Okay. We'll defer the patch for now. Will add usage of the params and address the comment later. >=20 > Regards, > Akhil