From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1282CA0540; Thu, 16 Jul 2020 07:06:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC1DE1BEA1; Thu, 16 Jul 2020 07:06:01 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id E6C744F9A for ; Thu, 16 Jul 2020 07:05:59 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06G54xL4019630; Wed, 15 Jul 2020 22:05:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=pCQtXDcRMQdM+oRCRKUh1eBpdyiJot54Tbr1gOUDCJc=; b=rjXswcKvFBB7zGMziUT+VS0anfQW345QpcFonWeSZGPWTqk4mTCniM5FS9dvuWwOyoZM 57wPmXb4xBlvBU3rElGgkBSj3qCintqxu5NxmXCQd+fZnlZmVNUiD75O5hsdvAS7dW1H T7/JQDtWc9CAFnIE9/SJAWJ5uJSQpCGjyJbPcI2oTwh/HMpWaaxEF9IdoGhImQO7RVTq zIcfXjxOw/pl48y+u1seFLs1KluBHBOOOvR6iM8bezjx/6kcGYosPHtzM5WV+fiaJLZf uOE290c/tP15EOisyn2h8fwZKXs7CJQLAElhsHF2qkwUzRn9Jb5AHy4KeAbp5jQE3G6x Dw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 327asnmyr2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 15 Jul 2020 22:05:58 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 15 Jul 2020 22:05:58 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.59) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 15 Jul 2020 22:05:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YcFp00FzcZuXf0bblnn9rHbJUjytMrtspdG55A0He+TLweuZbc6DuLAb/N4tj4USDZumfM122lUcQRIkj5sCXbQE+3lo/Gan3scQ+0/GbQ2iyncLsVSUZ0Pu5DZjpvwuSuwysXcYwBeNpNmI60cAk0fw9grWNChOj7iKqEM6mjnOah+SdO3P+tzZ5e8ojOrSE9w6gz4mtD1sVa37x9sjFEEMiSOS/tgpP+jIUXvIWPskj4Colrgc8hgRdIcQexvuN1kb5vmdk5BND4/MdoclCTCCfnJCrVwtbwHoShguyryqfOgLc1dNTFgoEC7tpwjd5JpvmcSaqfycBMc645NdWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pCQtXDcRMQdM+oRCRKUh1eBpdyiJot54Tbr1gOUDCJc=; b=nCLOIZM3sQKRF5qoXwTbbXon6Ujmspd3yUn8RKjEcuzk1OlTWyZkgumle23tO1BqfBCKaBFZQRUTku0XeXYLTFmrTKDMyMS3spJav56MhYpRQrNOlJaRUw8fb5aP1Dk0bpLaQ8eYBec1QBkMW79xt5fSrcz9a606w5hGHa2sZNRsYBXImHJGYuczH6+p10UCY60y4fKSBp8gHetsvQkSOQY5dHo3WBo97FMu4HWxuQY/wtA4GHsqoObPqzO0HvYeiad/6rAACYb93nWAT+555Nj7oFPnRDN6FBRhTzfjb6dB4TZdPZFnC0NzQPw8kcdRGXCavsjyCxvr44Q90yMywQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pCQtXDcRMQdM+oRCRKUh1eBpdyiJot54Tbr1gOUDCJc=; b=u5VSsV0LcG+QIDVlh51tOVSGCXhY6LGPJKcA5G3i7qp1Qv5508npsvQSi6UeF8pL7Hth5f8vxBG8CVf0OQzE03W+q6rMuo4AroAbm0L1hwIe46bUCBhKOLdeSMCo6zoBtX5ynnKh0CrgMzQrcS4ROCUHoJZFf74QqwZQla3WbvQ= Received: from MWHPR18MB1104.namprd18.prod.outlook.com (2603:10b6:300:a5::19) by MW2PR18MB2332.namprd18.prod.outlook.com (2603:10b6:907:8::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Thu, 16 Jul 2020 05:05:56 +0000 Received: from MWHPR18MB1104.namprd18.prod.outlook.com ([fe80::9446:2219:19c8:7ac9]) by MWHPR18MB1104.namprd18.prod.outlook.com ([fe80::9446:2219:19c8:7ac9%9]) with mapi id 15.20.3174.026; Thu, 16 Jul 2020 05:05:56 +0000 From: Tejasree Kondoj To: Akhil Goyal , Radu Nicolau CC: Vamsi Krishna Attunuru , "Narayana Prasad Raju Athreya" , Anoob Joseph , "dev@dpdk.org" Thread-Topic: [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec dequeue routine Thread-Index: AQHWWoLDCJJAkvRzg0ePJJb+cIEbrakI4JqAgADE+zA= Date: Thu, 16 Jul 2020 05:05:56 +0000 Message-ID: References: <20200715092703.17936-1-ktejasree@marvell.com> <20200715092703.17936-10-ktejasree@marvell.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [124.123.31.236] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 63ee3733-f748-4e2e-d527-08d82945ec59 x-ms-traffictypediagnostic: MW2PR18MB2332: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v9XRCg06RZ3ZM65D53doX2chfLTgb2QxJeV44bVzyj1hjMDl1UQNWjf+2wvOjm/30sTl1iY0Qa97ZsNB77G8gr2InzEn9OAtv2Sce+irvugg74mGV8jQmtJAwp7bfzKC26sYq8oApuXliSscjn3dI8lT/Hh7RbTR2xHmNv3Kvf7Q2jfPWP3e0gcZkbiYmXYfm8GzXuxe9Q1WQnmKOlAzaXvmGaCJ4m8FdInpWnvs3oFPlSbHJw+2xEv63LyO0kgIJOeZjx5knvjRR0RVq1Bkg4VR3yIGNsdQZeiqlYL9tc6VnKZLI0TwHvlM9hm1kGfVXsx9J3DCCAJbC0FMAQ5Y5w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR18MB1104.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(376002)(136003)(346002)(396003)(9686003)(71200400001)(26005)(478600001)(53546011)(186003)(6506007)(7696005)(54906003)(110136005)(83380400001)(4326008)(66946007)(55016002)(316002)(5660300002)(52536014)(76116006)(8936002)(64756008)(8676002)(33656002)(66556008)(66446008)(86362001)(2906002)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: DB12i7PzeEyXysRkbVZrpeXHjKcFwnEVJw9Tu+Pn+EJ+yV6V66YLSSPTdkYXRMIJcPvLqRPOeDS61SuGbEjI8hpP6/i69DUP9ZkwVX6Q6kW7clRPKQcEZLrHOB3EMeF/FR0iiMEDshyNUK7nT8uCsJy79sy1pCMgcUpUbjNwNIwObkhTj7g58/LyVaWgjUjWUPyLTRKs2NSX3Bs+SdSNA3YUQPCPK22Lu2DIfd3HzwKkxbsIr8LakjtjxT7LLvJOFdSWjC03doOgR4mAII+y7sEtEbQoL+sBq+ddopH+Z+8LMj/XCbHKOVO9ncYoZLl+oNWw82En5VbeqQaYnbFIKKdhy/3gsWRMd9dpprL1SSXjhabJm/qQr/UprNtXA1lZI0G8E9/+1k/jC038pfPbB2VKTix0gqRtY07nEVASBRn+w+ajO5sOZreaCyFoS7LXoY9pcJ/ljhiwkX2EcZoY3zdUVSK5XA/lIy8oGPUtf895EnPtXonO1Ptbes1Srok2 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR18MB1104.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63ee3733-f748-4e2e-d527-08d82945ec59 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2020 05:05:56.5058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N2zh7SOgozl1TSaHgZmYhwmsdftW+gBPqQAtvYD+1a2Wc4IDOyQ4R6fnSslN3m2uXV4aeFxvIxdOrd5sT0+LRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR18MB2332 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-07-15_12:2020-07-15, 2020-07-15 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec dequeue routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Please see inline. Thanks Tejasree > -----Original Message----- > From: Akhil Goyal > Sent: Wednesday, July 15, 2020 10:40 PM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Vamsi Krishna Attunuru ; Narayana Prasad > Raju Athreya ; Anoob Joseph > ; dev@dpdk.org > Subject: [EXT] RE: [PATCH v2 9/9] crypto/octeontx2: add cryptodev sec > dequeue routine >=20 > External Email >=20 > ---------------------------------------------------------------------- > > From: Vamsi Attunuru > > > > This patch adds lookaside IPsec dequeue routine. > > > > Signed-off-by: Vamsi Attunuru > > Signed-off-by: Tejasree Kondoj > > --- >=20 > The patch can be squashed into the previous one. > As enqueue will not work without dequeue operation. [Tejasree] Will squash it with previous patch. >=20 > > doc/guides/cryptodevs/octeontx2.rst | 19 ++++++++++ > > doc/guides/rel_notes/release_20_08.rst | 5 +++ > > drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 37 > +++++++++++++++++++ > > drivers/crypto/octeontx2/otx2_ipsec_po.h | 30 +++++++++++++++ > > 4 files changed, 91 insertions(+) > > > > diff --git a/doc/guides/cryptodevs/octeontx2.rst > > b/doc/guides/cryptodevs/octeontx2.rst > > index 085d669e49..5d111e46c3 100644 > > --- a/doc/guides/cryptodevs/octeontx2.rst > > +++ b/doc/guides/cryptodevs/octeontx2.rst > > @@ -158,3 +158,22 @@ application: > > > > ./test > > RTE>>cryptodev_octeontx2_asym_autotest > > + > > + > > +Lookaside IPsec Support > > +----------------------- > > + > > +The OCTEON TX2 SoC can accelerate IPsec traffic in lookaside protocol > > +mode, with its **cryptographic accelerator (CPT)**. ``OCTEON TX2 > > +crypto PMD`` > > implements > > +this as an ``RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL`` > offload. > > + > > +Refer to :doc:`../prog_guide/rte_security` for more details on > > +protocol > > offloads. > > + > You can probably add here that the feature can be tested with ipsec-secgw > sample application [Tejasree] Sure >=20 > > + > > +Features supported > > +~~~~~~~~~~~~~~~~~~ > > + > > +* IPv4 > > +* ESP > > +* Tunnel mode > > +* AES-128/192/256-GCM > > diff --git a/doc/guides/rel_notes/release_20_08.rst > > b/doc/guides/rel_notes/release_20_08.rst > > index f19b748728..2d57adc283 100644 > > --- a/doc/guides/rel_notes/release_20_08.rst > > +++ b/doc/guides/rel_notes/release_20_08.rst > > @@ -225,6 +225,11 @@ New Features > > See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more > > details of this parameter usage. > > > > +* **Added lookaside IPsec support to OCTEON TX2 crypto PMD.** > > + > > + Added lookaside IPsec support to OCTEON TX2 crypto PMD. With this > > + feature, applications will be able to offload lookaside IPsec to the > hardware. > > + >=20 > Move this bullet as per the order described in this doc(below the new > features section). > And it would be better to re-phrase the statement as > * **Updated the OCTEON TX2 crypto PMD to support rte_security.** >=20 > Updated the OCTEON TX2 crypto PMD to support ``rte_security`` lookaside > protocol offload for IPsec. [Tejasree] Will move it and rephrase the statement. >=20 > > > > Removed Items > > ------------- > > diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > > b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > > index 6a2753eb22..9d51b17ddd 100644 > > --- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > > +++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c > > @@ -835,11 +835,48 @@ otx2_cpt_asym_post_process(struct > rte_crypto_op > > *cop, > > } > > } > > >=20 > >=20 > > + > > enum otx2_ipsec_po_comp_e { > > OTX2_IPSEC_PO_CC_SUCCESS =3D 0x00, > > OTX2_IPSEC_PO_CC_AUTH_UNSUPPORTED =3D 0xB0, > > OTX2_IPSEC_PO_CC_ENCRYPT_UNSUPPORTED =3D 0xB1, > > + OTX2_IPSEC_PO_CC_IP_VERSION =3D 0xB2, > > + OTX2_IPSEC_PO_CC_PROTOCOL =3D 0xB3, > > + OTX2_IPSEC_PO_CC_CTX_INVALID =3D 0xB4, > > + OTX2_IPSEC_PO_CC_CTX_DIR_MISMATCH =3D 0xB5, > > + OTX2_IPSEC_PO_CC_IP_PAYLOAD_TYPE =3D 0xB6, > > + OTX2_IPSEC_PO_CC_CTX_FLAG_MISMATCH =3D 0xB7, > > + OTX2_IPSEC_PO_CC_GRE_HDR_MISMATCH =3D 0xB8, > > + OTX2_IPSEC_PO_CC_GRE_PROTOCOL =3D 0xB9, > > + OTX2_IPSEC_PO_CC_CUSTOM_HDR_LEN =3D 0xBA, > > + OTX2_IPSEC_PO_CC_ENC_TYPE_CTR_GCM =3D 0xBB, > > + OTX2_IPSEC_PO_CC_IPCOMP_CONF =3D 0xBC, > > + OTX2_IPSEC_PO_CC_FREG_SIZE_CONF =3D 0xBD, > > + OTX2_IPSEC_PO_CC_SPI_MISMATCH =3D 0xBE, > > + OTX2_IPSEC_PO_CC_CHECKSUM =3D 0xBF, > > + OTX2_IPSEC_PO_CC_IPCOMP_PKT_DETECTED =3D 0xC0, > > + OTX2_IPSEC_PO_CC_TFC_PADDING_WITH_PREFRAG =3D 0xC1, > > + OTX2_IPSEC_PO_CC_DSIV_INCORRECT_PARAM =3D 0xC2, > > + OTX2_IPSEC_PO_CC_AUTH_MISMATCH =3D 0xC3, > > + OTX2_IPSEC_PO_CC_PADDING =3D 0xC4, > > + OTX2_IPSEC_PO_CC_DUMMY_PADDING =3D 0xC5, > > + OTX2_IPSEC_PO_CC_IPV6_EXT_HDRS_TOO_BIG =3D 0xC6, > > + OTX2_IPSEC_PO_CC_IPV6_HOP_BY_HOP =3D 0xC7, > > + OTX2_IPSEC_PO_CC_IPV6_RH_LENGTH =3D 0xC8, > > + OTX2_IPSEC_PO_CC_IPV6_OUTB_RH_COPY_ADDR =3D 0xC9, > > + OTX2_IPSEC_PO_CC_IPV6_DEC_RH_SEGS_LEFT =3D 0xCA, > > + OTX2_IPSEC_PO_CC_IPV6_HDR_INVALID =3D 0xCB, > > + OTX2_IPSEC_PO_CC_IPV6_SELECTOR_MATCH =3D 0xCC, > > + OTX2_IPSEC_PO_CC_IPV6_UDP_PAYLOAD_CSUM_MISMATCH =3D 0xCE, > > }; >=20 > Are these error codes? Are they added in the debug prints somewhere? [Tejasree] Yes, these are error codes but they are not used right now. Will= remove them. > > > > enum { > > -- > > 2.27.0