DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tejasree Kondoj <ktejasree@marvell.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>,
	 Radu Nicolau <radu.nicolau@intel.com>
Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>,
	"Narayana Prasad Raju Athreya" <pathreya@marvell.com>,
	Anoob Joseph <anoobj@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines
Date: Mon, 20 Jul 2020 17:20:53 +0000
Message-ID: <MWHPR18MB110496C2054C37D8306BAF59A87B0@MWHPR18MB1104.namprd18.prod.outlook.com> (raw)
In-Reply-To: <28abc4a0-5b62-941a-b22d-2039742c53d3@intel.com>

Hi Ferruh,

Please see inline.

Thanks
Tejasree

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Monday, July 20, 2020 5:33 PM
> To: Tejasree Kondoj <ktejasree@marvell.com>; Akhil Goyal
> <akhil.goyal@nxp.com>; Radu Nicolau <radu.nicolau@intel.com>
> Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>; Narayana Prasad
> Raju Athreya <pathreya@marvell.com>; Anoob Joseph
> <anoobj@marvell.com>; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 8/8] crypto/octeontx2: add
> cryptodev sec enqueue and dequeue routines
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 7/16/2020 9:39 AM, Tejasree Kondoj wrote:
> > From: Vamsi Attunuru <vattunuru@marvell.com>
> >
> > This patch adds lookaside IPsec enqueue and dequeue routines.
> >
> > Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
> > Signed-off-by: Tejasree Kondoj <ktejasree@marvell.com>
> 
> <...>
> 
> > @@ -33,6 +34,13 @@ struct otx2_cpt_vf {
> >  	/**< CPT device capabilities */
> >  };
> >
> > +struct cpt_meta_info {
> > +	uint64_t deq_op_info[4];
> > +	uint64_t comp_code_sz;
> > +	union cpt_res_s cpt_res __rte_aligned(16);
> > +	struct cpt_request_info cpt_req __rte_aligned(8); };
> 
> "struct cpt_request_info" already has cache size alignment
> (__rte_cache_aligned) [1].
> 
> Trying to align it to 8 bytes is reducing the alignment, gcc & clang seems
> silently ignoring this case but icc is giving a warning.
> 
> Since it is already ignored, and I assume the real intention is not to reduce
> the alignment, can you please remove the above "__rte_aligned(8)"?
[Tejasree] 'struct cpt_request_info' need not be cache aligned. It will need to be aligned 
to 8 bytes as used in this patch. Will replace __rte_cache_aligned of 'struct cpt_request_info' 
with __rte_aligned(8) and remove above __rte_aligned(8). Will submit separate patch 
as a fix and mention commit id of merged patch (fab634eb87ca) in fixes section.
Would that be fine?
> 
> 
> @Thomas, it is still good to have icc around to catch additional issues ;)
> 
> 
> [1]
> https://urldefense.proofpoint.com/v2/url?u=http-
> 3A__lxr.dpdk.org_dpdk_v20.05_source_drivers_common_cpt_cpt-
> 5Fcommon.h-
> 23L79&d=DwIDaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=NjpqGUAf6Xc0ZLzxCvv4i
> df8zRFeSJHioNlG1Wif1Gs&m=KNBzM9j6nc00ue4kkISJLVTLpkDGjg4A4dUjIVFz
> Rps&s=Q0RPHY0v3g5f0uOh9vv7SKb61aQuQB2RhCDLiOtLZ7s&e=

  reply	other threads:[~2020-07-20 17:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-16  8:39 [dpdk-dev] [PATCH v3 0/8] add OCTEON TX2 lookaside IPsec support Tejasree Kondoj
2020-07-16  8:13 ` Anoob Joseph
2020-07-16 16:32   ` Akhil Goyal
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 1/8] crypto/octeontx2: move capabilities initialization into probe Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 2/8] net/octeontx2: move otx2_sec_session struct to otx2_security.h Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 3/8] crypto/octeontx2: add lookaside SA context definitions Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 4/8] crypto/octeontx2: add cryptodev sec registration Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 5/8] crypto/octeontx2: add cryptodev sec capabilities Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 6/8] crypto/octeontx2: add cryptodev sec misc callbacks Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 7/8] crypto/octeontx2: add cryptodev sec session create Tejasree Kondoj
2020-07-16  8:39 ` [dpdk-dev] [PATCH v3 8/8] crypto/octeontx2: add cryptodev sec enqueue and dequeue routines Tejasree Kondoj
2020-07-20 12:02   ` Ferruh Yigit
2020-07-20 17:20     ` Tejasree Kondoj [this message]
2020-07-20 18:13       ` [dpdk-dev] [EXT] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR18MB110496C2054C37D8306BAF59A87B0@MWHPR18MB1104.namprd18.prod.outlook.com \
    --to=ktejasree@marvell.com \
    --cc=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pathreya@marvell.com \
    --cc=radu.nicolau@intel.com \
    --cc=thomas@monjalon.net \
    --cc=vattunuru@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git