DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@microsoft.com>
To: thomas <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	ranjit.menon <ranjit.menon@intel.com>,
	"Kadam, Pallavi" <pallavi.kadam@intel.com>,
	Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>,
	"navasile@linux.microsoft.com" <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, talshn <talshn@mellanox.com>,
	"bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	Omar Cardona <ocardona@microsoft.com>
Subject: Re: [dpdk-dev] [EXTERNAL] Re: Handling missing export functions in MSVC linkage
Date: Fri, 26 Mar 2021 14:14:33 +0000	[thread overview]
Message-ID: <MWHPR21MB157936FB3EAE968C2ECA4FFEC8619@MWHPR21MB1579.namprd21.prod.outlook.com> (raw)
In-Reply-To: <6178668.jC4cgjogLs@thomas>

Unless I misunderstood the last status of this issue was that it was desired empty stubs that fail at runtime as opposed to conditionally generating exports.

Is this no longer the case?

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Friday, March 26, 2021 1:40 AM
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>; ranjit.menon <ranjit.menon@intel.com>; Kadam, Pallavi <pallavi.kadam@intel.com>; Harini Ramakrishnan <Harini.Ramakrishnan@microsoft.com>; navasile@linux.microsoft.com; Dmitry Malloy <dmitrym@microsoft.com>
Cc: dev@dpdk.org; talshn <talshn@mellanox.com>; bruce.richardson@intel.com; David Marchand <david.marchand@redhat.com>; Tyler Retzlaff <roretzla@microsoft.com>; Omar Cardona <ocardona@microsoft.com>
Subject: [EXTERNAL] Re: [dpdk-dev] Handling missing export functions in MSVC linkage

08/06/2020 10:33, David Marchand:
> On Mon, Jun 8, 2020 at 2:09 AM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> > On Sun, 7 Jun 2020 12:26:56 +0000
> > If you create a .def manually, it will override the generation from 
> > .map. Of cause, this adds manual work and ideally all .def files should be generated.
> On this topic, I just noticed that a patch of mine, that removed
> rte_eal_get_configuration() from the stable ABI, missed the 
> declaration in rte_eal_exports.def.
> Probably worth adding a check in devtools/, to avoid further misalignment.

The .def file keeps being out of sync.
We need a script to avoid forgetting the sync, or/and we must generate this .def from the .map.
Ideally the full EAL API (except VFIO) should be implemented for Windows.

This situation is waiting for a solution for too much time.
Windows maintainers, please solve it.

  reply	other threads:[~2021-03-29  8:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07 12:26 [dpdk-dev] " Tal Shnaiderman
2020-06-08  0:09 ` Dmitry Kozlyuk
2020-06-08  8:33   ` David Marchand
2021-03-26  8:39     ` Thomas Monjalon
2021-03-26 14:14       ` Tyler Retzlaff [this message]
2020-06-08 15:06   ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MWHPR21MB157936FB3EAE968C2ECA4FFEC8619@MWHPR21MB1579.namprd21.prod.outlook.com \
    --to=roretzla@microsoft.com \
    --cc=Harini.Ramakrishnan@microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=ocardona@microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@mellanox.com \
    --cc=thomas@monjalon.net \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).