From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1.zte.com.cn (out1.zte.com.cn [202.103.147.172]) by dpdk.org (Postfix) with ESMTP id 0139F10E22 for ; Fri, 23 Dec 2016 12:15:25 +0100 (CET) X-MAILFROM: X-RCPTTO: X-FROMIP: 10.30.3.20 X-SEG-Scaned: 1 X-Received: unknown,10.30.3.20,20161223190952 Received: from unknown (HELO mse01.zte.com.cn) (10.30.3.20) by localhost with (AES256-SHA encrypted) SMTP; 23 Dec 2016 11:09:52 -0000 Received: from notes_smtp.zte.com.cn ([10.30.1.239]) by mse01.zte.com.cn with ESMTP id uBNBF0lE091445; Fri, 23 Dec 2016 19:15:00 +0800 (GMT-8) (envelope-from wang.yong19@zte.com.cn) To: yuanhan.liu@linux.intel.com Cc: dev@dpdk.org MIME-Version: 1.0 X-KeepSent: 1A741D7D:89D6A688-48258092:003D8C87; type=4; name=$KeepSent X-Mailer: Lotus Notes Release 8.5.3 September 15, 2011 Message-ID: From: wang.yong19@zte.com.cn Date: Fri, 23 Dec 2016 19:15:12 +0800 X-MIMETrack: Serialize by Router on notes_smtp/zte_ltd(Release 8.5.3FP6|November 21, 2013) at 2016-12-23 19:15:00, Serialize complete at 2016-12-23 19:15:00 X-MAIL: mse01.zte.com.cn uBNBF0lE091445 X-HQIP: 127.0.0.1 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] examples/vhost: how to use vhost-switch between VMs? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 11:15:28 -0000 RGVhciBNci4gTGl1LA0KICBUaGVyZSBhcmUgc29tZSBkZXNjcmlwdGlvbnMgaW4gDQpkcGRrLTE2 LjExXGRvY1xndWlkZXNcc2FtcGxlX2FwcF91Z1x2aG9zdC5yc3QsDQoiVGhlIHNhbXBsZSBhcHBs aWNhdGlvbiBwZXJmb3JtcyBzaW1wbGUgcGFja2V0IHN3aXRjaGluZyBiZXR3ZWVuIHZpcnR1YWwg DQptYWNoaW5lcyBiYXNlZCBvbiBNZWRpYSBBY2Nlc3MgQ29udHJvbCAoTUFDKSBhZGRyZXNzIG9y IFZpcnR1YWwgTG9jYWwgQXJlYSANCg0KTmV0d29yayAoVkxBTikgdGFnLiIgU28sIHdlIHJ1bm5l ZCB0aGUgdmhvc3Qtc3dpdGNoIHNhbXBsZSBpbiBhIFZNIHdpdGggDQp0aHJlZQ0KdmlydGlvIHBv cnRzLiBGaXJzdCwgd2UgYmluZGVkIG9uZSB2aXJ0aW8gcG9ydCB0byBpZ2JfdWlvLiBUaGVuIHdl IHJ1bm5lZCANCnRoZSBjb21tYW5kDQoiLi92aG9zdC1zd2l0Y2ggLWMgZiAtbiA0IC0tc29ja2V0 LW1lbSAxMDI0IC0tIC0tc29ja2V0LWZpbGUgL3RtcC9zb2NrMCANCqhDLXZtMnZtIDEgqEMtZGVx dWV1ZS16ZXJvLWNvcHkiDQpBbmQgdGhlbiBlcnJvciBvY2N1cmVkLiBXZSBmb3VuZCB0aGF0IHRo ZSAnZGV2X2luZm8ubWF4X3ZtZHFfcG9vbHMnIG9mIHRoZSANCnZpcnRpbw0KcG9ydCB3YXMgMCwg YW5kIGRpdmlzaW9uIGJ5IHplcm8gZXJyb3Igb2NjdXJlZCBhdCB0aGUgc3RhdGVtZW50IA0KJ3F1 ZXVlc19wZXJfcG9vbCA9IGRldl9pbmZvLnZtZHFfcXVldWVfbnVtIC8gZGV2X2luZm8ubWF4X3Zt ZHFfcG9vbHM7Jw0KV2UgZml4ZWQgdGhpcyBieSBhc3NpZ25pbmcgJ3F1ZXVlc19wZXJfcG9vbCcg dG8gMCBpZiANCidkZXZfaW5mby5tYXhfdm1kcV9wb29scycNCndhcyAwLCBidXQgdGhlcmUgd2Vy ZSBzdGlsbCBvdGhlciBlcnJvcnMgd2hlbiBydW5uaW5nIHZob3N0LXN3aXRjaC4gDQogIFNvLCB3 ZSBkb3VidGVkIHdoZXRoZXIgd2UgdXNlIHRoZSB2aG9zdC1zd2l0Y2ggaW4gYSB3cm9uZyB3YXku IENvdWxkIHlvdQ0KcGxlYXNlIGdpdmUgdXMgc29tZSBhZHZpY2UgdGhhdCBob3cgdG8gdXNlIHRo ZSB2aG9zdC1zd2l0Y2ggYmV0d2VlbiB0d28gb3IgDQptb3JlDQogVk1zPw0KICBJIGxvb2sgZm9y d2FyZCB0byBoZWFyaW5nIGZyb20geW91Lg0KDQogWW91cnMgZmFpdGhmdWxseSwNCiBZb25nIFdh bmcNCg== >From jblunck@gmail.com Fri Dec 23 12:27:06 2016 Return-Path: Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com [74.125.82.65]) by dpdk.org (Postfix) with ESMTP id D238C10E22 for ; Fri, 23 Dec 2016 12:27:06 +0100 (CET) Received: by mail-wm0-f65.google.com with SMTP id c85so2904051wmi.1 for ; Fri, 23 Dec 2016 03:27:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8BJlSTdTeU3oH1HZcciJ/byTJiZ1FkrknIk4+/nDzvY=; b=JAeMPUIKmBUSfRgCyaP9dCGl5MZ4W9ZY7OAZiDq1xoCG6ZTC43Vm0GDOUmWU8DDcjT pZjyso4OsUsz5C+Vgzi/6ezscr2EzCFexRmc2GLCpzSt/VgUePAvWnum2JMCFlGTG5nx 4AoJ0GlC/OA3nVht6SxwsattSFY/XY2Ll7GoJ9hnq4Ym5TlFAXc3MaAoyvg+T5sNS8yu /h1+U1H7qG5fLgIJc7nbQNXm7xRJoob7ZmJK9NAzvhnCbVu7I6uyhSPL9JucZW3W6lIh Jj2RAzq9iSWl4hFDAEzvsKDJHl0Y2zgWaFbdCKQQfLjNaV9iaIB/uUJxWkAbgqkdIM3V VOfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8BJlSTdTeU3oH1HZcciJ/byTJiZ1FkrknIk4+/nDzvY=; b=WPGbO/A9k5zfY9FPjNPkW276VK6DGnvIgAyrVuqXdUG5yCUU6X/YSavKnQe6duC4HU ++xbz5z3osujpqYNFSU19vcuGl+LHYI/7v0EoujYOAjJXrKBXkGsmEJgvDBxx7k+RCDz y22BFeDVT5dNDnQL6HG4Pp/umsLuOY9XUl8HYMlJlQ5rLRhB++Mzp6ZhX1dIPrrteXMg c7nr1PE//XTIuJw1uGRCPs2QH3sdTGgYyVvXeixo/0ynsqOHudWh7Qrh7jjqiT+MTTYo JPg8EmiE/6iUc7dkeF8UJIGAZ4iwAMfWXENr0MZLq6zplubYQqVcbzcHvPN9+KRuqqEK rLdA== X-Gm-Message-State: AIkVDXJoUOaimCZ5ALuv0oYJgbDNSrb6kHQjXp+yLEJtBjwbxDnQR8HPuVPyg5PKUqnBwjVSRihIri2VkWY1qA== X-Received: by 10.28.8.202 with SMTP id 193mr12904637wmi.101.1482492426532; Fri, 23 Dec 2016 03:27:06 -0800 (PST) MIME-Version: 1.0 Sender: jblunck@gmail.com Received: by 10.28.63.83 with HTTP; Fri, 23 Dec 2016 03:27:05 -0800 (PST) In-Reply-To: References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482332986-7599-22-git-send-email-jblunck@infradead.org> <20161221120953.0282b531@xeon-e3> From: Jan Blunck Date: Fri, 23 Dec 2016 12:27:05 +0100 X-Google-Sender-Auth: ZUjLhpgjVTViNoI2f6KVZiEFjUc Message-ID: To: Shreyansh Jain Cc: Stephen Hemminger , dev@dpdk.org, David Marchand Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v4 21/23] ethdev: Move filling of rte_eth_dev_info->pci_dev to dev_infos_get() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2016 11:27:07 -0000 On Fri, Dec 23, 2016 at 12:11 PM, Shreyansh Jain wrote: > On Friday 23 December 2016 04:20 PM, Jan Blunck wrote: >> >> On Thu, Dec 22, 2016 at 9:11 AM, Shreyansh Jain >> wrote: >>> >>> On Thursday 22 December 2016 01:39 AM, Stephen Hemminger wrote: >>>> >>>> >>>> On Wed, 21 Dec 2016 16:09:44 +0100 >>>> Jan Blunck wrote: >>>> >>>>> Only the device itself can decide its PCI or not. >>>>> >>>>> Signed-off-by: Jan Blunck >>>>> Acked-by: Shreyansh Jain >>>>> --- >>>> >>>> >>>> >>>> I would still like to kill dev_pci from the dev_info API. >>>> >> >> I'm fine with that too. >> >>> >>> +1. It should be rte_dev reference instead. >>> >> >> Only if you can give use-cases for what users should be able to do >> with it. If that is the case we need to clearly define what that >> means. Do we want to enable users to control the low-level EAL device >> directly and shortcut the ethdev driver? If that is necessary we need >> to give control to the driver first to decide if it is safe to do so. >> > > An ethernet device is not necessarily a PCI device. With planned removal of > rte_pci_device from rte_eth_device, this will be realized. > Similarly, the info is also not PCI device specific. > > With the '+1', my intention was not to say we should do it in this patch. We > should prepare eth_dev_info in similar manner as done for pci_dev of > rte_eth_dev (ETH_DEV_PCI_DEV() style macro, or inline). Which is exactly what this patch is doing. I'm moving the filling of the PCI information out of the generic code because only the driver could know if it is actually handling a PCI device. The generic code can not use the ETH_DEV_PCI_DEV() macro in a safe manner. > And now for whether we should expose lower level device details or not, I > was of the view that keeping pci_dev linked to this structure exposes more > lower level info than keeping rte_dev. Another view point could be to > completely do away with pci_info within eth_dev_info - but, I am not sure of > dependencies on it. If I understand Stephen correctly he questions the benefit of pushing down the code to the drivers instead of killing that code completely. I'll see what I can do here.