From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 0A7671B148 for ; Wed, 10 Apr 2019 19:13:37 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3AH4n10024925 for ; Wed, 10 Apr 2019 13:13:37 -0400 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [192.155.248.90]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rsmj18hmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Apr 2019 13:13:36 -0400 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Wed, 10 Apr 2019 17:13:35 -0000 Received: from us1a3-smtp06.a3.dal06.isc4sb.com (10.146.103.243) by smtp.notes.na.collabserv.com (10.106.227.141) with smtp.notes.na.collabserv.com ESMTP; Wed, 10 Apr 2019 17:13:31 -0000 Received: from us1a3-mail93.a3.dal06.isc4sb.com ([10.146.21.248]) by us1a3-smtp06.a3.dal06.isc4sb.com with ESMTP id 2019041017133105-828862 ; Wed, 10 Apr 2019 17:13:31 +0000 MIME-Version: 1.0 In-Reply-To: <3802339.Lkezi3CoX2@xps> To: Thomas Monjalon Cc: dev@dpdk.org From: "Vivian Kong" Date: Wed, 10 Apr 2019 13:10:45 -0400 References: <20190409190630.31975-1-vivkong@ca.ibm.com> <20190409190630.31975-11-vivkong@ca.ibm.com> <3802339.Lkezi3CoX2@xps> X-KeepSent: 7D1EF614:CF2D5ABB-852583D8:005E4FD6; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1EXT SHF993 September 20, 2018 X-LLNOutbound: False X-Disclaimed: 4595 X-TNEFEvaluated: 1 x-cbid: 19041017-9717-0000-0000-00000BBE0307 X-IBM-SpamModules-Scores: BY=0; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.417846; ST=0; TS=0; UL=0; ISC=; MB=0.000000 X-IBM-SpamModules-Versions: BY=3.00010903; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01187147; UDB=6.00621813; IPR=6.00967910; BA=6.00006280; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00026379; XFM=3.00000015; UTC=2019-04-10 17:13:34 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2019-04-10 17:00:35 - 6.00009787 x-cbparentid: 19041017-9718-0000-0000-000050EF3A72 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-10_08:, , signatures=0 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Apr 2019 17:13:38 -0000 Hmm...we weren't able to compile without the cast. I'll take a closer look. Thanks. Regards, Vivian Kong Linux on IBM Z Open Source Ecosystem IBM Canada Toronto Lab Thomas Monjalon wrote on 2019/04/09 04:14:08 PM: > From: Thomas Monjalon > To: vivkong@ca.ibm.com > Cc: dev@dpdk.org > Date: 2019/04/09 04:14 PM > Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus=5Fdevice > > 09/04/2019 21:06, Vivian Kong: > > Signed-off-by: Vivian Kong > > --- > > static inline int > > eth=5Fdev=5Fpci=5Fspecific=5Finit(struct rte=5Feth=5Fdev *eth=5Fdev, v= oid *bus=5Fdevice) { > > - struct rte=5Fpci=5Fdevice *pci=5Fdev =3D bus=5Fdevice; > > + struct rte=5Fpci=5Fdevice *pci=5Fdev =3D (struct rte=5Fpci=5Fdevice= *) bus=5Fdevice; > > Why do we need such cast? > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A7D1BA0096 for ; Wed, 10 Apr 2019 19:13:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 495661B14C; Wed, 10 Apr 2019 19:13:39 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 0A7671B148 for ; Wed, 10 Apr 2019 19:13:37 +0200 (CEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3AH4n10024925 for ; Wed, 10 Apr 2019 13:13:37 -0400 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [192.155.248.90]) by mx0a-001b2d01.pphosted.com with ESMTP id 2rsmj18hmm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Apr 2019 13:13:36 -0400 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Wed, 10 Apr 2019 17:13:35 -0000 Received: from us1a3-smtp06.a3.dal06.isc4sb.com (10.146.103.243) by smtp.notes.na.collabserv.com (10.106.227.141) with smtp.notes.na.collabserv.com ESMTP; Wed, 10 Apr 2019 17:13:31 -0000 Received: from us1a3-mail93.a3.dal06.isc4sb.com ([10.146.21.248]) by us1a3-smtp06.a3.dal06.isc4sb.com with ESMTP id 2019041017133105-828862 ; Wed, 10 Apr 2019 17:13:31 +0000 MIME-Version: 1.0 In-Reply-To: <3802339.Lkezi3CoX2@xps> To: Thomas Monjalon Cc: dev@dpdk.org From: "Vivian Kong" Date: Wed, 10 Apr 2019 13:10:45 -0400 References: <20190409190630.31975-1-vivkong@ca.ibm.com> <20190409190630.31975-11-vivkong@ca.ibm.com> <3802339.Lkezi3CoX2@xps> X-KeepSent: 7D1EF614:CF2D5ABB-852583D8:005E4FD6; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1EXT SHF993 September 20, 2018 X-LLNOutbound: False X-Disclaimed: 4595 X-TNEFEvaluated: 1 x-cbid: 19041017-9717-0000-0000-00000BBE0307 X-IBM-SpamModules-Scores: BY=0; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.417846; ST=0; TS=0; UL=0; ISC=; MB=0.000000 X-IBM-SpamModules-Versions: BY=3.00010903; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000284; SDB=6.01187147; UDB=6.00621813; IPR=6.00967910; BA=6.00006280; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00026379; XFM=3.00000015; UTC=2019-04-10 17:13:34 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2019-04-10 17:00:35 - 6.00009787 x-cbparentid: 19041017-9718-0000-0000-000050EF3A72 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-10_08:, , signatures=0 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus_device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190410171045.nahxulybZZpMGYA5b2_j0OOG6ZZrDlRq_HeFRTXqQGI@z> Hmm...we weren't able to compile without the cast. I'll take a closer look. Thanks. Regards, Vivian Kong Linux on IBM Z Open Source Ecosystem IBM Canada Toronto Lab Thomas Monjalon wrote on 2019/04/09 04:14:08 PM: > From: Thomas Monjalon > To: vivkong@ca.ibm.com > Cc: dev@dpdk.org > Date: 2019/04/09 04:14 PM > Subject: Re: [dpdk-dev] [RFC 10/12] ethdev: add cast for bus=5Fdevice > > 09/04/2019 21:06, Vivian Kong: > > Signed-off-by: Vivian Kong > > --- > > static inline int > > eth=5Fdev=5Fpci=5Fspecific=5Finit(struct rte=5Feth=5Fdev *eth=5Fdev, v= oid *bus=5Fdevice) { > > - struct rte=5Fpci=5Fdevice *pci=5Fdev =3D bus=5Fdevice; > > + struct rte=5Fpci=5Fdevice *pci=5Fdev =3D (struct rte=5Fpci=5Fdevice= *) bus=5Fdevice; > > Why do we need such cast? > >