From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id E845B1B2C0 for ; Wed, 8 Nov 2017 12:52:03 +0100 (CET) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id vA8BjHx8163137 for ; Wed, 8 Nov 2017 06:52:03 -0500 Received: from smtp.notes.na.collabserv.com (smtp.notes.na.collabserv.com [192.155.248.75]) by mx0b-001b2d01.pphosted.com with ESMTP id 2e40grjwvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 08 Nov 2017 06:52:02 -0500 Received: from localhost by smtp.notes.na.collabserv.com with smtp.notes.na.collabserv.com ESMTP for from ; Wed, 8 Nov 2017 11:52:01 -0000 Received: from us1a3-smtp08.a3.dal06.isc4sb.com (10.146.103.57) by smtp.notes.na.collabserv.com (10.106.227.123) with smtp.notes.na.collabserv.com ESMTP; Wed, 8 Nov 2017 11:51:41 -0000 Received: from us1a3-mail173.a3.dal06.isc4sb.com ([10.146.71.126]) by us1a3-smtp08.a3.dal06.isc4sb.com with ESMTP id 2017110811514088-403560 ; Wed, 8 Nov 2017 11:51:40 +0000 MIME-Version: 1.0 In-Reply-To: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> To: "Burakov, Anatoly" Cc: dev@dpdk.org, jianfeng.tan@intel.com, Thomas Monjalon From: "Jonas Pfefferle1" Date: Wed, 8 Nov 2017 12:51:39 +0100 References: <1509440909-8068-1-git-send-email-jpf@zurich.ibm.com> <10656029.OGFJoE0f1c@xps> <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com> X-KeepSent: 9529F1CA:346AEF91-C12581D2:0040F9B7; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1 October 14, 2013 X-LLNOutbound: False X-Disclaimed: 31767 X-TNEFEvaluated: 1 x-cbid: 17110811-3815-0000-0000-0000034A0176 X-IBM-SpamModules-Scores: BY=0; FL=0; FP=0; FZ=0; HX=0; KW=0; PH=0; SC=0.417846; ST=0; TS=0; UL=0; ISC=; MB=0.055468 X-IBM-SpamModules-Versions: BY=3.00008031; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000239; SDB=6.00942881; UDB=6.00475666; IPR=6.00723169; BA=6.00005678; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00017909; XFM=3.00000015; UTC=2017-11-08 11:52:00 X-IBM-AV-DETECTION: SAVI=unsuspicious REMOTE=unsuspicious XFE=unused X-IBM-AV-VERSION: SAVI=2017-11-08 11:39:23 - 6.00007583 x-cbparentid: 17110811-3816-0000-0000-0000A8D30054 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-11-08_02:, , signatures=0 X-Proofpoint-Spam-Reason: safe Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Nov 2017 11:52:04 -0000 "Burakov, Anatoly" wrote on 11/07/2017 02:54:24 PM: > From: "Burakov, Anatoly" > To: Thomas Monjalon > Cc: dev@dpdk.org, Jonas Pfefferle , jianfeng.tan@intel.com > Date: 11/07/2017 02:54 PM > Subject: Re: [dpdk-dev] [PATCH] mem: warn if address hint is not respected > > On 06-Nov-17 8:26 PM, Thomas Monjalon wrote: > > 31/10/2017 10:08, Jonas Pfefferle: > >> Print a warning if the --base-virtaddr hint is not respected > >> since this might lead to problems when mapping memory in > >> the secondary process. > >> > >> Signed-off-by: Jonas Pfefferle > > > > Anatoly, please review this patch. > > It does not seem to fix something, so it is candidate for 18.02. > > > > For some reason my Thunderbird ate the original email, so i'll reply to > this one. > > One nitpick would be that we're calling get=5Fvirtual=5Farea many times a= nd > it would probably be a good idea to make pagesize static and call > sysconf only once. Otherwise, We should address this in a separate patch and introduce a pagesize function for everyone to use. sysconf is used like this all over the place. > > Acked-by: Anatoly Burakov > > -- > Thanks, > Anatoly >