From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) by dpdk.org (Postfix) with ESMTP id AE6178B0B for ; Sun, 12 Oct 2014 11:08:24 +0200 (CEST) Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 12 Oct 2014 19:15:55 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp05.au.ibm.com (202.81.31.211) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 12 Oct 2014 19:15:53 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id BDA892CE8040 for ; Sun, 12 Oct 2014 20:15:52 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9C9HtPt32702692 for ; Sun, 12 Oct 2014 20:17:55 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9C9Fqi7014233 for ; Sun, 12 Oct 2014 20:15:52 +1100 Received: from d23ml028.cn.ibm.com (d23ml028.cn.ibm.com [9.119.32.184]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s9C9FiGM014205; Sun, 12 Oct 2014 20:15:52 +1100 In-Reply-To: <54330D9A.3080003@tilera.com> References: <1411724018-7738-1-git-send-email-bjzhuc@cn.ibm.com> <54330D9A.3080003@tilera.com> To: Cyril Chemparathy MIME-Version: 1.0 X-KeepSent: AC58F6F8:97F451C4-48257D6F:0032AE99; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1SHF211 December 19, 2013 Message-ID: From: Chao CH Zhu Date: Sun, 12 Oct 2014 17:14:37 +0800 X-MIMETrack: Serialize by Router on d23ml028/23/M/IBM(Release 8.5.3FP6HF485 | May 7, 2014) at 10/12/2014 17:14:47, Serialize complete at 10/12/2014 17:14:47 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14101209-0017-0000-0000-000000539A5F Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/7] Patches to split architecture specific operations from DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2014 09:08:25 -0000 Q3lyaWwsDQoNClRoYW5rcyBmb3IgeW91ciBjb21tZW50cyEgWW91IGFyZSByaWdodC4gU1NFIG5l ZWRzIHRvIGJlIHNwbGl0ZWQuIFRoZSANCmN1cnJlbnQgc3BsaXQgaXMgbm90IGEgY29tcGxldGVk IG9uZS4gSSdsbCBjb250aW51ZSB0byBjb250cmlidXRlLg0KDQpCZXN0IFJlZ2FyZHMhDQotLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCkNoYW8gWmh1ICjXo7OsKQ0KUmVzZWFyY2ggU3Rh ZmYgTWVtYmVyDQpDbG91ZCBJbmZyYXN0cnVjdHVyZSBhbmQgVGVjaG5vbG9neSBHcm91cA0KSUJN IENoaW5hIFJlc2VhcmNoIExhYg0KQnVpbGRpbmcgMTkgWmhvbmdndWFuY3VuIFNvZnR3YXJlIFBh cmsNCjggRG9uZ2JlaXdhbmcgV2VzdCBSb2FkLCBIYWlkaWFuIERpc3RyaWN0LA0KQmVpamluZywg UFJDLiAxMDAxOTMNClRlbDogKzg2LTEwLTU4NzQ4NzExDQpFbWFpbDogYmp6aHVjQGNuLmlibS5j b20NCg0KDQoNCg0KRnJvbTogICBDeXJpbCBDaGVtcGFyYXRoeSA8Y2NoZW1wYXJhdGh5QHRpbGVy YS5jb20+DQpUbzogICAgIENoYW8gQ0ggWmh1L0NoaW5hL0lCTUBJQk1DTiwgPGRldkBkcGRrLm9y Zz4NCkRhdGU6ICAgMjAxNC8xMC8wNyAwNTozOQ0KU3ViamVjdDogICAgICAgIFJlOiBbZHBkay1k ZXZdIFtQQVRDSCAwLzddIFBhdGNoZXMgdG8gc3BsaXQgYXJjaGl0ZWN0dXJlIA0Kc3BlY2lmaWMg b3BlcmF0aW9ucyBmcm9tIERQREsNCg0KDQoNCk9uIDkvMjYvMjAxNCAyOjMzIEFNLCBDaGFvIFpo dSB3cm90ZToNCj4gVGhlIHNldCBvZiBwYXRjaGVzIHNwbGl0IHg4NiBhcmNoaXRlY3R1cmUgc3Bl Y2lmaWMgb3BlcmF0aW9ucyBmcm9tIERQREsgDQphbmQgcHV0IHRoZW0gdG8gdGhlDQo+IGFyY2gg ZGlyZWN0b3JpZXMgb2YgaTY4NiBhbmQgeDg2XzY0IGFyY2hpdGVjdHVyZS4gVGhpcyB3aWxsIG1h a2UgdGhlIA0KYWRwb3Rpb24gb2YgRFBESyBtdWNoIGVhc2llcg0KPiBvbiBvdGhlciBjb21wdXRl ciBhcmNoaXRlY3R1cmUuIEZvciBhIG5ldyBhcmNoaXRlY3R1cmUsIGp1c3QgYWRkIGFuIA0KYXJj aGl0ZWN0dXJlIHNwZWNpZmljDQo+IGRpcmVjdG9yeSBhbmQgbmVjZXNzYXJ5IGJ1aWxkaW5nIGNv bmZpZ3VyYXRpb24gZmlsZXMsIHRoZW4gRFBESyBjYW4gDQpzdXBwb3J0IGl0Lg0KDQpXb3VsZG4n dCB0aGUgU1NFIHNwZWNpZmljcyBpbiBydGVfY29tbW9uLmggYW5kIHJ0ZV9jb21tb25fdmVjdC5o IG5lZWQgdG8gDQpiZSBzaW1pbGFybHkgc3BsaXQgb3V0IGludG8gYXJjaGl0ZWN0dXJlIHNwZWNp Zmljcz8NCg0KVGhhbmtzDQotLSBDeXJpbC4NCg0KDQoNCg== >From bjzhuc@cn.ibm.com Sun Oct 12 11:33:38 2014 Return-Path: Received: from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145]) by dpdk.org (Postfix) with ESMTP id 3B4678B11 for ; Sun, 12 Oct 2014 11:33:36 +0200 (CEST) Received: from /spool/local by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 12 Oct 2014 19:41:08 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp03.au.ibm.com (202.81.31.209) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 12 Oct 2014 19:41:07 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id A91FD3578047 for ; Sun, 12 Oct 2014 20:41:05 +1100 (EST) Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9C9h81p13041688 for ; Sun, 12 Oct 2014 20:43:08 +1100 Received: from d23av04.au.ibm.com (localhost [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9C9f5m9023936 for ; Sun, 12 Oct 2014 20:41:05 +1100 Received: from d23ml028.cn.ibm.com (d23ml028.cn.ibm.com [9.119.32.184]) by d23av04.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s9C9ewMo023906; Sun, 12 Oct 2014 20:41:05 +1100 In-Reply-To: <20141003132917.GA10112@BRICHA3-MOBL> References: <1411724018-7738-1-git-send-email-bjzhuc@cn.ibm.com> <20141003132917.GA10112@BRICHA3-MOBL> To: David Marchand MIME-Version: 1.0 X-KeepSent: 57B67AA2:AC35A32C-48257D6F:0032FDC7; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1SHF211 December 19, 2013 Message-ID: From: Chao CH Zhu Date: Sun, 12 Oct 2014 17:39:52 +0800 X-MIMETrack: Serialize by Router on d23ml028/23/M/IBM(Release 8.5.3FP6HF485 | May 7, 2014) at 10/12/2014 17:40:00, Serialize complete at 10/12/2014 17:40:00 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14101209-0009-0000-0000-0000006D12E3 Content-Type: text/plain; charset="US-ASCII" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 0/7] Patches to split architecture specific operations from DPDK X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 12 Oct 2014 09:33:38 -0000 David, I agree that your idea may be better for the splitting. However, as Bruce said, I think people would like to see the multi-architecture support feature of DPDK first. We can improve it gradually. Do you have some comments? Best Regards! ------------------------------ Chao Zhu From: Bruce Richardson To: David Marchand Cc: Chao CH Zhu/China/IBM@IBMCN, "dev@dpdk.org" Date: 2014/10/03 21:28 Subject: Re: [dpdk-dev] [PATCH 0/7] Patches to split architecture specific operations from DPDK On Fri, Oct 03, 2014 at 03:21:53PM +0200, David Marchand wrote: > Hello Chao, > > On Fri, Sep 26, 2014 at 11:33 AM, Chao Zhu wrote: > > > The set of patches split x86 architecture specific operations from DPDK > > and put them to the > > arch directories of i686 and x86_64 architecture. This will make the > > adpotion of DPDK much easier > > on other computer architecture. For a new architecture, just add an > > architecture specific > > directory and necessary building configuration files, then DPDK can > > support it. > > > > > Here is a different approach for the headers splitting. > > If we are going to support multiple architectures, the best would be to > have a specific header for each arch which implements a common API (no need > for any _arch suffix). > These headers would be located in lib/librte_eal/common/include/arch/$arch/ > rather than lib/librte_eal/common/include/$arch/arch/ (which looks odd to > me). > Makefiles can add some -I for dpdk to build itself (and we can remove those > symlinks from the makefiles). > Makefiles only install the specific headers in RTE_SDK/include for use by > applications. > > For common code and documentation, we can add a "generic" directory in > lib/librte_eal/common/include (or "arch-generic", or "shared" ... any > better idea ?). > DPDK makefiles installs the generic headers in RTE_SDK/include/generic. > arch headers (like rte_atomic.h) include the generic one > (). > > These generic headers can be implemented using compiler intrinsics when > possible. > They also include the doxygen stuff in a single place. > > > This would look like something like this, for rte_atomic.h : > - in DPDK sources > $ ls lib/librte_eal/common/include/*/rte_atomic.h > lib/librte_eal/common/include/i686/rte_atomic.h > lib/librte_eal/common/include/x86_64/rte_atomic.h > lib/librte_eal/common/include/generic/rte_atomic.h > > - in installed RTE_SDK > $ ls RTE_SDK/include/{,*/}rte_atomic.h > RTE_SDK/include/rte_atomic.h > RTE_SDK/include/generic/rte_atomic.h > > Comments ? > > > I am only focusing on the first patchset at the moment, but if we can find > consensus here, a respin of the two patchsets would be great. > > Thanks. > > -- > David Marchand I would have no objection to such a scheme. However, I'm not seeing much advantage over the existing way of doing things. I think I'd rather see the proposed patch sets merged first and then any additional cleanup done, rather than holding up a worthwhile submission for a bit of tidy-up. /Bruce