From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e23smtp09.au.ibm.com (e23smtp09.au.ibm.com [202.81.31.142]) by dpdk.org (Postfix) with ESMTP id 7FFA658E6 for ; Mon, 13 Oct 2014 04:26:55 +0200 (CEST) Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 13 Oct 2014 12:34:29 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp09.au.ibm.com (202.81.31.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 13 Oct 2014 12:34:26 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 3DFDB2BB0040 for ; Mon, 13 Oct 2014 13:34:26 +1100 (EST) Received: from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9D2aRPX21364806 for ; Mon, 13 Oct 2014 13:36:30 +1100 Received: from d23av05.au.ibm.com (localhost [127.0.0.1]) by d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9D2YN8o002344 for ; Mon, 13 Oct 2014 13:34:23 +1100 Received: from d23ml028.cn.ibm.com (d23ml028.cn.ibm.com [9.119.32.184]) by d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s9D2YFf8002169; Mon, 13 Oct 2014 13:34:23 +1100 In-Reply-To: <2601191342CEEE43887BDE71AB97725821391202@IRSMSX105.ger.corp.intel.com> References: <1411724186-8036-1-git-send-email-bjzhuc@cn.ibm.com> <1411724186-8036-10-git-send-email-bjzhuc@cn.ibm.com> <543311C7.40906@tilera.com> <2601191342CEEE43887BDE71AB97725821391202@IRSMSX105.ger.corp.intel.com> To: "Ananyev, Konstantin" MIME-Version: 1.0 X-KeepSent: D2277C48:DE4DF69D-48257D70:000DF62C; type=4; name=$KeepSent X-Mailer: IBM Notes Release 9.0.1SHF211 December 19, 2013 Message-ID: From: Chao CH Zhu Date: Mon, 13 Oct 2014 10:33:08 +0800 X-MIMETrack: Serialize by Router on d23ml028/23/M/IBM(Release 8.5.3FP6HF485 | May 7, 2014) at 10/13/2014 10:33:17, Serialize complete at 10/13/2014 10:33:17 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14101302-0033-0000-0000-0000004DF297 Content-Type: text/plain; charset="US-ASCII" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM Power architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Oct 2014 02:26:57 -0000 OK. I'll update the patches. Thanks for your comments! Best Regards! ------------------------------ Chao Zhu From: "Ananyev, Konstantin" To: Cyril Chemparathy , Chao CH Zhu/China/IBM@IBMCN, "dev@dpdk.org" Date: 2014/10/07 22:45 Subject: RE: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM Power architecture > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cyril Chemparathy > Sent: Monday, October 06, 2014 11:04 PM > To: Chao Zhu; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 09/12] Remove iopl operation for IBM Power architecture > > On 9/26/2014 2:36 AM, Chao Zhu wrote: > > iopl() call is mostly for the i386 architecture. In Power architecture. > > It doesn't exist. This patch modified rte_eal_iopl_init() and make it > > return -1 on Power. This means rte_config.flags will not contain > > EAL_FLG_HIGH_IOPL flag on IBM Power architecture. > > Since iopl() is an x86-only thing, shouldn't the code be conditional on > defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686) instead of below? > > Better still, should we maybe break out an architecture specific init > function? This function could set iopl on x86, and possibly do other > lowlevel init things on other architectures... Yep, that sounds like a good way to me too. > > > Signed-off-by: Chao Zhu > > --- > > lib/librte_eal/linuxapp/eal/eal.c | 11 +++++++++++ > > 1 files changed, 11 insertions(+), 0 deletions(-) > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > > index 4869e7c..8cc1f21 100644 > > --- a/lib/librte_eal/linuxapp/eal/eal.c > > +++ b/lib/librte_eal/linuxapp/eal/eal.c > > @@ -50,7 +50,10 @@ > > #include > > #include > > #include > > +/* Power architecture doesn't have this header file */ > > +#ifndef RTE_ARCH_PPC_64 > > #include > > +#endif > > > > #include > > #include > > @@ -1019,11 +1022,19 @@ rte_eal_mcfg_complete(void) > > > > /* > > * Request iopl privilege for all RPL, returns 0 on success > > + * > > + * Power architecture doesn't have iopl function, so this function > > + * return -1 on Power architecture, because this function is only used > > + * in rte_eal_init to add EAL_FLG_HIGH_IOPL to rte_config.flags. > > */ > > static int > > rte_eal_iopl_init(void) > > { > > +#ifndef RTE_ARCH_PPC_64 > > return iopl(HIGHEST_RPL); > > +#else > > + return -1; > > +#endif > > } > > > > /* Launch threads, called at application init(). */