From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7246143ABD; Fri, 9 Feb 2024 16:40:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09A8142E64; Fri, 9 Feb 2024 16:40:46 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2098.outbound.protection.outlook.com [40.107.21.98]) by mails.dpdk.org (Postfix) with ESMTP id C75EF40697 for ; Fri, 9 Feb 2024 16:40:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bzZnXPaPgYzhWnUGYQjmHbrIGvYt7skHCo8Jgwn8hdH1tQcMs2REH+fkSD1vUHjrHkNBBruxZfxoxnfwIX3Y3jtIY5rglEIeWHkG34nE+iPXPRg71oS7XGY9KYSytC33FqW8MdwidjKhJY1KO1DL1WEknc8LRxhRMd4GEyTn40AAC2yPLdUoVt7ZMUlIXn/aiK3aDBb7J4gICipISmm6LBhnoOgsfLZ6LYmVbF8ONkVPvSZJiTxrGMl91bfP96JbWda8BaqaBkf3viGira7gk89JH7Pf1B9vKMwp6lnlQsTkGNsE0y2iliXc2nS7T1k6hWyRc3LKk01vVBkeHcCSEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DQkdQ+85zvKXJbDvaBh2esJyf4MZTDuj0NJU0rQe/BQ=; b=L/eEWyzX6ARMmhYN+McoKUsNRCvdVY4OFLRNDbrgR8Soc0w5SNqUJmr/ZPhWk6ghFQD1qiv7CmFxL3y7AXH8sa4Huk20dENgO1UkDtu93/cMneGefQm4NHZP8oxVcUzU8VFqZHrH29X1lieSocGqjoIkci62UH7lGgaHSmsAokfJyhLKf34vQEpkGxq7meNJCpj56M9vETSPSLIX1hLc97bsWfnfb7Yxt0RAoJRb0NJnTv2rO1bZLRO+DX4UPYr555vGQJlHrnMDCut2um/sIVphD4kETalclK529FMJvsma5OllRZV3uupnHzMPC9PilbRn7roI6pBs5pPKLdfmsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DQkdQ+85zvKXJbDvaBh2esJyf4MZTDuj0NJU0rQe/BQ=; b=PUgn6m2vZVPOzfpWIMZZ/35wjjkHO2OKXaTN9mvSmgoVcnXHTcdJ29duNN5h+g1/C6hk50tVpRmjCnD7IFs/BkpVbVGR+YJC9STGwnWzPoA3+sHdyPDNlw2xKKZxyTSMErRRCxMzDXIrh9CzXm5QU6zOelqZ97TePY6wc2tF6SE= Received: from PA4PR83MB0526.EURPRD83.prod.outlook.com (2603:10a6:102:26b::17) by DBBPR83MB0564.EURPRD83.prod.outlook.com (2603:10a6:10:533::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.12; Fri, 9 Feb 2024 15:40:41 +0000 Received: from PA4PR83MB0526.EURPRD83.prod.outlook.com ([fe80::b55f:3890:59e4:b623]) by PA4PR83MB0526.EURPRD83.prod.outlook.com ([fe80::b55f:3890:59e4:b623%7]) with mapi id 15.20.7292.012; Fri, 9 Feb 2024 15:40:40 +0000 From: Alan Elder To: Long Li , stephen CC: "dev@dpdk.org" Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata Thread-Topic: [PATCH v2] net/netvsc: fix parsing of VLAN metadata Thread-Index: AQHaWvVFyAqumrh3006vamaU+gwI47ECJXRQ Date: Fri, 9 Feb 2024 15:40:40 +0000 Message-ID: References: <20240208095419.3b5579eb@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=6b9f94c3-c82b-44bb-8036-75f0967d54cc; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2024-02-09T01:10:55Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PA4PR83MB0526:EE_|DBBPR83MB0564:EE_ x-ms-office365-filtering-correlation-id: b6ea9d7f-95da-4cf3-d09c-08dc2985782f x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PXTB7Qpsfv3aKfHoyKllejOfER/MZoV8L9rMuwwiPO4fvOGHR8UnaTjohfK47HYlsAifhjIUiY1ACmsAJ9tMz6Ix/12+s8MA2w2GNx8hSKTo4gxfudZyR1dPPBLH3trYIeEILPoAyoExaX1r24QC/3sgXitjb/JPc3QwwHGfMsNTVffloyDNQYmKnVuxIimWnDo9DaWHaEWTTKv8vcL3oKjt5rvBxuRPm8nhDXy0ypcZCwt7RTF4LfD1tRBwVmo5Ta2zT4R74oK0cbRzrIxZgPAS+pvHVs5uXSKkHeEpJKvUeVRp8nyuOF5D/Y2Mfd/6r0yBJ6bzTfeOVqUxzm9u5458q2wlvZXnyFaLcOuBviWw+b1n23qkYl0fqbgIXfy9R97Gzq6kOWP6FJipHImUe9H9h/0/2JsVnjhwSZy2xnOcM2QpWTADDop3RNRu9X6LC+j7LEzAV43pekRl7qnGOsVl/r1dcw7l7mIbW46PjVihiNAGteeAlxNmN5sYmXj2gn3Xg1PxujvZcL8R4UAyYTfx043LiklZ/kO+S5eQwJlw0ZX8GWwdKGuD0PwS4Z69LgZAsdKQroQHpYp8pH5J1XBxUX4XmBhL2zwPfLpsTRcaxq5tg1htSMW8KJpnujw/ x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR83MB0526.EURPRD83.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39860400002)(366004)(346002)(376002)(136003)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(122000001)(55016003)(38070700009)(33656002)(83380400001)(82960400001)(82950400001)(86362001)(316002)(8990500004)(38100700002)(41300700001)(4326008)(4744005)(2906002)(5660300002)(110136005)(7696005)(6506007)(53546011)(44832011)(52536014)(10290500003)(71200400001)(478600001)(9686003)(8676002)(66556008)(64756008)(66946007)(76116006)(66476007)(66446008)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1cCUTl+rLopZZ79AGT16QrogjcBwQqWT0GEPLr/Dh2v1hKcOAmEOP0z+EPxb?= =?us-ascii?Q?icat+6cgB2g1zHIAOmTDvsbwfraNj+hAjQV+5Ybp8+HQ5c2e9P/v/KDxpvC4?= =?us-ascii?Q?+s5u9GgxUnXEWyyudnBI+v3DSweXqTYR9qGAHdfhtx4MYJPt2k6h7kebuvAv?= =?us-ascii?Q?fNH5e4Ec4lYQ2Xq3ZKKku0uQQW93DtQ4XxTjMtLfwHqbnMKh9kvo/Fp97cHp?= =?us-ascii?Q?r/j4hYMhX2jGhL+X5smAuryNFkIJnzoCc3v5yJrutilMKY5cYjLirHk6tIiQ?= =?us-ascii?Q?jovFSIvjAWMmxAMly/GBXZp7rB3gaN5jI3gDaOSiMVGGrprI7a7b9cd3nm9Z?= =?us-ascii?Q?GjDRHnornAzLGv1aEjrmMaEaLo87FoV1H67quUwqelLskIefwyYTyZjFFu+J?= =?us-ascii?Q?9XkfD/1Dzjg3BwGoC97E4aPeeQQFbduIJTmeHG+U2gpGx2fPR2p4xm8IvxJD?= =?us-ascii?Q?Pj5a8CuBrVXrT7+RGuOfAL32nx3PL4bXIyvdVOFfJdqhaJOx5zlaOtubDcPe?= =?us-ascii?Q?aYq7Go5zQiLnflxJOghSjsvas/9wQ8hLXlxvF0sU5fXbRbCGhCD0sep7AFKo?= =?us-ascii?Q?rhJpsmHd2qflwYYuKmQV2WZK326LWGfkBycYkf5QB3ZtPc39Ixgs6oSDYCns?= =?us-ascii?Q?F6FNWFZB0NkAa7EfAezF2JZ9iwhskITf0fUCeZkZ3cKgvc8Xywdu4ID11t9r?= =?us-ascii?Q?eLsN6Mu4XAX/MhsQ5CMc8WYPnB5koFLa08BKTUfC5cEkaoALpI4znPZEUKV0?= =?us-ascii?Q?JtK1gfSVKrLjplMk7j3/Zhu6R/DgN8x+gWqRZN1jGOiUvii/z3eGZwl3S9R6?= =?us-ascii?Q?/e3tYWUAzsOpiJiM5fd+0xSv1KxUjsW2WVIo2grmmTnRZzcrj6tKlTzTuW1Y?= =?us-ascii?Q?N2sn2Jkdj3k2xWmHWBFRVKZnFbI6jN/kzdKlun98pK39LEmpfAnft0KTCwxi?= =?us-ascii?Q?BytxpwMH9FRy5XbdKCQuTvTMXYlrrxSvHswDcHViU5fD/meJ9SjFvWYTLfxd?= =?us-ascii?Q?WPzEV1WVutrDq/+HQgwg1eO1GhDyDUbp0hVNS0+lW77ZctqRC4PtKwfD3QAD?= =?us-ascii?Q?hIZLEdWcqpnvVBg7toCiYlrMcvGn1ADhpRAxQsKrK3FV9MvcTe8Y8yEpeCuq?= =?us-ascii?Q?G02hFpzAlCMjIAdeZFiwgeWBaL0VO7D3S8PGjXKCO96akxAHKWQqEVgRG9iT?= =?us-ascii?Q?Kpn247QAdDD7KItariTJ6Vy/QW2Cufv3X3iIHMfEBUHSx1gy4cbF/wsvhcu6?= =?us-ascii?Q?YgaFoRVWksqsIQAwKBRsGhS6bIZFyip3yHcwU847FQ3+X/ObXbRZivx+XUk6?= =?us-ascii?Q?doCChD6ZYSJGF2nY89uox9Gz1S8cbxvFxFd7HnohjRVYJrER5eQNtHBFGhYR?= =?us-ascii?Q?xX+8uSXoYf98396LnlEUv43Bd4XIMe6QdCYW/fl4/KOdfCEcyT6/jJuIaGyf?= =?us-ascii?Q?PdwF/kC5w7y5tQD0fxKuCg46ZTI6F7PkAcprpm/3JLFpRGXLn5G27uwv+Lqc?= =?us-ascii?Q?NjheGIJ3i99rAnmyJLQiDwzUpxiCLeNp+KhU2+kAM2cMId5166OKeJjgMtOA?= =?us-ascii?Q?zmt2C1Ew+UjZCQrf8G+fzVnj3l5+qau+c2DGLWpL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR83MB0526.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6ea9d7f-95da-4cf3-d09c-08dc2985782f X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2024 15:40:40.2987 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SywMk1fNipJrPI3qC3HEHbG36+fSm35RoGoUPYNuvKzjvpiZvjN+JxwpzsDhzSKyz86A/zoykYA7x7rhBdj9OQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR83MB0564 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org -----Original Message----- From: Long Li =20 Sent: Friday, February 9, 2024 1:14 AM To: stephen ; Alan Elder Cc: dev@dpdk.org Subject: RE: [PATCH v2] net/netvsc: fix parsing of VLAN metadata >=20 > Most of this driver came from FreeBSD. Did you look there to make sure=20 > naming is the same. I.e would be good to be able to have same code in=20 > both places as much as possible. I hadn't looked, but have now - the FreeBSD code does not suffer from the s= ame issue as it uses a series of MACROs to convert between formats. Agree it seems sensible to keep the same code structure, so I will update t= he patch to follow the same style as FreeBSD code.