From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E43FA0350; Mon, 3 Jan 2022 06:47:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3347A40042; Mon, 3 Jan 2022 06:47:26 +0100 (CET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150077.outbound.protection.outlook.com [40.107.15.77]) by mails.dpdk.org (Postfix) with ESMTP id 84ED64003C for ; Mon, 3 Jan 2022 06:47:24 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NPPdbzhdtj3SU9PG9GHOUQyyMIaeOiUTNHXbu5w6v4oxblmODKM4xm39lGHGO3JefJa//mo+Xc+CauePaA8CkaylagzYvtU48g/aCIoFkyqMO6kssuC1jZ0CMupLmZWvHj4p57l/nescMFzMH9YzzV91jf9EedgRmkShqBQnR0Wtpj7ZlVd201UchtKRqmNgNU/T+l3wj/ePuho02NZywvV79+qbLJWTjKI4rI7SNXae63bjdzz/TukiGX5wwWeC6L1J5s2Tlweo9fEz/r+NN5LWndgCOwYagv5FeMx+TbUkScsJmaPCi9kUCZiCDByffHDbo5v7SSGO14YqXF96Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UCCAs5ksrv/36ReXoc7+7EKtpLvUOG4aXHFs1N2bNgY=; b=lp8vmaO0OEePQCN8fYw0JqQjcU26MXyQQC7DBkExkvmObKPtpsXz0YxEr8yjTTXiRPW9bY0MH+8vTDhhH/pUA+bdnglsuMwBfxteutZOe5LEFXyPyW+TguUBDBEJ4Oi0XbCq8Cr6FHveEo3jrFZNtpRJE6zsGjNrhhXKdZYXNJHKlOt69/AfgR99ASbbsis4ITeTPvGS1eZDHPLOodYGGyNsLD2Adu25L5Jdm6YojJzYyce0mfypFG9zZsQoQUxwQYmQTGr4CEOH9qKGEq6nkmm+zrFm9Pda5GebvTD+5dvdb8hGOACpurJXewXgRUCfASWEADFTYrzmpd+hLmexdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UCCAs5ksrv/36ReXoc7+7EKtpLvUOG4aXHFs1N2bNgY=; b=r8ipAAUh1hOtfFbXCDglEzDQrrGOUfefiPryATLoCwF5ZH8KMO++S69eCumdmYxmyoPgC8bACtYz8QvRTwVpbGLVH4UOXR8whwYVgmyEA5t/Dr6mDEYObyVX0CfljXjk1vkj3VgMlIvN0Mupmd8XZUmHoowWOq9CHznTXsUxyPE= Received: from PAXPR04MB8427.eurprd04.prod.outlook.com (2603:10a6:102:1cd::13) by PR3PR04MB7290.eurprd04.prod.outlook.com (2603:10a6:102:82::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 3 Jan 2022 05:47:23 +0000 Received: from PAXPR04MB8427.eurprd04.prod.outlook.com ([fe80::b18f:f500:eccf:90b5]) by PAXPR04MB8427.eurprd04.prod.outlook.com ([fe80::b18f:f500:eccf:90b5%4]) with mapi id 15.20.4844.015; Mon, 3 Jan 2022 05:47:22 +0000 From: Nipun Gupta To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , Hemant Agrawal , Jun Yang Subject: RE: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue for ordered Thread-Topic: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue for ordered Thread-Index: AQHX+z1B52Zc2Nmqi0Ogpeq0u76LrKxGoS4AgAoyn8A= Date: Mon, 3 Jan 2022 05:47:22 +0000 Message-ID: References: <20211206121824.3493-1-nipun.gupta@nxp.com> <20211227161645.24359-1-nipun.gupta@nxp.com> <20211227161645.24359-7-nipun.gupta@nxp.com> <20211227100154.15da0346@hermes.local> In-Reply-To: <20211227100154.15da0346@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56ca7fb1-f616-404b-7d3e-08d9ce7c839a x-ms-traffictypediagnostic: PR3PR04MB7290:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3X4bw8LBxvWNiYVwTf5cLXef6jWBQIde7o6HdsQDgmYD093/+gBfcpXFEHsGfhVr854Kmq2bREeMDoVKQXtkYvgr8pUsYL+CxbnsRHIx8dG2NBKTpS1GykhRGcUUATu6MzpU+140/bTbBgCAvCFrG64t+2zTMRKD7bziir60Y58IuG/pCIpKA/WcHXpQ15XWP36QO20sC91k8BOuQTJCAIUp4uF6a+6ElvWLERVh5dQsy4b64NVOlZxI817/3kZvIa/9bqpliEjRnpqx7AuxuPlBnJV9RD3/V+hyxxABQocBac8dFqykbcjLvBTDIn6ShdhJLvB36Y56YH7PnQEn9GMWqHUqqaA2SPBOA6WlDvFy5YrelUw+Dr8TtmhjM/8vjqJ2FpG/7RIkPLZc0G6ofdvZvSDKUB6+YRryX+6F4dCu6DpMh3UBLRBoiFwQ9eQrmnymW9XPVvFup4rMArQh07j2yiYoy7fKPNZIwne/MSeQ87iuJNUrvt3oGwwQBRsFHAPwKKKy+rYWVbqo4S4QDLzfrgrmIr95RQLXRRNQ/7uGZmUILvm0Is3rZLCIwgCVT4OI+nMY4SeTm2JiMyeB7A9ScCG5YCdGKur4kTnYanX5+hdplpEsxo2yTf9LiIKYIowxYM0kwoOYAfaQlUNoh0XFReVapkASqx4GhNX7Ko2ZR8JWP4krQ6CmpSkjC0CPlM+cIKEAnpGArvbS38zpiQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8427.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8936002)(2906002)(83380400001)(7696005)(186003)(44832011)(86362001)(33656002)(55016003)(508600001)(54906003)(52536014)(26005)(55236004)(122000001)(9686003)(38070700005)(71200400001)(5660300002)(66946007)(4326008)(76116006)(6916009)(53546011)(8676002)(6506007)(64756008)(66476007)(66556008)(38100700002)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?86wJim+jtE6b2s1Oe4W37o6/Ks2ktmZVRtVNLVAxr/NPuMutoCD6RVdrKbHg?= =?us-ascii?Q?a5rDcIZdFOJogTvM1lj1z1f9Kuug3JARCYf9IWaekNkzs93+CvTnjwjz0pEC?= =?us-ascii?Q?+A8aHOP0NC98inLzzQHZqNei71b8l4lAaCyI6iitrPEqI5MJhHFW/cKYQ/Ao?= =?us-ascii?Q?kR+xHk0jGtZqlX/XfGKvDzOqs1UMrBmrM2HvT7dGUB/uT9jfyMU4m2w1JRBP?= =?us-ascii?Q?O4FnVh+WvmDqzGZtnh+yBGMRX2CmxgDJ22kxZ13G6ltFIH4AJLU7xd0kob8+?= =?us-ascii?Q?w2KPHFH7pQlBgl8yMJyRyQCc+MGKLE2SBslhJHfZd0rpaAK92HpVicIg9OYJ?= =?us-ascii?Q?vMkI+WmKXp7wgz88byckck8i3Tc4GIJU8KIV3o8Z1OdqewSOpgBUbIZ/JXH+?= =?us-ascii?Q?zNUaqyVJP0OO3uPVfDG+HCWJfVjW/4nAt2aXWJLOt3i8+nzvlRZMyWqvIDMz?= =?us-ascii?Q?LPgb51Sg+teaiX3OztITtJlye8AYhSqQvb03hjiz2pn6iwHOlMjL7CNiuQPV?= =?us-ascii?Q?auASIz6hbtb77H5bO2lZmNWANmc9JTwSByW+vZKb7pcC/Qfp+fAjTvmrlwfn?= =?us-ascii?Q?8fM7cBfEQYyyke+YqLScDQFkL8DKI77k1SeGLNM71dvXI/8asYQinXHwWuC7?= =?us-ascii?Q?HXVkITDXIhFspHCzUrgfPVj+I4Me8etHLNAiRDXtaAFkBbIr44ECbCoEuHzT?= =?us-ascii?Q?Sfv9Y8+39GO8TPETaX5ScSIZlKvJjTmhASqFvynEGQCOLKpf3EqWc8pTsIHy?= =?us-ascii?Q?TwJJX9N7y9PjsFuVfWilZpGO87UE6GpQAd5LVvudr9vsZ+51edC06fDw4owG?= =?us-ascii?Q?8ze15HhW6Ude67jjlFaOf2z3rhFffr25amUoGdvejtRoOKda8UfB9rBO0/DK?= =?us-ascii?Q?TZuAxWw2ILSy+U9R8Js2+7QBWfZaRebWrsx4d5bCtpGF/h+r/Tp+GXU8bnZI?= =?us-ascii?Q?Y2Eu6vKfUWiKioeDwq+hbbkOK9znAhLrQ6hAbg+rBNe1oR3YQdm9D8Osv9tw?= =?us-ascii?Q?pjZ67FUSmoSVInT2JfZoJ2MWYah4QHuNKNsauOH+tu3BXbRIKoFmNOYR7F4K?= =?us-ascii?Q?RJcSHTr4PjmBfRxATEFcxuaMh0jD8AXMXiA1W0nrCUPnuL933TNwodfJIOy6?= =?us-ascii?Q?jeWfRDCAheS7jDBszEDq/G0hH/99d77pEzAIhhqbgvsVnvM91xAPIAv6dmfA?= =?us-ascii?Q?O3u206h2xs4RpEWs3VvuVwAX5hHty2qNJRe0D6gPzvdDBqqfjaTQqFLyjm2Q?= =?us-ascii?Q?lYn+7Kc9nJgbyXrSR2tA1MP+AQAf2M7xlbzAOOkNwaI2xJeyLk+4pLXJjvZP?= =?us-ascii?Q?tyIVEi4+xPoZF9sjCdc3QR1lHqT/WM2dSbq/Oa/xpQVLBbPRhgGV+WmC8HL6?= =?us-ascii?Q?ZvUbdo362Ya4g3YjCNXBaE8BnCa1Y56vLV8xSmvtm8zcBoCE8EXu6Zg/4NEo?= =?us-ascii?Q?7+Qfmxeg9g0jhBwiW/7YqPQLekjRN/8a4UVRUKpSkgVPHa2H+JuA7z7/KvbY?= =?us-ascii?Q?7dudP2biyKDLyFZHpSiVbLGP17NC2NJ+Hm5pH/094OMELtVPVALvsbVmxq+7?= =?us-ascii?Q?wjvS5SeCnsX/Uvnxlrc3vXrgIhuqojI/J9BBF5d1pPkWEELCkDnkcnUuB794?= =?us-ascii?Q?xg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8427.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56ca7fb1-f616-404b-7d3e-08d9ce7c839a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 05:47:22.7786 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IAIO/mz06LtuV2Zgc0rLZMHBop2WFHg1Up4GXKZR3PQu3usYUUXH4PKDG5odsrqhAoOg6GFYgIKVlstT/c8NfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7290 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: 27 December 2021 23:32 > To: Nipun Gupta > Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com; Hemant > Agrawal ; Jun Yang > Subject: Re: [PATCH v2 06/16] net/dpaa2: support multiple txqs en-queue f= or > ordered >=20 > On Mon, 27 Dec 2021 21:46:35 +0530 > nipun.gupta@nxp.com wrote: >=20 > > @@ -1003,16 +1003,20 @@ dpaa2_eventdev_txa_enqueue(void *port, > > struct rte_event ev[], > > uint16_t nb_events) > > { > > - struct rte_mbuf *m =3D (struct rte_mbuf *)ev[0].mbuf; > > + void *txq[32]; > > + struct rte_mbuf *m[32]; >=20 > You are assuming nb_events <=3D 32. > Why not size the array based on nb_events. Agree. Actually I will use DPAA2_EVENT_MAX_PORT_ENQUEUE_DEPTH here. >=20 > > uint8_t qid, i; > > > > RTE_SET_USED(port); > > > > for (i =3D 0; i < nb_events; i++) { > > - qid =3D rte_event_eth_tx_adapter_txq_get(m); > > - rte_eth_tx_burst(m->port, qid, &m, 1); > > + m[i] =3D (struct rte_mbuf *)ev[i].mbuf; >=20 > Why the cast? it is already the right type. Will remove the cast. Thanks, Nipun >=20 > > + qid =3D rte_event_eth_tx_adapter_txq_get(m[i]); > > + txq[i] =3D rte_eth_devices[m[i]->port].data->tx_queues[qid];