From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D03F7A0350; Mon, 3 Jan 2022 07:09:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46D5940042; Mon, 3 Jan 2022 07:09:34 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140055.outbound.protection.outlook.com [40.107.14.55]) by mails.dpdk.org (Postfix) with ESMTP id 55C364003C for ; Mon, 3 Jan 2022 07:09:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bcKeaBYRFoWRQ5kz7iVdf3ykbWaOjTmroFK1GuFJR0dvpnCJwSomA55I3oUWnBP+oFmtxcLHgxHX2CsJLVLU9WAZQnLs4kqvWTeByzAufl2zERp9+IIzTgTcv20aNhCZ+3EHzbMdSw8UlecJqDtN0RFlJB63K9p7TelegpJgrkSri5aem2hLCHPdeqIOKf4lJEp+NbE+cCVTI4dvbn2ywn1gupYr6LwBuwRMBALqDJ+NNobkPHC1GScEkE+cYiZymvY4mcrVH/gl6Ij63KMtEcm9Zpi/o/Y3KflhAqKQcojDDFui/zSLtHBwxc0YYfU7ymCSthOuM/3xwPxafMfp2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tnA7eQTf2Vd6HUroWfmxOH0n7yZxzIwLI6CCKvU4UsA=; b=BG6k/O5d+/ijStQVzBSI0AgBr4E54VvJc5rkRW2PIUE1rzHPJxjd6vEIbVFuypXmHSflwOjVkkNpbW4Lvqjz9cmkETW8ofWGffsrw9lWMOxNSVkmq//KMLVP/m8WySTA+IkAJVAG7Vx5HemkEthrCCr7sLijM+yB2ibd2ZAJg8/bIPGLb/FY1+ssOtO3VwkvyBEH4qjhlC4u404cwu1XKCn76Z9EjZQT0zErD/cVTg0Rk3V9DYVRVFWqq49Nfv4l4NDdtr5SlrYIFEAKeV0wUMfCOuf9HL1xtX9s6hy+tQRU7yIbkFpZod0O52jefVoJaYB5wH6GcfQteWcn7pQd/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tnA7eQTf2Vd6HUroWfmxOH0n7yZxzIwLI6CCKvU4UsA=; b=iWRLv/hzzTWsaNlxMhFNAtqDsyhPJJ+7gNVSX4it6CiUmKucPLX1ipCbjz/FeQB44+ZlMXHZL8i729AzX+b4ys3leM3eVrHLpfgtMu6RjdsgwT6Zr+Dgjd5ydJp+t+7yHQxZw+TAylHBu6lhfLoeJJi2nhQEDldfznM2BZfSA2A= Received: from PAXPR04MB8427.eurprd04.prod.outlook.com (2603:10a6:102:1cd::13) by PA4PR04MB7869.eurprd04.prod.outlook.com (2603:10a6:102:c4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Mon, 3 Jan 2022 06:09:31 +0000 Received: from PAXPR04MB8427.eurprd04.prod.outlook.com ([fe80::b18f:f500:eccf:90b5]) by PAXPR04MB8427.eurprd04.prod.outlook.com ([fe80::b18f:f500:eccf:90b5%4]) with mapi id 15.20.4844.015; Mon, 3 Jan 2022 06:09:31 +0000 From: Nipun Gupta To: Stephen Hemminger CC: "dev@dpdk.org" , "thomas@monjalon.net" , "ferruh.yigit@intel.com" , Hemant Agrawal , Gagandeep Singh Subject: RE: [PATCH v2 14/16] net/pfe: disable HW CRC stripping Thread-Topic: [PATCH v2 14/16] net/pfe: disable HW CRC stripping Thread-Index: AQHX+z1aKScN+NCnpkiK25l1/kW7Y6xGnacAgAo8PNA= Date: Mon, 3 Jan 2022 06:09:31 +0000 Message-ID: References: <20211206121824.3493-1-nipun.gupta@nxp.com> <20211227161645.24359-1-nipun.gupta@nxp.com> <20211227161645.24359-15-nipun.gupta@nxp.com> <20211227094916.6aa2218c@hermes.local> In-Reply-To: <20211227094916.6aa2218c@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8d0ebd3-530c-4aae-ec19-08d9ce7f9bb0 x-ms-traffictypediagnostic: PA4PR04MB7869:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 167dR5hOGbotd86jGt4oNfFbATKf8CzZK2PpItPvrZ+mwLKvRNfAehojrr5Cazm5EbV3lL/N/suQVcCULab6Khi1mRHLt+aiCbrS0WCvVl5QOsTdRDzWOCTtzwB5rCKALoKCbw81iFAyCV7vhF+lUZA7ZiDwegtn7Wn8AneviPuVHwyqDvHq0JY7j0GkSKY+LupTlyY5+PxP7WYI239WlL85ZtKkTIsGMgDSrJNtYYu+MNGkrmVkHVOKTKwrI+6cvX1iz6ie/49rvb9Vz9lAyoPyCV81eMqgsTddBEn01Uw1ZFkS+rS8+Y36nDPAiL6+vgYnQovcMt2TFboN6juUAxxh+dXj64ZvhR+GrZVYwP6i5ans6d2wNtc0QBG+o7DmNWI4i0W47tqm7dtS5mk/s2fEBUgEE0N4/UTkjSTPeJy6VYwpmCzSiybscbjD2ILuAaz8jIyUbCegn6UltTPsGCFjqJCzyEmG9p5IVr/PcqHMnBq0I22uwofxuyrceAt1uqqfKjtwa0P8io3TKBkSY6BqpMfC3DNn9O1Y+gABXrZiKwM6HnSAyOw824NCsMGwrWC6Fhr3gQGozNTZZGDAD2Meb8oqj4fJWKCzUY2H2Np9UjgjtuHrw4a/nqpwymamGmRwPwlEfKbvtGfL5WUrm1wY74d5PAJHcm+9Q1nSvQymy8zAlm51ri+7Wnc7bRrl4e8UPpPy8tBrVi3/hG+HrS/j1iuS8QXhssGMO3FsmTo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8427.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(83380400001)(52536014)(38100700002)(44832011)(54906003)(55016003)(76116006)(71200400001)(2906002)(26005)(38070700005)(5660300002)(33656002)(7696005)(9686003)(6506007)(316002)(53546011)(8936002)(186003)(55236004)(66446008)(66556008)(8676002)(86362001)(6916009)(64756008)(4744005)(508600001)(4326008)(66946007)(66476007)(168613001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lGawXyfXNjn8DoNUlhGiba56u7TqKa892naqGAsCP7/Clf9nLeX6EiA1xi6v?= =?us-ascii?Q?xEX0z+zjyNlI7Jn45+pFGx1aiy/qCTCRcBgUH4AnDCXY293ziynjcKz2Gux4?= =?us-ascii?Q?edgaJQoTZMsunVHI4RPhnGfSMzOEUTQPBJy3A2GAmyii5hizwC+X3xrGkfk/?= =?us-ascii?Q?msO75FimqoBR7PpMlEdwfSTtgKFA/9Kh1lxcqRtITqqLBOqQZl8SBEWpGgjF?= =?us-ascii?Q?FkhXqynzr89CBoa9X+aWZVVQ6zWK5PY9WVM8JKcPOzRbhh8qTm+ajYgqYZoY?= =?us-ascii?Q?H63FZF3p4S23G7MadS4eTpirWSWrLHGGszrNZffLeqe87obsv7Bh1bHyZ9eg?= =?us-ascii?Q?zwbCxWHX30YYBBG1U10KWHDuFT1omvq6GEv1SBR6F9dK3TsKDWo6gZnLIjTC?= =?us-ascii?Q?oDGSoAVnOSWvJ3MlN+TPMfJYLb8l6tp/AXlP63wq7qxXaPLjNfF8tFd2cimb?= =?us-ascii?Q?S764Egf+ZlBmsPV/9hpRio5pNr5yAZ2xLmRMb06gNDGBIqC2qSbe+qlCma/v?= =?us-ascii?Q?GW1gV14tLmFU/2Kt5lfxWu0U8Va8K+LDR7Q+SPoRSC1MyYtxbT/eBhD2j4cu?= =?us-ascii?Q?+8yTN/oT6Cl2Hf+DyKHgyVdKYrlL+kvNOOhq06AJr2AcxyzbizYmLnqCjoWc?= =?us-ascii?Q?ZZjzjkV9BFVTV2kZmD73JZ36wqwi1N4PzFfLjY+62PUbc5jgxzvKOjBqPxQU?= =?us-ascii?Q?rYcLa4yaWUKaYPiv/JP6lzGIjjTPyocO2VBsWRVKfJD5mh9Y2/OmV4TwtOhD?= =?us-ascii?Q?Ae1jrndIZz6g5s+KS01TdfTcL6Yg09Sh1m1WqDCNonOy3r/oGAn5bq69Yrbl?= =?us-ascii?Q?X89MdH5OauvjScQwKv8Eb1ly8rcK5h43DryI02Wjiw8S0q8HocNK9BWvzjnI?= =?us-ascii?Q?wyR4GislZ8PJIVF/mVp54efH4f+HtDxGUJtoFcI9sYQFhD1l1PG+qFhk0GR/?= =?us-ascii?Q?1Zp0amAdFSgIdOqZFOLTn2bz3FeAlTu9m9vaPUd2KB/1QfqgJTIiVAm0oGrh?= =?us-ascii?Q?KXd3tum658pfMq5tn8dCSA/55mggpWO0B/+cBvqV4+X48AB+Qf4rmGRJqe8Q?= =?us-ascii?Q?4CjMyRudIDGXVFWhTmL6meMq1XRyE6qSzLeu8fbfVjSEpetDucH2GrsQoVQc?= =?us-ascii?Q?eY7aT026VNnjVcH2luxeibMKEpZ7WxGJhDM8Ypu0aAXqATU9IV8P4TeXb+6b?= =?us-ascii?Q?Cae0NLH4pPSI1xk3guzGwHhNJ+CgJNsmIWbezVyvy7fzVlvLXS0R4yYUPBPM?= =?us-ascii?Q?CGc0vs/8bs3npOeEJWXwEx1QUE/VB/CiGdL/YLsxRmeIoawE9k4fXWJC06r2?= =?us-ascii?Q?3PHnFYYou6Xqk95aIwjKFHz4MP+TfivmpK170jB8GqDJiOQg/e3gKmWByRKs?= =?us-ascii?Q?fKw4Zq6MV0R0MG6LENbCoFAq7GIzIygCifj4pJ+uP1qNsluILaxJwOVERCzg?= =?us-ascii?Q?jP2RCXPknOdQrTW7xMEWu6+6jVYMpdn/U039AiNv74IIv6inXysn1Wx8jwXg?= =?us-ascii?Q?Mh6Q72gO78AlEgkMm/+51nx+s5PvjPdfX2ValWBosg4qq5Z+rY5TVceu18pR?= =?us-ascii?Q?JPXG5F+Ohwa1uR+bJ8l6FsC1LSCUZpF6/sgqVYdVLeK4EOv+cZyWa9hr69gS?= =?us-ascii?Q?kA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8427.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8d0ebd3-530c-4aae-ec19-08d9ce7f9bb0 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jan 2022 06:09:31.6573 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gSPb2ccP1ciZQ4WGctm7l4tkN7OM2WiBN8L5Xjc8lo9lUdRmzAGh1k9JV77ahp451pIyWl6WHiczOgyy71R1YQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7869 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: 27 December 2021 23:19 > To: Nipun Gupta > Cc: dev@dpdk.org; thomas@monjalon.net; ferruh.yigit@intel.com; Hemant > Agrawal ; Gagandeep Singh > Subject: Re: [PATCH v2 14/16] net/pfe: disable HW CRC stripping >=20 > On Mon, 27 Dec 2021 21:46:43 +0530 > nipun.gupta@nxp.com wrote: >=20 > > @@ -422,8 +422,11 @@ pfe_eth_close(struct rte_eth_dev *dev) > > } > > > > static int > > -pfe_eth_configure(struct rte_eth_dev *dev __rte_unused) > > +pfe_eth_configure(struct rte_eth_dev *dev) > > { > > + if (dev->data->dev_conf.rxmode.offloads & > DEV_RX_OFFLOAD_KEEP_CRC) > > + PFE_PMD_ERR("PMD does not support KEEP_CRC offload"); > > + > > return 0; > > } > > >=20 > Why is this necessary? There is already a check for offload capabilities = in > rte_eth_dev_configure(). The device should report correct supported offlo= ads > instead. Agree. Will remove this patch.