From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
Gagandeep Singh <G.Singh@nxp.com>,
Nipun Gupta <nipun.gupta@amd.com>
Subject: RE: [PATCH] dma/dpaa2: fix logtype register
Date: Mon, 18 Dec 2023 16:43:21 +0000 [thread overview]
Message-ID: <PAXPR04MB9328BB7863BF7325FB8719EC8990A@PAXPR04MB9328.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20231218154639.1508095-1-david.marchand@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 18, 2023 9:17 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Gagandeep Singh <G.Singh@nxp.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@amd.com>
> Subject: [PATCH] dma/dpaa2: fix logtype register
> Importance: High
>
> This driver logtype was not initialized so its logs would end up under the
0
> logtype, iow, RTE_LOGTYPE_EAL.
> This issue comes from a typo on the logtype variable name.
>
> Fixes: 8caf8427f85a ("dma/dpaa2: introduce driver skeleton")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
[Hemant] Thanks
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> drivers/dma/dpaa2/dpaa2_qdma.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c
> b/drivers/dma/dpaa2/dpaa2_qdma.c index 8968bb853b..2c91ceec13 100644
> --- a/drivers/dma/dpaa2/dpaa2_qdma.c
> +++ b/drivers/dma/dpaa2/dpaa2_qdma.c
> @@ -16,9 +16,6 @@
>
> #define DPAA2_QDMA_PREFETCH "prefetch"
>
> -/* Dynamic log type identifier */
> -int dpaa2_qdma_logtype;
> -
> uint32_t dpaa2_coherent_no_alloc_cache; uint32_t
> dpaa2_coherent_alloc_cache;
>
> @@ -1699,4 +1696,4 @@ static struct rte_dpaa2_driver
> rte_dpaa2_qdma_pmd = { RTE_PMD_REGISTER_DPAA2(dpaa2_qdma,
> rte_dpaa2_qdma_pmd); RTE_PMD_REGISTER_PARAM_STRING(dpaa2_qdma,
> "no_prefetch=<int> ");
> -RTE_LOG_REGISTER_DEFAULT(dpaa_qdma2_logtype, INFO);
> +RTE_LOG_REGISTER_DEFAULT(dpaa2_qdma_logtype, INFO);
> --
> 2.43.0
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9818 bytes --]
next prev parent reply other threads:[~2023-12-18 16:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 15:46 David Marchand
2023-12-18 16:34 ` Stephen Hemminger
2023-12-18 16:43 ` Hemant Agrawal [this message]
2024-01-19 11:08 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR04MB9328BB7863BF7325FB8719EC8990A@PAXPR04MB9328.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=G.Singh@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=nipun.gupta@amd.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).