RE: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API

[Hemant Agrawal <hemant.agrawal@nxp.com>]

HI Ferruh,

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Sunday, September 22, 2024 8:44 AM
> To: Hemant Agrawal <hemant.agrawal@nxp.com>; dev@dpdk.org
> Cc: ferruh.yigit@intel.com; Vinod Pullabhatla <vinod.pullabhatla@nxp.com>;
> Rohit Raj <rohit.raj@nxp.com>
> Subject: Re: [PATCH v2 14/18] net/dpaa: add Tx rate limiting DPAA PMD API
> Importance: High
> 
> On 8/23/2024 8:32 AM, Hemant Agrawal wrote:
> > diff --git a/drivers/net/dpaa/version.map
> > b/drivers/net/dpaa/version.map index 3fdb63caf3..24a28ce649 100644
> > --- a/drivers/net/dpaa/version.map
> > +++ b/drivers/net/dpaa/version.map
> > @@ -6,6 +6,13 @@ DPDK_25 {
> >  	local: *;
> >  };
> >
> > +EXPERIMENTAL {
> > +	global:
> > +
> > +	# added in 24.11
> > +	rte_pmd_dpaa_port_set_rate_limit;
> > +};
> > +
> >  INTERNAL {
> >  	global:
> >
> 
> PMD specific API needs to be justified, can't we use TM framework for this,
> does TM needs to be improved for this support?
> 
> What do you think to send the rest of the set without this patch, so they can
> progress, and this one can be discussed separately (assuming there is no
> dependency).

[Hemant] I think, I replied to your earlier concerns. 

We are yet to implement TM framework for DPAA1.  But that involves more of egress QoS.

This one is additional capability to limit the ingress port. Kind of policing in Rx side.

However, if you still disagree. Please apply the series without this patch.