From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 813DAA09E4; Thu, 21 Jan 2021 11:38:33 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 080AD140D1D; Thu, 21 Jan 2021 11:38:28 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 4E9E2140CD6 for ; Wed, 20 Jan 2021 15:09:59 +0100 (CET) IronPort-SDR: DyC8eNSAHI1id2/tsP/u7pkk58BHeZDV+veA/b8BloXvZMgoFFvDjrNmn1LI7kdMqGn6T96shE 7gcfswj0j8Kw== X-IronPort-AV: E=McAfee;i="6000,8403,9869"; a="158288607" X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="158288607" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jan 2021 06:09:58 -0800 IronPort-SDR: wKscwjj51Aq+sKzpPE/3j6dfqU0jlfZVmGG2XGHdvTBOHwFynwVUcWg6LcVbjqKAyUoYqxz7yV g1jZlKdHgeLg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,361,1602572400"; d="scan'208";a="391564026" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 20 Jan 2021 06:09:57 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 20 Jan 2021 06:09:57 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 20 Jan 2021 06:09:56 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 20 Jan 2021 06:09:55 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 20 Jan 2021 06:09:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X/NfHBoxZ5x6+0koFj8eqMMNckuHp/XPYPiuJpEvIB+NqVVZ5lebLSqFvJJM68YCPHxMqmAyK/XZgEHbkAMHnrGZicwaM5b42lqKgr26u46wuKnV6llZmiJdpWur6yOH+y3bQHsas/hgz5IUHntiC78C8YRWCqNI3j7jGj0CvkU1sBEO20VEkxlnfov2ZlKsQwI9Ijg+mGpSOTtGSsv0P0FiqxF6RECQJ976A1S69kINGs6FuK0HzZciV5hlhRo7uJFv4xU+YzyFDiTSqvPxUGZHjyKPyJJwaF1Ou7/cbZjKhLjb8H50gSZe/INb8XNS3Mh19bDQrVfFxMabgZ7/Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aZNYw6sY5k4jfL0mN5glGA3RaWHHJfsOGaIH65ZUrig=; b=ACz3baScAlxS99M0Njp+nc1/WzEUeeWJcCO9J4u+z4m/YS7UUygbKQ3XCPD+ZfwBgoH0hchq18YpBTtKYQXnnUhdgqVSoAddMcynycZzb70Y7ksmFITNsdPvM56WvbkF59Hu3P7ccK0UZ5xyw6LC8qccZDh74/SKgzKaNOjp2vX4sCv/eK/aujWelFww/ge9KJq88zSbyY6LIZ2a12b/8Rz2ZvNyRqSiUiT61STK5ci/ey8Ixt93UpTX9CJp8wgu2e28dNkrlCQP2oMvYEDkyUJeHOfQGzrC4ksFwpDJ8qAvHl/8zaO3wio1DzDBLL3Z61w3P6PSUSS8QJEgPbkYJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aZNYw6sY5k4jfL0mN5glGA3RaWHHJfsOGaIH65ZUrig=; b=g7fw8OTVRaV2aGbBYXehsvne4artg1nNLG2DXaWMcLWkCMhRwqMzyKQ3wbbQavW/dLh9YdpTlZawqA8L6JJ5D3SD1LbvcwBc1ASS+VyV0NQ/5m7C5s+bJYl5Jxj0sAd1PkelmWWnD2IH5iirF9YzawqwlrBfEdVqMEFbGTSnkbM= Received: from PH0PR11MB4776.namprd11.prod.outlook.com (2603:10b6:510:30::14) by PH0PR11MB5127.namprd11.prod.outlook.com (2603:10b6:510:3c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.11; Wed, 20 Jan 2021 14:09:49 +0000 Received: from PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::516d:3e18:d496:487e]) by PH0PR11MB4776.namprd11.prod.outlook.com ([fe80::516d:3e18:d496:487e%2]) with mapi id 15.20.3763.015; Wed, 20 Jan 2021 14:09:49 +0000 From: "Kinsella, Ray" To: Thomas Monjalon , "Gujjar, Abhinandan S" , "mdr@ashroe.eu" CC: "dev@dpdk.org" , "Ananyev, Konstantin" , Akhil Goyal , "aconole@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions Thread-Index: AQHW7pFrfIVZaKiL1kCiG9GHMpi77aowMhhAgABNcACAAA7dUA== Date: Wed, 20 Jan 2021 14:09:49 +0000 Message-ID: References: <20201222144243.552262-1-abhinandan.gujjar@intel.com> <5458566.rWvySYnu6v@thomas> <1697053.2DkutoUMdu@thomas> In-Reply-To: <1697053.2DkutoUMdu@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [89.124.12.13] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34e483a7-7045-4010-954c-08d8bd4d0c7c x-ms-traffictypediagnostic: PH0PR11MB5127: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MkSVxHl8V/23zXpDo0EV+pnDdMaFfWOtwNhPSgIOFbUOoG9TJLISoWwhTo5Qt4g+wtMP0Wbdlpub+dWv8dBzIVS68BsWBEpbO4LFTsskDTkWu57KTMiqgTTI6s9KVVl1jv15YWSgIDK2Myhfwld+v3V8vlf5vq5wgxfKbzJroxeMT8h67Mg3TJLZYwo/SvliFHJgMwYdGJl2qj+9+8bN2FX4j2qc9rcK9Pu9lsYoUEoYTvs0lM3QUDwrrP2pEJbjY+lUob2ULf4aEY1CUcoklwSuOrieXXyxJCj/+BdLr3vfPobG5tl45QPLiZsv0crssg5zXpbWqfKVeJuEnQUxaZbfWCfL86WWCtWUHqKcRAS++7Xa/sz7f7JzUKUFnQF/+AZtwlQaeZcMzqCNtY00Zg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB4776.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(136003)(366004)(396003)(66556008)(6506007)(86362001)(71200400001)(53546011)(2906002)(66446008)(76116006)(9686003)(52536014)(66476007)(54906003)(64756008)(4326008)(8676002)(26005)(66946007)(478600001)(33656002)(110136005)(8936002)(316002)(5660300002)(186003)(55016002)(7696005)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hVBwuOfEvamRH/NIX7G62UIJig7fL/rQW4rkqFoJ2RQ75ySzo4zumnhMsQFX?= =?us-ascii?Q?rBlc59XCzgnEw6rey39WXQJjnuENkkIo7AN6uNOieq4zbqmE4VP0DCreUYtc?= =?us-ascii?Q?dvvE+qGvedF1fjNWvG+HGEJ3x2AJMytNwW8lQhVp0IxmO9lFcO6cXZpXuYnt?= =?us-ascii?Q?L+Nub3TXqXa2oAXTwqDz1+JMauOgLjro7IK2s8tyO+0VreJuQICoTkn539vm?= =?us-ascii?Q?n/5AZk2FnWcp4irt1dF3+OS19rkv1QweLPsyn9v1dAozvdh6FMqxxnUgc+1C?= =?us-ascii?Q?MPqKUdhAAsN8kjONP5FH0Tf8wTKL6lHE+x8FdgJYy/lNwirHnOo3JBtMFL+A?= =?us-ascii?Q?o/ZCtLT267XBbPtOd4aFHiHHkYqgZtugzfcOehk/0JL7OwuVYdgRFyoX+leJ?= =?us-ascii?Q?6dlyoCy2jyuVBaHqGFaU47V7Y9YtUcItO5L0/RQxewaBZakx4nqNePpBTu4+?= =?us-ascii?Q?RFdW3bG2vkIunI5wtI+znm4K5xBXqS7AZQLnAr+hrNuIqQyG+0ld55tp4oDS?= =?us-ascii?Q?qkmUosvA7X8CnXXsNthKK9CjfHeyK7fsfMxyGTqgsNYDlEQXesTgo973b0NC?= =?us-ascii?Q?oTWJCPJYJ9NbXff0zxGunTyB8468vvKfOAUfGyOc75n3+iDPT3RTCFLWHYNp?= =?us-ascii?Q?ADAz3CAxhuPJY4bvbjaQC6W6WPWj7jlciswn1IySv/x+GF9BRrpRQ70lejov?= =?us-ascii?Q?uMI85TvMl+uKqIkjp+KxWSIVp0F2wkBmWMDNwbwQKBfxmLATSSQrOMUYF9Vv?= =?us-ascii?Q?nIOBMC8RzTjOQSJvNEO4SLd6Nf8EGENCF4H3LwgHicxV+SZwzmP2Z0NcVw7/?= =?us-ascii?Q?N/ie014KWHyV72FkPifD/npr6cnOHtNiUGEhH49bLK4sjyvNrsD6Zb7UwfkO?= =?us-ascii?Q?FxeNNujHeqgvunmZ0YUubaCL8l7LPStBJy+NqEnoV78WfqaadezWXEeZVMu9?= =?us-ascii?Q?OlwDCMEs1a5I2L4dyhlVVdEJ2uesSBIQrLAeDZgmQKkmYyGlYC+Kb/rvHo4o?= =?us-ascii?Q?0juV4pdS347FcwTQ5fYPz9QLDCozZN8CYnn9qbQ/DVsKPivYY//tjB3mO7ap?= =?us-ascii?Q?GWjsltfc?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34e483a7-7045-4010-954c-08d8bd4d0c7c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jan 2021 14:09:49.1313 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5VeA3cGp2PLAqbkmCnY8CYjLhpuGIzYcTl64hQjK8IB+hpcCRwRGKxD514lgA6bnJtiWcdSbp9RTYb/eN3OB+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5127 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Thu, 21 Jan 2021 11:38:26 +0100 Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and dequeue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday 20 January 2021 13:16 > To: Gujjar, Abhinandan S ; Kinsella, Ray > ; mdr@ashroe.eu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > Akhil Goyal ; aconole@redhat.com; > david.marchand@redhat.com > Subject: Re: [dpdk-dev] [PATCH v7 1/2] cryptodev: support enqueue and > dequeue callback functions >=20 > 20/01/2021 14:01, Kinsella, Ray: > > From: Thomas Monjalon > > > 15/01/2021 17:01, Akhil Goyal: > > > > > This patch adds APIs to add/remove callback functions on crypto > > > > > enqueue/dequeue burst. The callback function will be called for > > > each > > > > > burst of crypto ops received/sent on a given crypto device > queue > > > > > pair. > > > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > > Acked-by: Konstantin Ananyev > > > > > --- > > > > Series applied to dpdk-next-crypto > > > > > > > > > It is missing a rule to ignore the false positive ABI break: > > > > > > --- a/devtools/libabigail.abignore > > > +++ b/devtools/libabigail.abignore > > > @@ -11,3 +11,8 @@ > > > ; Explicit ignore for driver-only ABI [suppress_type] > > > name =3D eth_dev_ops > > > + > > > +; Ignore fields inserted in cacheline boundary of rte_cryptodev > > > +[suppress_type] > > > + name =3D rte_cryptodev > > > + has_data_member_inserted_between =3D {0, 1023} > > > > > > > This is a bit of a blunt instrument as the range quiet large? >=20 > The range is in bits. It matches the actual size of the struct for 64B > cacheline. Ok >=20 > > {offset_after(attached), end} instead works better - I will send a > patch. >=20 > Yes that's exactly what David told me earlier today. Makes sense, I think. >=20 > > > I'll add this change while pulling in the main tree. >=20 > Yes please. > Note: we missed requiring this exception rule in the original patch. Ok, in the next 20 minutes or so.